GNU bug report logs - #17576
[PATCH] dfa: speed-up at initial state

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sat, 24 May 2014 03:33:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17576-done <at> debbugs.gnu.org
Subject: bug#17576: [PATCH] dfa: speed-up at initial state
Date: Sun, 28 Sep 2014 16:18:15 +0900
Paul Eggert wrote:
> Thanks, I finally got around to looking at this and got similar 
> performance results to yours.  That __attribute__((noinline)) bothers
> me, though, as it's not portable and is a bit inelegant.  I figured
> out a different way to avoid the inlining, and tweaked the commentary
> a bit, and so installed the attached additional patch after installing
> your patches.

Excellent.

Thanks for the review and additional improvement.  I don't like that my
patch have uses `((noinline)) __attribute __' which isn't portable, but
you fix it.





This bug report was last modified 10 years and 317 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.