GNU bug report logs - #17562
24.4.50; REGRESSION: mouse double-click on `(` does not select whole Lisp sexp

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17562: closed (24.4.50; REGRESSION: mouse double-click on `(`
 does not select whole Lisp sexp)
Date: Tue, 27 May 2014 05:09:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 27 May 2014 01:08:30 -0400
with message-id <jwvwqd7rf0d.fsf-monnier+emacsbugs <at> gnu.org>
and subject line Re: bug#17562: 24.4.50; REGRESSION: mouse double-click on `(` does not select whole Lisp sexp
has caused the debbugs.gnu.org bug report #17562,
regarding 24.4.50; REGRESSION: mouse double-click on `(` does not select whole Lisp sexp
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17562: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17562
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; REGRESSION: mouse double-click on `(` does not select whole
 Lisp sexp
Date: Fri, 23 May 2014 10:00:17 -0700 (PDT)

Regression after Emacs 24.3.

emacs -Q

Visit dired.el. Double-click on the opening paren of

(defun dired-get-filename ...

Only part of the defun is selected.  It seems that a defun needs to fit
entirely within the window (i.e., be completely visible) for mouse
selection by double-clicking to work correctly now.



In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-05-17 on ODIEONE
Bzr revision: 117119 eggert <at> cs.ucla.edu-20140517081131-ugu7ociaoec2xk7y
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 17562-done <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#17562: 24.4.50;
 REGRESSION: mouse double-click on `(` does not select whole Lisp sexp
Date: Tue, 27 May 2014 01:08:30 -0400

> In general, in current trunk, when window scrolling happens, point is
> now always positioned in the line under the mouse, instead of after the
> sexp.  Seems like something happens similar to what is described in the
> old code:

>   ;; Don't run the up-event handler if the window
>   ;; start changed in a redisplay after the
>   ;; mouse-set-point for the down-mouse event at
>   ;; the beginning of this function.  When the
>   ;; window start has changed, the up-mouse event
>   ;; contains a different position due to the new
>   ;; window contents, and point is set again.

Indeed, it's something along these lines, although the above code is not
reached anyway in this kind of "double click on a paren" situation.

The problem is that Emacs generates a drag event even though there's not
been a drag per-se, and the end-posn of the drag is based on the "after
scroll" display, whereas the user usually hasn't had the time to really
see this display before releasing his mouse button.

The old code used a hack to work around the problem, and I installed
another hack that does something morally very similar, although it gets
there in a fairly different way.

In both the old and the new code you can still get the undesired
behavior if you move your mouse slightly between the second down-mouse
and the second up-mouse.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.