From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 11:02:49 2014 Received: (at submit) by debbugs.gnu.org; 23 May 2014 15:02:49 +0000 Received: from localhost ([127.0.0.1]:58003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnqzg-0006R3-Ru for submit@debbugs.gnu.org; Fri, 23 May 2014 11:02:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43868) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnqze-0006Ql-BG for submit@debbugs.gnu.org; Fri, 23 May 2014 11:02:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnqzQ-0006DW-A4 for submit@debbugs.gnu.org; Fri, 23 May 2014 11:02:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnqzQ-0006DS-7H for submit@debbugs.gnu.org; Fri, 23 May 2014 11:02:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnqzJ-00014k-Mx for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 11:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnqzD-0006Bb-Ia for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 11:02:25 -0400 Received: from cosmos.phy.tufts.edu ([130.64.83.16]:38093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnqzD-0006BX-CF for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 11:02:19 -0400 Received: from kdo by cosmos.phy.tufts.edu ([local]:local) with local id 1WnqzC-00009p-VH - Using Exim-4.80.1 (MandrivaLinux) MTA (return-path ); Fri, 23 May 2014 11:02:19 -0400 From: Ken Olum To: bug-gnu-emacs@gnu.org Subject: 24.4.50; wrong type argument if rmail-delete-after-output set Date: Fri, 23 May 2014 11:02:18 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Under a recent change, rmail-delete-forward takes an optional repeat count. If not specified, the count defaults to nil, giving an error. This function is called with no arguments in several places including rmail-output (if rmail-delete-after-output is set). emacs -Q M-X rmail set rmail-delete-after-output to t press "o" Give output filename Get error: Wrong type argument: number-or-marker-p, nil In GNU Emacs 24.4.50.2 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bars) of 2014-05-22 on cosmos Repository revision: 117139 eggert@cs.ucla.edu-20140522164035-y1m18x4smoxvgy58 Windowing system distributor `The Cygwin/X Project', version 11.0.10903000 System Description: Ubuntu 12.04.4 LTS Configured features: XPM JPEG TIFF GIF PNG SOUND NOTIFY LIBXML2 FREETYPE XFT ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x r e p o r t - b u g Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. delete-backward-char: Text is read-only Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process inotify dynamic-setting font-render-setting x-toolkit x multi-tty emacs) Memory information: ((conses 16 75357 6383) (symbols 48 17734 0) (miscs 40 37 152) (strings 32 11042 3962) (string-bytes 1 287633) (vectors 16 9192) (vector-slots 8 374109 11495) (floats 8 68 264) (intervals 56 190 4) (buffers 960 11) (heap 1024 38120 1325)) From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 11:31:32 2014 Received: (at 17560) by debbugs.gnu.org; 23 May 2014 15:31:32 +0000 Received: from localhost ([127.0.0.1]:58016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnrRU-0007KS-5b for submit@debbugs.gnu.org; Fri, 23 May 2014 11:31:32 -0400 Received: from mtaout29.012.net.il ([80.179.55.185]:49036) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnrRQ-0007K4-Tp for 17560@debbugs.gnu.org; Fri, 23 May 2014 11:31:30 -0400 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N6100G0093WCP00@mtaout29.012.net.il> for 17560@debbugs.gnu.org; Fri, 23 May 2014 18:32:02 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6100E2H9TEXL50@mtaout29.012.net.il>; Fri, 23 May 2014 18:32:02 +0300 (IDT) Date: Fri, 23 May 2014 18:31:37 +0300 From: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-reply-to: X-012-Sender: halo1@inter.net.il To: Ken Olum Message-id: <83mwe8ldeu.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17560 Cc: 17560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ken Olum > Date: Fri, 23 May 2014 11:02:18 -0400 > > Under a recent change, rmail-delete-forward takes an optional repeat > count. If not specified, the count defaults to nil, giving an error. > This function is called with no arguments in several places including > rmail-output (if rmail-delete-after-output is set). Could you perhaps suggest a patch to fix this? TIA. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 11:51:18 2014 Received: (at 17560) by debbugs.gnu.org; 23 May 2014 15:51:18 +0000 Received: from localhost ([127.0.0.1]:58033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnrkX-0007vS-1l for submit@debbugs.gnu.org; Fri, 23 May 2014 11:51:18 -0400 Received: from cosmos.phy.tufts.edu ([130.64.83.16]:41908) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnrkK-0007uj-4h for 17560@debbugs.gnu.org; Fri, 23 May 2014 11:51:12 -0400 Received: from kdo by cosmos.phy.tufts.edu ([local]:local) with local id 1WnrkJ-0000M2-Ie - Using Exim-4.80.1 (MandrivaLinux) MTA (return-path ); Fri, 23 May 2014 11:50:59 -0400 From: Ken Olum To: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-Reply-To: <83mwe8ldeu.fsf@gnu.org> (message from Eli Zaretskii on Fri, 23 May 2014 18:31:37 +0300) Date: Fri, 23 May 2014 11:50:59 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17560 Cc: 17560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) I'd put (if (not count) (setq count 1)) in rmail-delete-forward and for consistency make the argument of rmail-delete-backward optional and add the same code there. Unfortunately, that is not consistent with rmail-next-message, for example. The alternative would be to make the argument not optional and change all callers to say (rmail-delete-forward 1). Unfortunately, in previous versions of emacs this would mean to move backward, so new calls would be incompatible with the old definition, which I think argues against this plan. Ken From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 13:37:42 2014 Received: (at 17560) by debbugs.gnu.org; 23 May 2014 17:37:42 +0000 Received: from localhost ([127.0.0.1]:58132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WntPa-0004KI-6N for submit@debbugs.gnu.org; Fri, 23 May 2014 13:37:42 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:32932) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WntPX-0004Jv-DL for 17560@debbugs.gnu.org; Fri, 23 May 2014 13:37:40 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N6100400EEEC800@mtaout25.012.net.il> for 17560@debbugs.gnu.org; Fri, 23 May 2014 20:34:22 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N61006GNFHAJ030@mtaout25.012.net.il>; Fri, 23 May 2014 20:34:22 +0300 (IDT) Date: Fri, 23 May 2014 20:37:48 +0300 From: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-reply-to: X-012-Sender: halo1@inter.net.il To: Ken Olum Message-id: <83k39cl7kj.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17560 Cc: 17560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ken Olum > Cc: 17560@debbugs.gnu.org > Date: Fri, 23 May 2014 11:50:59 -0400 > > I'd put > > (if (not count) (setq count 1)) > > in rmail-delete-forward and for consistency make the argument of > rmail-delete-backward optional and add the same code there. > > Unfortunately, that is not consistent with rmail-next-message, for > example. The alternative would be to make the argument not optional and > change all callers to say (rmail-delete-forward 1). The alternative is what I had in mind, yes. > Unfortunately, in previous versions of emacs this would mean to move > backward, so new calls would be incompatible with the old > definition, which I think argues against this plan. I don't think this problem should bother us, as the change in rmail-delete-forward is backward-incompatible anyway. Which reminds me: could you also make a suitable entry in NEWS? TIA From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 14:48:29 2014 Received: (at 17560) by debbugs.gnu.org; 23 May 2014 18:48:29 +0000 Received: from localhost ([127.0.0.1]:58180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnuW4-0007i2-Cd for submit@debbugs.gnu.org; Fri, 23 May 2014 14:48:28 -0400 Received: from cosmos.phy.tufts.edu ([130.64.83.16]:43553) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnuW1-0007ht-Uv for 17560@debbugs.gnu.org; Fri, 23 May 2014 14:48:26 -0400 Received: from kdo by cosmos.phy.tufts.edu ([local]:local) with local id 1WnuW1-0005FS-D4 - Using Exim-4.80.1 (MandrivaLinux) MTA (return-path ); Fri, 23 May 2014 14:48:25 -0400 From: Ken Olum To: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-Reply-To: <83k39cl7kj.fsf@gnu.org> (message from Eli Zaretskii on Fri, 23 May 2014 20:37:48 +0300) Date: Fri, 23 May 2014 14:48:25 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 17560 Cc: 17560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --=-=-= Content-Type: text/plain OK. Here is a patch, including NEWS and ChangeLog entries. I made the argument to rmail-delete-forward not optional, and fixed callers. Ken --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=rmail-delete.patch === modified file 'etc/NEWS' --- etc/NEWS 2014-05-17 08:11:31 +0000 +++ etc/NEWS 2014-05-23 18:14:27 +0000 @@ -130,6 +130,9 @@ ** You can access the slots of structures using `cl-struct-slot-value'. +** Functions `rmail-delete-forward' and `rmail-delete-backward' take a +repeat-count argument. + * Changes in Emacs 24.5 on Non-Free Operating Systems === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-05-23 15:54:44 +0000 +++ lisp/ChangeLog 2014-05-23 18:26:24 +0000 @@ -1,3 +1,12 @@ +2014-05-23 Ken Olum + + * mail/rmail.el: (rmail-delete-forward) make `count' arg not optional. + (rmail-auto-file): + * mail/rmailout.el: (rmail-output, rmail-output-as-seen) + (rmail-output-body-to-file): + * mail/rmailout.el: (undigestify-rmail-message): + Supply `count' arg to rmail-delete-forward. + 2014-05-23 Stefan Monnier * minibuffer.el (completion--sreverse): Remove. === modified file 'lisp/mail/rmail.el' --- lisp/mail/rmail.el 2014-05-05 01:08:54 +0000 +++ lisp/mail/rmail.el 2014-05-23 18:22:56 +0000 @@ -3078,7 +3078,7 @@ ;; If there are no directives left, then it was a complete match. (if (null directive-loop) (if (null folder) - (rmail-delete-forward) + (rmail-delete-forward 1) (if (string= "/dev/null" folder) (rmail-delete-message) (rmail-output folder 1) @@ -3474,7 +3474,7 @@ (rmail-summary-mark-undeleted msg)))))) (rmail-maybe-display-summary))) -(defun rmail-delete-forward (&optional count) +(defun rmail-delete-forward (count) "Delete this message and move to next nondeleted one. Deleted messages stay in the file until the \\[rmail-expunge] command is given. A prefix argument is a repeat count; === modified file 'lisp/mail/rmailout.el' --- lisp/mail/rmailout.el 2014-02-10 01:34:22 +0000 +++ lisp/mail/rmailout.el 2014-05-23 18:03:25 +0000 @@ -514,7 +514,7 @@ (setq count (1- count)) (let ((next-message-p (if rmail-delete-after-output - (rmail-delete-forward) + (rmail-delete-forward 1) (if (> count 0) (rmail-next-undeleted-message 1)))) (num-appended (- orig-count count))) @@ -581,7 +581,7 @@ (setq count (1- count)) (let ((next-message-p (if rmail-delete-after-output - (rmail-delete-forward) + (rmail-delete-forward 1) (if (> count 0) (rmail-next-undeleted-message 1)))) (num-appended (- orig-count count))) @@ -630,6 +630,6 @@ (error "Operation aborted")) (write-region (point) (point-max) file-name)) (if rmail-delete-after-output - (rmail-delete-forward))) + (rmail-delete-forward 1))) ;;; rmailout.el ends here === modified file 'lisp/mail/undigest.el' --- lisp/mail/undigest.el 2014-02-10 01:34:22 +0000 +++ lisp/mail/undigest.el 2014-05-23 18:02:49 +0000 @@ -217,7 +217,7 @@ (rmail-set-message-counters) (set-buffer-modified-p t) (rmail-show-message current) - (rmail-delete-forward) + (rmail-delete-forward 1) (if (rmail-summary-exists) (rmail-select-summary (rmail-update-summary)))) (when error --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 15:53:08 2014 Received: (at 17560) by debbugs.gnu.org; 23 May 2014 19:53:08 +0000 Received: from localhost ([127.0.0.1]:58216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnvWd-0002U5-VE for submit@debbugs.gnu.org; Fri, 23 May 2014 15:53:08 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:57446) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnvWb-0002TX-3B for 17560@debbugs.gnu.org; Fri, 23 May 2014 15:53:06 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N6100400KEHTG00@a-mtaout23.012.net.il> for 17560@debbugs.gnu.org; Fri, 23 May 2014 22:52:58 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N61004C6LW9RB60@a-mtaout23.012.net.il>; Fri, 23 May 2014 22:52:58 +0300 (IDT) Date: Fri, 23 May 2014 22:53:14 +0300 From: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-reply-to: X-012-Sender: halo1@inter.net.il To: Ken Olum Message-id: <83ioowl1at.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17560 Cc: 17560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ken Olum > Cc: 17560@debbugs.gnu.org > Date: Fri, 23 May 2014 14:48:25 -0400 > > OK. Here is a patch, including NEWS and ChangeLog entries. I made the > argument to rmail-delete-forward not optional, and fixed callers. Thanks. But on second thought, what exactly was wrong with making nil mean 1? What did you mean by "not consistent with rmail-next-message"? Sorry for not asking that earlier. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 16:05:12 2014 Received: (at 17560) by debbugs.gnu.org; 23 May 2014 20:05:12 +0000 Received: from localhost ([127.0.0.1]:58223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnviJ-0002tR-9U for submit@debbugs.gnu.org; Fri, 23 May 2014 16:05:11 -0400 Received: from cosmos.phy.tufts.edu ([130.64.83.16]:44306) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnvi4-0002se-Cd for 17560@debbugs.gnu.org; Fri, 23 May 2014 16:05:10 -0400 Received: from kdo by cosmos.phy.tufts.edu ([local]:local) with local id 1Wnvi4-0005SH-2V - Using Exim-4.80.1 (MandrivaLinux) MTA (return-path ); Fri, 23 May 2014 16:04:56 -0400 From: Ken Olum To: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-Reply-To: <83ioowl1at.fsf@gnu.org> (message from Eli Zaretskii on Fri, 23 May 2014 22:53:14 +0300) Date: Fri, 23 May 2014 16:04:56 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17560 Cc: 17560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) What I meant was that you cannot say (rmail-next-message) to go forward one message. You have to say (rmail-next-message 1). So I wasn't sure whether it would be a good idea to allow (rmail-delete-forward) to default to deleting one message. On the other hand, I now see that rmail-search has a repeat count that is optional. Ken From debbugs-submit-bounces@debbugs.gnu.org Sat May 24 02:54:46 2014 Received: (at 17560) by debbugs.gnu.org; 24 May 2014 06:54:46 +0000 Received: from localhost ([127.0.0.1]:58581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wo5qv-0000MD-7T for submit@debbugs.gnu.org; Sat, 24 May 2014 02:54:45 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:65239) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wo5qr-0000Lt-Ce for 17560@debbugs.gnu.org; Sat, 24 May 2014 02:54:42 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N6200600G6JK200@a-mtaout23.012.net.il> for 17560@debbugs.gnu.org; Sat, 24 May 2014 09:54:33 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N62006KJGIXDTA0@a-mtaout23.012.net.il>; Sat, 24 May 2014 09:54:33 +0300 (IDT) Date: Sat, 24 May 2014 09:54:51 +0300 From: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-reply-to: X-012-Sender: halo1@inter.net.il To: Ken Olum Message-id: <83ha4fll8k.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17560 Cc: 17560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ken Olum > Cc: 17560@debbugs.gnu.org > Date: Fri, 23 May 2014 16:04:56 -0400 > > What I meant was that you cannot say (rmail-next-message) to go forward > one message. You have to say (rmail-next-message 1). So I wasn't sure > whether it would be a good idea to allow (rmail-delete-forward) to > default to deleting one message. > > On the other hand, I now see that rmail-search has a repeat count that > is optional. I see. So that was my misunderstanding, and it is better to go with your first alternative, since it is backward-compatible, and requires less changes. Again, sorry for not bringing this up earlier. From debbugs-submit-bounces@debbugs.gnu.org Tue May 27 11:08:20 2014 Received: (at 17560) by debbugs.gnu.org; 27 May 2014 15:08:20 +0000 Received: from localhost ([127.0.0.1]:33528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpIzA-0006CT-1G for submit@debbugs.gnu.org; Tue, 27 May 2014 11:08:19 -0400 Received: from cosmos.phy.tufts.edu ([130.64.83.16]:36411) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpIz1-0006CC-13 for 17560@debbugs.gnu.org; Tue, 27 May 2014 11:08:14 -0400 Received: from kdo by cosmos.phy.tufts.edu ([local]:local) with local id 1WpIz0-0003jS-Mp - Using Exim-4.80.1 (MandrivaLinux) MTA (return-path ); Tue, 27 May 2014 11:08:06 -0400 From: Ken Olum To: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-Reply-To: <83ha4fll8k.fsf@gnu.org> (message from Eli Zaretskii on Sat, 24 May 2014 09:54:51 +0300) Date: Tue, 27 May 2014 11:08:06 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 17560 Cc: 17560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --=-=-= Content-Type: text/plain OK. Here is a different patch making the arguments to rmail-delete-forward and rmail-delete-backward optional and defaulting to 1. NEWS and ChangeLog are included. Ken --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=rmail-delete.patch === modified file 'etc/NEWS' --- etc/NEWS 2014-05-17 08:11:31 +0000 +++ etc/NEWS 2014-05-27 14:50:48 +0000 @@ -130,6 +130,9 @@ ** You can access the slots of structures using `cl-struct-slot-value'. +** Functions `rmail-delete-forward' and `rmail-delete-backward' take an +optional repeat-count argument. + * Changes in Emacs 24.5 on Non-Free Operating Systems === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-05-23 15:54:44 +0000 +++ lisp/ChangeLog 2014-05-27 15:04:59 +0000 @@ -1,3 +1,8 @@ +2014-05-27 Ken Olum + + * mail/rmail.el (rmail-delete-forward): Default `count' to 1. + (rmail-delete-forward): Argument `count' optional, default to 1. + 2014-05-23 Stefan Monnier * minibuffer.el (completion--sreverse): Remove. === modified file 'lisp/mail/rmail.el' --- lisp/mail/rmail.el 2014-05-05 01:08:54 +0000 +++ lisp/mail/rmail.el 2014-05-27 14:53:00 +0000 @@ -3482,6 +3482,7 @@ Returns t if a new message is displayed after the delete, or nil otherwise." (interactive "p") + (if (not count) (setq count 1)) (let (value backward) (if (< count 0) (setq count (- count) backward t)) @@ -3496,7 +3497,7 @@ (rmail-maybe-display-summary) value)) -(defun rmail-delete-backward (count) +(defun rmail-delete-backward (&optional count) "Delete this message and move to previous nondeleted one. Deleted messages stay in the file until the \\[rmail-expunge] command is given. A prefix argument is a repeat count; @@ -3505,6 +3506,7 @@ Returns t if a new message is displayed after the delete, or nil otherwise." (interactive "p") + (if (not count) (setq count 1)) (rmail-delete-forward (- count))) ;; Expunging. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 30 05:35:16 2014 Received: (at 17560-done) by debbugs.gnu.org; 30 May 2014 09:35:16 +0000 Received: from localhost ([127.0.0.1]:36870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqJDX-0002Ht-Vy for submit@debbugs.gnu.org; Fri, 30 May 2014 05:35:16 -0400 Received: from mtaout29.012.net.il ([80.179.55.185]:58373) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqJDU-0002HZ-IZ for 17560-done@debbugs.gnu.org; Fri, 30 May 2014 05:35:13 -0400 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N6D00700RQ2BX00@mtaout29.012.net.il> for 17560-done@debbugs.gnu.org; Fri, 30 May 2014 12:35:38 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6D005SSRZE3030@mtaout29.012.net.il>; Fri, 30 May 2014 12:35:38 +0300 (IDT) Date: Fri, 30 May 2014 12:35:20 +0300 From: Eli Zaretskii Subject: Re: bug#17560: 24.4.50; wrong type argument if rmail-delete-after-output set In-reply-to: X-012-Sender: halo1@inter.net.il To: Ken Olum Message-id: <83sinrfw2v.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17560-done Cc: 17560-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Ken Olum > Cc: 17560@debbugs.gnu.org > Date: Tue, 27 May 2014 11:08:06 -0400 > > OK. Here is a different patch making the arguments to > rmail-delete-forward and rmail-delete-backward optional and defaulting > to 1. NEWS and ChangeLog are included. Thanks, committed as trunk revision 117204. From unknown Sun Jun 15 08:33:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Jun 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator