From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 May 2014 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17558@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140083678011344 (code B ref -1); Fri, 23 May 2014 09:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 May 2014 09:19:40 +0000 Received: from localhost ([127.0.0.1]:57292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnldc-0002wt-4C for submit@debbugs.gnu.org; Fri, 23 May 2014 05:19:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42524) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnldY-0002wc-KE for submit@debbugs.gnu.org; Fri, 23 May 2014 05:19:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnldN-0001IA-Bh for submit@debbugs.gnu.org; Fri, 23 May 2014 05:19:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnldN-0001I6-8T for submit@debbugs.gnu.org; Fri, 23 May 2014 05:19:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnldH-0005V0-Dn for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 05:19:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnldB-0001FS-GW for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 05:19:19 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:57550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnldB-0001F6-6B for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 05:19:13 -0400 Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 76BA1209B3 for ; Fri, 23 May 2014 05:19:11 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 23 May 2014 05:19:11 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=from:to:subject:date:message-id:mime-version:content-type; s= mesmtp; bh=jdrxJQCuRplgRU2x1ogt6WkXuFg=; b=fhvqmeLyxeb5QZKMa+FUo 2Y6efn10rwx0lq3aQDuL8ZOt6dUi2ZHRXy3FjJd6FTu3x4bnSntqFpRFEk4DRXrn WziXa5ayCsgvMPubO33wcKBy2UodmSzDiL/iJkQ/iahQ/RX/i/j/pbqanOTbmCZA AN+d7K83xGKQQd1hPnlYBo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:subject:date:message-id :mime-version:content-type; s=smtpout; bh=jdrxJQCuRplgRU2x1ogt6W kXuFg=; b=A2Fc4qNFbbJo4uDf2wfmcfSgz4bc6RuwRmjloSL6lhRUgbr4JUDkqN AHm8SxvNrnaMgHvB+33j5Mw0zlUKzeGyQCXa4LLj06WQWY4VGoM/qO7kacb5Re65 A+gHSW7Wra0H7+ZbZXVUHfTbC1fgJo/uVJ/acbYR4tVNVPxq3TGzs= X-Sasl-enc: i2PYxaYL5MfRLsrtfXNEUoLPDASp62gHq4Lx6JdnAGxA 1400836751 Received: from shorty.local (unknown [23.243.199.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 3D42AC007AB for ; Fri, 23 May 2014 05:19:11 -0400 (EDT) Received: from dima by shorty.local with local (Exim 4.82) (envelope-from ) id 1Wnld7-0004Hf-B4 for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 02:19:09 -0700 From: Dima Kogan Date: Fri, 23 May 2014 02:19:09 -0700 Message-ID: <87ppj4ette.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi. I'm using a very recent build of emacs from the VCS. With this build ERC gets very confused if global-subword-mode is on. I believe it worked fine just a few months ago. Recipe: 1. emacs -Q 2. (global-subword-mode) 3. M-x erc 4. Default values for the server, nickname, password, etc are fine to show the issue I observe the following two error repeated many times: error in process filter: erc-button-add-nickname-buttons: Wrong type argument: integer-or-marker-p, nil error in process filter: Wrong type argument: integer-or-marker-p, nil ERC kinda works even with those issues, but the data comes back from the server sporadically and it's not really usable. Emacs details: In GNU Emacs 24.4.50.1 (x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2014-05-21 on lilbastard, modified by Debian (emacs-snapshot package, version 2:20140521-1) Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Debian GNU/Linux testing (jessie) Configured using: `configure --build x86_64-linux-gnu --host x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var --infodir=/usr/share/info/emacs-snapshot --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.4.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4.50/site-lisp:/usr/share/emacs/site-lisp --with-crt-dir=/usr/lib/x86_64-linux-gnu/ --with-x=yes --with-x-toolkit=lucid 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' CPPFLAGS=-D_FORTIFY_SOURCE=2 'LDFLAGS=-g -Wl,--as-needed -znocombreloc'' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB Important settings: value of $LC_ALL: C value of $LANG: C locale-coding-system: nil From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 May 2014 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dima Kogan , 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.140087828816844 (code B ref 17558); Fri, 23 May 2014 20:52:01 +0000 Received: (at 17558) by debbugs.gnu.org; 23 May 2014 20:51:28 +0000 Received: from localhost ([127.0.0.1]:58262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnwR5-0004Nb-Qx for submit@debbugs.gnu.org; Fri, 23 May 2014 16:51:28 -0400 Received: from dancol.org ([96.126.100.184]:53454) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnwR2-0004NN-Ge for 17558@debbugs.gnu.org; Fri, 23 May 2014 16:51:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:To:MIME-Version:From:Date:Message-ID; bh=F0eyDHJJeHZkH5Nu/7vPpX8idNQCgOeX92XdG01Ca6s=; b=H20y4nj1qMrYPeS3B1vWB5G518trsL/ItUFhyCkPuzwMAPz9yGDxtLrKKfFGwNLYiY8VXhdA066uH/0wVxa8j4G2DvlUwKRKFetLCNFN7q+n9VZEAQZnYyc4p5exQZf7vD9329NQ1jgcRBkRQKt20tZqOJaoIzzAeWPTn44yG2MbMoY5zktY5qs0q3FQiAPmYcgkQad35SCCA3NK4h2qACYM7oIt9r/lVJD8yuZE/4gt/dpq2ewFUNUJgMsGSBF5MRxqbRdP+sviYnXTA3PvUzVIBrnUvwWZ+UOZ3wj4/K98lb95j8bMBL2gsYFCUHPTwty3CQ9lK09j2n8WPsAaHw==; Received: from c-67-171-18-24.hsd1.wa.comcast.net ([67.171.18.24] helo=[192.168.1.50]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1WnwR0-00051l-D8; Fri, 23 May 2014 13:51:22 -0700 Message-ID: <537FB4C8.3080809@dancol.org> Date: Fri, 23 May 2014 13:51:20 -0700 From: Daniel Colascione User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <87ppj4ette.fsf@secretsauce.net> In-Reply-To: <87ppj4ette.fsf@secretsauce.net> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QXtcrQ3C9DSMng74vO5bV4lRkA5a0kjXr" X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QXtcrQ3C9DSMng74vO5bV4lRkA5a0kjXr Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/23/2014 02:19 AM, Dima Kogan wrote: > Hi. I'm using a very recent build of emacs from the VCS. With this buil= d > ERC gets very confused if global-subword-mode is on. I believe it worke= d > fine just a few months ago. >=20 > Recipe: >=20 > 1. emacs -Q > 2. (global-subword-mode) > 3. M-x erc > 4. Default values for the server, nickname, password, etc are fine to > show the issue Thanks for the repro. This bug is probably due to my changing how subword-mode works: now, forward-word will stop at subword boundaries, and I'm guessing ERC was relying on the old behavior. I can try to take a look at it if nobody who knows ERC better wants to try first. --QXtcrQ3C9DSMng74vO5bV4lRkA5a0kjXr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTf7TIAAoJEMAaIROpHW7IgWwP/03pSTEX/M72PHh5dYmRCSzo WfEuo7m2Yf7XiSynAnzgM1i5WWd0agBCXfP3iTi5aLA4dG8xFpfHdGch1KkpDWW+ VyB1L/9igI5+DAWYsQSnnXtSi5GA7Qljys9uReiCsOaj426t6a0CW+/IgfkglHsz Lj2bVcngeP5DQmQShpWZyfA5NmhYTdFwrEhrqCtttAgYLg23cCC8aLfp0HUlkojX 02G2d096c+HW+bXZoNeWnYsguVdyRDFiFkePzmfvYrR8uHHCMGb+AyKnhTmHdoLq ls9urMqeu68JV6Up2ovKAVmXRJjMJ8lLEsxJ7Ip2yDTBEvPo7fAT9Wff9WrA/yai Sr2cvzcsO//d3sR5jKiNci8cw5IOEWvVZIQO+lIyEmsgeVz3+HpZwxJDyE/yTZf8 KQpBJQCe60B6V9AOMgvugxuugoom+beOnDMQSb1KoxZtOawSGvf92LYdylCK+42M x76zBKdOXDWpalO8OHBeiVsZUpUoL54byJXQiSMLBSjSzw6QzvmrNsRf3INMiOKF MmG5UHToFCTYGeFsL8gkJv/6qG/l2NHoUjzUXX15fTi0yMJMOWxcmJmnhmI+cwti Xd3Jf+JBqqkpgyMFiAbTM+UGxLjElbWkQHpiLUXH76hm+V+HiTUbcSujsl6lqmIh 72wbaCBsj+6x8k/s94BO =k8y+ -----END PGP SIGNATURE----- --QXtcrQ3C9DSMng74vO5bV4lRkA5a0kjXr-- From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Dec 2014 09:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Colascione Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.142001654424498 (code B ref 17558); Wed, 31 Dec 2014 09:03:01 +0000 Received: (at 17558) by debbugs.gnu.org; 31 Dec 2014 09:02:24 +0000 Received: from localhost ([127.0.0.1]:33307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6FAd-0006N4-KZ for submit@debbugs.gnu.org; Wed, 31 Dec 2014 04:02:24 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40150) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6FAb-0006Mw-80 for 17558@debbugs.gnu.org; Wed, 31 Dec 2014 04:02:21 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 033B0205D3 for <17558@debbugs.gnu.org>; Wed, 31 Dec 2014 04:02:20 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Wed, 31 Dec 2014 04:02:21 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=W4dKdY2GH5GG 2HC6dTyJnm6jJRg=; b=idwgWzFh9jUJ0Hsw2EoXIN/mk5+yAy4QYZaY0j34amXr 6Kotd4OTlDNDqrnNh1zl3mCKe6miHhqLB4SV5vjkCwfUQnRop9KUK0iwmw65D3mR bmh6KhsuJ4Beopu0zK+lHwB6OjBCEkYHB+ShrQEg3phC4U2491urDg2cDiXa/FI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=W4dKdY2GH5GG2HC6dTyJnm6jJRg=; b=iPiN9+slM2u5UzlBz+PX ja+xiYqDW9j9NJtKJdNcOP7/eBl2wByJrWCQ4GrCkirbTtaDsCiqu3PAs1hZI+qK nAtz74dEYSlaKMEOQaoZ4HbO1o0o57O25JjMQTts6AGAP4SvY18wmMH5SEIS44Ku 6I7BQs9gcZ6nvQr+PWnIYxw= X-Sasl-enc: fxiyAp11VaC/XaTvIKGGF2a/90U/e0uuPeATRulcQAS4 1420016526 Received: from shorty.local (unknown [208.54.64.204]) by mail.messagingengine.com (Postfix) with ESMTPA id 1EF00C0027D; Wed, 31 Dec 2014 04:02:06 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y6FAB-0002Tk-KE; Wed, 31 Dec 2014 01:01:55 -0800 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> From: Dima Kogan Date: Wed, 31 Dec 2014 01:01:35 -0800 In-reply-to: <537FB4C8.3080809@dancol.org> Message-ID: <87a924mbuk.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Daniel Colascione writes: > On 05/23/2014 02:19 AM, Dima Kogan wrote: >> Hi. I'm using a very recent build of emacs from the VCS. With this build >> ERC gets very confused if global-subword-mode is on. I believe it worked >> fine just a few months ago. >> >> Recipe: >> >> 1. emacs -Q >> 2. (global-subword-mode) >> 3. M-x erc >> 4. Default values for the server, nickname, password, etc are fine to >> show the issue > > Thanks for the repro. This bug is probably due to my changing how > subword-mode works: now, forward-word will stop at subword boundaries, > and I'm guessing ERC was relying on the old behavior. I can try to take > a look at it if nobody who knows ERC better wants to try first. Here's a patch. It works, but I don't like how un-future-proof it is. An uncareful coder can simply use (forward-word) somewhere and get things to break again. Is there a better way? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ERC-no-longer-gets-confused-by-subword-mode.patch >From 655e7b9b5735bd62aac104645b5a224636ab97ff Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Tue, 30 Dec 2014 23:29:21 -0800 Subject: [PATCH] ERC no longer gets confused by subword-mode In commit 6ddc44225e743e2b2a0d5c192f50aefd7a4a915b subword-mode was integrated into the syntax table instead of simply remapping the interactive motion bindings as was done previously. This had the unintended effect of changing the behavior of lisp programs that touch words. In the case of ERC, it completely broke it: emacs now throws an error when ERC is launched, making it unusable when subword-mode is active. This commit temporarily disables subword-mode so that ERC functions that touch words do so the "normal" way. Closes: #17558 --- lisp/erc/erc-backend.el | 9 ++++++++- lisp/erc/erc-button.el | 23 +++++++++++++++-------- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index bedb20f..fa95d7e 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -480,7 +480,14 @@ Currently this is called by `erc-send-input'." (with-temp-buffer (insert str) (goto-char (point-min)) - (upcase-word 1) + + ;; If we're in subword-mode then functions operating on words act + ;; differently. Here I temporarily disable subword-mode before + ;; touching the words + (let ((find-word-boundary-function-table + (if (boundp 'subword-empty-char-table) + subword-empty-char-table find-word-boundary-function-table))) + (upcase-word 1)) (buffer-string))) (defun erc-server-setup-periodical-ping (buffer) diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el index 10e7318..8343425 100644 --- a/lisp/erc/erc-button.el +++ b/lisp/erc/erc-button.el @@ -300,14 +300,21 @@ specified by `erc-button-alist'." (when (or (eq t form) (eval form)) (goto-char (point-min)) - (while (forward-word 1) - (setq bounds (bounds-of-thing-at-point 'word)) - (setq word (buffer-substring-no-properties - (car bounds) (cdr bounds))) - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) - (and erc-channel-users (erc-get-channel-user word))) - (erc-button-add-button (car bounds) (cdr bounds) - fun t (list word))))))) + + ;; If we're in subword-mode then functions operating on words + ;; act differently. Here I temporarily disable subword-mode + ;; before touching the words + (let ((find-word-boundary-function-table + (if (boundp 'subword-empty-char-table) + subword-empty-char-table find-word-boundary-function-table))) + (while (forward-word 1) + (setq bounds (bounds-of-thing-at-point 'word)) + (setq word (buffer-substring-no-properties + (car bounds) (cdr bounds))) + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) + (and erc-channel-users (erc-get-channel-user word))) + (erc-button-add-button (car bounds) (cdr bounds) + fun t (list word)))))))) (defun erc-button-add-buttons-1 (regexp entry) "Search through the buffer for matches to ENTRY and add buttons." -- 2.1.3 --=-=-=-- From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Dec 2014 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Colascione Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.142005948524992 (code B ref 17558); Wed, 31 Dec 2014 20:59:02 +0000 Received: (at 17558) by debbugs.gnu.org; 31 Dec 2014 20:58:05 +0000 Received: from localhost ([127.0.0.1]:33996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6QLF-0006V1-6e for submit@debbugs.gnu.org; Wed, 31 Dec 2014 15:58:05 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52977) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6QLB-0006UU-Em for 17558@debbugs.gnu.org; Wed, 31 Dec 2014 15:58:02 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3272320676 for <17558@debbugs.gnu.org>; Wed, 31 Dec 2014 15:57:59 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Wed, 31 Dec 2014 15:57:59 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=GvRJ4BN7iyuz /hPtfSuj4XAJIHw=; b=ApfgQT7e+kUIMImrRspWafVpONWUVtiBMmmvP/KItxxg VyLEklAvp3ZR9oBT1fy1R/or+keewao2YO3XYmoE1wDMSey3GonWHqjOKhVavAkH kDyIpF96q8JfAAXUT2IznV/AbTGTAg5YC7hyQvyKkMou0mOAdA3AI4u/yPQzkxc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=GvRJ4BN7iyuz/hPtfSuj4XAJIHw=; b=okH3EwnPF1S5uJdCriaa fqrCwQ4Jk1UmxFXPyEIcL9/qQSSwswtGBjOXMAIt+llH7EYqnQy0CIgBtO19Lkv1 v1M0iCigX8eYfUFyqLOh1VdYxh315VNUOuerNZKlGOxTgE9REP57XYkX6xo640vS E/xePYfIs3ZbzE7XKiMDi6w= X-Sasl-enc: DcGXdfG2RrItUWGZRAHhl2koONF2r8hzcVlNob3b3lnq 1420059478 Received: from shorty.local (unknown [174.28.80.18]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B92BC00281; Wed, 31 Dec 2014 15:57:58 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y6EwA-0002Of-TT; Wed, 31 Dec 2014 00:47:26 -0800 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> From: Dima Kogan Date: Wed, 31 Dec 2014 00:46:39 -0800 In-reply-to: <537FB4C8.3080809@dancol.org> Message-ID: <87d270mciq.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Daniel Colascione writes: > On 05/23/2014 02:19 AM, Dima Kogan wrote: >> Hi. I'm using a very recent build of emacs from the VCS. With this build >> ERC gets very confused if global-subword-mode is on. I believe it worked >> fine just a few months ago. >> >> Recipe: >> >> 1. emacs -Q >> 2. (global-subword-mode) >> 3. M-x erc >> 4. Default values for the server, nickname, password, etc are fine to >> show the issue > > Thanks for the repro. This bug is probably due to my changing how > subword-mode works: now, forward-word will stop at subword boundaries, > and I'm guessing ERC was relying on the old behavior. I can try to take > a look at it if nobody who knows ERC better wants to try first. Here's a patch. It works, but I don't like how un-future-proof it is. An uncareful coder can simply use (forward-word) somewhere and get things to break again. Is there a better way? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ERC-no-longer-gets-confused-by-subword-mode.patch >From 655e7b9b5735bd62aac104645b5a224636ab97ff Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Tue, 30 Dec 2014 23:29:21 -0800 Subject: [PATCH] ERC no longer gets confused by subword-mode In commit 6ddc44225e743e2b2a0d5c192f50aefd7a4a915b subword-mode was integrated into the syntax table instead of simply remapping the interactive motion bindings as was done previously. This had the unintended effect of changing the behavior of lisp programs that touch words. In the case of ERC, it completely broke it: emacs now throws an error when ERC is launched, making it unusable when subword-mode is active. This commit temporarily disables subword-mode so that ERC functions that touch words do so the "normal" way. Closes: #17558 --- lisp/erc/erc-backend.el | 9 ++++++++- lisp/erc/erc-button.el | 23 +++++++++++++++-------- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index bedb20f..fa95d7e 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -480,7 +480,14 @@ Currently this is called by `erc-send-input'." (with-temp-buffer (insert str) (goto-char (point-min)) - (upcase-word 1) + + ;; If we're in subword-mode then functions operating on words act + ;; differently. Here I temporarily disable subword-mode before + ;; touching the words + (let ((find-word-boundary-function-table + (if (boundp 'subword-empty-char-table) + subword-empty-char-table find-word-boundary-function-table))) + (upcase-word 1)) (buffer-string))) (defun erc-server-setup-periodical-ping (buffer) diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el index 10e7318..8343425 100644 --- a/lisp/erc/erc-button.el +++ b/lisp/erc/erc-button.el @@ -300,14 +300,21 @@ specified by `erc-button-alist'." (when (or (eq t form) (eval form)) (goto-char (point-min)) - (while (forward-word 1) - (setq bounds (bounds-of-thing-at-point 'word)) - (setq word (buffer-substring-no-properties - (car bounds) (cdr bounds))) - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) - (and erc-channel-users (erc-get-channel-user word))) - (erc-button-add-button (car bounds) (cdr bounds) - fun t (list word))))))) + + ;; If we're in subword-mode then functions operating on words + ;; act differently. Here I temporarily disable subword-mode + ;; before touching the words + (let ((find-word-boundary-function-table + (if (boundp 'subword-empty-char-table) + subword-empty-char-table find-word-boundary-function-table))) + (while (forward-word 1) + (setq bounds (bounds-of-thing-at-point 'word)) + (setq word (buffer-substring-no-properties + (car bounds) (cdr bounds))) + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) + (and erc-channel-users (erc-get-channel-user word))) + (erc-button-add-button (car bounds) (cdr bounds) + fun t (list word)))))))) (defun erc-button-add-buttons-1 (regexp entry) "Search through the buffer for matches to ENTRY and add buttons." -- 2.1.3 --=-=-=-- From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jan 2015 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dima Kogan Cc: Daniel Colascione , 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.142013058622164 (code B ref 17558); Thu, 01 Jan 2015 16:44:01 +0000 Received: (at 17558) by debbugs.gnu.org; 1 Jan 2015 16:43:06 +0000 Received: from localhost ([127.0.0.1]:34598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6iq1-0005lP-DS for submit@debbugs.gnu.org; Thu, 01 Jan 2015 11:43:05 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:33345) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6ipz-0005lH-9X for 17558@debbugs.gnu.org; Thu, 01 Jan 2015 11:43:03 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t01GgvXn032162; Thu, 1 Jan 2015 11:42:57 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C088AAE130; Thu, 1 Jan 2015 11:42:56 -0500 (EST) From: Stefan Monnier Message-ID: References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> Date: Thu, 01 Jan 2015 11:42:56 -0500 In-Reply-To: <87a924mbuk.fsf@secretsauce.net> (Dima Kogan's message of "Wed, 31 Dec 2014 01:01:35 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5173=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5173> : inlines <1719> : streams <1366504> : uri <1840837> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> Thanks for the repro. This bug is probably due to my changing how >> subword-mode works: now, forward-word will stop at subword boundaries, >> and I'm guessing ERC was relying on the old behavior. I can try to take >> a look at it if nobody who knows ERC better wants to try first. Indeed, with the new implementation of subword-mode, most of the word-operating commands should be marked as "interactive use only", since their behavior is too unreliable for use in Lisp code. > - (upcase-word 1) > + > + ;; If we're in subword-mode then functions operating on words act > + ;; differently. Here I temporarily disable subword-mode before > + ;; touching the words > + (let ((find-word-boundary-function-table > + (if (boundp 'subword-empty-char-table) > + subword-empty-char-table find-word-boundary-function-table))) > + (upcase-word 1)) Yuck. I suggest you use upcase-region instead (and probably something like skip-char-forward to find the word's boundaries). > - (while (forward-word 1) > - (setq bounds (bounds-of-thing-at-point 'word)) > - (setq word (buffer-substring-no-properties > - (car bounds) (cdr bounds))) > - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) > - (and erc-channel-users (erc-get-channel-user word))) > - (erc-button-add-button (car bounds) (cdr bounds) > - fun t (list word))))))) > + > + ;; If we're in subword-mode then functions operating on words > + ;; act differently. Here I temporarily disable subword-mode > + ;; before touching the words > + (let ((find-word-boundary-function-table > + (if (boundp 'subword-empty-char-table) > + subword-empty-char-table find-word-boundary-function-table))) > + (while (forward-word 1) > + (setq bounds (bounds-of-thing-at-point 'word)) > + (setq word (buffer-substring-no-properties > + (car bounds) (cdr bounds))) > + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) > + (and erc-channel-users (erc-get-channel-user word))) > + (erc-button-add-button (car bounds) (cdr bounds) > + fun t (list word)))))))) Similarly here, we should use "word" operations at all. Maybe forward-sexp can be used instead of forward-word, or else skip-syntax-forward or skip-chars-forward. The call to (bounds-of-thing-at-point 'word) should be avoided as well (we already know the end of the bounds is (point) anyway and we can probably find the other bound at the same time as we skip-chars-forward. Stefan From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jan 2015 21:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.142014896118263 (code B ref 17558); Thu, 01 Jan 2015 21:50:01 +0000 Received: (at 17558) by debbugs.gnu.org; 1 Jan 2015 21:49:21 +0000 Received: from localhost ([127.0.0.1]:34713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6ncO-0004kV-PN for submit@debbugs.gnu.org; Thu, 01 Jan 2015 16:49:21 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57123) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y6ncK-0004kK-5f for 17558@debbugs.gnu.org; Thu, 01 Jan 2015 16:49:17 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A9EAF207B6 for <17558@debbugs.gnu.org>; Thu, 1 Jan 2015 16:49:15 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Thu, 01 Jan 2015 16:49:15 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=EOqzPXDtUl6I 2XD0tfd/ANOCu3s=; b=I4NU80wfNHC7zja/7E1QIAHGrjpO0VhnInHquxe9R2te cfgppc8Y1vxb/oeHbNXJZFNnqUdYd+1j0s2KMYydASi+OraGVeviu/LzLl8zIADF vhdnOqQmJSkoVUCoTpPMt197BzHgB2FbPsZVs9qaSZf6Wql4nPLhVteSTRmwiOk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=EOqzPXDtUl6I2XD0tfd/ANOCu3s=; b=UPTT7z3ilXeyLCLZrI5b eC0aYT38jgLrtKmP/JUMEjA1DaEVYyLYJuRJQiBkVD6vD5qcgmk6D7CpHzP4xfXk NIBYCfPpjyDUB9OjDcV3FpTzWqU0p2rIM6UMxmDu7VPV1PpvNn3A7waZKetPSSk1 vFUdqTpe34i3IuKL8vPB4xk= X-Sasl-enc: TBsU8fuq5BXTYcbOt1FOtDVghUtBsybceJ/KE+7VvmcC 1420148955 Received: from shorty.local (unknown [174.28.80.18]) by mail.messagingengine.com (Postfix) with ESMTPA id 042A5680107 for <17558@debbugs.gnu.org>; Thu, 1 Jan 2015 16:49:15 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y6ncD-0006yA-Vf for 17558@debbugs.gnu.org; Thu, 01 Jan 2015 13:49:09 -0800 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> From: Dima Kogan Date: Thu, 01 Jan 2015 13:47:41 -0800 In-reply-to: Message-ID: <871tnemasq.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> - (upcase-word 1) >> + >> + ;; If we're in subword-mode then functions operating on words act >> + ;; differently. Here I temporarily disable subword-mode before >> + ;; touching the words >> + (let ((find-word-boundary-function-table >> + (if (boundp 'subword-empty-char-table) >> + subword-empty-char-table find-word-boundary-function-table))) >> + (upcase-word 1)) > > Yuck. I suggest you use upcase-region instead (and probably something > like skip-char-forward to find the word's boundaries). OK. New patch attached. It's a bit less ugly, maybe; still pretty verbose. Marking the -word functions as interactive-only would be a great thing to do. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ERC-no-longer-gets-confused-by-subword-mode.patch >From 3017aba1093c8f57d3a3b7193692d62a56b68d3b Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Tue, 30 Dec 2014 23:29:21 -0800 Subject: [PATCH] ERC no longer gets confused by subword-mode In commit 6ddc44225e743e2b2a0d5c192f50aefd7a4a915b subword-mode was integrated into the syntax table instead of simply remapping the interactive motion bindings as was done previously. This had the unintended effect of changing the behavior of lisp programs that touch words. In the case of ERC, it completely broke it: emacs now throws an error when ERC is launched, making it unusable when subword-mode is active. This commit replaces the word-oriented calls with ones that navigate the buffer using syntax classes Closes: #17558 --- lisp/erc/erc-backend.el | 11 ++++++++++- lisp/erc/erc-button.el | 30 ++++++++++++++++++++++-------- 2 files changed, 32 insertions(+), 9 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index 1ef494c..0e80438 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -480,7 +480,16 @@ Currently this is called by `erc-send-input'." (with-temp-buffer (insert str) (goto-char (point-min)) - (upcase-word 1) + + ;; this is (upcase-word 1), but working even with subword-mode + ;; active + (skip-syntax-forward "^w") + (let* + ((word-start (point)) + (word-end + (progn (skip-syntax-forward "w") (point)))) + (upcase-region word-start word-end)) + (buffer-string))) (defun erc-server-setup-periodical-ping (buffer) diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el index 10e7318..d194627 100644 --- a/lisp/erc/erc-button.el +++ b/lisp/erc/erc-button.el @@ -300,14 +300,28 @@ specified by `erc-button-alist'." (when (or (eq t form) (eval form)) (goto-char (point-min)) - (while (forward-word 1) - (setq bounds (bounds-of-thing-at-point 'word)) - (setq word (buffer-substring-no-properties - (car bounds) (cdr bounds))) - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) - (and erc-channel-users (erc-get-channel-user word))) - (erc-button-add-button (car bounds) (cdr bounds) - fun t (list word))))))) + + (while + (progn + + ;; I move forward a word (independent of subword-mode) ... + (skip-syntax-forward "^w") + (let* + ((word-start (point)) + (word-end + (progn (skip-syntax-forward "w") (point)))) + + ;; ... if the word was empty we're at the end of buffer ... + (and (/= word-start word-end) + + ;; ... otherwise, we do stuff with this word + (progn + (setq word (buffer-substring-no-properties + word-start word-end)) + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) + (and erc-channel-users (erc-get-channel-user word))) + (erc-button-add-button word-start word-end + fun t (list word))))))))))) (defun erc-button-add-buttons-1 (regexp entry) "Search through the buffer for matches to ENTRY and add buttons." -- 2.1.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 16 13:24:10 2015 Received: (at control) by debbugs.gnu.org; 16 Apr 2015 17:24:10 +0000 Received: from localhost ([127.0.0.1]:58291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YinWL-0007Dm-DB for submit@debbugs.gnu.org; Thu, 16 Apr 2015 13:24:09 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:44383 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YinWJ-0007De-Qz for control@debbugs.gnu.org; Thu, 16 Apr 2015 13:24:08 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YinWJ-0001H1-Ga for control@debbugs.gnu.org; Thu, 16 Apr 2015 13:24:07 -0400 Date: Thu, 16 Apr 2015 13:24:07 -0400 Message-Id: Subject: control message for bug 20347 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 17558 20347 From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC In-Reply-To: <87ppj4ette.fsf@secretsauce.net> Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2015 20:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Daniel Colascione , Dima Kogan , 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.143016500922926 (code B ref 17558); Mon, 27 Apr 2015 20:04:02 +0000 Received: (at 17558) by debbugs.gnu.org; 27 Apr 2015 20:03:29 +0000 Received: from localhost ([127.0.0.1]:41576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmpFY-0005xh-LN for submit@debbugs.gnu.org; Mon, 27 Apr 2015 16:03:29 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:45614 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmpFX-0005xa-FJ for 17558@debbugs.gnu.org; Mon, 27 Apr 2015 16:03:27 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YmpFS-0003Lu-4o; Mon, 27 Apr 2015 16:03:22 -0400 From: Glenn Morris References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> X-Spook: target Guantanamo encryption sweep Exon Shell insurgency X-Ran: ]!MW)ZQ(HsDY(V7O1TdAz;xf1h,_-%UrYO>r X-Hue: magenta X-Attribution: GM Date: Mon, 27 Apr 2015 16:03:21 -0400 Message-ID: <8rvbghcp9y.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Stefan Monnier wrote: > Indeed, with the new implementation of subword-mode, most of the > word-operating commands should be marked as "interactive use only", > since their behavior is too unreliable for use in Lisp code. Sounds to me like it will be a PITA to review/replace every non-interactive usage of those commands. Are people certain they want to go down this road? (At time of writing, I don't see any mention of forward-word etc no longer being safe in NEWS.) From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2015 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris , Stefan Monnier Cc: Dima Kogan , 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.143017387826032 (code B ref 17558); Mon, 27 Apr 2015 22:32:02 +0000 Received: (at 17558) by debbugs.gnu.org; 27 Apr 2015 22:31:18 +0000 Received: from localhost ([127.0.0.1]:41687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmrYa-0006lm-FT for submit@debbugs.gnu.org; Mon, 27 Apr 2015 18:31:17 -0400 Received: from dancol.org ([96.126.100.184]:58802) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmrYX-0006ld-QW for 17558@debbugs.gnu.org; Mon, 27 Apr 2015 18:31:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=KBj9dFHY8RqTJkO6n6hsjiE/+0LHeJf/w82y3CyK4hM=; b=lqcaqo+O+LbSlB900N8IW64ROppKIFbCSYtrlrg/pew6UEz7jkxZfM2zy6ySHqoGP070PQakouxZE6/PxVJtrcsqmeuI06lpaBtrAahuk4HUe7s9dvcX4gZEVNDNoAo6Rasxuvb0I/D120JtNNuwAF0yJAMHnp/6+FpqejmRfX26gRpOqH9IYgIA+3s8suD/YlvYlAxZuSkxeauZU+nc4fCTtTmu3GH/S1PV6NJXSRgKS6n3syiX6Zd5SKdQuGYEPLG+NsVhMyfvlhBT7mNw9p8YvhZ49vItToGIumhr8ojtKb0mFmJK90fnpfRzbHv2YKRssKubZ7pDZ3+l46OhoQ==; Received: from [2620:10d:c083:10fb:2ab2:bdff:fe1c:db58] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1YmrYU-0006Q3-PX; Mon, 27 Apr 2015 15:31:10 -0700 Message-ID: <553EB8A7.7070103@dancol.org> Date: Mon, 27 Apr 2015 15:31:03 -0700 From: Daniel Colascione User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> In-Reply-To: <8rvbghcp9y.fsf@fencepost.gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="POV8US5jiifLU0FlgWKGBFoM8uUHJ0U16" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --POV8US5jiifLU0FlgWKGBFoM8uUHJ0U16 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 04/27/2015 01:03 PM, Glenn Morris wrote: > Stefan Monnier wrote: >=20 >> Indeed, with the new implementation of subword-mode, most of the >> word-operating commands should be marked as "interactive use only", >> since their behavior is too unreliable for use in Lisp code. >=20 > Sounds to me like it will be a PITA to review/replace every > non-interactive usage of those commands. >=20 > Are people certain they want to go down this road? I am. It's the only way we can make sure that interactive commands that move by words *indirectly* do the right thing in the presence of user customizations. > (At time of writing, I don't see any mention of forward-word etc no > longer being safe in NEWS.) ERC is the only component I've heard of breaking. I don't think forward-word has *ever* been "safe" in the sense that you're suggesting. Modes almost always *actually* want sexp movement. --POV8US5jiifLU0FlgWKGBFoM8uUHJ0U16 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJVPrinAAoJEN4WImmbpWBl+TEP/2gOoZ4qQwVWSgNdb5jGfewz 9aiCuEpGetNQq0KEgQlIeFM80jzENpUNlvUeiQ5Esf9hHvIx45uUGGMbbCIJMmFK MqIZH725fDdKlr+ZwCZ+C2ftjg/35OnUz2eQEBO4bveTQPjc7PF2oT+ncpqWqpU8 BRbM/H6oHXWsXVrkSDc1SKwTwvaFFlPkc/1JfzaKTlomeiuSOpKwc8pkhwDXKx5w mMkJDMT8ILQ/hWYybcdnjlTZJUswqT7y52nr/ZbFb0Y/MspJeUpFP+JeuP0iQIwc dt/5A9d/sB6PSnAJpY7a4OCyDLOfSpU10+an9HJX4e4kyWWow2K8EYW0lum2WSEx omMhvVrA5m8G5PsNCs6TCibRSo8KoFcVzjhfqC1yOxVaHAxGj7wQrfbExOzexgMW 0bf3va3JdNNBKAmRRaGKStVOXuUrQL68vXOOE2HE4wpwG3pwR+QsZMrIm62NK0SF 1yV3Yp03xWJawHsXCP8qMONMIrNH2nMSYSWaWI0R8qdey7VNlRWoqRI6Y+2OtHha 3grXzpkesQRRyABdgK5ymthOqizJYUV6pZP4Z5czDSzgGIbZR2+x5hejH+uQpya9 JGcczqWK6N+7zT30AOkZoOsf07LLbOHjb7qMfzdhC9JIyFdSMpIl58Jn+LofvMVa f650OiMGVS9UsCoCiB2Y =0G2k -----END PGP SIGNATURE----- --POV8US5jiifLU0FlgWKGBFoM8uUHJ0U16-- From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2015 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Colascione , Glenn Morris , Stefan Monnier Cc: Dima Kogan , 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.143017706530889 (code B ref 17558); Mon, 27 Apr 2015 23:25:02 +0000 Received: (at 17558) by debbugs.gnu.org; 27 Apr 2015 23:24:25 +0000 Received: from localhost ([127.0.0.1]:41755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmsO1-000828-2J for submit@debbugs.gnu.org; Mon, 27 Apr 2015 19:24:25 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:24960) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmsNz-00081u-AC for 17558@debbugs.gnu.org; Mon, 27 Apr 2015 19:24:24 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3RNOAjS015618 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 27 Apr 2015 23:24:10 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t3RNO83W016074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 27 Apr 2015 23:24:08 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t3RNO7BP017494; Mon, 27 Apr 2015 23:24:07 GMT MIME-Version: 1.0 Message-ID: <215222bf-164d-4547-af43-8d24b488c80d@default> Date: Mon, 27 Apr 2015 16:24:07 -0700 (PDT) From: Drew Adams References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> In-Reply-To: <553EB8A7.7070103@dancol.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > >> Indeed, with the new implementation of subword-mode, most of the > >> word-operating commands should be marked as "interactive use > >> only", since their behavior is too unreliable for use in Lisp code. > > > > Sounds to me like it will be a PITA to review/replace every > > non-interactive usage of those commands. > > Are people certain they want to go down this road? >=20 > I am. It's the only way we can make sure that interactive commands > that move by words *indirectly* do the right thing in the presence of > user customizations. Mille excuses - I have not been following this thread. Just what is meant by "non-interactive use of `forward-word' and `backward-word'"? Any call to either of them in Lisp code? And what is meant by "*indirectly*". Will you be telling users (e.g. in NEWS) precisely *how* they need to modify existing non-interactive calls to those functions? Saying that they should be used only interactively from now on does not tell users how to fix existing code that calls them. And just what is unsafe about calling these two functions from Lisp? Sorry, but this is not clear to me. (And why not create new functions/commands, instead of changing the meaning/behavior of these longstanding ones?) > > (At time of writing, I don't see any mention of forward-word etc > > no longer being safe in NEWS.) >=20 > ERC is the only component I've heard of breaking. I don't think > forward-word has *ever* been "safe" in the sense that you're > suggesting. Modes almost always *actually* want sexp movement. From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2015 23:31:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams , Glenn Morris , Stefan Monnier Cc: Dima Kogan , 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.143017743331529 (code B ref 17558); Mon, 27 Apr 2015 23:31:03 +0000 Received: (at 17558) by debbugs.gnu.org; 27 Apr 2015 23:30:33 +0000 Received: from localhost ([127.0.0.1]:41763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmsTv-0008CS-Oe for submit@debbugs.gnu.org; Mon, 27 Apr 2015 19:30:32 -0400 Received: from dancol.org ([96.126.100.184]:59045) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmsTn-0008C6-VZ for 17558@debbugs.gnu.org; Mon, 27 Apr 2015 19:30:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=ArdHLvgbgb7pmUkDZVNDZTfD21tjgr8hLstin3Qeu4E=; b=puPIh++rDtHLcO+NJpK25YIAUcqlpEuTiTg4M+0NdnSAmoAcLtnMy6wHmc2CyKNgKcrDdr1pzaeM+ziNvzLQHQL4fERpa7YyZqCNbOmMwZCQKDsoo7bfKmxHqq0xNbCkHEXZFR1oiNAdiZ9AVDJlHGDNhlToIujhP+I/by+Rjrqvz10OnHKbe8oZXvD7AeSxv/omGnNZm6sE8PYBxA+7UclNWDryG1Cfa/NzpP49gSMzAUEA1htFe2RTbsAAoUUaiesrZ0oRs4uqHcMaJZfaGhFAL9xJz8ieVLy2bNvqXTY6F5lad8fTAiCUvXnZufIw03dnRph2vOtkWWwho+ZUDA==; Received: from [2620:10d:c083:10fb:2ab2:bdff:fe1c:db58] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1YmsTm-0006pI-MI; Mon, 27 Apr 2015 16:30:22 -0700 Message-ID: <553EC687.7080807@dancol.org> Date: Mon, 27 Apr 2015 16:30:15 -0700 From: Daniel Colascione User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <215222bf-164d-4547-af43-8d24b488c80d@default> In-Reply-To: <215222bf-164d-4547-af43-8d24b488c80d@default> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uv6QhUFcbs3xSMc22CI6Hbaj6I7qltnpV" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uv6QhUFcbs3xSMc22CI6Hbaj6I7qltnpV Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 04/27/2015 04:24 PM, Drew Adams wrote: >>>> Indeed, with the new implementation of subword-mode, most of the >>>> word-operating commands should be marked as "interactive use >>>> only", since their behavior is too unreliable for use in Lisp code. >>> >>> Sounds to me like it will be a PITA to review/replace every >>> non-interactive usage of those commands. >>> Are people certain they want to go down this road? >> >> I am. It's the only way we can make sure that interactive commands >> that move by words *indirectly* do the right thing in the presence of >> user customizations. >=20 > Mille excuses - I have not been following this thread. >=20 > Just what is meant by "non-interactive use of `forward-word' > and `backward-word'"? Any call to either of them in Lisp code? > And what is meant by "*indirectly*". Lisp code has no right to expect that "words" mean anything in particular. The scheme for detecting word boundaries is a user customization point. find-word-boundary-function-table has been supported for a while now, if not heavily used. > Will you be telling users (e.g. in NEWS) precisely *how* they > need to modify existing non-interactive calls to those functions? > Saying that they should be used only interactively from now on > does not tell users how to fix existing code that calls them. Code can either use sexp movement or bind find-word-boundary-function-table (which has been in Emacs for ages, by the way) to a value they expect. > And just what is unsafe about calling these two functions from > Lisp? Nothing: what's unsafe is expecting that users haven't customized word boundaries. >=20 > Sorry, but this is not clear to me. (And why not create new > functions/commands, instead of changing the meaning/behavior > of these longstanding ones?) Because lots of packages invoke word movement commands on the user's behalf, expecting that movement happens by words. By changing word boundaries, we make subword mode work as expected everywhere instead of making everyone that deals with word movement handle the possibility of subword-mode separately. The behavior of forward-word hasn't changed. We now make use of an Emacs core feature that was not heavily used before. Code that relied on this core feature going unused has always been broken. It's worth mentioning in NEWS, sure, but I'm against just rebinding the movement commands. --uv6QhUFcbs3xSMc22CI6Hbaj6I7qltnpV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJVPsaHAAoJEN4WImmbpWBlti8P/jmt0mxXKKKElKJeRBGmdhBb 0qK9X2eC0kVqNDvUOkL+NO61Y9Xk9/mNVqjk0naw/atFFKNUsc6eZDv0Gdo4MZxk JuVQkpCoKECrYvSrMDB3FRNKcawA9c9/ceh3IBxBj1Nho+fmcWNCvymPqQMHVD/V 6Hf82RErI2C9f7IhYvFPPLat5Rr/gEIpfobjIzM+wnEGk38DOFWzIdLvezdGp+Yh H2fE3phTd2JZ09Rpvl0ozAa93FfxYbcqAGZPvgKU/Y7pZwgbr5CJuQ7Y8WZpzTcs RF4URzKeZ0bl2iBJ521RAxOR0FxyPyclqMr0HX477Sr5/lNSTSUyaVP8y3HjGInK K969eMsdBje3bOY5PLS09WL8adEs7oHsqiut1wt9bd0+5gTdhWJNB9i00g3ewACA c2cZpSUPpupyI3P/FrUJkNFAoGjxsr+YYhw/btI1p/u9Fr2+6fIyWNJZS5lqQNzk gRQNu4wZzOmJRHDOkNOj1XvoI0fvPqQtp3WhzjCwLleaYnpNLSFjqXsrQv915TkY /do17XTobb48bHzsQguPvc8VC6T9APgjUQQrS4WpGEiKqTlTUP3G4cuEetgKVzgr xzmn6nTWMHDi76mx3e5BxsD4rvkY55NwDyCLJohNChR1GpCbj51kW0wsL5ZAwQzj tCJsrX11B+DMCCuwv5Fp =WwKv -----END PGP SIGNATURE----- --uv6QhUFcbs3xSMc22CI6Hbaj6I7qltnpV-- From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Apr 2015 00:01:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Colascione , Glenn Morris , Stefan Monnier Cc: Dima Kogan , 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.14301792193861 (code B ref 17558); Tue, 28 Apr 2015 00:01:03 +0000 Received: (at 17558) by debbugs.gnu.org; 28 Apr 2015 00:00:19 +0000 Received: from localhost ([127.0.0.1]:41775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ymswk-000109-0a for submit@debbugs.gnu.org; Mon, 27 Apr 2015 20:00:19 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45416) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ymswd-0000zS-Uq for 17558@debbugs.gnu.org; Mon, 27 Apr 2015 20:00:14 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3RNxvt5004746 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 27 Apr 2015 23:59:57 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t3RNxttP030939 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 27 Apr 2015 23:59:56 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t3RNxtW7004494; Mon, 27 Apr 2015 23:59:55 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 27 Apr 2015 16:59:55 -0700 (PDT) From: Drew Adams References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <215222bf-164d-4547-af43-8d24b488c80d@default> <553EC687.7080807@dancol.org> In-Reply-To: <553EC687.7080807@dancol.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Lisp code has no right to expect that "words" mean anything in > particular. Dunno whether it has any "rights" at all. ;-) Is it a bad idea that some Lisp code treats sequences of word-constituent chars as a group in some way? Should no Lisp code do that? > The scheme for detecting word boundaries is a user customization > point. find-word-boundary-function-table has been supported for > a while now, if not heavily used. I know nothing about that `*-table' - mea culpa. But what are \b and \B for in Elisp regexps, if not for matching word boundaries? > Code can either use sexp movement or bind > find-word-boundary-function-table (which has been in Emacs for ages, > by the way) to a value they expect. >=20 > what's unsafe is expecting that users haven't customized > word boundaries. Not sure what that means. But if a user changes a char so that it becomes or stops being a word-constituent char, that customization is handled by \b, \B, \w, and \W. If the magic table complicates the picture, does it also change how \b, \B, \w, and \W act? Are they sometimes broken, depending on user customization via that table? > lots of packages invoke word movement commands on the user's > behalf, expecting that movement happens by words. By changing word > boundaries, we make subword mode work as expected everywhere instead > of making everyone that deals with word movement handle the possibility > of subword-mode separately. Is this perhaps all about `subword-mode'? Just wondering. > The behavior of forward-word hasn't changed. We now make use of an > Emacs core feature that was not heavily used before. Code that relied > on this core feature going unused has always been broken. It's worth > mentioning in NEWS, sure, but I'm against just rebinding the > movement commands. Sounds complicated, but I won't try to deal with it here & now. Seems to me that both users and code can decide on the syntax classes for given characters, and code should be able to move over or otherwise manipulate "words" defined as sequences of word-constituent chars. If that's what's being proscribed now, then I might be disappointed. But it is probably more complex than my naive understanding of these things sees. Perhaps things are complicated because of the existence of subword mode? I will anyway wait for NEWS, to see what, if anything, I need to change in my code. From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC In-Reply-To: <87ppj4ette.fsf@secretsauce.net> Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Apr 2015 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Colascione Cc: 17558@debbugs.gnu.org, Stefan Monnier , Dima Kogan Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.143023981427878 (code B ref 17558); Tue, 28 Apr 2015 16:51:02 +0000 Received: (at 17558) by debbugs.gnu.org; 28 Apr 2015 16:50:14 +0000 Received: from localhost ([127.0.0.1]:42959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yn8i5-0007FZ-VA for submit@debbugs.gnu.org; Tue, 28 Apr 2015 12:50:14 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:44063 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yn8i2-0007FQ-F2 for 17558@debbugs.gnu.org; Tue, 28 Apr 2015 12:50:11 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Yn8hy-0006kO-DP; Tue, 28 Apr 2015 12:50:06 -0400 From: Glenn Morris References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> X-Spook: military CID Exon Shell SP4 unclassified USCOI emc X-Ran: W User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Daniel Colascione wrote: > I am. It's the only way we can make sure that interactive commands that > move by words *indirectly* do the right thing in the presence of user > customizations. Then I think the onus is on... someone to do the work that this entails: Fix erc (this report is one year old and has a patch); make (belated) NEWS entries; update the documentation relating to word motion commands; mark said commands interactive-only; address all resulting compilation warnings in the Emacs tree. From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Apr 2015 01:51:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: Daniel Colascione , Dima Kogan , 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.14302722211033 (code B ref 17558); Wed, 29 Apr 2015 01:51:03 +0000 Received: (at 17558) by debbugs.gnu.org; 29 Apr 2015 01:50:21 +0000 Received: from localhost ([127.0.0.1]:55367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnH8n-0000Ga-9R for submit@debbugs.gnu.org; Tue, 28 Apr 2015 21:50:21 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:10214) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnH8k-0000GK-KX for 17558@debbugs.gnu.org; Tue, 28 Apr 2015 21:50:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEFAGvvdVRMCqjW/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIwULCw4mEhQYDSSIE6IRjGQHAgECAQKDPgODcASjY4RY X-IPAS-Result: AnEFAGvvdVRMCqjW/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIwULCw4mEhQYDSSIE6IRjGQHAgECAQKDPgODcASjY4RY X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="117734744" Received: from 76-10-168-214.dsl.teksavvy.com (HELO pastel.home) ([76.10.168.214]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 28 Apr 2015 21:50:13 -0400 Received: by pastel.home (Postfix, from userid 20848) id B47C64650; Tue, 28 Apr 2015 21:50:12 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> Date: Tue, 28 Apr 2015 21:50:12 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 28 Apr 2015 12:50:02 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > mark said commands interactive-only; address all resulting compilation ^^^ most > warnings in the Emacs tree. Stefan "let's not push it too far" From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Apr 2015 02:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 17558@debbugs.gnu.org, Stefan Monnier , Dima Kogan Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.14302747224879 (code B ref 17558); Wed, 29 Apr 2015 02:32:02 +0000 Received: (at 17558) by debbugs.gnu.org; 29 Apr 2015 02:32:02 +0000 Received: from localhost ([127.0.0.1]:55383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnHn7-0001GZ-7x for submit@debbugs.gnu.org; Tue, 28 Apr 2015 22:32:01 -0400 Received: from dancol.org ([96.126.100.184]:38186) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnHn4-0001GQ-NM for 17558@debbugs.gnu.org; Tue, 28 Apr 2015 22:31:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=e52Mwstr8pJ/Jjw9SXGJsMPu8GjvGAuYbYLVPrqFCIM=; b=ZcoHoLwySeul5SmyZ/Ner/P6qJNe16Dj3AzctcJ9Yr7WQDN3vM8afhbXZflbF3zVIUeXHAjTGN4hiD+XRNzZHe8yL9RE7MK3NvKRcA8mPX129mfYDENiVAfpddR9VhRaLhi0fzqhi43mMfbhWplztit21w9vXtocJwO0I5mUbFvrpMTjSQRO5jksMSVQJtApbWrafrlQVF3g0ybzqDGdyZk4KHqP/2ruAZ0N91Uq5VcioVP+h4551O3D5NENbb+Ci46H3PtrdKHGCHaipVoma5UE6+6udS4g/mn1MpEhUmEnCVYwZHTFk0Uw+ebSwNN1b6UQ5XUCbbfPso8HPkzTug==; Received: from [2620:10d:c083:10fb:2ab2:bdff:fe1c:db58] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1YnHn2-0001IW-Bv; Tue, 28 Apr 2015 19:31:56 -0700 Message-ID: <55404294.40908@dancol.org> Date: Tue, 28 Apr 2015 19:31:48 -0700 From: Daniel Colascione User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vjEeI1nHP9jWGMK5TOToQFQFnJdveiDcC" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vjEeI1nHP9jWGMK5TOToQFQFnJdveiDcC Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 04/28/2015 09:50 AM, Glenn Morris wrote: > Daniel Colascione wrote: >=20 >> I am. It's the only way we can make sure that interactive commands tha= t >> move by words *indirectly* do the right thing in the presence of user >> customizations. >=20 > Then I think the onus is on... someone to do the work that this entails= : > Fix erc (this report is one year old and has a patch);=20 So let's apply the patch to ERC. > make (belated) > NEWS entries; update the documentation relating to word motion commands= ; I'll do that. > mark said commands interactive-only; address all resulting compilation > warnings in the Emacs tree. The functions aren't interactive-only though. It's perfectly legitimate for lisp code to want to move by words --- it's just that the user gets to define what "word" means. ispell-word, for example, really ought to use word motion commands. --vjEeI1nHP9jWGMK5TOToQFQFnJdveiDcC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJVQEKUAAoJEN4WImmbpWBlBBUP/3bHdWTu9G86QpQkOYJuxZcE yMm9LikMVDlBQge7L6UDpYBF1gemR+zERxg9+OvYBwMeHBxHeRWrCcpJo6oFknv6 ve1eI7eVPD3TzYUfwJu/0U+GNWM18MpjyIT+mq/Is+fYdI53Dn+BNrZiZuJDmE+m CwZY+hT0nBvvc55OLSJlZQdGr7B0DHbRwUt4fsFVF4Vtw0yFl3B+/wn1Kj+TG7eQ W9+BVba2biv8a9Fe4dNm7t1er6dMJLp3MsadydjbcDXizXDplfmi+52kNDEHM8f2 fj0sk4TTnCZKl/FDMN8453+NltzRY4Cc2Jh6YM3g0GYFOvQla/9KI5yMxVKXn+ZT 5DmBFPLKki3EkHqqMMVUy832DMMJsq4CfyLaVFhIRT/9r+v65KlkqApMd+DAWele +/Yuwv7lSjH8LPvG2RpBJHLtbaknPYy+X20cO9Q+5en8ZzhZFC+w42OXAYezf5SD 5g3V1A8f9DTmx78o3GzJ8G/mzerYABO9Q2cCnGO079t3nFwISqnAJmgrt1PpmPEP ms1M1QL8chjAST9cOliyD8+4bAJoZjzHScgqsGfSc2ekqKL8UjV85LFdMCSlM6ms 5KVmom+pRqNLkM4iyTDtn1sLO/XJ1YbuwIb0c7j+mVN1rsOQPc3lEWCcXqcyd+Pb Y7tkhcZVSCfgVBhMm/OK =5l+j -----END PGP SIGNATURE----- --vjEeI1nHP9jWGMK5TOToQFQFnJdveiDcC-- From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jul 2015 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.14369313442935 (code B ref 17558); Wed, 15 Jul 2015 03:36:01 +0000 Received: (at 17558) by debbugs.gnu.org; 15 Jul 2015 03:35:44 +0000 Received: from localhost ([127.0.0.1]:49471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZFDTz-0000lF-Gf for submit@debbugs.gnu.org; Tue, 14 Jul 2015 23:35:43 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60318) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZFDTw-0000l4-IC for 17558@debbugs.gnu.org; Tue, 14 Jul 2015 23:35:41 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0B8D22119E for <17558@debbugs.gnu.org>; Tue, 14 Jul 2015 23:35:40 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 14 Jul 2015 23:35:40 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=bdw1m m01QTvmpgrXYIZm5o4tvB8=; b=E1sdI3O5Bum81X6ekhwAQQidlR9eRoyiSVGrr v/BVW20hW0ra6emPeJ4VwMw5d0g9tTLgx9g+XcMAQqEnqAO4flGW/lubfzEac1Zx 0gh8bJBfhZkPzHJobZlZxMA8tLCb++BTENXtk8SjotpjuP5dCXbQLAmayXxiAIK0 1QJcwg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=bdw1mm01QTvmpgrXYIZm5o4tvB8=; b=Sg/io W/EbR8X/GIQ4Z5CkwZBXOETr0Qdi5X/gCn1ZFGTrJ474M84K/8qeSWY8syq4xs/p V+Iq+0k2Tgxefk72Cg//6OjyUxzQLSaULBiN1ZOQeo3OIZPCoQRjXVJ3b3WG4jBr uf73Howaz28Amxy+iDBupIkwloplPCVcaZdh6Q= X-Sasl-enc: OnQwuzLndQaxKv3kDA7sGP13s9S+QJyAZL0IBZF8Rbmb 1436931339 Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id A5297C0001F for <17558@debbugs.gnu.org>; Tue, 14 Jul 2015 23:35:39 -0400 (EDT) Received: from localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1ZFDVg-0000zM-IU for 17558@debbugs.gnu.org; Tue, 14 Jul 2015 20:37:28 -0700 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> From: Dima Kogan In-reply-to: <55404294.40908@dancol.org> Date: Tue, 14 Jul 2015 20:37:28 -0700 Message-ID: <87y4iiw0p3.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Daniel Colascione writes: > On 04/28/2015 09:50 AM, Glenn Morris wrote: > >> Then I think the onus is on... someone to do the work that this entails: >> Fix erc (this report is one year old and has a patch); > > So let's apply the patch to ERC. Hi. Can somebody please apply this patch? ERC from HEAD is completely broken without it. From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Dec 2015 21:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dima Kogan Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.145116640216905 (code B ref 17558); Sat, 26 Dec 2015 21:47:01 +0000 Received: (at 17558) by debbugs.gnu.org; 26 Dec 2015 21:46:42 +0000 Received: from localhost ([127.0.0.1]:42240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCwfi-0004Ob-HB for submit@debbugs.gnu.org; Sat, 26 Dec 2015 16:46:42 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:54578) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCwfh-0004OU-BP for 17558@debbugs.gnu.org; Sat, 26 Dec 2015 16:46:41 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCwfL-0005UO-7F; Sat, 26 Dec 2015 22:46:19 +0100 From: Lars Ingebrigtsen References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> <87y4iiw0p3.fsf@secretsauce.net> Date: Sat, 26 Dec 2015 22:46:18 +0100 In-Reply-To: <87y4iiw0p3.fsf@secretsauce.net> (Dima Kogan's message of "Tue, 14 Jul 2015 20:37:28 -0700") Message-ID: <87wps0opcl.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aCwfL-0005UO-7F X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451771180.14896@iwEA2ndpXbcI5971jVnYjA X-Spam-Status: No X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dima Kogan writes: > Hi. Can somebody please apply this patch? ERC from HEAD is completely > broken without it. I've got a couple of comments about the code... > (goto-char (point-min)) > - (upcase-word 1) > + > + ;; this is (upcase-word 1), but working even with subword-mode > + ;; active > + (skip-syntax-forward "^w") > + (let* > + ((word-start (point)) > + (word-end > + (progn (skip-syntax-forward "w") (point)))) > + (upcase-region word-start word-end)) > + If you had a function `erc-forward-word' that did all the syntax skipping, you could basically just say (upcase-region (point) (erc-forward-word)) > - (while (forward-word 1) > - (setq bounds (bounds-of-thing-at-point 'word)) > - (setq word (buffer-substring-no-properties > - (car bounds) (cdr bounds))) > - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) > - (and erc-channel-users (erc-get-channel-user word))) > - (erc-button-add-button (car bounds) (cdr bounds) > - fun t (list word))))))) > + > + (while > + (progn > + > + ;; I move forward a word (independent of subword-mode) ... > + (skip-syntax-forward "^w") > + (let* > + ((word-start (point)) > + (word-end > + (progn (skip-syntax-forward "w") (point)))) > + > + ;; ... if the word was empty we're at the end of buffer ... > + (and (/= word-start word-end) > + > + ;; ... otherwise, we do stuff with this word > + (progn > + (setq word (buffer-substring-no-properties > + word-start word-end)) > + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) > + (and erc-channel-users (erc-get-channel-user word))) > + (erc-button-add-button word-start word-end > + fun t (list word))))))))))) Similarly here, you could use that erc-forward-word to avoid rewriting this code so much. It would be just (while (erc-forward-word) (setq bound-stuff ...) ) Or something. I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 21:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.145125098914575 (code B ref 17558); Sun, 27 Dec 2015 21:17:02 +0000 Received: (at 17558) by debbugs.gnu.org; 27 Dec 2015 21:16:29 +0000 Received: from localhost ([127.0.0.1]:44971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIg0-0003lp-05 for submit@debbugs.gnu.org; Sun, 27 Dec 2015 16:16:28 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40221) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIfu-0003gJ-Jf for 17558@debbugs.gnu.org; Sun, 27 Dec 2015 16:16:26 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 42580203A0 for <17558@debbugs.gnu.org>; Sun, 27 Dec 2015 16:16:22 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 27 Dec 2015 16:16:22 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=fqAFw wEhfQV4RhEsnTl3W90HgvQ=; b=AvXMUtb4Y8UWGtlxZ8WxcW+TAm5aBzil7WkfE viHJYeP0Ob+lDJLHPX/T+DV/guPAujSbO4k7pCHdb5A49JVC6TQ/t8vWRuuC4EAZ cRdjz+WtL8EWwfriVBraWFeXB3EV9QYeEX1Rrh4vlebw3e57B5btuMWldPE8Q6sn ++rvsE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=fqAFwwEhfQV4RhEsnTl3W90HgvQ=; b=okpSu NtOdc5+HS9+dHYri33EvW/bT+pGXe4tAQwmCcn2p1f1L/j9Z4ogBcAOuUhEMqI3L cUeAV/OXkA3qz4D314ut6p3gjhK85DUN11lcfQH5O3tWS9mwl/IO8rP8Bp2dUiwk RNTsbfK/JkpszA2f6LHPEWTFc19uqdkG1y5XRw= X-Sasl-enc: PPU/45FOE+7Q/FoQlg7ha1PDZ8Xn+nBTWZyGMMvteGs3 1451250981 Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id E12206801A2; Sun, 27 Dec 2015 16:16:21 -0500 (EST) Received: from ip6-localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1aDIfs-0006we-Kk; Sun, 27 Dec 2015 13:16:20 -0800 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> <87y4iiw0p3.fsf@secretsauce.net> <87wps0opcl.fsf@gnus.org> User-agent: mu4e 0.9.11; emacs 25.0.50.1 From: Dima Kogan In-reply-to: <87wps0opcl.fsf@gnus.org> Date: Sun, 27 Dec 2015 13:16:20 -0800 Message-ID: <87ege7r3rv.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Lars Ingebrigtsen writes: > If you had a function `erc-forward-word' that did all the syntax > skipping, you could basically just say > > (upcase-region (point) (erc-forward-word)) Sure, that's fine. Are you suggesting that such a function be written, and then this patch will be accepted? This isn't erc-specific, so something named "forward-word-nosubword" probably would be better From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dima Kogan Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.145125236523638 (code B ref 17558); Sun, 27 Dec 2015 21:40:02 +0000 Received: (at 17558) by debbugs.gnu.org; 27 Dec 2015 21:39:25 +0000 Received: from localhost ([127.0.0.1]:45018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDJ2B-00069B-KQ for submit@debbugs.gnu.org; Sun, 27 Dec 2015 16:39:25 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:57752) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDJ26-00068z-Qg for 17558@debbugs.gnu.org; Sun, 27 Dec 2015 16:39:22 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDJ1i-0004By-Iz; Sun, 27 Dec 2015 22:38:54 +0100 From: Lars Ingebrigtsen References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> <87y4iiw0p3.fsf@secretsauce.net> <87wps0opcl.fsf@gnus.org> <87ege7r3rv.fsf@secretsauce.net> Date: Sun, 27 Dec 2015 22:38:53 +0100 In-Reply-To: <87ege7r3rv.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 27 Dec 2015 13:16:20 -0800") Message-ID: <874mf38tci.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aDJ1i-0004By-Iz X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451857135.14024@KzXaDpTOqEQTgxtsNPZxvA X-Spam-Status: No X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dima Kogan writes: > Lars Ingebrigtsen writes: > >> If you had a function `erc-forward-word' that did all the syntax >> skipping, you could basically just say >> >> (upcase-region (point) (erc-forward-word)) > > Sure, that's fine. Are you suggesting that such a function be written, > and then this patch will be accepted? Yup. > This isn't erc-specific, so something named "forward-word-nosubword" > probably would be better I think that might be somewhat controversial. As a start, let's keep this contained to erc, and we can move stuff around afterwards, if needed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jan 2016 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.145227925827236 (code B ref 17558); Fri, 08 Jan 2016 18:55:01 +0000 Received: (at 17558) by debbugs.gnu.org; 8 Jan 2016 18:54:18 +0000 Received: from localhost ([127.0.0.1]:43392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aHcAw-00075A-G3 for submit@debbugs.gnu.org; Fri, 08 Jan 2016 13:54:18 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:54124) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aHcAr-00074z-5x for 17558@debbugs.gnu.org; Fri, 08 Jan 2016 13:54:13 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C78F120D39 for <17558@debbugs.gnu.org>; Fri, 8 Jan 2016 13:54:08 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 08 Jan 2016 13:54:08 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=7GHXM Qy74tgXBnvmwCLTrHGf5cs=; b=Zv1+YJY8o+o/TzPIz5UtRE+5FERm9qRvKaMCr TyC71+uyIFPfP3u2hjC4h0gPNQJMhd3b4dm0moyBy8av1yGThMMZyY2LY0pJlSKm sxEMEYR5ymcGhqoD+0DH6i+6fAUhrxE0UGv6WNligIxXD0KJSA1+bsowuacjb5/I +qNPm4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=7GHXMQy74tgXBnvmwCLTrHGf5cs=; b=U7MPm oC/qtM6XsSghFolqh46VO21t6rPhs6iO/z1hsgwfA2+OE0alKt+NVf/p7pDYhSJL fzzbfcvCrAx1NuftXvfbQjMBeyCRXRfizShvSzH/H+SxCymD0aTodgYgWFOD8QqQ 0WWn97HCSaBuhHbF5gar43b7BL0Lhg3nW77jOE= X-Sasl-enc: uG3XVGQzyumj86SrFwxsL7/cwvfCRSc9qSSxhtqbc2Fg 1452279248 Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 57991C00017; Fri, 8 Jan 2016 13:54:08 -0500 (EST) Received: from localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1aHcAn-00064z-AL; Fri, 08 Jan 2016 10:54:05 -0800 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> <87y4iiw0p3.fsf@secretsauce.net> <87wps0opcl.fsf@gnus.org> User-agent: mu4e 0.9.11; emacs 25.0.50.1 From: Dima Kogan In-reply-to: <87wps0opcl.fsf@gnus.org> Date: Fri, 08 Jan 2016 10:54:05 -0800 Message-ID: <87fuy7dhrm.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Hi. New patch attached. Notes inline Lars Ingebrigtsen writes: > I've got a couple of comments about the code... > >> (goto-char (point-min)) >> - (upcase-word 1) >> + >> + ;; this is (upcase-word 1), but working even with subword-mode >> + ;; active >> + (skip-syntax-forward "^w") >> + (let* >> + ((word-start (point)) >> + (word-end >> + (progn (skip-syntax-forward "w") (point)))) >> + (upcase-region word-start word-end)) >> + > > If you had a function `erc-forward-word' that did all the syntax > skipping, you could basically just say > > (upcase-region (point) (erc-forward-word)) Sure. New patch does this. >> - (while (forward-word 1) >> - (setq bounds (bounds-of-thing-at-point 'word)) >> - (setq word (buffer-substring-no-properties >> - (car bounds) (cdr bounds))) >> - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) >> - (and erc-channel-users (erc-get-channel-user word))) >> - (erc-button-add-button (car bounds) (cdr bounds) >> - fun t (list word))))))) >> + >> + (while >> + (progn >> + >> + ;; I move forward a word (independent of subword-mode) ... >> + (skip-syntax-forward "^w") >> + (let* >> + ((word-start (point)) >> + (word-end >> + (progn (skip-syntax-forward "w") (point)))) >> + >> + ;; ... if the word was empty we're at the end of buffer ... >> + (and (/= word-start word-end) >> + >> + ;; ... otherwise, we do stuff with this word >> + (progn >> + (setq word (buffer-substring-no-properties >> + word-start word-end)) >> + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) >> + (and erc-channel-users (erc-get-channel-user word))) >> + (erc-button-add-button word-start word-end >> + fun t (list word))))))))))) > > Similarly here, you could use that erc-forward-word to avoid rewriting > this code so much. It would be just > > (while (erc-forward-word) > (setq bound-stuff ...) > ) That would be nice, but no. This chunk of code was affected by subword-mode in two ways: 1. (forward-word 1) 2. (bounds-of-thing-at-point 'word) The proposed change only takes care of #1, and I don't see an obvious way to make it take care of both. I can do (while (erc-forward-word) ...), but then to get the word, I'd need to backtrack to the previous word marker, and it's not obvious to me that this would be an improvement over the existing change in the patch. The attached patch thus has no changes to this hunk. Let me know if you think of a nicer way to do this. dima --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ERC-no-longer-gets-confused-by-subword-mode.patch >From 28d49bfe6581a108b68c9b85dd57c77ecc94125c Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Tue, 30 Dec 2014 23:29:21 -0800 Subject: [PATCH] ERC no longer gets confused by subword-mode In commit 6ddc44225e743e2b2a0d5c192f50aefd7a4a915b subword-mode was integrated into the syntax table instead of simply remapping the interactive motion bindings as was done previously. This had the unintended effect of changing the behavior of lisp programs that touch words. In the case of ERC, it completely broke it: emacs now throws an error when ERC is launched, making it unusable when subword-mode is active. This commit replaces the word-oriented calls with ones that navigate the buffer using syntax classes Closes: #17558 --- lisp/erc/erc-backend.el | 8 +++++++- lisp/erc/erc-button.el | 30 ++++++++++++++++++++++-------- 2 files changed, 29 insertions(+), 9 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index ec45dcf..c315c47 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -474,13 +474,19 @@ Currently this is called by `erc-send-input'." nil t)) (split-string (buffer-string) "\n")))) +(defun erc-forward-word () + "Moves forward one word, ignoring any subword settings. If no +subword-mode is active, then this is (forward-word)." + (skip-syntax-forward "^w") + (> (skip-syntax-forward "w") 0)) + ;; Used by CTCP functions (defun erc-upcase-first-word (str) "Upcase the first word in STR." (with-temp-buffer (insert str) (goto-char (point-min)) - (upcase-word 1) + (upcase-region (point) (erc-forward-word)) (buffer-string))) (defun erc-server-setup-periodical-ping (buffer) diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el index 0e4c709..653488c 100644 --- a/lisp/erc/erc-button.el +++ b/lisp/erc/erc-button.el @@ -300,14 +300,28 @@ specified by `erc-button-alist'." (when (or (eq t form) (eval form)) (goto-char (point-min)) - (while (forward-word 1) - (setq bounds (bounds-of-thing-at-point 'word)) - (setq word (buffer-substring-no-properties - (car bounds) (cdr bounds))) - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) - (and erc-channel-users (erc-get-channel-user word))) - (erc-button-add-button (car bounds) (cdr bounds) - fun t (list word))))))) + + (while + (progn + + ;; I move forward a word (independent of subword-mode) ... + (skip-syntax-forward "^w") + (let* + ((word-start (point)) + (word-end + (progn (skip-syntax-forward "w") (point)))) + + ;; ... if the word was empty we're at the end of buffer ... + (and (/= word-start word-end) + + ;; ... otherwise, we do stuff with this word + (progn + (setq word (buffer-substring-no-properties + word-start word-end)) + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) + (and erc-channel-users (erc-get-channel-user word))) + (erc-button-add-button word-start word-end + fun t (list word))))))))))) (defun erc-button-add-buttons-1 (regexp entry) "Search through the buffer for matches to ENTRY and add buttons." -- 2.1.4 --=-=-=-- From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Lars Magne Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jan 2016 09:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dima Kogan Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.145233026925529 (code B ref 17558); Sat, 09 Jan 2016 09:05:01 +0000 Received: (at 17558) by debbugs.gnu.org; 9 Jan 2016 09:04:29 +0000 Received: from localhost ([127.0.0.1]:43602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aHpRk-0006dh-VH for submit@debbugs.gnu.org; Sat, 09 Jan 2016 04:04:29 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:59978) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aHpRj-0006dW-6E for 17558@debbugs.gnu.org; Sat, 09 Jan 2016 04:04:27 -0500 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aHpRL-00081N-Ro; Sat, 09 Jan 2016 10:04:03 +0100 From: Lars Magne Ingebrigtsen References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> <87y4iiw0p3.fsf@secretsauce.net> <87wps0opcl.fsf@gnus.org> <87fuy7dhrm.fsf@secretsauce.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAADFBMVEU1Njacm5jOzcv6+vmX d6tUAAACSElEQVQokSXOT0ySYQDH8d+LoHN2QBdr1cwutZWHTh06AWW5buh4pBdmeEgKCLlkKs3p +nPqQiUaOkM34R0vi+eEJQuetg5dbU37t3JtgqlLT49M3+Dpbd1+n/0uXyzbTGmSD4SGXnoofo4f Jcm87869dbMVatTie16I7WvrfVaE5ob7lwps54JznuJ7qtq/MxpcJ6qfwj8jVlaLmWgqthTG14n6 J5Ns+n7SxylcUUsLGVNLDnkhDJKDgRW3+QHTERtFtyiK7YMRzhCSYdGxJlIlhnD80WW1SKn4EaNw 06fxBSlQo5+JQHJtfBVS/ZJ3goTh35BvAUheJy6GXh7o03Em6x9IIL4nP9TRyCKjQaRpQd8wiaGM hmw4AjNxGFgkrKN9BCdPfDCw6TENXs9r4FhUYmtMg7vnmg6npCbUDCriDzAwByGqFO/ZbR3zEt+L ekBMs7CkndLGC7Sj2ekGLLa6rTw64SDHYZRsdYubxgY4zJ5xI8xNyq9DdRhsnlrW0ab8Dj3AsJ3o 1bYg/bT/DmabqRUwPM7GS5f0XnvTMlrdSlx+pj+wi8xE52b57keYjTib4F3y9l6/ghuAlOdX0lta OQOHo6Ejy68qeZp0gRxumz3NPVM0Er+J3pDypjHnmX6V3/HAm6hUO3IRNb+1q8EqhOjiwZnAJNUw JkStmyfK6Syt/IOw5xbLgQ3Xf1zk1VSSKxWcE6Jo4AUfF0MKvEIw8NoXTawcQYsO2/laPLjLO9Ej xO7bU2zW+63UA0L8cmyQyG5VVf8CtHEodbLbHikAAAAASUVORK5CYII= Date: Sat, 09 Jan 2016 10:04:03 +0100 In-Reply-To: <87fuy7dhrm.fsf@secretsauce.net> (Dima Kogan's message of "Fri, 08 Jan 2016 10:54:05 -0800") Message-ID: User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aHpRL-00081N-Ro X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1452935044.01108@D3ocC448VhNc0i0FxmmMHw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Dima Kogan writes: > That would be nice, but no. This chunk of code was affected by > subword-mode in two ways: > > 1. (forward-word 1) > 2. (bounds-of-thing-at-point 'word) > > The proposed change only takes care of #1, and I don't see an obvious > way to make it take care of both. I can do (while (erc-forward-word) > ...), but then to get the word, I'd need to backtrack to the previous > word marker, and it's not obvious to me that this would be an > improvement over the existing change in the patch. > > The attached patch thus has no changes to this hunk. Let me know if you > think of a nicer way to do this. [...] > - (while (forward-word 1) > - (setq bounds (bounds-of-thing-at-point 'word)) > - (setq word (buffer-substring-no-properties > - (car bounds) (cdr bounds))) > - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) > - (and erc-channel-users (erc-get-channel-user word))) > - (erc-button-add-button (car bounds) (cdr bounds) > - fun t (list word))))))) > + > + (while > + (progn > + > + ;; I move forward a word (independent of subword-mode) ... > + (skip-syntax-forward "^w") > + (let* > + ((word-start (point)) > + (word-end > + (progn (skip-syntax-forward "w") (point)))) > + This still seems very difficult to understand. The old version has a clear loop condition > - (while (forward-word 1) while in the new version everything is inside a progn, making it kinda difficult to follow. Would it be possible to write a version of (bounds-of-thing-at-point 'word) that's subword-mode agostic (erc-word-at-point) to preserve the logic? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jan 2016 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Magne Ingebrigtsen Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.145236330123382 (code B ref 17558); Sat, 09 Jan 2016 18:15:02 +0000 Received: (at 17558) by debbugs.gnu.org; 9 Jan 2016 18:15:01 +0000 Received: from localhost ([127.0.0.1]:44609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aHy2T-000651-Sl for submit@debbugs.gnu.org; Sat, 09 Jan 2016 13:15:01 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35480) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aHy2P-00064q-CF for 17558@debbugs.gnu.org; Sat, 09 Jan 2016 13:14:57 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D731E20676 for <17558@debbugs.gnu.org>; Sat, 9 Jan 2016 13:14:52 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Sat, 09 Jan 2016 13:14:52 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=YclvB tkfQlzIAKaXWqh5jV0BArM=; b=ssNPgGZC1oIBG41aGcvbkzEfoaq3Ac/plBsjm 6mS/Y101Dvto2dmIBFGSfSl6i7aXtFNNk6b2RNOqvA+TCoUhKsCMObe3/FVRrMTE S9jXbumYenn9bxhMdjWJ2Oc357kEhZz0PFOEyal2NoAahqkfx/Df2jAE2FCeX1LF CNk//4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=YclvBtkfQlzIAKaXWqh5jV0BArM=; b=SRRGH toa8auEzeeohJ8yOTmz5ccdJzfl/II3fIw+Ld7wzWLR2TjO3DqqnjBugPFZ7sku4 v/EEakMF+hEDsHToWLRwpshAxVkEN6/65DaMWVDPNAu0heMexBZh5ToZj0Xh25Vg s1ajLy2zITST0Sl2UiqDLdhZKO64uux50p7lH4= X-Sasl-enc: lY8j2GNDLgoFL1z5g88m374S220iQbpMc/xjnK8mqeA0 1452363292 Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 7633168011F; Sat, 9 Jan 2016 13:14:52 -0500 (EST) Received: from localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1aHy2N-0005FR-9a; Sat, 09 Jan 2016 10:14:51 -0800 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> <87y4iiw0p3.fsf@secretsauce.net> <87wps0opcl.fsf@gnus.org> <87fuy7dhrm.fsf@secretsauce.net> User-agent: mu4e 0.9.11; emacs 25.0.50.1 From: Dima Kogan In-reply-to: Date: Sat, 09 Jan 2016 10:14:51 -0800 Message-ID: <87twmmhb6s.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Lars Magne Ingebrigtsen writes: >> The attached patch thus has no changes to this hunk. Let me know if you >> think of a nicer way to do this. > > This still seems very difficult to understand. The old version has a > clear loop condition > >> - (while (forward-word 1) > > while in the new version everything is inside a progn, making it kinda > difficult to follow. Aaah, I see the complaint now. New patch attached. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-ERC-no-longer-gets-confused-by-subword-mode.patch >From ba2f53e864cc36a3a9296104975407274b59b601 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Tue, 30 Dec 2014 23:29:21 -0800 Subject: [PATCH] ERC no longer gets confused by subword-mode In commit 6ddc44225e743e2b2a0d5c192f50aefd7a4a915b subword-mode was integrated into the syntax table instead of simply remapping the interactive motion bindings as was done previously. This had the unintended effect of changing the behavior of lisp programs that touch words. In the case of ERC, it completely broke it: emacs now throws an error when ERC is launched, making it unusable when subword-mode is active. This commit replaces the word-oriented calls with ones that navigate the buffer using syntax classes Closes: #17558 --- lisp/erc/erc-backend.el | 28 +++++++++++++++++++++++++++- lisp/erc/erc-button.el | 16 ++++++++-------- 2 files changed, 35 insertions(+), 9 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index ec45dcf..4925c96 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -474,13 +474,39 @@ Currently this is called by `erc-send-input'." nil t)) (split-string (buffer-string) "\n")))) +(defun erc-forward-word () + "Moves forward one word, ignoring any subword settings. If no +subword-mode is active, then this is (forward-word)." + (skip-syntax-forward "^w") + (> (skip-syntax-forward "w") 0)) + +(defun erc-word-at-arg-p (pos) + "Reports whether the char after a given POS has word syntax. +If POS is out of range, the value is nil." + (let ((c (char-after pos))) + (if c + (eq ?w (char-syntax c)) + nil))) + +(defun erc-bounds-of-word-at-point () + "Returns the bounds of a word at point, or nil if we're not at +a word. If no subword-mode is active, then this +is (bounds-of-thing-at-point 'word)." + (if (or (erc-word-at-arg-p (point)) + (erc-word-at-arg-p (1- (point)))) + (save-excursion + (let* ((start (progn (skip-syntax-backward "w") (point))) + (end (progn (skip-syntax-forward "w") (point)))) + (cons start end))) + nil)) + ;; Used by CTCP functions (defun erc-upcase-first-word (str) "Upcase the first word in STR." (with-temp-buffer (insert str) (goto-char (point-min)) - (upcase-word 1) + (upcase-region (point) (progn (erc-forward-word) (point))) (buffer-string))) (defun erc-server-setup-periodical-ping (buffer) diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el index 0e4c709..a59ad22 100644 --- a/lisp/erc/erc-button.el +++ b/lisp/erc/erc-button.el @@ -300,14 +300,14 @@ specified by `erc-button-alist'." (when (or (eq t form) (eval form)) (goto-char (point-min)) - (while (forward-word 1) - (setq bounds (bounds-of-thing-at-point 'word)) - (setq word (buffer-substring-no-properties - (car bounds) (cdr bounds))) - (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) - (and erc-channel-users (erc-get-channel-user word))) - (erc-button-add-button (car bounds) (cdr bounds) - fun t (list word))))))) + (while (erc-forward-word) + (when (setq bounds (erc-bounds-of-word-at-point)) + (setq word (buffer-substring-no-properties + (car bounds) (cdr bounds))) + (when (or (and (erc-server-buffer-p) (erc-get-server-user word)) + (and erc-channel-users (erc-get-channel-user word))) + (erc-button-add-button (car bounds) (cdr bounds) + fun t (list word)))))))) (defun erc-button-add-buttons-1 (regexp entry) "Search through the buffer for matches to ENTRY and add buttons." -- 2.1.4 --=-=-=-- From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jan 2016 08:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Magne Ingebrigtsen Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.145379565421893 (code B ref 17558); Tue, 26 Jan 2016 08:08:02 +0000 Received: (at 17558) by debbugs.gnu.org; 26 Jan 2016 08:07:34 +0000 Received: from localhost ([127.0.0.1]:36581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNyew-0005gz-Cr for submit@debbugs.gnu.org; Tue, 26 Jan 2016 03:07:33 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53433) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNyer-0005go-C7 for 17558@debbugs.gnu.org; Tue, 26 Jan 2016 03:07:29 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 862F321A76 for <17558@debbugs.gnu.org>; Tue, 26 Jan 2016 03:07:23 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Tue, 26 Jan 2016 03:07:23 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=yghFl ZZOZCRYa5kHCMXft/k4VEI=; b=CPPagKPS/5JrOEDcPv0us2giAr5u7d0Mf0mz9 vct52ddtKWmz0xLZL7RDytH1GpYU8jj690zhUsJNYKa4+KzxQylnODOL4kWA+NAj P12qo90hQ43iOeu0OVcXdAIY2/d3R8zyOOTOLslCxWgCi+BHeYKBO5WkKGVjZgHn KwM1RI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=yghFlZZOZCRYa5kHCMXft/k4VEI=; b=o0Odx sE13pa1bEJfxRyp5LCcb59J5sYzV8V6c7e7/+g428UiqlLwbDXPsQ1niDCfhrjSR GjrqtTb8MbrSMRUZ9nkbbqEvbjCRBwDEtx6WvxilewSi34aOW7wgyNPhuw3Q4chB vz8eDHYrfE7isJvu9hlWeN4ZeVJKHNPD77flwM= X-Sasl-enc: zMeEsBywdYGHW3WJQm3P09vxJB2rFLWCuvWjbQK5B1dc 1453795642 Received: from shorty.attlocal.net (108-218-61-91.lightspeed.irvnca.sbcglobal.net [108.218.61.91]) by mail.messagingengine.com (Postfix) with ESMTPA id D48E9680114; Tue, 26 Jan 2016 03:07:22 -0500 (EST) Received: from localhost6.attlocal.net ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1aNyem-0001JG-1v; Tue, 26 Jan 2016 00:07:20 -0800 References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> <87y4iiw0p3.fsf@secretsauce.net> <87wps0opcl.fsf@gnus.org> <87fuy7dhrm.fsf@secretsauce.net> <87twmmhb6s.fsf@secretsauce.net> User-agent: mu4e 0.9.11; emacs 25.0.50.1 From: Dima Kogan In-reply-to: <87twmmhb6s.fsf@secretsauce.net> Date: Tue, 26 Jan 2016 00:07:19 -0800 Message-ID: <87bn88ahmw.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dima Kogan writes: > Lars Magne Ingebrigtsen writes: > >>> The attached patch thus has no changes to this hunk. Let me know if you >>> think of a nicer way to do this. >> >> This still seems very difficult to understand. The old version has a >> clear loop condition >> >>> - (while (forward-word 1) >> >> while in the new version everything is inside a progn, making it kinda >> difficult to follow. > > Aaah, I see the complaint now. New patch attached. Hi. This is a gentle ping. Did you get a chance to look at the new patch, by chance? Thanks! From unknown Sat Aug 09 13:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17558: 24.4.50; global-subword-mode breaks ERC Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 03:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dima Kogan Cc: 17558@debbugs.gnu.org Received: via spool by 17558-submit@debbugs.gnu.org id=B17558.14545561171347 (code B ref 17558); Thu, 04 Feb 2016 03:22:01 +0000 Received: (at 17558) by debbugs.gnu.org; 4 Feb 2016 03:21:57 +0000 Received: from localhost ([127.0.0.1]:58592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRAUW-0000Lf-Qj for submit@debbugs.gnu.org; Wed, 03 Feb 2016 22:21:57 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:40190) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRAUU-0000LW-BR for 17558@debbugs.gnu.org; Wed, 03 Feb 2016 22:21:54 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRAU5-0006Jz-78; Thu, 04 Feb 2016 04:21:29 +0100 From: Lars Ingebrigtsen References: <87ppj4ette.fsf@secretsauce.net> <537FB4C8.3080809@dancol.org> <87a924mbuk.fsf@secretsauce.net> <8rvbghcp9y.fsf@fencepost.gnu.org> <553EB8A7.7070103@dancol.org> <55404294.40908@dancol.org> <87y4iiw0p3.fsf@secretsauce.net> <87wps0opcl.fsf@gnus.org> <87fuy7dhrm.fsf@secretsauce.net> <87twmmhb6s.fsf@secretsauce.net> Date: Thu, 04 Feb 2016 14:21:24 +1100 In-Reply-To: <87twmmhb6s.fsf@secretsauce.net> (Dima Kogan's message of "Sat, 09 Jan 2016 10:14:51 -0800") Message-ID: <87lh71ma8b.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aRAU5-0006Jz-78 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455160890.53484@8AKi8jz+8PC/rgOB6ZozjA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Dima Kogan writes: > Aaah, I see the complaint now. New patch attached. Looks good; applying. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 03 22:24:55 2016 Received: (at control) by debbugs.gnu.org; 4 Feb 2016 03:24:55 +0000 Received: from localhost ([127.0.0.1]:58607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRAXP-0000QU-3p for submit@debbugs.gnu.org; Wed, 03 Feb 2016 22:24:55 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:57028) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRAXN-0000QN-Pn for control@debbugs.gnu.org; Wed, 03 Feb 2016 22:24:54 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRAX1-0006Lm-6G for control@debbugs.gnu.org; Thu, 04 Feb 2016 04:24:31 +0100 Date: Thu, 04 Feb 2016 14:24:27 +1100 Message-Id: <87k2mlma38.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #17558 X-MailScanner-ID: 1aRAX1-0006Lm-6G X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455161072.97381@wQHSA4pt7WW0nnHSFXxA9Q X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 17558 fixed close 17558 25.1