From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 00:47:58 2014 Received: (at submit) by debbugs.gnu.org; 23 May 2014 04:47:58 +0000 Received: from localhost ([127.0.0.1]:57133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnhOf-0002dz-6r for submit@debbugs.gnu.org; Fri, 23 May 2014 00:47:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53018) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnhOc-0002dg-FW for submit@debbugs.gnu.org; Fri, 23 May 2014 00:47:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnhOO-0002Rp-3V for submit@debbugs.gnu.org; Fri, 23 May 2014 00:47:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnhOO-0002Rl-0b for submit@debbugs.gnu.org; Fri, 23 May 2014 00:47:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnhOE-0001Bl-VN for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 00:47:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnhO5-0002QO-UX for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 00:47:30 -0400 Received: from mail-pb0-x235.google.com ([2607:f8b0:400e:c01::235]:36309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnhO5-0002QF-NE for bug-gnu-emacs@gnu.org; Fri, 23 May 2014 00:47:21 -0400 Received: by mail-pb0-f53.google.com with SMTP id md12so3549999pbc.12 for ; Thu, 22 May 2014 21:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=E6Rqg93ltIib+7vEmti5nuvJwa+/XnHVAhfsghY+nB4=; b=XhUGTWq1N1pyAGV78AblWMz9ousW2FPMoYVU2svOwCPkHPOXQL/RnFT2tW99wKSOA4 opSuMp3PwkOMcKMzji6t5GGFvvA7VG8qJ/B/qW3CkPGYNWII+qx0rpGpldPBjEvxzLEN M2ftmLnzY9elbPzOl9Dfjg8skQyfNLmr3T7aeCxR4CXGnnTUrAY7xJeSo9RygzhkSuvz 84/QRgRV80QbpMgv8nfkH/AMB7Dp5Sex8lsCvPcKdp6xOipvESEcZk4HxRpOJfAICrpr C9BmtPCiadMxS0pJzkU6hhJ//PhfrHXyRThKrb1R7amcIVpwkYIckn2nxbC4uDU3c2yW Ja9g== X-Received: by 10.66.142.73 with SMTP id ru9mr2556932pab.41.1400820440095; Thu, 22 May 2014 21:47:20 -0700 (PDT) Received: from fortuna ([123.119.93.100]) by mx.google.com with ESMTPSA id eh4sm2283010pbc.79.2014.05.22.21.47.17 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 22 May 2014 21:47:18 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.4.50; fix math-bignum X-Debbugs-CC: Jay Belanger Date: Fri, 23 May 2014 12:46:05 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Due to integer overflow (math-bignum most-negative-fixnum) is incorrect. Any objection if I fix it like in this patch: === modified file 'lisp/calc/calc.el' --- lisp/calc/calc.el 2014-01-01 07:43:34 +0000 +++ lisp/calc/calc.el 2014-05-23 04:42:18 +0000 @@ -2773,9 +2773,15 @@ ;; Coerce integer A to be a bignum. [B S] (defun math-bignum (a) - (if (>= a 0) - (cons 'bigpos (math-bignum-big a)) - (cons 'bigneg (math-bignum-big (- a))))) + (cond + ((>= a 0) + (cons 'bigpos (math-bignum-big a))) + ((= a most-negative-fixnum) + ;; Note: (- most-negative-fixnum) is most-negative-fixnum + (math-sub (cons 'bigneg (math-bignum-big (- (1+ a)))) + 1)) + (t + (cons 'bigneg (math-bignum-big (- a)))))) (defun math-bignum-big (a) ; [L s] (if (= a 0) From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 03:33:47 2014 Received: (at 17556) by debbugs.gnu.org; 23 May 2014 07:33:47 +0000 Received: from localhost ([127.0.0.1]:57222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnjz8-00082B-Eg for submit@debbugs.gnu.org; Fri, 23 May 2014 03:33:46 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:42400) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnjz5-00081x-Qz for 17556@debbugs.gnu.org; Fri, 23 May 2014 03:33:44 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3gZfZZ3sMqz3hhbd; Fri, 23 May 2014 09:33:42 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3gZfZZ2Nm5zbbfr; Fri, 23 May 2014 09:33:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id jnArL2u_jFbX; Fri, 23 May 2014 09:33:37 +0200 (CEST) X-Auth-Info: FtVXyZd5tnS5mBc0ayFfh/QYR9EExRylsrssCOj8Jpg= Received: from igel.home (ppp-188-174-63-42.dynamic.mnet-online.de [188.174.63.42]) by mail.mnet-online.de (Postfix) with ESMTPA; Fri, 23 May 2014 09:33:37 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 0A02E2C1C47; Fri, 23 May 2014 09:33:37 +0200 (CEST) From: Andreas Schwab To: Leo Liu Subject: Re: bug#17556: 24.4.50; fix math-bignum References: X-Yow: I've read SEVEN MILLION books!! Date: Fri, 23 May 2014 09:33:36 +0200 In-Reply-To: (Leo Liu's message of "Fri, 23 May 2014 12:46:05 +0800") Message-ID: <87tx8hne3z.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17556 Cc: 17556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Leo Liu writes: > + (math-sub (cons 'bigneg (math-bignum-big (- (1+ a)))) aka (- 1 a) Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 04:23:46 2014 Received: (at 17556) by debbugs.gnu.org; 23 May 2014 08:23:46 +0000 Received: from localhost ([127.0.0.1]:57249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnklW-00019y-0z for submit@debbugs.gnu.org; Fri, 23 May 2014 04:23:46 -0400 Received: from mout.gmx.net ([212.227.17.22]:49506) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnklT-00019e-8C for 17556@debbugs.gnu.org; Fri, 23 May 2014 04:23:44 -0400 Received: from [93.82.15.238] ([93.82.15.238]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M9s2y-1WcnTc3fho-00B7o5; Fri, 23 May 2014 10:23:37 +0200 Message-ID: <537F057E.6050902@gmx.at> Date: Fri, 23 May 2014 10:23:26 +0200 From: martin rudalics MIME-Version: 1.0 To: Andreas Schwab , Leo Liu Subject: Re: bug#17556: 24.4.50; fix math-bignum References: <87tx8hne3z.fsf@igel.home> In-Reply-To: <87tx8hne3z.fsf@igel.home> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7S7/FrK/uu0Ri35ZOciVFCJ+pqJYkyWvYSVEP1PEHh8G5vlcmVP hcjV40ryaypoMfiRgZyL3Bh1UBPgCYpovC14AvDabOHwdsVVgJc4w3lcQwIeo9YpXvXpgLZ 2BchuwQc4aokAzdjreJZnusD7wLz1YQ3UIh0hwJawwdXmplKnPCldxzgCuM+YJ2oBZB36D9 4wvsYuG5qVXHZ5zXO7D2A== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17556 Cc: 17556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> + (math-sub (cons 'bigneg (math-bignum-big (- (1+ a)))) > > aka (- 1 a) Hmmm... martin From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 05:45:50 2014 Received: (at 17556) by debbugs.gnu.org; 23 May 2014 09:45:50 +0000 Received: from localhost ([127.0.0.1]:57303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnm2v-0003j4-OB for submit@debbugs.gnu.org; Fri, 23 May 2014 05:45:50 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:55238) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnm2t-0003ij-F0 for 17556@debbugs.gnu.org; Fri, 23 May 2014 05:45:48 -0400 Received: by mail-pb0-f46.google.com with SMTP id rq2so3889175pbb.5 for <17556@debbugs.gnu.org>; Fri, 23 May 2014 02:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=yU+Az1BvlB6X47oJwJ7UHEXJqUCLdbhL4BeexfYhYts=; b=YRgtbaazoe3bMe+A17WTIt0d/OPSxhPiIyXby1/1zfFsUdpFfzjhV5n+Pcm69DjUX/ 53toA1qjqH6ZtHbs7AICRhorjfkLLYhC2DUgF0Jxo26RKHZDl9/Dil+rQeOOyW8j00te GjB1KXielhJHYeEnwRNQC/VSsGDc0g/ZHA7BgcQb0AgOw9wAVRgLoTm24TiP8rfgsHoP aHAcKNN8QmDc5RLOh1jkFWAUg04GWaE475B721FXBd6RMz+UM8fOwMOQ8rulidrj+TzR fs/W0c+mKdPUA/ZA64PI9EUReotmD/oqp1tTIL+oo0c3raRkyKM70BHAW4bJQcILDrkO gPZQ== X-Received: by 10.66.146.199 with SMTP id te7mr4444372pab.106.1400838341291; Fri, 23 May 2014 02:45:41 -0700 (PDT) Received: from fortuna ([123.119.93.100]) by mx.google.com with ESMTPSA id or4sm3769454pbb.17.2014.05.23.02.45.33 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Fri, 23 May 2014 02:45:40 -0700 (PDT) From: Leo Liu To: Andreas Schwab Subject: Re: bug#17556: 24.4.50; fix math-bignum References: <87tx8hne3z.fsf@igel.home> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Fri, 23 May 2014 17:44:24 +0800 In-Reply-To: <87tx8hne3z.fsf@igel.home> (Andreas Schwab's message of "Fri, 23 May 2014 09:33:36 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17556 Cc: 17556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2014-05-23 09:33 +0200, Andreas Schwab wrote: > aka (- 1 a) aka most-positive-fixnum ;) Leo From debbugs-submit-bounces@debbugs.gnu.org Sat May 24 11:21:48 2014 Received: (at 17556-done) by debbugs.gnu.org; 24 May 2014 15:21:48 +0000 Received: from localhost ([127.0.0.1]:59208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoDlb-0007Ib-Ti for submit@debbugs.gnu.org; Sat, 24 May 2014 11:21:48 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:48361) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoDlZ-0007II-9W for 17556-done@debbugs.gnu.org; Sat, 24 May 2014 11:21:46 -0400 Received: by mail-pb0-f52.google.com with SMTP id rr13so5518070pbb.25 for <17556-done@debbugs.gnu.org>; Sat, 24 May 2014 08:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=2lhQjv5dgbTOtyqZqbbTc4QL6mfncj954tiIL38/xx0=; b=X71EpO1BiisAFvLVra/mV6vB4aj58RCfCd7Uoaq2pzMs6GERZqJ0Z8W5FkunA+4XPG sFMJJF+a/jer8lsvWf8QA0xhiTyu5VcJELGzyjxS7L9JzJ2Mk+7WPzayZ/4XNP3F4OCa fiLEQEN8moy1ktmG2Zt3TsEl1+wHixf2vK8G4Apxkne/khNqcNxRI1zUrVdfbyJ8zXT2 P1MYTr14BXiHAvK0xp4YrfUTCrfmyQko821RK9j3j7YXaDydE4+JQZk3yA8Rz6R7WO+J Tm8KXT8BIrMg/8ZO3Pzp1KBHrVq+VA2JIyf7L+PjgcpczxmsIvhW8WSSEYLdsE7sDJVk We/Q== X-Received: by 10.68.171.193 with SMTP id aw1mr14406632pbc.117.1400944899182; Sat, 24 May 2014 08:21:39 -0700 (PDT) Received: from fortuna ([123.119.93.100]) by mx.google.com with ESMTPSA id ek2sm9855557pbd.30.2014.05.24.08.21.31 for <17556-done@debbugs.gnu.org> (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Sat, 24 May 2014 08:21:38 -0700 (PDT) From: Leo Liu To: 17556-done@debbugs.gnu.org Subject: Re: bug#17556: 24.4.50; fix math-bignum References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Sat, 24 May 2014 23:19:50 +0800 In-Reply-To: (Leo Liu's message of "Fri, 23 May 2014 12:46:05 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17556-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed in 24.5 From unknown Wed Jun 25 09:11:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 22 Jun 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator