From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 16:00:32 2014 Received: (at submit) by debbugs.gnu.org; 22 May 2014 20:00:33 +0000 Received: from localhost ([127.0.0.1]:56910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnZAC-0003O7-HH for submit@debbugs.gnu.org; Thu, 22 May 2014 16:00:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44371) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnZA5-0003Nj-LS for submit@debbugs.gnu.org; Thu, 22 May 2014 16:00:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnZ9u-0000iC-Fg for submit@debbugs.gnu.org; Thu, 22 May 2014 16:00:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnZ9u-0000i8-Dr for submit@debbugs.gnu.org; Thu, 22 May 2014 16:00:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnZ9o-0003iD-F4 for bug-gnu-emacs@gnu.org; Thu, 22 May 2014 16:00:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnZ9i-0000Sr-HH for bug-gnu-emacs@gnu.org; Thu, 22 May 2014 16:00:04 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnZ9i-0000Sd-E7 for bug-gnu-emacs@gnu.org; Thu, 22 May 2014 15:59:58 -0400 Received: from lukas.physics.niu.edu ([131.156.85.221]:50847) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1WnZ9i-0005By-1t for bug-gnu-emacs@gnu.org; Thu, 22 May 2014 15:59:58 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <22309.78500.835208.21374@gargle.gargle.HOWL> Date: Thu, 22 May 2014 14:59:33 -0500 From: "Roland Winkler" To: bug-gnu-emacs@gnu.org Subject: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) emacs -Q open a dired buffer mark two files type R to move these files to some other directory emacs displays a buffer *Marked Files* listing the files to be moved (with two files to be moved the window displaying this buffer has three lines) use TAB completion to find the directory where you want to move these files emacs re-uses the three-line window from the *Marked Files* buffer in order to display the *Completions* buffer. As the first completion appears in the 4th line of the *Completions* buffer, a 3-line window is rather ineffective I guess, quite generally emacs should make sure that the *Completions* buffer uses a "sufficiently large" window to serve its purpose. In GNU Emacs 24.3.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2014-05-12 on lukas Windowing system distributor `The X.Org Foundation', version 11.0.10706000 System Description: Ubuntu 12.04.4 LTS Important settings: value of $LC_COLLATE: C value of $LANG: en_US.ISO-8859-15 locale-coding-system: iso-latin-9-unix Major mode: Dired by name From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 21:07:10 2014 Received: (at 17554) by debbugs.gnu.org; 23 May 2014 01:07:11 +0000 Received: from localhost ([127.0.0.1]:57069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wndwz-0004f6-Aw for submit@debbugs.gnu.org; Thu, 22 May 2014 21:07:10 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20395) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wndwx-0004em-12 for 17554@debbugs.gnu.org; Thu, 22 May 2014 21:07:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+KQe/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4AQOUYpQ3gWqBcYFbIQ X-IPAS-Result: ArYGAIDvNVPO+KQe/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4AQOUYpQ3gWqBcYFbIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="63796256" Received: from 206-248-164-30.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.164.30]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 May 2014 21:07:01 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id BFA76AE0D2; Thu, 22 May 2014 21:07:00 -0400 (EDT) From: Stefan Monnier To: "Roland Winkler" Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Message-ID: References: <22309.78500.835208.21374@gargle.gargle.HOWL> Date: Thu, 22 May 2014 21:07:00 -0400 In-Reply-To: <22309.78500.835208.21374@gargle.gargle.HOWL> (Roland Winkler's message of "Thu, 22 May 2014 14:59:33 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > emacs re-uses the three-line window from the *Marked Files* buffer > in order to display the *Completions* buffer. As the first > completion appears in the 4th line of the *Completions* buffer, a > 3-line window is rather ineffective Your subject says it's a regression: which previous version of Emacs do you know did not suffer from this problem? Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 22:17:34 2014 Received: (at 17554) by debbugs.gnu.org; 23 May 2014 02:17:34 +0000 Received: from localhost ([127.0.0.1]:57097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnf37-0006ND-Jp for submit@debbugs.gnu.org; Thu, 22 May 2014 22:17:33 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43410 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnf34-0006N5-TW for 17554@debbugs.gnu.org; Thu, 22 May 2014 22:17:31 -0400 Received: from 162-229-45-114.lightspeed.cicril.sbcglobal.net ([162.229.45.114]:59840 helo=regnitz) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Wnf34-0002yh-44; Thu, 22 May 2014 22:17:30 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <44983.87719.904757.21374@gargle.gargle.HOWL> Date: Thu, 22 May 2014 21:17:27 -0500 From: "Roland Winkler" To: Stefan Monnier Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window In-Reply-To: References: <22309.78500.835208.21374@gargle.gargle.HOWL> X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) On Thu May 22 2014 Stefan Monnier wrote: > Your subject says it's a regression: which previous version of Emacs do > you know did not suffer from this problem? Emacs 24.3 does not give me this problem (I just double-checked): First it gives me the *Marked Files* window by splitting the main window (only two lines high if I want to move only two files, whereas 24.3.91 makes it three lines high). Then it splits once more the main window for the *Completions* buffer. So I get a *Completions* window which is typically large enough to display the complete *Completions* buffer. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 01:48:13 2014 Received: (at 17554) by debbugs.gnu.org; 23 May 2014 05:48:14 +0000 Received: from localhost ([127.0.0.1]:57155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WniKy-0004dM-PX for submit@debbugs.gnu.org; Fri, 23 May 2014 01:48:13 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:58862) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WniKu-0004cw-T1 for 17554@debbugs.gnu.org; Fri, 23 May 2014 01:48:10 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N6000J00I1AEF00@mtaout25.012.net.il> for 17554@debbugs.gnu.org; Fri, 23 May 2014 08:44:53 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6000CUJIMTT7A0@mtaout25.012.net.il>; Fri, 23 May 2014 08:44:53 +0300 (IDT) Date: Fri, 23 May 2014 08:48:17 +0300 From: Eli Zaretskii Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window In-reply-to: <22309.78500.835208.21374@gargle.gargle.HOWL> X-012-Sender: halo1@inter.net.il To: Roland Winkler Message-id: <831tvlm4f2.fsf@gnu.org> References: <22309.78500.835208.21374@gargle.gargle.HOWL> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 22 May 2014 14:59:33 -0500 > From: "Roland Winkler" > > I guess, quite generally emacs should make sure that the > *Completions* buffer uses a "sufficiently large" window to serve its > purpose. Emacs has never done that: if completions are displayed in an existing window, Emacs would always reuse the size, and not resize it. This is not a regression. If you don't like what you see, I'm sure Martin will be able to tell you how to customize the window creation such that it suits your wishes. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 02:06:44 2014 Received: (at 17554) by debbugs.gnu.org; 23 May 2014 06:06:44 +0000 Received: from localhost ([127.0.0.1]:57174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnict-0005E1-EN for submit@debbugs.gnu.org; Fri, 23 May 2014 02:06:43 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:39392) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnicp-0005Db-MC for 17554@debbugs.gnu.org; Fri, 23 May 2014 02:06:40 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0N6000H00IUV9D00@mtaout28.012.net.il> for 17554@debbugs.gnu.org; Fri, 23 May 2014 09:04:34 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6000AQFJJM82A0@mtaout28.012.net.il>; Fri, 23 May 2014 09:04:34 +0300 (IDT) Date: Fri, 23 May 2014 09:06:48 +0300 From: Eli Zaretskii Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window In-reply-to: <44983.87719.904757.21374@gargle.gargle.HOWL> X-012-Sender: halo1@inter.net.il To: Roland Winkler Message-id: <83tx8hkozr.fsf@gnu.org> References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 22 May 2014 21:17:27 -0500 > From: "Roland Winkler" > Cc: 17554@debbugs.gnu.org > > Then it splits once more the main window for the *Completions* > buffer. So I get a *Completions* window which is typically large > enough to display the complete *Completions* buffer. That's a side effect of popping a new window. Current Emacs reuses the same window, so it doesn't resize. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 03:24:49 2014 Received: (at 17554) by debbugs.gnu.org; 23 May 2014 07:24:49 +0000 Received: from localhost ([127.0.0.1]:57210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnjqT-0007jE-3M for submit@debbugs.gnu.org; Fri, 23 May 2014 03:24:49 -0400 Received: from mout.gmx.net ([212.227.17.22]:53888) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnjqQ-0007ir-6z for 17554@debbugs.gnu.org; Fri, 23 May 2014 03:24:47 -0400 Received: from [93.82.15.238] ([93.82.15.238]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M7UUd-1WzKbd3vOx-00xJYT; Fri, 23 May 2014 09:24:35 +0200 Message-ID: <537EF7A7.8040608@gmx.at> Date: Fri, 23 May 2014 09:24:23 +0200 From: martin rudalics MIME-Version: 1.0 To: Roland Winkler , Stefan Monnier Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> In-Reply-To: <44983.87719.904757.21374@gargle.gargle.HOWL> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:2H2MMrXv6aLUjKprRtakSUq/K9eFMlycmHTc8KP0PYZuJ1ZOCdi s2YpHMI7Et57TjVjhRWlfFdta9WKb539kaxc58B8uXNARj8gfmZ+fGCk8wwYYFQfMhjvVUA el/fZ9XfbAzxgUKoOSjWr6B5ZM7fAScU+V8epryiVSuPYjAUP15lFyoCLwLVHjCbczibEHf i/EUh6DMFH+fng6S0GzeQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17554 Cc: Juri Linkov , 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Emacs 24.3 does not give me this problem (I just double-checked): IIUC we now use `display-buffer' for displaying the list of marked files and completions and both seem to backfire in the present case. > First it gives me the *Marked Files* window by splitting the main > window (only two lines high if I want to move only two files, > whereas 24.3.91 makes it three lines high). A regression. It happens because `display-buffer-pop-up-window' obeys `window-min-height' which is 4, by default. Subtracting one for the mode-line gives three lines. If you mark at least three files you won't see it. We could add a `window-height' alist entry to fix this. Juri - any ideas where? My knowledge of `dired' is about zero so I don't want to add any such switch without some advice. > Then it splits once more the main window for the *Completions* > buffer. So I get a *Completions* window which is typically large > enough to display the complete *Completions* buffer. Which is much better indeed. You can customize `split-height-threshold' to get three windows again - the *Completions* buffer then appears at the bottom when the question is asked. But the default would really look better with three windows. Juri - any ideas? martin From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 03:25:36 2014 Received: (at 17554) by debbugs.gnu.org; 23 May 2014 07:25:36 +0000 Received: from localhost ([127.0.0.1]:57214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnjr9-0007l0-Na for submit@debbugs.gnu.org; Fri, 23 May 2014 03:25:36 -0400 Received: from mout.gmx.net ([212.227.17.21]:60652) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnjr6-0007kf-E6 for 17554@debbugs.gnu.org; Fri, 23 May 2014 03:25:29 -0400 Received: from [93.82.15.238] ([93.82.15.238]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MDR21-1WXSyD21U5-00GsE6; Fri, 23 May 2014 09:25:20 +0200 Message-ID: <537EF7D2.1080303@gmx.at> Date: Fri, 23 May 2014 09:25:06 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii , Roland Winkler Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window References: <22309.78500.835208.21374@gargle.gargle.HOWL> <831tvlm4f2.fsf@gnu.org> In-Reply-To: <831tvlm4f2.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:yxATCb8ysqa4Ocx3XXIVOF8SsmR5BjZ23Og+or77/5eWYQzwgEo qxicIJ8I8onJDeuOx/PXGA16pFzpveDzeN5vVbD0+tP5xk/e++fWMTawMJaUPdZFuqvLXIF LrIVZuUPpTeFN9q1D32ni4KwhguyG+9E/Rr79vzfEY/v4+6NRsBnoi7CwfOvPnniGnfuEyQ wsHbJR0pLH+EoFNSoFlFg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> I guess, quite generally emacs should make sure that the >> *Completions* buffer uses a "sufficiently large" window to serve its >> purpose. > > Emacs has never done that: if completions are displayed in an existing > window, Emacs would always reuse the size, and not resize it. > > This is not a regression. The behavior is worse in this particular case because we reuse an existing window. So the default behavior has worsened. > If you don't like what you see, I'm sure Martin will be able to tell > you how to customize the window creation such that it suits your > wishes. We should try to improve the default behavior. The points Roland made are valid, unfortunately. martin From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 03:31:18 2014 Received: (at 17554) by debbugs.gnu.org; 23 May 2014 07:31:18 +0000 Received: from localhost ([127.0.0.1]:57218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnjwg-0007xD-7D for submit@debbugs.gnu.org; Fri, 23 May 2014 03:31:17 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:55339) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnjwa-0007wT-4F for 17554@debbugs.gnu.org; Fri, 23 May 2014 03:31:12 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0N6000500MR59C00@a-mtaout21.012.net.il> for 17554@debbugs.gnu.org; Fri, 23 May 2014 10:31:00 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N60005SHNJN5I60@a-mtaout21.012.net.il>; Fri, 23 May 2014 10:31:00 +0300 (IDT) Date: Fri, 23 May 2014 10:31:15 +0300 From: Eli Zaretskii Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window In-reply-to: <537EF7D2.1080303@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83r43lkl30.fsf@gnu.org> References: <22309.78500.835208.21374@gargle.gargle.HOWL> <831tvlm4f2.fsf@gnu.org> <537EF7D2.1080303@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, winkler@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 23 May 2014 09:25:06 +0200 > From: martin rudalics > CC: 17554@debbugs.gnu.org > > We should try to improve the default behavior. The points Roland made > are valid, unfortunately. I didn't say there weren't, I'm just saying it's not a regression. From debbugs-submit-bounces@debbugs.gnu.org Fri May 23 17:36:26 2014 Received: (at 17554) by debbugs.gnu.org; 23 May 2014 21:36:26 +0000 Received: from localhost ([127.0.0.1]:58288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnx8b-0005nP-TW for submit@debbugs.gnu.org; Fri, 23 May 2014 17:36:26 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:38873 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnx8Z-0005nG-DV for 17554@debbugs.gnu.org; Fri, 23 May 2014 17:36:24 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id F3AD330A13E676; Fri, 23 May 2014 14:36:15 -0700 (PDT) From: Juri Linkov To: martin rudalics Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> Date: Sat, 24 May 2014 00:32:28 +0300 In-Reply-To: <537EF7A7.8040608@gmx.at> (martin rudalics's message of "Fri, 23 May 2014 09:24:23 +0200") Message-ID: <87ioowmb9v.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> Then it splits once more the main window for the *Completions* >> buffer. So I get a *Completions* window which is typically large >> enough to display the complete *Completions* buffer. > > Which is much better indeed. You can customize `split-height-threshold' > to get three windows again - the *Completions* buffer then appears at the > bottom when the question is asked. But the default would really look > better with three windows. Juri - any ideas? [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> Then it splits once more the main window for the *Completions* >> buffer. So I get a *Completions* window which is typically large >> enough to display the complete *Completions* buffer. > > Which is much better indeed. You can customize `split-height-threshold' > to get three windows again - the *Completions* buffer then appears at the > bottom when the question is asked. But the default would really look > better with three windows. Juri - any ideas? [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> Then it splits once more the main window for the *Completions* >> buffer. So I get a *Completions* window which is typically large >> enough to display the complete *Completions* buffer. > > Which is much better indeed. You can customize `split-height-threshold' > to get three windows again - the *Completions* buffer then appears at the > bottom when the question is asked. But the default would really look > better with three windows. Juri - any ideas? When the frame is wide enough, then the *Completions* buffer appears in the side window at the full height of the frame that is nice. When the frame is narrow then maybe we should use the same positioning of the *Completions* buffer as was in 23.1? I.e. to show *Completions* in the window of the original Dired buffer. But it seems this problem is not specific to Dired. Creating manually a window configuration with a small window at the bottom (`C-x 2' and then `C-x ^' several times), typing `C-x d TAB TAB' displays *Completions* in the small window. From debbugs-submit-bounces@debbugs.gnu.org Tue May 27 17:58:23 2014 Received: (at 17554) by debbugs.gnu.org; 27 May 2014 21:58:23 +0000 Received: from localhost ([127.0.0.1]:33753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpPO3-0001oI-6O for submit@debbugs.gnu.org; Tue, 27 May 2014 17:58:23 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:51586 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpPO0-0001o1-20 for 17554@debbugs.gnu.org; Tue, 27 May 2014 17:58:20 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 716B330502A07F; Tue, 27 May 2014 14:58:17 -0700 (PDT) From: Juri Linkov To: martin rudalics Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> Date: Wed, 28 May 2014 00:54:54 +0300 In-Reply-To: <87ioowmb9v.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 24 May 2014 00:32:28 +0300") Message-ID: <8738fu51ld.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> Which is much better indeed. You can customize `split-height-threshold' >> to get three windows again - the *Completions* buffer then appears at the >> bottom when the question is asked. But the default would really look >> better with three windows. Juri - any ideas? > > But it seems this problem is not specific to Dired. Creating manually > a window configuration with a small window at the bottom (`C-x 2' and then > `C-x ^' several times), typing `C-x d TAB TAB' displays *Completions* > in the small window. [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> Which is much better indeed. You can customize `split-height-threshold' >> to get three windows again - the *Completions* buffer then appears at the >> bottom when the question is asked. But the default would really look >> better with three windows. Juri - any ideas? > > But it seems this problem is not specific to Dired. Creating manually > a window configuration with a small window at the bottom (`C-x 2' and then > `C-x ^' several times), typing `C-x d TAB TAB' displays *Completions* > in the small window. [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] >> Which is much better indeed. You can customize `split-height-threshold' >> to get three windows again - the *Completions* buffer then appears at the >> bottom when the question is asked. But the default would really look >> better with three windows. Juri - any ideas? > > But it seems this problem is not specific to Dired. Creating manually > a window configuration with a small window at the bottom (`C-x 2' and then > `C-x ^' several times), typing `C-x d TAB TAB' displays *Completions* > in the small window. A good placement of the *Completions* buffer can be achieved by using: (add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) It works in Dired as well with different window configurations. From debbugs-submit-bounces@debbugs.gnu.org Tue May 27 18:46:04 2014 Received: (at 17554) by debbugs.gnu.org; 27 May 2014 22:46:04 +0000 Received: from localhost ([127.0.0.1]:33778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpQ8B-00031H-MJ for submit@debbugs.gnu.org; Tue, 27 May 2014 18:46:03 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:50274 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WpQ87-00030j-90 for 17554@debbugs.gnu.org; Tue, 27 May 2014 18:46:00 -0400 Received: from lukas.physics.niu.edu ([131.156.85.221]:56308) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1WpQ86-0008SB-La; Tue, 27 May 2014 18:45:58 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <5541.86351.568913.21381@gargle.gargle.HOWL> Date: Tue, 27 May 2014 17:45:57 -0500 From: "Roland Winkler" To: Juri Linkov Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window In-Reply-To: <8738fu51ld.fsf@mail.jurta.org> References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17554 Cc: martin rudalics , 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) On Wed May 28 2014 Juri Linkov wrote: > A good placement of the *Completions* buffer can be achieved by using: > > (add-to-list 'display-buffer-alist '("\\*Completions\\*" > display-buffer-at-bottom (nil))) > > It works in Dired as well with different window configurations. This displays the *Completions* buffer at the bottom, whereas 24.3 puts it above the *Marked Files* buffer. I have no strong preferences with this. I expect either way is fine. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 05 20:02:18 2014 Received: (at 17554) by debbugs.gnu.org; 6 Jun 2014 00:02:18 +0000 Received: from localhost ([127.0.0.1]:46278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wshbt-0002xa-PH for submit@debbugs.gnu.org; Thu, 05 Jun 2014 20:02:18 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:53391 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wshbs-0002xT-16 for 17554@debbugs.gnu.org; Thu, 05 Jun 2014 20:02:16 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 4EEF136B8B52D2; Thu, 5 Jun 2014 17:02:14 -0700 (PDT) From: Juri Linkov To: "Roland Winkler" Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> Date: Fri, 06 Jun 2014 02:48:50 +0300 In-Reply-To: <5541.86351.568913.21381@gargle.gargle.HOWL> (Roland Winkler's message of "Tue, 27 May 2014 17:45:57 -0500") Message-ID: <87k38u52o5.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> A good placement of the *Completions* buffer can be achieved by using: >> >> (add-to-list 'display-buffer-alist '("\\*Completions\\*" >> display-buffer-at-bottom (nil))) >> >> It works in Dired as well with different window configurations. > > This displays the *Completions* buffer at the bottom, whereas 24.3 > puts it above the *Marked Files* buffer. I have no strong > preferences with this. I expect either way is fine. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 17554 Cc: martin rudalics , 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> A good placement of the *Completions* buffer can be achieved by using: >> >> (add-to-list 'display-buffer-alist '("\\*Completions\\*" >> display-buffer-at-bottom (nil))) >> >> It works in Dired as well with different window configurations. > > This displays the *Completions* buffer at the bottom, whereas 24.3 > puts it above the *Marked Files* buffer. I have no strong > preferences with this. I expect either way is fine. [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 RCVD_IN_XBL RBL: Received via a relay in Spamhaus XBL [69.163.216.107 listed in zen.spamhaus.org] 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> A good placement of the *Completions* buffer can be achieved by using: >> >> (add-to-list 'display-buffer-alist '("\\*Completions\\*" >> display-buffer-at-bottom (nil))) >> >> It works in Dired as well with different window configurations. > > This displays the *Completions* buffer at the bottom, whereas 24.3 > puts it above the *Marked Files* buffer. I have no strong > preferences with this. I expect either way is fine. The *Completions* buffer is displayed by `internal-temp-output-buffer-show', so adding a new action `display-buffer-at-bottom' to it would affect many other unrelated commands besides completion commands. To modify the behavior of only *Completions* we need to add it to display-buffer-alist that will be non-empty by default: === modified file 'lisp/simple.el' --- lisp/simple.el 2014-06-02 00:18:22 +0000 +++ lisp/simple.el 2014-06-05 23:43:17 +0000 @@ -7300,6 +7300,9 @@ (defun switch-to-completions () ;; FIXME: Perhaps this should be done in `minibuffer-completion-help'. (when (bobp) (next-completion 1))))) + +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) + ;;; Support keyboard commands to turn on various modifiers. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 05 21:07:09 2014 Received: (at 17554) by debbugs.gnu.org; 6 Jun 2014 01:07:10 +0000 Received: from localhost ([127.0.0.1]:46295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wsicf-0005AJ-IP for submit@debbugs.gnu.org; Thu, 05 Jun 2014 21:07:09 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:30429) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wsice-0005A2-Cm for 17554@debbugs.gnu.org; Thu, 05 Jun 2014 21:07:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALNBIUGA0kiAzSGReOegeEOASpGYFqgXGBWyE X-IPAS-Result: ArYGAIDvNVPO+IOj/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALNBIUGA0kiAzSGReOegeEOASpGYFqgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65991867" Received: from 206-248-131-163.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Jun 2014 21:07:02 -0400 Received: by pastel.home (Postfix, from userid 20848) id 9868B60705; Thu, 5 Jun 2014 21:07:02 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Message-ID: References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> Date: Thu, 05 Jun 2014 21:07:02 -0400 In-Reply-To: <87k38u52o5.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 06 Jun 2014 02:48:50 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) `display-buffer-alist' has to stay nil by default. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 00:17:17 2014 Received: (at 17554) by debbugs.gnu.org; 6 Jun 2014 04:17:17 +0000 Received: from localhost ([127.0.0.1]:46369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wslae-0004NK-TH for submit@debbugs.gnu.org; Fri, 06 Jun 2014 00:17:17 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:40988 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wslac-0004N9-G9 for 17554@debbugs.gnu.org; Fri, 06 Jun 2014 00:17:15 -0400 Received: from 162-229-45-114.lightspeed.cicril.sbcglobal.net ([162.229.45.114]:57225 helo=regnitz) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Wslab-0004ft-GE; Fri, 06 Jun 2014 00:17:13 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16581.64879.470025.21393@gargle.gargle.HOWL> Date: Thu, 5 Jun 2014 23:17:09 -0500 From: "Roland Winkler" To: Stefan Monnier Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window In-Reply-To: References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17554 Cc: Juri Linkov , 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) On Thu Jun 5 2014 Stefan Monnier wrote: > > +(add-to-list 'display-buffer-alist '("\\*Completions\\*" > display-buffer-at-bottom (nil))) > > `display-buffer-alist' has to stay nil by default. I do not know much about how emacs manages its windows. Yet I am a bit surprised that the above approach establishes a rather special treatment of *Completions* buffers. I'd say the problem is that *a* buffer with typically more than two or three lines gets automatically displayed in a window that is only three lines high. We have a particular example where this happens to the *Completions* buffer. But if this happened with any other buffer this would be equally annoying. So it seems to me that this should be solved in a more generic way. Am I missing something? Roland From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 19:09:51 2014 Received: (at 17554) by debbugs.gnu.org; 6 Jun 2014 23:09:51 +0000 Received: from localhost ([127.0.0.1]:39946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt3Gh-00060g-CO for submit@debbugs.gnu.org; Fri, 06 Jun 2014 19:09:51 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:47321 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt3Ge-00060V-SU for 17554@debbugs.gnu.org; Fri, 06 Jun 2014 19:09:49 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 73D2B30A3E6F42; Fri, 6 Jun 2014 16:09:47 -0700 (PDT) From: Juri Linkov To: "Roland Winkler" Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> Date: Sat, 07 Jun 2014 02:05:30 +0300 In-Reply-To: <16581.64879.470025.21393@gargle.gargle.HOWL> (Roland Winkler's message of "Thu, 5 Jun 2014 23:17:09 -0500") Message-ID: <87r431prk5.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> > +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) >> >> `display-buffer-alist' has to stay nil by default. > > I do not know much about how emacs manages its windows. Yet I am a > bit surprised that the above approach establishes a rather special > treatment of *Completions* buffers. I'd say the problem is that *a* > buffer with typically more than two or three lines gets > automatically displayed in a window that is only three lines high. > We have a particular example where this happens to the *Completions* > buffer. But if this happened with any other buffer this would be > equally annoying. So it seems to me that this should be solved in a > more generic way. > > Am I missing something? [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> > +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) >> >> `display-buffer-alist' has to stay nil by default. > > I do not know much about how emacs manages its windows. Yet I am a > bit surprised that the above approach establishes a rather special > treatment of *Completions* buffers. I'd say the problem is that *a* > buffer with typically more than two or three lines gets > automatically displayed in a window that is only three lines high. > We have a particular example where this happens to the *Completions* > buffer. But if this happened with any other buffer this would be > equally annoying. So it seems to me that this should be solved in a > more generic way. > > Am I missing something? [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> > +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) >> >> `display-buffer-alist' has to stay nil by default. > > I do not know much about how emacs manages its windows. Yet I am a > bit surprised that the above approach establishes a rather special > treatment of *Completions* buffers. I'd say the problem is that *a* > buffer with typically more than two or three lines gets > automatically displayed in a window that is only three lines high. > We have a particular example where this happens to the *Completions* > buffer. But if this happened with any other buffer this would be > equally annoying. So it seems to me that this should be solved in a > more generic way. > > Am I missing something? This is how `display-buffer-use-some-window' works: it calls `get-lru-window' to get the least recently used window which is `*Marked Files*' in this case. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 06 19:09:54 2014 Received: (at 17554) by debbugs.gnu.org; 6 Jun 2014 23:09:54 +0000 Received: from localhost ([127.0.0.1]:39949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt3Gj-000610-PD for submit@debbugs.gnu.org; Fri, 06 Jun 2014 19:09:54 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:47304 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wt3Gc-00060S-VL for 17554@debbugs.gnu.org; Fri, 06 Jun 2014 19:09:51 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 0609930A32CB9A; Fri, 6 Jun 2014 16:09:44 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> Date: Sat, 07 Jun 2014 02:04:11 +0300 In-Reply-To: (Stefan Monnier's message of "Thu, 05 Jun 2014 21:07:02 -0400") Message-ID: <87sinhprmc.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) > > `display-buffer-alist' has to stay nil by default. This will do the same without changing the default value of `display-buffer-alist': [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) > > `display-buffer-alist' has to stay nil by default. This will do the same without changing the default value of `display-buffer-alist': [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) > > `display-buffer-alist' has to stay nil by default. This will do the same without changing the default value of `display-buffer-alist': === modified file 'lisp/minibuffer.el' --- lisp/minibuffer.el 2014-06-02 00:18:22 +0000 +++ lisp/minibuffer.el 2014-06-06 22:55:17 +0000 @@ -1796,7 +1796,10 @@ (defun minibuffer-completion-help (&opti ;; window, mark it as softly-dedicated, so bury-buffer in ;; minibuffer-hide-completions will know whether to ;; delete the window or not. - (display-buffer-mark-dedicated 'soft)) + (display-buffer-mark-dedicated 'soft) + (temp-buffer-show-function + (lambda (buffer) + (temp-buffer-window-show buffer '(display-buffer-at-bottom))))) (with-output-to-temp-buffer "*Completions*" ;; Remove the base-size tail because `sort' requires a properly ;; nil-terminated list. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 09 12:15:42 2014 Received: (at 17554) by debbugs.gnu.org; 9 Jun 2014 16:15:42 +0000 Received: from localhost ([127.0.0.1]:42117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wu2EX-0007OT-MQ for submit@debbugs.gnu.org; Mon, 09 Jun 2014 12:15:42 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:60842 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wu2EU-0007OI-RW for 17554@debbugs.gnu.org; Mon, 09 Jun 2014 12:15:40 -0400 Received: from lukas.physics.niu.edu ([131.156.85.221]:60783) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Wu2ET-0003kg-V8; Mon, 09 Jun 2014 12:15:38 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <56744.21680.858077.21397@gargle.gargle.HOWL> Date: Mon, 9 Jun 2014 11:15:36 -0500 From: "Roland Winkler" To: Juri Linkov Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window In-Reply-To: <87r431prk5.fsf@mail.jurta.org> References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) On Sat Jun 7 2014 Juri Linkov wrote: > > Am I missing something? > > This is how `display-buffer-use-some-window' works: > it calls `get-lru-window' to get the least recently used window > which is `*Marked Files*' in this case. I see. Thanks for your efforts to get this fixed. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 09 20:28:47 2014 Received: (at 17554) by debbugs.gnu.org; 10 Jun 2014 00:28:47 +0000 Received: from localhost ([127.0.0.1]:42263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wu9vj-0004BK-89 for submit@debbugs.gnu.org; Mon, 09 Jun 2014 20:28:47 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:43453 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wu9vg-0004B6-97 for 17554@debbugs.gnu.org; Mon, 09 Jun 2014 20:28:45 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id AA044315F84BDE; Mon, 9 Jun 2014 17:28:41 -0700 (PDT) From: Juri Linkov To: "Roland Winkler" Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> Date: Tue, 10 Jun 2014 03:12:08 +0300 In-Reply-To: <56744.21680.858077.21397@gargle.gargle.HOWL> (Roland Winkler's message of "Mon, 9 Jun 2014 11:15:36 -0500") Message-ID: <87sind4npv.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> > Am I missing something? >> >> This is how `display-buffer-use-some-window' works: >> it calls `get-lru-window' to get the least recently used window >> which is `*Marked Files*' in this case. > > I see. Thanks for your efforts to get this fixed. [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554 Cc: martin rudalics , Stefan Monnier , 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> > Am I missing something? >> >> This is how `display-buffer-use-some-window' works: >> it calls `get-lru-window' to get the least recently used window >> which is `*Marked Files*' in this case. > > I see. Thanks for your efforts to get this fixed. [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> > Am I missing something? >> >> This is how `display-buffer-use-some-window' works: >> it calls `get-lru-window' to get the least recently used window >> which is `*Marked Files*' in this case. > > I see. Thanks for your efforts to get this fixed. While the latest patch with `display-buffer-at-bottom' provides a better behavior for displaying *Completions*, I'm afraid it can't be installed into emacs-24 branch because it changes the behavior of *Completions* instead of just fixing the regression. Since `get-lru-window' has a higher precedence than `get-largest-window' in `display-buffer-use-some-window', we need to find a way to mark the *Marked Files* window as dedicated to not use it for displaying *Compilations*. I tried to set `dedicated' in the window action alist: === modified file 'lisp/dired.el' --- lisp/dired.el 2014-05-08 19:22:43 +0000 +++ lisp/dired.el 2014-06-10 00:02:14 +0000 @@ -3104,7 +3104,8 @@ (defun dired-mark-pop-up (buffer-or-name (with-current-buffer-window buffer (cons 'display-buffer-below-selected - '((window-height . fit-window-to-buffer))) + '((window-height . fit-window-to-buffer) + (dedicated . t))) #'(lambda (window _value) (with-selected-window window (unwind-protect but this doesn't seem to work. Then I found a workable solution: === modified file 'lisp/dired.el' --- lisp/dired.el 2014-05-08 19:22:43 +0000 +++ lisp/dired.el 2014-06-10 00:08:38 +0000 @@ -3099,7 +3099,11 @@ (defun dired-mark-pop-up (buffer-or-name ;; If FILES defaulted to the current line's file. (= (length files) 1)) (apply function args) - (let ((buffer (get-buffer-create (or buffer-or-name " *Marked Files*")))) + (let ((buffer (get-buffer-create (or buffer-or-name " *Marked Files*"))) + (temp-buffer-window-show-hook + (cons (lambda () + (set-window-dedicated-p window t)) + temp-buffer-window-show-hook))) (with-current-buffer buffer (with-current-buffer-window buffer But it's too ugly and produces compilation warning "reference to free variable `window'". Maybe Martin has better ideas? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 10 02:07:20 2014 Received: (at 17554) by debbugs.gnu.org; 10 Jun 2014 06:07:20 +0000 Received: from localhost ([127.0.0.1]:42480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WuFDL-0005GM-SF for submit@debbugs.gnu.org; Tue, 10 Jun 2014 02:07:20 -0400 Received: from mout.gmx.net ([212.227.17.22]:59617) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WuFDJ-0005Fz-GH for 17554@debbugs.gnu.org; Tue, 10 Jun 2014 02:07:18 -0400 Received: from [194.166.86.116] ([194.166.86.116]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LxgM7-1Witba3uwd-017HrX; Tue, 10 Jun 2014 08:07:10 +0200 Message-ID: <5396A087.6090606@gmx.at> Date: Tue, 10 Jun 2014 08:07:03 +0200 From: martin rudalics MIME-Version: 1.0 To: Juri Linkov , Roland Winkler Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> In-Reply-To: <87sind4npv.fsf@mail.jurta.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:UX3nzyvCPzHxVrdY3c1wKVyWwdJaLAnPKgGgndCSj4hRaOAtIKm VQb4kOv+dSWCIz09WB4F/NRR0njiQKg++v1SvSigqj+Wb2Im+9DQQJD75sWKRoQ8Ja0f5xq afsaGkb4QOLQZ7exQyIfHRZF0rKekzK1klhYVHLY6UpIGBu8mB+PROgQ12qPxDKEOsKEF3W lA3eiXxHN22/5YLMn7sBg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Maybe Martin has better ideas? The earlier behavior was handwoven and allowed three windows to coexist simultaneously on one and the same frame. We can't achieve that via `display-buffer' because the default value of `split-height-threshold' precludes it. IMHO that value is ridiculously small and in practice always inhibits popping up a third window. But changing that value for the release doesn't sound like a good idea to me. So IIUC we have to write our own `split-window-preferred-function' here. Unless anyone has a better idea ... martin From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 10 19:08:22 2014 Received: (at 17554) by debbugs.gnu.org; 10 Jun 2014 23:08:22 +0000 Received: from localhost ([127.0.0.1]:43295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WuV9S-00082p-2P for submit@debbugs.gnu.org; Tue, 10 Jun 2014 19:08:22 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:34059 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WuV9Q-00082g-4B for 17554@debbugs.gnu.org; Tue, 10 Jun 2014 19:08:20 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 949E5309749FC3; Tue, 10 Jun 2014 16:08:15 -0700 (PDT) From: Juri Linkov To: martin rudalics Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> Date: Wed, 11 Jun 2014 01:57:30 +0300 In-Reply-To: <5396A087.6090606@gmx.at> (martin rudalics's message of "Tue, 10 Jun 2014 08:07:03 +0200") Message-ID: <874mzs8jad.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > The earlier behavior was handwoven and allowed three windows to coexist > simultaneously on one and the same frame. We can't achieve that via > `display-buffer' because the default value of `split-height-threshold' > precludes it. IMHO that value is ridiculously small and in practice > always inhibits popping up a third window. But changing that value for > the release doesn't sound like a good idea to me. [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > The earlier behavior was handwoven and allowed three windows to coexist > simultaneously on one and the same frame. We can't achieve that via > `display-buffer' because the default value of `split-height-threshold' > precludes it. IMHO that value is ridiculously small and in practice > always inhibits popping up a third window. But changing that value for > the release doesn't sound like a good idea to me. [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] > The earlier behavior was handwoven and allowed three windows to coexist > simultaneously on one and the same frame. We can't achieve that via > `display-buffer' because the default value of `split-height-threshold' > precludes it. IMHO that value is ridiculously small and in practice > always inhibits popping up a third window. But changing that value for > the release doesn't sound like a good idea to me. The standard terminal size is 80x25. 80*2 = 160 which is a good default width for `split-width-threshold'. Correspondingly, 25*2 = 50 would be a better default height for `split-height-threshold' to be changed in the trunk. (Another good change for the trunk is to use `display-buffer-at-bottom' for *Completions*). > So IIUC we have to write our own `split-window-preferred-function' here. For the emacs-24 branch `split-window-preferred-function' won't help if the window height is smaller than `split-height-threshold', and *Completions* still will be displayed in the small window of *Marked Files*. This could be fixed only by displaying *Completions* in the window containing the Dired buffer (without using split-window) like it was in previous releases. This is why I tried to mark *Marked Files* as dedicated. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 11 03:15:28 2014 Received: (at 17554) by debbugs.gnu.org; 11 Jun 2014 07:15:28 +0000 Received: from localhost ([127.0.0.1]:43482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wuckp-0003LC-Dv for submit@debbugs.gnu.org; Wed, 11 Jun 2014 03:15:27 -0400 Received: from mout.gmx.net ([212.227.15.15]:53601) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wuckm-0003Ky-RU for 17554@debbugs.gnu.org; Wed, 11 Jun 2014 03:15:26 -0400 Received: from [194.118.137.29] ([194.118.137.29]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Lk81O-1WJv9k1kzK-00c7pt; Wed, 11 Jun 2014 09:15:14 +0200 Message-ID: <539801FA.2040400@gmx.at> Date: Wed, 11 Jun 2014 09:15:06 +0200 From: martin rudalics MIME-Version: 1.0 To: Juri Linkov Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> In-Reply-To: <874mzs8jad.fsf@mail.jurta.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:rh7ciG+PD+VVmnFRWnzF3eXX34m/v/l97hdICTV2TeyX8ZNG46o enA4zO97Gxpna0Uv3JxK4X/S6HmCmFiuUgxUuUyMLiG/uAAIlqi2Dj2+g2zHXPGjMM58nPQ aDbmVV9afoa3Gd5pMDBwWvP6H8CGntZdFPvBJuDGsCSkSyNWcrq9+CDFfOwS0c3NMQFbSAB gUUTnb9fosMPQ+Sj97/3Q== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > The standard terminal size is 80x25. 80*2 = 160 which is a good > default width for `split-width-threshold'. Correspondingly, 25*2 = 50 > would be a better default height for `split-height-threshold' > to be changed in the trunk. (Another good change for the trunk > is to use `display-buffer-at-bottom' for *Completions*). What does it use currently? > For the emacs-24 branch `split-window-preferred-function' won't help > if the window height is smaller than `split-height-threshold', We'd have to write our own `split-window-preferred-function' which would set `split-height-threshold' accordingly. This is not entirely clean though since we'd bind a user variable. A user could override it via `display-buffer-alist' but this is not entirely obvious. Usually, the right choice would be to pass appropriate functions via the ACTION argument. Unfortunately, the `display-buffer' call issued for *Completions* is virtually nested in the call for *Marked Files* which makes things more complicated than expected. (1) I wouldn't want to change the general behavior of how *Completions* are presented just in order to fix the problem at hand. (2) Changing the ACTION argument for the `display-buffer' call used to show *Completions* such as to check whether a *Marked Files* buffer is currently shown and avoid using that or the original dired window is no viable alternative either. (3) Marking any of the dired or *Marked Files* windows as dedicated is somewhat dangerous (even when done softly) when the user quits the *Completions* window in some non-standard, non-modal way. (4) Using `display-buffer-overriding-action' is clearly to harsh. > and *Completions* still will be displayed in the small window > of *Marked Files*. This could be fixed only by displaying > *Completions* in the window containing the Dired buffer > (without using split-window) like it was in previous releases. > This is why I tried to mark *Marked Files* as dedicated. But the 24.3 code handles Roland's scenario by displaying *Completions* in a third window. At least it does so here. What do you get? martin From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 12 02:34:51 2014 Received: (at 17554) by debbugs.gnu.org; 12 Jun 2014 06:34:51 +0000 Received: from localhost ([127.0.0.1]:45008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wuyb4-0004ip-Kd for submit@debbugs.gnu.org; Thu, 12 Jun 2014 02:34:50 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:58809 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wuyao-0004iH-0g for 17554@debbugs.gnu.org; Thu, 12 Jun 2014 02:34:49 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9768430A2DEAD7; Wed, 11 Jun 2014 23:34:31 -0700 (PDT) From: Juri Linkov To: martin rudalics Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> <539801FA.2040400@gmx.at> Date: Thu, 12 Jun 2014 09:33:11 +0300 In-Reply-To: <539801FA.2040400@gmx.at> (martin rudalics's message of "Wed, 11 Jun 2014 09:15:06 +0200") Message-ID: <87vbs6r61k.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > But the 24.3 code handles Roland's scenario by displaying *Completions* > in a third window. At least it does so here. What do you get? 24.3 displays *Completions* in the window with the dired buffer because the lru-window is the dired window in 24.3, but in 24.4 the lru-window is the small window with *Marked Files*. [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] > But the 24.3 code handles Roland's scenario by displaying *Completions* > in a third window. At least it does so here. What do you get? 24.3 displays *Completions* in the window with the dired buffer because the lru-window is the dired window in 24.3, but in 24.4 the lru-window is the small window with *Marked Files*. Maybe it's possible to change window's timestamp after displaying *Marked Files* to make the dired window lru, to display *Completions* in it like in 24.3? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 16 02:56:54 2014 Received: (at 17554) by debbugs.gnu.org; 16 Jun 2014 06:56:54 +0000 Received: from localhost ([127.0.0.1]:48673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwQqb-0008Rn-7j for submit@debbugs.gnu.org; Mon, 16 Jun 2014 02:56:53 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:34543 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwQqZ-0008Re-54 for 17554@debbugs.gnu.org; Mon, 16 Jun 2014 02:56:51 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 0C467349517F58; Sun, 15 Jun 2014 23:56:48 -0700 (PDT) From: Juri Linkov To: martin rudalics Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> <539801FA.2040400@gmx.at> <87vbs6r61k.fsf@mail.jurta.org> Date: Mon, 16 Jun 2014 09:51:17 +0300 In-Reply-To: <87vbs6r61k.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 12 Jun 2014 09:33:11 +0300") Message-ID: <87fvj5fq8q.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> But the 24.3 code handles Roland's scenario by displaying *Completions* >> in a third window. At least it does so here. What do you get? > > 24.3 displays *Completions* in the window with the dired buffer > because the lru-window is the dired window in 24.3, but in 24.4 > the lru-window is the small window with *Marked Files*. > > Maybe it's possible to change window's timestamp after displaying > *Marked Files* to make the dired window lru, to display *Completions* > in it like in 24.3? [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> But the 24.3 code handles Roland's scenario by displaying *Completions* >> in a third window. At least it does so here. What do you get? > > 24.3 displays *Completions* in the window with the dired buffer > because the lru-window is the dired window in 24.3, but in 24.4 > the lru-window is the small window with *Marked Files*. > > Maybe it's possible to change window's timestamp after displaying > *Marked Files* to make the dired window lru, to display *Completions* > in it like in 24.3? [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> But the 24.3 code handles Roland's scenario by displaying *Completions* >> in a third window. At least it does so here. What do you get? > > 24.3 displays *Completions* in the window with the dired buffer > because the lru-window is the dired window in 24.3, but in 24.4 > the lru-window is the small window with *Marked Files*. > > Maybe it's possible to change window's timestamp after displaying > *Marked Files* to make the dired window lru, to display *Completions* > in it like in 24.3? The problem is that `with-selected-window' calls `select-window' with the non-nil arg `norecord' that doesn't update the window's use_time, so the displayed window considered least-recently used. I don't know how general this problem is, but at least for *Marked files* the following patch causes the Dired window to be least-recently used, thus avoiding using *Marked files* window to display *Completions*: === modified file 'lisp/dired.el' --- lisp/dired.el 2014-05-08 19:22:43 +0000 +++ lisp/dired.el 2014-06-16 06:45:18 +0000 @@ -3107,6 +3107,7 @@ (defun dired-mark-pop-up (buffer-or-name '((window-height . fit-window-to-buffer))) #'(lambda (window _value) (with-selected-window window + (select-window window) ;; use nil NORECORD to make window the most recently selected. (unwind-protect (apply function args) (when (window-live-p window) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 16 15:49:44 2014 Received: (at 17554) by debbugs.gnu.org; 16 Jun 2014 19:49:44 +0000 Received: from localhost ([127.0.0.1]:49663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwcuW-000447-4g for submit@debbugs.gnu.org; Mon, 16 Jun 2014 15:49:44 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:60414 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwcuT-00043z-Rw for 17554@debbugs.gnu.org; Mon, 16 Jun 2014 15:49:42 -0400 Received: from lukas.physics.niu.edu ([131.156.85.221]:35469) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1WwcuT-00009N-7t; Mon, 16 Jun 2014 15:49:41 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19028.48992.2350.21407@gargle.gargle.HOWL> Date: Mon, 16 Jun 2014 14:49:40 -0500 From: "Roland Winkler" To: Juri Linkov Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window In-Reply-To: <87fvj5fq8q.fsf@mail.jurta.org> References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> <539801FA.2040400@gmx.at> <87vbs6r61k.fsf@mail.jurta.org> <87fvj5fq8q.fsf@mail.jurta.org> X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 17554 Cc: martin rudalics , 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) On Mon Jun 16 2014 Juri Linkov wrote: > I don't know how general this problem is, but at least for *Marked > files* the following patch causes the Dired window to be > least-recently used, thus avoiding using *Marked files* window to > display *Completions*: Just for the records: I guess there might be similar problems in other usage cases, too. However, using Emacs 24.3.91 I did not encounter so far a 2nd scenario where a temporary buffer like *Completions* gets displayed in a ridiculously small window. We need two temp buffers like *Marked files* (small) and *Completions* (bigger) for this bug to show up. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 16 17:48:12 2014 Received: (at 17554) by debbugs.gnu.org; 16 Jun 2014 21:48:12 +0000 Received: from localhost ([127.0.0.1]:49718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wwel9-00071u-UE for submit@debbugs.gnu.org; Mon, 16 Jun 2014 17:48:12 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:49644) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wwel4-00071h-Dz for 17554@debbugs.gnu.org; Mon, 16 Jun 2014 17:48:11 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 189F924133; Mon, 16 Jun 2014 17:48:06 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 3F94C1E5B8A; Mon, 16 Jun 2014 17:47:42 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 27ADBB4167; Mon, 16 Jun 2014 17:47:42 -0400 (EDT) From: Stefan Monnier To: "Roland Winkler" Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Message-ID: References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> <539801FA.2040400@gmx.at> <87vbs6r61k.fsf@mail.jurta.org> <87fvj5fq8q.fsf@mail.jurta.org> <19028.48992.2350.21407@gargle.gargle.HOWL> Date: Mon, 16 Jun 2014 17:47:42 -0400 In-Reply-To: <19028.48992.2350.21407@gargle.gargle.HOWL> (Roland Winkler's message of "Mon, 16 Jun 2014 14:49:40 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 17554 Cc: Juri Linkov , 17554@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > We need two temp buffers like *Marked files* (small) and > *Completions* (bigger) for this bug to show up. FWIW, I think the right way to handle this case is to mark the window displaying *Marked files* as "dedicated". Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 02:49:06 2014 Received: (at 17554) by debbugs.gnu.org; 17 Jun 2014 06:49:06 +0000 Received: from localhost ([127.0.0.1]:49896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwnCb-0004tQ-Hw for submit@debbugs.gnu.org; Tue, 17 Jun 2014 02:49:05 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:46884 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwnCM-0004sg-SG for 17554@debbugs.gnu.org; Tue, 17 Jun 2014 02:49:04 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 772D632302F6C9; Mon, 16 Jun 2014 23:48:48 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> <539801FA.2040400@gmx.at> <87vbs6r61k.fsf@mail.jurta.org> <87fvj5fq8q.fsf@mail.jurta.org> <19028.48992.2350.21407@gargle.gargle.HOWL> Date: Tue, 17 Jun 2014 09:44:19 +0300 In-Reply-To: (Stefan Monnier's message of "Mon, 16 Jun 2014 17:47:42 -0400") Message-ID: <87y4wwujb0.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> We need two temp buffers like *Marked files* (small) and >> *Completions* (bigger) for this bug to show up. > > FWIW, I think the right way to handle this case is to mark the window > displaying *Marked files* as "dedicated". [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> We need two temp buffers like *Marked files* (small) and >> *Completions* (bigger) for this bug to show up. > > FWIW, I think the right way to handle this case is to mark the window > displaying *Marked files* as "dedicated". [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> We need two temp buffers like *Marked files* (small) and >> *Completions* (bigger) for this bug to show up. > > FWIW, I think the right way to handle this case is to mark the window > displaying *Marked files* as "dedicated". This is achieved in this patch by binding `display-buffer-mark-dedicated' to the same value 'soft' as in `minibuffer-completion-help' used to display *Completions*. Also I noticed that everywhere in code only `soft' is used instead of `softly' that is suggested in window.el, so documentation could be fixed as well. === modified file 'lisp/dired.el' --- lisp/dired.el 2014-05-08 19:22:43 +0000 +++ lisp/dired.el 2014-06-17 06:42:52 +0000 @@ -3099,7 +3099,10 @@ (defun dired-mark-pop-up (buffer-or-name ;; If FILES defaulted to the current line's file. (= (length files) 1)) (apply function args) - (let ((buffer (get-buffer-create (or buffer-or-name " *Marked Files*")))) + (let ((buffer (get-buffer-create (or buffer-or-name " *Marked Files*"))) + ;; Mark *Marked Files* as softly-dedicated, to prevent other + ;; new windows e.g. *Completions* from reusing it (bug#17554). + (display-buffer-mark-dedicated 'soft)) (with-current-buffer buffer (with-current-buffer-window buffer === modified file 'lisp/window.el' --- lisp/window.el 2014-06-03 12:38:17 +0000 +++ lisp/window.el 2014-06-17 06:42:19 +0000 @@ -5966,7 +5966,7 @@ (defun window--maybe-raise-frame (frame) ;; FIXME: By the way, there could be more levels of dedication: ;; - `barely' dedicated doesn't prevent reuse of the window, only records that ;; the window hasn't been used for something else yet. -;; - `softly' dedicated only allows reuse when asked explicitly. +;; - `soft' dedicated only allows reuse when asked explicitly. ;; - `strongly' never allows reuse. (defvar display-buffer-mark-dedicated nil "If non-nil, `display-buffer' marks the windows it creates as dedicated. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 03:59:44 2014 Received: (at 17554-done) by debbugs.gnu.org; 18 Jun 2014 07:59:44 +0000 Received: from localhost ([127.0.0.1]:51101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxAmV-0000Ez-SU for submit@debbugs.gnu.org; Wed, 18 Jun 2014 03:59:44 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:58413 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxAmT-0000Eq-K1 for 17554-done@debbugs.gnu.org; Wed, 18 Jun 2014 03:59:42 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 4E7773074F9245; Wed, 18 Jun 2014 00:59:39 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <16581.64879.470025.21393@gargle.gargle.HOWL> <87r431prk5.fsf@mail.jurta.org> <56744.21680.858077.21397@gargle.gargle.HOWL> <87sind4npv.fsf@mail.jurta.org> <5396A087.6090606@gmx.at> <874mzs8jad.fsf@mail.jurta.org> <539801FA.2040400@gmx.at> <87vbs6r61k.fsf@mail.jurta.org> <87fvj5fq8q.fsf@mail.jurta.org> <19028.48992.2350.21407@gargle.gargle.HOWL> <87y4wwujb0.fsf@mail.jurta.org> Date: Wed, 18 Jun 2014 10:57:54 +0300 In-Reply-To: <87y4wwujb0.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 17 Jun 2014 09:44:19 +0300") Message-ID: <87mwdak5tp.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> FWIW, I think the right way to handle this case is to mark the window >> displaying *Marked files* as "dedicated". > > This is achieved in this patch by binding `display-buffer-mark-dedicated' > to the same value 'soft' as in `minibuffer-completion-help' used > to display *Completions*. [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554-done Cc: 17554-done@debbugs.gnu.org, Roland Winkler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> FWIW, I think the right way to handle this case is to mark the window >> displaying *Marked files* as "dedicated". > > This is achieved in this patch by binding `display-buffer-mark-dedicated' > to the same value 'soft' as in `minibuffer-completion-help' used > to display *Completions*. [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >> FWIW, I think the right way to handle this case is to mark the window >> displaying *Marked files* as "dedicated". > > This is achieved in this patch by binding `display-buffer-mark-dedicated' > to the same value 'soft' as in `minibuffer-completion-help' used > to display *Completions*. Regression is fixed in the emacs-24 branch. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 04:19:54 2014 Received: (at 17554) by debbugs.gnu.org; 18 Jun 2014 08:19:54 +0000 Received: from localhost ([127.0.0.1]:51111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxB61-0000k7-QU for submit@debbugs.gnu.org; Wed, 18 Jun 2014 04:19:54 -0400 Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:46434 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WxB60-0000jx-3N for 17554@debbugs.gnu.org; Wed, 18 Jun 2014 04:19:52 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 25489303235924; Wed, 18 Jun 2014 01:19:46 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Organization: JURTA References: <22309.78500.835208.21374@gargle.gargle.HOWL> <44983.87719.904757.21374@gargle.gargle.HOWL> <537EF7A7.8040608@gmx.at> <87ioowmb9v.fsf@mail.jurta.org> <8738fu51ld.fsf@mail.jurta.org> <5541.86351.568913.21381@gargle.gargle.HOWL> <87k38u52o5.fsf@mail.jurta.org> <87sinhprmc.fsf@mail.jurta.org> Date: Wed, 18 Jun 2014 11:07:05 +0300 In-Reply-To: <87sinhprmc.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 07 Jun 2014 02:04:11 +0300") Message-ID: <87mwdaiqbm.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>> +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) >> >> `display-buffer-alist' has to stay nil by default. > > This will do the same without changing the default value of `display-buffer-alist': [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] X-Debbugs-Envelope-To: 17554 Cc: 17554@debbugs.gnu.org, Roland Winkler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>> +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) >> >> `display-buffer-alist' has to stay nil by default. > > This will do the same without changing the default value of `display-buffer-alist': [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_BRBL_LASTEXT RBL: RCVD_IN_BRBL_LASTEXT [69.163.216.107 listed in bb.barracudacentral.org] >>> +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil))) >> >> `display-buffer-alist' has to stay nil by default. > > This will do the same without changing the default value of `display-buffer-alist': More changes are needed (for the trunk to better display *Completions*) to copy all default actions from `display-buffer-fallback-action', but replace `display-buffer-use-some-window' with `display-buffer-at-bottom': === modified file 'lisp/minibuffer.el' --- lisp/minibuffer.el 2014-06-02 00:18:22 +0000 +++ lisp/minibuffer.el 2014-06-18 08:01:12 +0000 @@ -1796,7 +1796,21 @@ (defun minibuffer-completion-help (&opti ;; window, mark it as softly-dedicated, so bury-buffer in ;; minibuffer-hide-completions will know whether to ;; delete the window or not. - (display-buffer-mark-dedicated 'soft)) + (display-buffer-mark-dedicated 'soft) + ;; Disable `pop-up-windows' temporarily to allow + ;; `display-buffer--maybe-pop-up-frame-or-window' + ;; in the overridden actions below to pop up a frame + ;; if `pop-up-frames' is non-nil, but not to pop up a window. + ;; Use `display-buffer-at-bottom' to display completions + ;; in a window at the bottom of the selected frame. + (pop-up-windows nil) + (temp-buffer-show-function + (lambda (buffer) + (temp-buffer-window-show buffer '((display-buffer--maybe-same-window + display-buffer-reuse-window + display-buffer--maybe-pop-up-frame-or-window + display-buffer-at-bottom) + (window-height . fit-window-to-buffer)))))) (with-output-to-temp-buffer "*Completions*" ;; Remove the base-size tail because `sort' requires a properly ;; nil-terminated list. From unknown Tue Jun 24 22:37:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Jul 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator