From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 07:13:57 2014 Received: (at submit) by debbugs.gnu.org; 22 May 2014 11:13:58 +0000 Received: from localhost ([127.0.0.1]:56136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnQwf-00087F-9n for submit@debbugs.gnu.org; Thu, 22 May 2014 07:13:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47046) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnQwc-00086t-6u for submit@debbugs.gnu.org; Thu, 22 May 2014 07:13:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnQwN-0003FF-TF for submit@debbugs.gnu.org; Thu, 22 May 2014 07:13:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnQwN-0003FA-Qa for submit@debbugs.gnu.org; Thu, 22 May 2014 07:13:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnQwE-0006xA-Kz for bug-gnu-emacs@gnu.org; Thu, 22 May 2014 07:13:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnQw4-00039D-Rg for bug-gnu-emacs@gnu.org; Thu, 22 May 2014 07:13:30 -0400 Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]:55427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnQw4-00038z-Lu for bug-gnu-emacs@gnu.org; Thu, 22 May 2014 07:13:20 -0400 Received: by mail-pd0-f177.google.com with SMTP id g10so2366499pdj.22 for ; Thu, 22 May 2014 04:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=fAn89EMfLJI94PvibbDVjfXPadL3GvpZwtwGUNq/dMs=; b=P2M1L1vyZ25m6Bg1E3d/ebqDJIRn2DuuwGtf5P33y4oSfFNSQHmb6Jg4Tx8xl9nQS/ PPGQNIxO11KUEnTuxaviiQUSP5RtWjLzkCg0ps4S1u+rOmJkwOQ1oQIF8Un63hLjfwpH FBx8I3ePdeX9rio96C7gmhldMvtZrbozfzst3NPwbZ29HrbLFaxbAmRJHpJ8pAPU8gz/ zw5wWdtCbxUnQcLe9x+tK369wuV36xAA2tZp89d238PP/GjlTZmBsGXaE7WRV7ESS+oc BIHS08jgg/eKxmWo9E9uopEO+sdTJ1FLnB+t08VXMs2OFXCgsmxlYBo+kln+GIk9Sg9L 4bSw== X-Received: by 10.68.247.131 with SMTP id ye3mr3366870pbc.40.1400757199605; Thu, 22 May 2014 04:13:19 -0700 (PDT) Received: from fortuna ([123.119.93.100]) by mx.google.com with ESMTPSA id pe3sm12567505pbc.23.2014.05.22.04.13.09 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 22 May 2014 04:13:18 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.4.50; regression: url-insert-file-contents X-Debbugs-CC: Juanma Barranquero Date: Thu, 22 May 2014 19:11:31 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) In using url-http-parse-response we have restricted url-insert-file-contents to only HTTP. Previously it handles all URL protocols. For example, if fed file:///url-to-whatever, it throws an error: Debugger entered--Lisp error: (void-variable url-http-end-of-headers) Leo From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 19:24:55 2014 Received: (at 17549) by debbugs.gnu.org; 29 May 2014 23:24:56 +0000 Received: from localhost ([127.0.0.1]:36594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq9gt-0006WZ-DU for submit@debbugs.gnu.org; Thu, 29 May 2014 19:24:55 -0400 Received: from mail-pb0-f51.google.com ([209.85.160.51]:49814) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wq9gr-0006WI-30 for 17549@debbugs.gnu.org; Thu, 29 May 2014 19:24:54 -0400 Received: by mail-pb0-f51.google.com with SMTP id ma3so1022489pbc.38 for <17549@debbugs.gnu.org>; Thu, 29 May 2014 16:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=qQjNtY5elr7wpvXt6vpeJ5BjztGQ/a0JdqYzDEKn6dw=; b=GiNi9Wv42AZgiZVoiyIzP0QbKXWsyX+kbWvYyHceJW8x1XBcaCzFVRTtpYBMYYAbUC KsUbmWNxaXqdcvntDzBUIXDVQhReDt40IYvN6O3Py1XYbUNC422/x2N5NG7lCyoUhucD +VoLelq/wNzOw0aXGPOxZlxki2c67w72iiDBeql8AYlqssOIHaS/SUuT20ysDMvHSqm3 1Q0cP3AsrbR4lvgq3mhm4tNkwtFAYDCZCcMPI7quoiqBbalL3ay5dPO79qq1dAejSaFw EUvH3llgSmZb9iEIaOTuboPvtDmebJDfFNB00e5vPfYsZLn00ml34ebLeLh7DKoB31wQ iJ3Q== X-Received: by 10.68.240.5 with SMTP id vw5mr12896973pbc.113.1401405886923; Thu, 29 May 2014 16:24:46 -0700 (PDT) Received: from fortuna ([222.130.180.115]) by mx.google.com with ESMTPSA id iq10sm3091575pbc.14.2014.05.29.16.24.44 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 29 May 2014 16:24:46 -0700 (PDT) From: Leo Liu To: 17549@debbugs.gnu.org Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Fri, 30 May 2014 07:24:40 +0800 In-Reply-To: (Leo Liu's message of "Thu, 22 May 2014 19:11:31 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17549 Cc: Juanma Barranquero X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Juanma, The regression is introduced by your commit 116865 in emacs-24 and this causes a core function in my setup to fail. I have temporarily reverted the change in my local copy. Could you take a look and fix it before the next pretest? Thanks, Leo From debbugs-submit-bounces@debbugs.gnu.org Thu May 29 22:10:37 2014 Received: (at 17549) by debbugs.gnu.org; 30 May 2014 02:10:37 +0000 Received: from localhost ([127.0.0.1]:36687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqCHA-0004Wj-PG for submit@debbugs.gnu.org; Thu, 29 May 2014 22:10:35 -0400 Received: from mail-yh0-f42.google.com ([209.85.213.42]:63866) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqCH8-0004WQ-Cg for 17549@debbugs.gnu.org; Thu, 29 May 2014 22:10:31 -0400 Received: by mail-yh0-f42.google.com with SMTP id t59so1077763yho.1 for <17549@debbugs.gnu.org>; Thu, 29 May 2014 19:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=zeMmfmFoIUe+6OJx9AolIdKjuXVq6J9b4KQIhqRQbyc=; b=eE4bUe54bm20EkX2H6AdDqsGeoN03M2gLnZzQfF26A2YqDHzeyAJMceshxhdMHQcCe 4+RmKcGGYOA/uJicRL0M4zZlqxgCyZditbOnW2YKdVEk9DCmyTzcE+m2a5zzwfLRMh6n BpgS+FdzhgcXKxwmXp5d9FQhDlovEYNl7S3vu8s6rNa6MdpPYk0FQXXuO6L6GXfs+c4e oB8gf7h7PGABXXmir9c3ZlxNzccjQVQ1ElaHv+hmUU8Ll2GKo8jawZQiKB9gjyhFFEKr QYpp5rtcion7e9/J9Hog1c52oQr2WKhhOTbOk9m7i6GqQ6630kjcBqKv5CQUUJMiNa0T 3gQw== X-Received: by 10.236.226.101 with SMTP id a95mr15655254yhq.88.1401415824762; Thu, 29 May 2014 19:10:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.127.66 with HTTP; Thu, 29 May 2014 19:09:44 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Fri, 30 May 2014 04:09:44 +0200 Message-ID: Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents To: Leo Liu Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17549 Cc: 17549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, May 30, 2014 at 1:24 AM, Leo Liu wrote: > Could you take a look and fix it before the next pretest? Yes, I'll look into it. J From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 23 23:24:17 2014 Received: (at 17549) by debbugs.gnu.org; 24 Jun 2014 03:24:17 +0000 Received: from localhost ([127.0.0.1]:58771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzHLE-0006MW-IR for submit@debbugs.gnu.org; Mon, 23 Jun 2014 23:24:16 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:49175) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzHLB-0006MD-Sr for 17549@debbugs.gnu.org; Mon, 23 Jun 2014 23:24:14 -0400 Received: by mail-pb0-f43.google.com with SMTP id um1so6420754pbc.30 for <17549@debbugs.gnu.org>; Mon, 23 Jun 2014 20:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=o+KUy0RVDYHYaOGEMU6Et2FRI6b+q3yH8Nrx7REQEyU=; b=rDo3Lxwk5Dt5mcRZV2tq7HDFce2BsbikfM1WlvfQk40hSbtGR8XIiX8BFyed+eimHE FRLE02+VWCbP1toFSbLs5vHO2+V4qwE605BeuXfUwRRYlV0t5+69CxZDW54j4dKQwys2 LJDmZVlup5CewAKyRYeTzg1NmkBiHfLPhhOBfcQL0HqBaigK9Wuj5cBTDfjQMJ6s6DmQ jVds+Cl3xry4bjsZZMvxLSpeLN+dDJM30gWBihMptEVuG0o7QJlxvIvTW0jlD4OmxAE4 TOf72reRYhfKcdsWOK+QTSpduj1Tnx+NfBu/aI2oPPaWxM0Oy7YkGwO6UrtYVuaNZLlU 94hQ== X-Received: by 10.66.243.225 with SMTP id xb1mr35007061pac.49.1403580247739; Mon, 23 Jun 2014 20:24:07 -0700 (PDT) Received: from fortuna ([221.222.158.228]) by mx.google.com with ESMTPSA id fe2sm29265088pbc.68.2014.06.23.20.24.05 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Mon, 23 Jun 2014 20:24:06 -0700 (PDT) From: Leo Liu To: Juanma Barranquero Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Tue, 24 Jun 2014 11:24:03 +0800 In-Reply-To: (Juanma Barranquero's message of "Fri, 30 May 2014 04:09:44 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17549 Cc: 17549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2014-05-30 04:09 +0200, Juanma Barranquero wrote: > Yes, I'll look into it. > > J Ping? Any objection to moving the http/s code back to package.el? Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 24 08:50:08 2014 Received: (at 17549) by debbugs.gnu.org; 24 Jun 2014 12:50:08 +0000 Received: from localhost ([127.0.0.1]:58943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzQAl-0007O5-Ct for submit@debbugs.gnu.org; Tue, 24 Jun 2014 08:50:08 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:16295) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzQAe-0007NM-I7 for 17549@debbugs.gnu.org; Tue, 24 Jun 2014 08:50:01 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArkGAIDvNVNLd+D9/2dsb2JhbABZgwY7gw+9L4MGCIEXF3SCJQEBAQECAVYjEAsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArkGAIDvNVNLd+D9/2dsb2JhbABZgwY7gw+9L4MGCIEXF3SCJQEBAQECAVYjEAsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="69375181" Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Jun 2014 08:49:50 -0400 Received: by pastel.home (Postfix, from userid 20848) id 741C3604AF; Tue, 24 Jun 2014 08:49:50 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents Message-ID: References: Date: Tue, 24 Jun 2014 08:49:50 -0400 In-Reply-To: (Leo Liu's message of "Tue, 24 Jun 2014 11:24:03 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17549 Cc: Juanma Barranquero , 17549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Yes, I'll look into it. > Ping? > Any objection to moving the http/s code back to package.el? Does this affect emacs-24 as well? If so, for emacs-24, it's OK, but for trunk we want something better. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 24 08:59:04 2014 Received: (at 17549) by debbugs.gnu.org; 24 Jun 2014 12:59:04 +0000 Received: from localhost ([127.0.0.1]:58951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzQJO-0007d6-P0 for submit@debbugs.gnu.org; Tue, 24 Jun 2014 08:59:03 -0400 Received: from mail-yk0-f174.google.com ([209.85.160.174]:53921) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzQJH-0007ck-ID for 17549@debbugs.gnu.org; Tue, 24 Jun 2014 08:58:56 -0400 Received: by mail-yk0-f174.google.com with SMTP id 19so132690ykq.5 for <17549@debbugs.gnu.org>; Tue, 24 Jun 2014 05:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=1HWAWPboJ8neYEfgp2Shl6oAbW0eK7toacPxDwu6MIo=; b=RkeCaKUFSMXoJozIvqZ5fi0Vsq1Y7WJDlWn3BYtg3l2yhsC0TgOF5/JT+D+YM7nKT0 OSMwEzt1KKchHZHPHEd/6cmi3XtlFwxsKQzCpsR5J7N6ExcxGnDT9fZKRDSwl4z4U0LA 07NRXmEyMJebJukdYEfUtIn7E6tvJLMFca8m1KX7Brus79BIZiyKGkr9gjQh6zD+mXJf +q0CcgsSUDTmdmxCmlxf6az6wdoh+RzueSf5lBwqec4Vqn5MFGvt1lN5Bgz08nPnRs62 dsG4giLeZD/zGLZjMy9H8jXqM7QM8IdpCVJoA0/DduZgHnGUQY/gbY4F5O4LD5in5rKL NotA== X-Received: by 10.236.37.231 with SMTP id y67mr1194347yha.146.1403614725828; Tue, 24 Jun 2014 05:58:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.95.9 with HTTP; Tue, 24 Jun 2014 05:58:05 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 24 Jun 2014 14:58:05 +0200 Message-ID: Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents To: Stefan Monnier Content-Type: multipart/alternative; boundary=20cf303a2bb12277ae04fc9485ba X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17549 Cc: 17549@debbugs.gnu.org, Leo Liu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --20cf303a2bb12277ae04fc9485ba Content-Type: text/plain; charset=UTF-8 AFAIK, we are not yet ready to release emacs-24, so it'd be better to find a fix than revert. --20cf303a2bb12277ae04fc9485ba Content-Type: text/html; charset=UTF-8
AFAIK, we are not yet ready to release emacs-24, so it'd be better to find a fix than revert.

--20cf303a2bb12277ae04fc9485ba-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 24 09:38:27 2014 Received: (at 17549) by debbugs.gnu.org; 24 Jun 2014 13:38:27 +0000 Received: from localhost ([127.0.0.1]:59092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzQvW-0000N5-9K for submit@debbugs.gnu.org; Tue, 24 Jun 2014 09:38:26 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:39589) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzQvP-0000Mf-Bv for 17549@debbugs.gnu.org; Tue, 24 Jun 2014 09:38:20 -0400 Received: by mail-pd0-f179.google.com with SMTP id w10so261954pde.38 for <17549@debbugs.gnu.org>; Tue, 24 Jun 2014 06:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=8ieqV+ypw58NA/iNQOnR881DoGsiCRKILZrgd4OJT0U=; b=LqRiuMnkEIPNOXFsauOEUXBTmuzrn06goRQuX8xbFwCfvYGCk3OxOlREpBRcMIu9aN Vj76AqHrQQlJhlbzBU4QPKjFKhTT39KaX+Xbyun4a+AWfmbR3CTqCEHLsua93yUSDrut 2qSfYpiJ61AN28d4qpd9qhZE8ppL+03qC/2RNTcYoIzvkXTZyhmBEpDe2SBKNYjmb3rU UUf892lI9jVw9nzoyQBhiXORjUa9+q2RVKJssUDk7dYVldE840CxfX+LOtm7WA+Cemwn zKLpP9Cz95hu4sUOZ9jYqXUUEs0g30a5VEa+k3NBHFaHOZHPaiFUP81eyyc8NvMlm2j5 tZ3A== X-Received: by 10.68.137.193 with SMTP id qk1mr1359678pbb.155.1403617088982; Tue, 24 Jun 2014 06:38:08 -0700 (PDT) Received: from fortuna ([221.222.158.228]) by mx.google.com with ESMTPSA id i10sm1518430pat.36.2014.06.24.06.38.06 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Tue, 24 Jun 2014 06:38:08 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= Date: Tue, 24 Jun 2014 21:38:04 +0800 In-Reply-To: (Stefan Monnier's message of "Tue, 24 Jun 2014 08:49:50 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17549 Cc: Juanma Barranquero , 17549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 2014-06-24 08:49 -0400, Stefan Monnier wrote: > Does this affect emacs-24 as well? If so, for emacs-24, it's OK, but > for trunk we want something better. > > > Stefan Yes, this is a bug in emacs-24 as well. On 2014-06-24 14:58 +0200, Juanma Barranquero wrote: > AFAIK, we are not yet ready to release emacs-24, so it'd be better to find > a fix than revert. I am not against a thorough solution but I think leaving this broken for months can be problematic. Secondly that code moved from package.el might be a quick dirty hack anyway, a quick look at url-http seems to suggest it is repeating some work already done by url-retrieve-synchronously. Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 24 10:02:34 2014 Received: (at 17549) by debbugs.gnu.org; 24 Jun 2014 14:02:34 +0000 Received: from localhost ([127.0.0.1]:59411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzRIr-00017s-4Q for submit@debbugs.gnu.org; Tue, 24 Jun 2014 10:02:34 -0400 Received: from mail-yh0-f50.google.com ([209.85.213.50]:32974) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzRIk-00017W-7c for 17549@debbugs.gnu.org; Tue, 24 Jun 2014 10:02:27 -0400 Received: by mail-yh0-f50.google.com with SMTP id t59so203036yho.9 for <17549@debbugs.gnu.org>; Tue, 24 Jun 2014 07:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=nFMMh5p+CuqSerWAN1TA/f+6f6MzXy7zm9mJOQP3cA8=; b=SLrmfDzHgYPgEHUBcJ3/rSsFytrAIUl5LtLGaj6w7wAYKADi98ZkIdGL5+D9r+W/Eo HmqTQco1iH0VGQ1fOUruC1S3oQNpQh6hZQRMqYI8vw2/2bAoaxxDt83/iO2jwxphYlwF WvNMU50tVIWUC6KvFq+vVaitv5KJPCRmZtgUjMUa9a35EIQj04nnHG/BL7kDDyE1kn1A c7iwDTI3J/eTqCILxoeDFfXxIT5aHsIFG4Kj8R0GydCXAJPIMXzVb0DdDRm5pPSedBGF Tf6ktFQxnIA4o6rrily2oMr1pTuXGEr/bnCNjtNp/JkypA+CBeXwB2DD9vhvZ276E+Kz i+dA== X-Received: by 10.236.220.34 with SMTP id n32mr1849146yhp.88.1403618536509; Tue, 24 Jun 2014 07:02:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.95.9 with HTTP; Tue, 24 Jun 2014 07:01:35 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 24 Jun 2014 16:01:35 +0200 Message-ID: Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents To: Leo Liu Content-Type: multipart/alternative; boundary=001a11c229da44d9a404fc9568cb X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17549 Cc: 17549@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c229da44d9a404fc9568cb Content-Type: text/plain; charset=UTF-8 On Tue, Jun 24, 2014 at 3:38 PM, Leo Liu wrote: > I am not against a thorough solution but I think leaving this broken for > months can be problematic. Sorry. I keep trying to find time to fix this and a few other bugs, but I'm very busy right now. > Secondly that code moved from package.el > might be a quick dirty hack anyway, a quick look at url-http seems to > suggest it is repeating some work already done by > url-retrieve-synchronously. AFAIR, originally I wanted a small change, just throw an error in a specific case, and Stefan pushed for a bigger (though, I suppose, cleaner) fix; there was some back-and-forth and we finally settled on what's installed. So perhaps you can go back, reread the bug thread and find something in the proposed solutions that fixes the original problem and does not cause the one you're reporting. J --001a11c229da44d9a404fc9568cb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Jun 24, 2014 at 3:38 PM, Leo Liu <sdl.web@gmail.com> wrote:

> I= am not against a thorough solution but I think leaving this broken for
= > months can be problematic.

Sorry. I keep trying to find time to fix this and a few= other bugs, but I'm very busy right now.

>= Secondly that code moved from package.el
> might be a quick dirty ha= ck anyway, a quick look at url-http seems to
> suggest it is repeating some work already done by
> url-retrieve= -synchronously.

AFAIR, originally I wanted a small= change, just throw an error in a specific case, and Stefan pushed for a bi= gger (though, I suppose, cleaner) fix; there was some back-and-forth and we= finally settled on what's installed. So perhaps you can go back, rerea= d the bug thread and find something in the proposed solutions that fixes th= e original problem and does not cause the one you're reporting.

=C2=A0 =C2=A0 J
--001a11c229da44d9a404fc9568cb-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 24 20:59:04 2014 Received: (at 17549) by debbugs.gnu.org; 25 Jun 2014 00:59:04 +0000 Received: from localhost ([127.0.0.1]:59781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzbYE-0003v9-Vq for submit@debbugs.gnu.org; Tue, 24 Jun 2014 20:59:03 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:43558) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzbYC-0003ub-17 for 17549@debbugs.gnu.org; Tue, 24 Jun 2014 20:59:01 -0400 Received: by mail-pd0-f177.google.com with SMTP id y10so920270pdj.22 for <17549@debbugs.gnu.org>; Tue, 24 Jun 2014 17:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=sBlTP+rvehrPzpG0w3PHUbIg1hoVgRPFQdq4Qsoh+ys=; b=YkGQogdMsj1P+l7elIc+mjQV/+beHiQBgUXukFdS2946u0cYtwafmzRTen7Hed9VYm nCzINr37jmxEvhXnnBBsFGdzwHbD6cvipAjoyTm7897gapWiQDH7Gl0cfVHECErfOubd HneQ2JVL7BaHz6GlvYeb82Dm52iac14i0hwuzaJ6HX/Xg5YUQwD3G3TekvAx9I5frdTJ V6CshJ+DCx+dP/Yhmgim+WBf8FDm4TmGryiv6wqO7rNNqc8jo/kbvSbjYobuRCQfvy0G 1lMnb8NfaBNzebPFqLU7uo3CFsW4sPPLWLWqaQZM+AngVPrvWaGOULcmnO4YoKCna2hL D8NQ== X-Received: by 10.66.148.70 with SMTP id tq6mr6615203pab.56.1403657933941; Tue, 24 Jun 2014 17:58:53 -0700 (PDT) Received: from fortuna ([221.222.158.228]) by mx.google.com with ESMTPSA id z3sm9073782pas.15.2014.06.24.17.58.51 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Tue, 24 Jun 2014 17:58:53 -0700 (PDT) From: Leo Liu To: Juanma Barranquero Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Wed, 25 Jun 2014 08:58:49 +0800 In-Reply-To: (Juanma Barranquero's message of "Tue, 24 Jun 2014 16:01:35 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17549 Cc: 17549@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 2014-06-24 16:01 +0200, Juanma Barranquero wrote: > Sorry. I keep trying to find time to fix this and a few other bugs, but I'm > very busy right now. No worries ;) > AFAIR, originally I wanted a small change, just throw an error in a > specific case, and Stefan pushed for a bigger (though, I suppose, cleaner) > fix; there was some back-and-forth and we finally settled on what's > installed. So perhaps you can go back, reread the bug thread and find > something in the proposed solutions that fixes the original problem and > does not cause the one you're reporting. OK, I read that thread quickly and now understood the decision. I propose the following solution for now. The patch introduces a compiler warning on url-http-codes. How best to suppress it? === modified file 'lisp/url/url-handlers.el' --- lisp/url/url-handlers.el 2014-05-12 06:59:30 +0000 +++ lisp/url/url-handlers.el 2014-06-25 00:41:33 +0000 @@ -33,7 +33,6 @@ (autoload 'url-expand-file-name "url-expand" "Convert url to a fully specified url, and canonicalize it.") (autoload 'mm-dissect-buffer "mm-decode" "Dissect the current buffer and return a list of MIME handles.") (autoload 'url-scheme-get-property "url-methods" "Get property of a URL SCHEME.") -(autoload 'url-http-parse-response "url-http" "Parse just the response code.") ;; Always used after mm-dissect-buffer and defined in the same file. (declare-function mm-save-part-to-file "mm-decode" (handle file)) @@ -313,12 +312,12 @@ (let ((buffer (url-retrieve-synchronously url))) (unless buffer (signal 'file-error (list url "No Data"))) (with-current-buffer buffer - (let ((response (url-http-parse-response))) - (if (and (>= response 200) (< response 300)) - (goto-char (point-min)) - (let ((desc (buffer-substring-no-properties (1+ (point)) - (line-end-position)))) + (when (bound-and-true-p url-http-response-status) + (unless (and (>= url-http-response-status 200) + (< url-http-response-status 300)) + (let ((desc (nth 2 (assq url-http-response-status url-http-codes)))) (kill-buffer buffer) + ;; Signal file-error per http://debbugs.gnu.org/16733. (signal 'file-error (list url desc)))))) (if visit (setq buffer-file-name url)) (save-excursion @@ -333,6 +332,7 @@ ;; usual heuristic/rules that we apply to files. (decode-coding-inserted-region start (point) url visit beg end replace)) (list url (car size-and-charset)))))) + (put 'insert-file-contents 'url-file-handlers 'url-insert-file-contents) (defun url-file-name-completion (url directory &optional predicate) === modified file 'lisp/url/url-http.el' --- lisp/url/url-http.el 2014-03-29 00:55:44 +0000 +++ lisp/url/url-http.el 2014-06-25 00:23:24 +0000 @@ -48,7 +48,6 @@ (defvar url-http-response-version) (defvar url-http-target-url) (defvar url-http-transfer-encoding) -(defvar url-http-end-of-headers) (defvar url-show-status) (require 'url-gw) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 25 20:20:04 2014 Received: (at 17549) by debbugs.gnu.org; 26 Jun 2014 00:20:04 +0000 Received: from localhost ([127.0.0.1]:60931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzxQ2-00065s-V7 for submit@debbugs.gnu.org; Wed, 25 Jun 2014 20:20:04 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:44888) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzxQ0-00065G-3n for 17549@debbugs.gnu.org; Wed, 25 Jun 2014 20:20:00 -0400 Received: by mail-pd0-f177.google.com with SMTP id y10so2258999pdj.8 for <17549@debbugs.gnu.org>; Wed, 25 Jun 2014 17:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=HLytOQ3+51/BJBBSwTknzK+J8kv4YZXGE6b6hygBkhw=; b=uD44o19t5iTBN4Q9BUITSlf2r4aorkf3wp5AD6NaLCizEoTEIpxuKNZhN+xIH5pAgD o4tXUMp85NRz3C/xykTX84DYHVqzLHWKpMks1xrkzmCgFCmoJFLahhOG+ZAcyaoAgaib R+iIxQ1MRhhqQ6EE1lp/5271Xl1SchTtN5sJwkhNVu1/iYq7rtfccjnXPDqFdoCwtE2N B4lRMvwGFKzc6fKIdSzSPAzPpp5oSQU8hZtPHaG/9ksJfBzNblr2jNthC6rtO1GBDnFt dKOHtpjhM97gMtDYbyhA0RneZwRQA1EsLEQ4zkkf/W25v1t8ySARc63wI/cqbh2Bfh04 mgAg== X-Received: by 10.69.3.196 with SMTP id by4mr9687195pbd.63.1403741993733; Wed, 25 Jun 2014 17:19:53 -0700 (PDT) Received: from fortuna ([221.222.155.37]) by mx.google.com with ESMTPSA id is5sm7064585pbb.8.2014.06.25.17.19.51 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Wed, 25 Jun 2014 17:19:53 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents References: Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= Date: Thu, 26 Jun 2014 08:19:49 +0800 In-Reply-To: (Leo Liu's message of "Wed, 25 Jun 2014 08:58:49 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17549 Cc: 17549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 2014-06-25 08:58 +0800, Leo Liu wrote: > The patch introduces a compiler warning on url-http-codes. How best to > suppress it? I'd be very happy if this bug can be fixed for the next release. Any comments on the proposed patch? Thanks, Leo === modified file 'lisp/url/url-handlers.el' --- lisp/url/url-handlers.el 2014-05-12 06:59:30 +0000 +++ lisp/url/url-handlers.el 2014-06-26 00:18:44 +0000 @@ -33,7 +33,6 @@ (autoload 'url-expand-file-name "url-expand" "Convert url to a fully specified url, and canonicalize it.") (autoload 'mm-dissect-buffer "mm-decode" "Dissect the current buffer and return a list of MIME handles.") (autoload 'url-scheme-get-property "url-methods" "Get property of a URL SCHEME.") -(autoload 'url-http-parse-response "url-http" "Parse just the response code.") ;; Always used after mm-dissect-buffer and defined in the same file. (declare-function mm-save-part-to-file "mm-decode" (handle file)) @@ -308,17 +307,19 @@ (insert data)) (list (length data) charset))) +(defconst url-http-codes) + ;;;###autoload (defun url-insert-file-contents (url &optional visit beg end replace) (let ((buffer (url-retrieve-synchronously url))) (unless buffer (signal 'file-error (list url "No Data"))) (with-current-buffer buffer - (let ((response (url-http-parse-response))) - (if (and (>= response 200) (< response 300)) - (goto-char (point-min)) - (let ((desc (buffer-substring-no-properties (1+ (point)) - (line-end-position)))) + (when (bound-and-true-p url-http-response-status) + (unless (and (>= url-http-response-status 200) + (< url-http-response-status 300)) + (let ((desc (nth 2 (assq url-http-response-status url-http-codes)))) (kill-buffer buffer) + ;; Signal file-error per http://debbugs.gnu.org/16733. (signal 'file-error (list url desc)))))) (if visit (setq buffer-file-name url)) (save-excursion @@ -333,6 +334,7 @@ ;; usual heuristic/rules that we apply to files. (decode-coding-inserted-region start (point) url visit beg end replace)) (list url (car size-and-charset)))))) + (put 'insert-file-contents 'url-file-handlers 'url-insert-file-contents) (defun url-file-name-completion (url directory &optional predicate) === modified file 'lisp/url/url-http.el' --- lisp/url/url-http.el 2014-03-29 00:55:44 +0000 +++ lisp/url/url-http.el 2014-06-25 00:23:24 +0000 @@ -48,7 +48,6 @@ (defvar url-http-response-version) (defvar url-http-target-url) (defvar url-http-transfer-encoding) -(defvar url-http-end-of-headers) (defvar url-show-status) (require 'url-gw) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 25 22:38:47 2014 Received: (at 17549) by debbugs.gnu.org; 26 Jun 2014 02:38:47 +0000 Received: from localhost ([127.0.0.1]:60976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzzaJ-0003dU-3h for submit@debbugs.gnu.org; Wed, 25 Jun 2014 22:38:47 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:45489) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WzzaF-0003d7-Qg for 17549@debbugs.gnu.org; Wed, 25 Jun 2014 22:38:44 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArcGAIDvNVNLd+D9/2dsb2JhbABZgwY7gw+9L4MOgRcXdIImAQEEViMQCw4mEhQYDSSIDNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArcGAIDvNVNLd+D9/2dsb2JhbABZgwY7gw+9L4MOgRcXdIImAQEEViMQCw4mEhQYDSSIDNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="69587935" Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Jun 2014 22:38:37 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 92B5266302; Wed, 25 Jun 2014 22:38:37 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents Message-ID: References: Date: Wed, 25 Jun 2014 22:38:37 -0400 In-Reply-To: (Leo Liu's message of "Thu, 26 Jun 2014 08:19:49 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 17549 Cc: 17549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > +(defconst url-http-codes) This should use `defvar'. > - (let ((response (url-http-parse-response))) > - (if (and (>= response 200) (< response 300)) > - (goto-char (point-min)) > - (let ((desc (buffer-substring-no-properties (1+ (point)) > - (line-end-position)))) > + (when (bound-and-true-p url-http-response-status) > + (unless (and (>= url-http-response-status 200) > + (< url-http-response-status 300)) > + (let ((desc (nth 2 (assq url-http-response-status url-http-codes)))) IIUC the above just adds a "(when (bound-and-true-p url-http-response-status)" wrapper around the existing code, right? If so, it looks like a safe enough fix to install it in emacs-24. This still doesn't look like The Right Way to do things in URL. I think The Right Way would be for the url-http code to set some backend-agnostic properties which url-handlers.el can then use. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 26 00:03:33 2014 Received: (at 17549) by debbugs.gnu.org; 26 Jun 2014 04:03:33 +0000 Received: from localhost ([127.0.0.1]:32779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X00uL-0006Za-9N for submit@debbugs.gnu.org; Thu, 26 Jun 2014 00:03:33 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:39271) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X00uH-0006ZD-BA for 17549@debbugs.gnu.org; Thu, 26 Jun 2014 00:03:30 -0400 Received: by mail-pd0-f177.google.com with SMTP id y10so2466706pdj.8 for <17549@debbugs.gnu.org>; Wed, 25 Jun 2014 21:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=jLFIcprmKURWcmyqrMSvDUVjDan41LHp92xDDdFW3lk=; b=nzsw1HhOULuw5XsfaifTaVxdDRvgVLoYjlGL7dslfKcDQesh0wL5Edl4ztR+V8mQ6J nQ+2KK/LHSSA78GllvdAllxe+M31mDLt97q+kr2jJzlCW8x9NG4L8wNY70B/9LEdi8LP x1D7xwNlp8mutBvgkDZdHM8ekcVak+mWLuHAxOi1ldx7QY3SdOiHzEHi2eo6scURbvwG MTrqyIdS8qdmiUXCgaA5qUtcNSTClkEpAAEZBjtAeeA9vgc/K3a3jzObuYztepN0J+dS EuAi5S2rs/ZSXdZjoZkpw84qlMHSNUxDRMwefid5cZo4J4rac+ghvn6BPCMP573GhrDw c92A== X-Received: by 10.68.164.100 with SMTP id yp4mr17416344pbb.136.1403755403300; Wed, 25 Jun 2014 21:03:23 -0700 (PDT) Received: from fortuna ([221.222.155.37]) by mx.google.com with ESMTPSA id yv7sm27829029pac.33.2014.06.25.21.03.21 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Wed, 25 Jun 2014 21:03:22 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#17549: 24.4.50; regression: url-insert-file-contents References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= Date: Thu, 26 Jun 2014 12:03:19 +0800 In-Reply-To: (Stefan Monnier's message of "Wed, 25 Jun 2014 22:38:37 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17549 Cc: 17549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Fixed in 24.4 On 2014-06-25 22:38 -0400, Stefan Monnier wrote: > IIUC the above just adds a "(when (bound-and-true-p > url-http-response-status)" wrapper around the existing code, right? > If so, it looks like a safe enough fix to install it in emacs-24. Yes, it should be safe enough. So bound-and-true-p make sure it is http/s. Secondly we don't re-do url-http-parse-response and rely on its point end at before the status-text. > This still doesn't look like The Right Way to do things in URL. > I think The Right Way would be for the url-http code to set some > backend-agnostic properties which url-handlers.el can then use. I agree. This bit of code is http specific and should be in the backend instead. I'll add a note for now. BTW, it might not be easy to invent similar semantics for other protocols though. Thanks, Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 26 20:54:32 2014 Received: (at control) by debbugs.gnu.org; 27 Jun 2014 00:54:32 +0000 Received: from localhost ([127.0.0.1]:34131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X0KQy-0002i0-5u for submit@debbugs.gnu.org; Thu, 26 Jun 2014 20:54:32 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:36688 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X0KQw-0002hr-CY for control@debbugs.gnu.org; Thu, 26 Jun 2014 20:54:31 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1X0KQv-0006j7-Sh for control@debbugs.gnu.org; Thu, 26 Jun 2014 20:54:29 -0400 Date: Thu, 26 Jun 2014 20:54:29 -0400 Message-Id: Subject: control message for bug 17549 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 17549 24.3.92 From unknown Mon Jun 23 09:37:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Jul 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator