GNU bug report logs - #17544
24.3; [PATCH] Improved diff-mode navigation/manipulation

Previous Next

Full log

Message #41 received at 17544 <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: npostavs <at> users.sourceforge.net
Cc: Eli Zaretskii <eliz <at> gnu.org>, Andreas Schwab <schwab <at> linux-m68k.org>,
 17544 <at> debbugs.gnu.org
Subject: Re: bug#17544: 24.3;
 [PATCH] Improved diff-mode navigation/manipulation
Date: Sat, 22 Oct 2016 18:44:15 -0700

npostavs <at> users.sourceforge.net writes:

> Dima Kogan <dima <at> secretsauce.net> writes:
>
>> Here's yet another revised patch. The (call-interactively) at the end of
>> (diff-apply-hunk) was important, it turns out. This would force it to
>> use the new logic to move to the next hunk, instead of the legacy logic.
>> I purposely left the behavior of (diff-next-hunk) unchanged from before
>> when running non-interactively, and here I explicitly want the new
>> behavior.
>
> If both behaviours are needed, it would be much better if lisp code
> could choose between them without having to use call-interactively,
> that's quite an awkward interface.

Hi. I'm open to suggestions. The goal was to retain the previous logic
for any existing code, but to provide improved user-facing behavior.
Given this, it doesn't seem to me to be too awkward to pass-on the
"interactive-p" state to child functions. Am I wrong to want to preserve
existing behavior for elisp code? If so, then the entire old path can
simply go away unconditionally.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.