GNU bug report logs - #17544
24.3; [PATCH] Improved diff-mode navigation/manipulation

Previous Next

Package: emacs;

Reported by: Dima Kogan <lists <at> dima.secretsauce.net>

Date: Wed, 21 May 2014 15:00:05 UTC

Severity: normal

Tags: patch

Found in version 24.3

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Dima Kogan <dima <at> secretsauce.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Andreas Schwab <schwab <at> linux-m68k.org>, 17544 <at> debbugs.gnu.org
Subject: bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation
Date: Sat, 22 Oct 2016 11:47:29 -0400

Dima Kogan <dima <at> secretsauce.net> writes:

> Here's yet another revised patch. The (call-interactively) at the end of
> (diff-apply-hunk) was important, it turns out. This would force it to
> use the new logic to move to the next hunk, instead of the legacy logic.
> I purposely left the behavior of (diff-next-hunk) unchanged from before
> when running non-interactively, and here I explicitly want the new
> behavior.

If both behaviours are needed, it would be much better if lisp code
could choose between them without having to use call-interactively,
that's quite an awkward interface.
This bug report was last modified 8 years and 180 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.