GNU bug report logs - #17544
24.3; [PATCH] Improved diff-mode navigation/manipulation

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: larsi <at> gnus.org, 17544 <at> debbugs.gnu.org
Subject: bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation
Date: Sat, 03 Sep 2016 13:14:24 +0300

> From: Dima Kogan <dima <at> secretsauce.net>
> Date: Sat, 03 Sep 2016 02:17:19 -0700
> Cc: 17544 <at> debbugs.gnu.org
> 
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> 
> > I think this makes sense, and the patch looks good to me. Does it
> > still apply to the Emacs trunk? Anybody got any objections to
> > installing it?
> >
> > It should also have an entry in NEWS, I think.
> 
> This is a gentle ping. Can we install this?

I'd like to hear Stefan's comments.

Regardless, the doc string of diff--wrap-hunk-navigation is not
according to our coding style, so please fix it.  Also, I don't quite
understand why you need changes like this one:

  -	(diff-hunk-next))))))
  +	(call-interactively 'diff-hunk-next))))))

and the whole issue of testing called-interactively-p that goes with
it.  Can you explain?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.