GNU bug report logs - #17519
[PATCH] take into account QuantumScale when reading imagemagick images

Previous Next

Package: emacs;

Reported by: Nicolas Léveillé <nicolas <at> uucidl.com>

Date: Sat, 17 May 2014 18:05:02 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Nicolas Léveillé <nicolas <at> uucidl.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17519 <at> debbugs.gnu.org
Subject: bug#17519: [PATCH] take into account QuantumScale when reading imagemagick images
Date: Tue, 20 May 2014 09:37:17 +0200

I'll come back to you once I'll have tested your patch.

Do you object with the other cleanups or is it poor form in this project to clean up code while fixing a bug? (Not sure what the philosophy in this project is, I tend to alway opportunistically do a little clean up (in separate commits/patches) when I fix bugs as a form of low intensity maintenance work)

Cheers,
Nicolas

On 2014-05-19, at 22:04 , Paul Eggert <eggert <at> cs.ucla.edu> wrote:

> Thanks for reporting this. Does the attached simpler patch fix the problem for you?  Dividing by QuantumRange instead of multiplying by QuantumScale avoids potential double-rounding problems in future versions of ImageMagick.
> <imagemagick.patch>
This bug report was last modified 11 years and 55 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.