GNU bug report logs - #17516
[PATCH] grep: no count newline at the head of a text buffer

Previous Next

Full log

Message #25 received at 17516 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Eric Blake <eblake <at> redhat.com>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, Norihiro Tanaka <noritnk <at> kcn.ne.jp>,
 17516 <17516 <at> debbugs.gnu.org>
Subject: Re: bug#17516: [PATCH] grep: no count newline at the head of a text
 buffer
Date: Wed, 21 May 2014 21:55:30 -0700

On Wed, May 21, 2014 at 9:52 PM, Eric Blake <eblake <at> redhat.com> wrote:
> On 05/21/2014 10:34 PM, Jim Meyering wrote:
>> On Sat, May 17, 2014 at 3:59 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>>> Thanks for the review and push.
>>>
>>> I also submit a test case for this bug.  It fails in grep-2.18.146-ebf3,
>>> and succeeds in current master.
>>
>> Thanks again.
>> However, that new test made it so "make syntax-check" would fail.
>> I've suppressed that new failure via the attached:
>
> It's also possible to rewrite the line:
>
> grep -f in 'in' >out || fail=1
>
> so as to avoid needing the suppression (I'm not sure which is prettier).

Thanks for the suggestion.
Since this is a false-positive after all, I prefer to keep the
work-around out of the primary source file, even if that
means exempting this entire file from that one syntax-check.
It is unlikely to matter.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.