GNU bug report logs - #17516
[PATCH] grep: no count newline at the head of a text buffer

Previous Next

Full log

Message #22 received at 17516 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Jim Meyering <jim <at> meyering.net>, Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, 17516 <at> debbugs.gnu.org
Subject: Re: bug#17516: [PATCH] grep: no count newline at the head of a text
 buffer
Date: Wed, 21 May 2014 22:52:30 -0600

[Message part 1 (text/plain, inline)]

On 05/21/2014 10:34 PM, Jim Meyering wrote:
> On Sat, May 17, 2014 at 3:59 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> Thanks for the review and push.
>>
>> I also submit a test case for this bug.  It fails in grep-2.18.146-ebf3,
>> and succeeds in current master.
> 
> Thanks again.
> However, that new test made it so "make syntax-check" would fail.
> I've suppressed that new failure via the attached:

It's also possible to rewrite the line:

grep -f in 'in' >out || fail=1

so as to avoid needing the suppression (I'm not sure which is prettier).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.