From unknown Fri Jun 20 20:10:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17516: [PATCH] grep: no count newline at the head of a text buffer Resent-From: Norihiro Tanaka Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Sat, 17 May 2014 01:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17516 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: 17516@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140029025028034 (code B ref -1); Sat, 17 May 2014 01:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 May 2014 01:30:50 +0000 Received: from localhost ([127.0.0.1]:50985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlTSb-0007I6-Cj for submit@debbugs.gnu.org; Fri, 16 May 2014 21:30:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56511) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlTSY-0007Ho-BI for submit@debbugs.gnu.org; Fri, 16 May 2014 21:30:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlTSL-0007QX-GI for submit@debbugs.gnu.org; Fri, 16 May 2014 21:30:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlTSL-0007QS-6q for submit@debbugs.gnu.org; Fri, 16 May 2014 21:30:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlTSD-0004Tu-VT for bug-grep@gnu.org; Fri, 16 May 2014 21:30:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlTS7-0007NE-2C for bug-grep@gnu.org; Fri, 16 May 2014 21:30:25 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:40049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlTS6-0007MB-Jh for bug-grep@gnu.org; Fri, 16 May 2014 21:30:18 -0400 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 14B57E8001F for ; Sat, 17 May 2014 10:20:53 +0900 (JST) Received: from mail02.kcn.ne.jp ([61.86.6.181]) by imp02 with bizsmtp id 2pLt1o0033uLcVp01pLtlF; Sat, 17 May 2014 10:20:53 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.33] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail02.kcn.ne.jp (Postfix) with ESMTPA id E8FBBF10092 for ; Sat, 17 May 2014 10:20:52 +0900 (JST) Date: Sat, 17 May 2014 10:20:51 +0900 From: Norihiro Tanaka Message-Id: <20140517102051.673A.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5368DFB600000000288A_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_5368DFB600000000288A_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Severity: critical When cleared caches of transition tables, number of newline is counted incorrectly, As a result, grep may crash. I confirmed crash of grep with a text case in bug#15191 http://dobrokot.ru/dump/slow_dfa_merge.2013-08-26.tar.gz $ env LC_ALL=C time -p src/egrep -f regex.re input_lines.txt When `p' is beginning, p[-1] is out of the buffer. Therefore, we shouldn't count it. Norihiro --------_5368DFB600000000288A_MULTIPART_MIXED_ Content-Type: application/octet-stream; name="0001-grep-no-count-newline-at-the-head-of-a-text-buffer.patch" Content-Disposition: attachment; filename="0001-grep-no-count-newline-at-the-head-of-a-text-buffer.patch" Content-Transfer-Encoding: base64 RnJvbSBlODg2ZWY0MTdmYTQ2MzcyOTg4MmQ1YjI3MTljNGFlYzYzNGZjZjY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTYXQsIDE3IE1heSAyMDE0IDA5OjQwOjM4ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogbm8gY291bnQgbmV3bGluZSBhdCB0aGUgaGVhZCBvZiBhIHRleHQgYnVmZmVyCgoqIHNyYy9k ZmEuYyAoYnVpbGRfc3RhdGUpOiBEbyBpdC4KLS0tCiBzcmMvZGZhLmMgfCAyICstCiAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMv ZGZhLmMgYi9zcmMvZGZhLmMKaW5kZXggM2M5Y2I3NS4uOGZmMjlkMCAxMDA2NDQKLS0tIGEvc3Jj L2RmYS5jCisrKyBiL3NyYy9kZmEuYwpAQCAtMzM5Niw3ICszMzk2LDcgQEAgZGZhZXhlYyAoc3Ry dWN0IGRmYSAqZCwgY2hhciBjb25zdCAqYmVnaW4sIGNoYXIgKmVuZCwKIAogICAgICAgLyogSWYg dGhlIHByZXZpb3VzIGNoYXJhY3RlciB3YXMgYSBuZXdsaW5lLCBjb3VudCBpdCwgYW5kIHNraXAK ICAgICAgICAgIGNoZWNraW5nIG9mIG11bHRpYnl0ZSBjaGFyYWN0ZXIgYm91bmRhcnkgdW50aWwg aGVyZS4gICovCi0gICAgICBpZiAocFstMV0gPT0gZW9sKQorICAgICAgaWYgKHBbLTFdID09IGVv bCAmJiAoY2hhciAqKSBwICE9IGJlZ2luKQogICAgICAgICB7CiAgICAgICAgICAgbmxjb3VudCsr OwogICAgICAgICAgIG1icCA9IHA7Ci0tIAoxLjkuMwoK --------_5368DFB600000000288A_MULTIPART_MIXED_-- From unknown Fri Jun 20 20:10:13 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Norihiro Tanaka Subject: bug#17516: closed (Re: bug#17516: [PATCH] grep: no count newline at the head of a text buffer) Message-ID: References: <5376EED9.9060509@cs.ucla.edu> <20140517102051.673A.27F6AC2D@kcn.ne.jp> X-Gnu-PR-Message: they-closed 17516 X-Gnu-PR-Package: grep X-Gnu-PR-Keywords: patch Reply-To: 17516@debbugs.gnu.org Date: Sat, 17 May 2014 05:09:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1400303343-23753-1" This is a multi-part message in MIME format... ------------=_1400303343-23753-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17516: [PATCH] grep: no count newline at the head of a text buffer which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17516@debbugs.gnu.org. --=20 17516: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17516 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1400303343-23753-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17516-done) by debbugs.gnu.org; 17 May 2014 05:09:01 +0000 Received: from localhost ([127.0.0.1]:51072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlWrk-0006Aq-30 for submit@debbugs.gnu.org; Sat, 17 May 2014 01:09:00 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:33925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlWrf-0006AP-Tg for 17516-done@debbugs.gnu.org; Sat, 17 May 2014 01:08:56 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id E2DEBA60096; Fri, 16 May 2014 22:08:49 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AAx866-4VZJu; Fri, 16 May 2014 22:08:41 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 5CA2FA60001; Fri, 16 May 2014 22:08:41 -0700 (PDT) Message-ID: <5376EED9.9060509@cs.ucla.edu> Date: Fri, 16 May 2014 22:08:41 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Norihiro Tanaka , 17516-done@debbugs.gnu.org Subject: Re: bug#17516: [PATCH] grep: no count newline at the head of a text buffer References: <20140517102051.673A.27F6AC2D@kcn.ne.jp> In-Reply-To: <20140517102051.673A.27F6AC2D@kcn.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17516-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Thanks for catching that; I installed the patch with a slightly reworded ChangeLog entry. ------------=_1400303343-23753-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 May 2014 01:30:50 +0000 Received: from localhost ([127.0.0.1]:50985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlTSb-0007I6-Cj for submit@debbugs.gnu.org; Fri, 16 May 2014 21:30:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56511) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlTSY-0007Ho-BI for submit@debbugs.gnu.org; Fri, 16 May 2014 21:30:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlTSL-0007QX-GI for submit@debbugs.gnu.org; Fri, 16 May 2014 21:30:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlTSL-0007QS-6q for submit@debbugs.gnu.org; Fri, 16 May 2014 21:30:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlTSD-0004Tu-VT for bug-grep@gnu.org; Fri, 16 May 2014 21:30:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlTS7-0007NE-2C for bug-grep@gnu.org; Fri, 16 May 2014 21:30:25 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:40049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlTS6-0007MB-Jh for bug-grep@gnu.org; Fri, 16 May 2014 21:30:18 -0400 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 14B57E8001F for ; Sat, 17 May 2014 10:20:53 +0900 (JST) Received: from mail02.kcn.ne.jp ([61.86.6.181]) by imp02 with bizsmtp id 2pLt1o0033uLcVp01pLtlF; Sat, 17 May 2014 10:20:53 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.33] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail02.kcn.ne.jp (Postfix) with ESMTPA id E8FBBF10092 for ; Sat, 17 May 2014 10:20:52 +0900 (JST) Date: Sat, 17 May 2014 10:20:51 +0900 From: Norihiro Tanaka To: bug-grep@gnu.org Subject: [PATCH] grep: no count newline at the head of a text buffer Message-Id: <20140517102051.673A.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5368DFB600000000288A_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_5368DFB600000000288A_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Severity: critical When cleared caches of transition tables, number of newline is counted incorrectly, As a result, grep may crash. I confirmed crash of grep with a text case in bug#15191 http://dobrokot.ru/dump/slow_dfa_merge.2013-08-26.tar.gz $ env LC_ALL=C time -p src/egrep -f regex.re input_lines.txt When `p' is beginning, p[-1] is out of the buffer. Therefore, we shouldn't count it. Norihiro --------_5368DFB600000000288A_MULTIPART_MIXED_ Content-Type: application/octet-stream; name="0001-grep-no-count-newline-at-the-head-of-a-text-buffer.patch" Content-Disposition: attachment; filename="0001-grep-no-count-newline-at-the-head-of-a-text-buffer.patch" Content-Transfer-Encoding: base64 RnJvbSBlODg2ZWY0MTdmYTQ2MzcyOTg4MmQ1YjI3MTljNGFlYzYzNGZjZjY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTYXQsIDE3IE1heSAyMDE0IDA5OjQwOjM4ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogbm8gY291bnQgbmV3bGluZSBhdCB0aGUgaGVhZCBvZiBhIHRleHQgYnVmZmVyCgoqIHNyYy9k ZmEuYyAoYnVpbGRfc3RhdGUpOiBEbyBpdC4KLS0tCiBzcmMvZGZhLmMgfCAyICstCiAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMv ZGZhLmMgYi9zcmMvZGZhLmMKaW5kZXggM2M5Y2I3NS4uOGZmMjlkMCAxMDA2NDQKLS0tIGEvc3Jj L2RmYS5jCisrKyBiL3NyYy9kZmEuYwpAQCAtMzM5Niw3ICszMzk2LDcgQEAgZGZhZXhlYyAoc3Ry dWN0IGRmYSAqZCwgY2hhciBjb25zdCAqYmVnaW4sIGNoYXIgKmVuZCwKIAogICAgICAgLyogSWYg dGhlIHByZXZpb3VzIGNoYXJhY3RlciB3YXMgYSBuZXdsaW5lLCBjb3VudCBpdCwgYW5kIHNraXAK ICAgICAgICAgIGNoZWNraW5nIG9mIG11bHRpYnl0ZSBjaGFyYWN0ZXIgYm91bmRhcnkgdW50aWwg aGVyZS4gICovCi0gICAgICBpZiAocFstMV0gPT0gZW9sKQorICAgICAgaWYgKHBbLTFdID09IGVv bCAmJiAoY2hhciAqKSBwICE9IGJlZ2luKQogICAgICAgICB7CiAgICAgICAgICAgbmxjb3VudCsr OwogICAgICAgICAgIG1icCA9IHA7Ci0tIAoxLjkuMwoK --------_5368DFB600000000288A_MULTIPART_MIXED_-- ------------=_1400303343-23753-1-- From unknown Fri Jun 20 20:10:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17516: [PATCH] grep: no count newline at the head of a text buffer Resent-From: Norihiro Tanaka Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Sat, 17 May 2014 23:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17516 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: 17516@debbugs.gnu.org Cc: Paul Eggert , jim@meyering.net Received: via spool by 17516-submit@debbugs.gnu.org id=B17516.140036756229768 (code B ref 17516); Sat, 17 May 2014 23:00:04 +0000 Received: (at 17516) by debbugs.gnu.org; 17 May 2014 22:59:22 +0000 Received: from localhost ([127.0.0.1]:51793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlnZZ-0007k3-FE for submit@debbugs.gnu.org; Sat, 17 May 2014 18:59:21 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:51300) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlnZV-0007jr-8d for 17516@debbugs.gnu.org; Sat, 17 May 2014 18:59:18 -0400 Received: from imp01 (mailgw5.kcn.ne.jp [61.86.15.231]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 93169138005 for <17516@debbugs.gnu.org>; Sun, 18 May 2014 07:59:13 +0900 (JST) Received: from mail08.kcn.ne.jp ([61.86.6.187]) by imp01 with bizsmtp id 3AzD1o00C426eXR01AzDqq; Sun, 18 May 2014 07:59:13 +0900 X-OrgRCPT: 17516@debbugs.gnu.org Received: from [10.120.1.43] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail08.kcn.ne.jp (Postfix) with ESMTPA id 5DDB312B8098; Sun, 18 May 2014 07:59:13 +0900 (JST) Date: Sun, 18 May 2014 07:59:12 +0900 From: Norihiro Tanaka In-Reply-To: <5376EED9.9060509@cs.ucla.edu> References: <20140517102051.673A.27F6AC2D@kcn.ne.jp> <5376EED9.9060509@cs.ucla.edu> Message-Id: <20140518075853.1FB8.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5377E80C000000001FB0_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --------_5377E80C000000001FB0_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Thanks for the review and push. I also submit a test case for this bug. It fails in grep-2.18.146-ebf3, and succeeds in current master. --------_5377E80C000000001FB0_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-tests-add-test-case-previous-fix-previous-change.patch" Content-Disposition: attachment; filename="0001-tests-add-test-case-previous-fix-previous-change.patch" Content-Transfer-Encoding: base64 RnJvbSA1MmQxY2YyYmU4NjJkNjZiZWI0ZjBkZTQyMGQ3NTBkNjIyNGU1MjVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTdW4sIDE4IE1heSAyMDE0IDA3OjQ1OjQwICswOTAwClN1YmplY3Q6IFtQQVRDSF0gdGVz dHM6IGFkZCB0ZXN0IGNhc2UgcHJldmlvdXMgZml4IHByZXZpb3VzIGNoYW5nZQoKKiB0ZXN0cy9j b3VudC1uZXdsaW5lOiBOZXcgdGVzdC4KKiB0ZXN0cy9NYWtlZmlsZS5hbSAoVEVTVFMpOiBBZGQg aXQuCi0tLQogdGVzdHMvTWFrZWZpbGUuYW0gICB8ICAxICsKIHRlc3RzL2NvdW50LW5ld2xpbmUg fCAyOCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI5IGlu c2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDc1NSB0ZXN0cy9jb3VudC1uZXdsaW5lCgpkaWZm IC0tZ2l0IGEvdGVzdHMvTWFrZWZpbGUuYW0gYi90ZXN0cy9NYWtlZmlsZS5hbQppbmRleCA2MjZi MjVhLi44MmE2ZDJkIDEwMDY0NAotLS0gYS90ZXN0cy9NYWtlZmlsZS5hbQorKysgYi90ZXN0cy9N YWtlZmlsZS5hbQpAQCAtNDksNiArNDksNyBAQCBURVNUUyA9CQkJCQkJXAogICBjaGFyLWNsYXNz LW11bHRpYnl0ZQkJCQlcCiAgIGNoYXItY2xhc3MtbXVsdGlieXRlMgkJCQlcCiAgIGNvbnRleHQt MAkJCQkJXAorICBjb3VudC1uZXdsaW5lCQkJCQlcCiAgIGRmYS1jb3ZlcmFnZQkJCQkJXAogICBk ZmEtaGVhcC1vdmVycnVuCQkJCVwKICAgZGZhZXhlYy1tdWx0aWJ5dGUJCQkJXApkaWZmIC0tZ2l0 IGEvdGVzdHMvY291bnQtbmV3bGluZSBiL3Rlc3RzL2NvdW50LW5ld2xpbmUKbmV3IGZpbGUgbW9k ZSAxMDA3NTUKaW5kZXggMDAwMDAwMC4uMjc4ZTc0ZgotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3Rz L2NvdW50LW5ld2xpbmUKQEAgLTAsMCArMSwyOCBAQAorIyEvYmluL3NoCisjIFRlc3QgdGhhdCBu ZXdsaW5lIGlzIGNvdW50ZWQgY29ycmVjdGx5IGV2ZW4gd2hlbiB0cmFuc2l0aW9uIHRhYmxlIGlz CisjIHJlYnVpbGQuCisKKyMgQ29weXJpZ2h0IDIwMTQgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u LCBJbmMuCisKKyMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU6IHlvdSBjYW4gcmVkaXN0 cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKyMgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdh cmUgRm91bmRhdGlvbiwgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3IKKyMgKGF0 IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKworIyBUaGlzIHByb2dyYW0gaXMgZGlz dHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyMgYnV0IFdJVEhP VVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyMg TUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2Vl IHRoZQorIyBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCisj IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1Ymxp YyBMaWNlbnNlCisjIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6 Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgorCisuICIke3NyY2Rpcj0ufS9pbml0LnNoIjsgcGF0 aF9wcmVwZW5kXyAuLi9zcmMKKworcHJpbnRmICclMTAyNGRcbmJcbicgMCA+aW4gfHwgZnJhbWV3 b3JrX2ZhaWx1cmVfCisKK2dyZXAgLWYgaW4gaW4gPm91dCB8fCBmYWlsPTEKKworY29tcGFyZSBp biBvdXQgfHwgZmFpbD0xCisKK0V4aXQgJGZhaWwKLS0gCjEuOS4zCgo= --------_5377E80C000000001FB0_MULTIPART_MIXED_-- From unknown Fri Jun 20 20:10:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17516: [PATCH] grep: no count newline at the head of a text buffer Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Sun, 18 May 2014 00:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17516 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: Norihiro Tanaka , 17516@debbugs.gnu.org Cc: jim@meyering.net Received: via spool by 17516-submit@debbugs.gnu.org id=B17516.14003730116269 (code B ref 17516); Sun, 18 May 2014 00:31:01 +0000 Received: (at 17516) by debbugs.gnu.org; 18 May 2014 00:30:11 +0000 Received: from localhost ([127.0.0.1]:51819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlozS-0001d3-F0 for submit@debbugs.gnu.org; Sat, 17 May 2014 20:30:10 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:38359) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlozP-0001bb-38 for 17516@debbugs.gnu.org; Sat, 17 May 2014 20:30:07 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 47D83A60008; Sat, 17 May 2014 17:30:01 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tzDXe1NAwqa6; Sat, 17 May 2014 17:29:52 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id B3F6C39E8019; Sat, 17 May 2014 17:29:52 -0700 (PDT) Message-ID: <5377FF00.4020908@cs.ucla.edu> Date: Sat, 17 May 2014 17:29:52 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <20140517102051.673A.27F6AC2D@kcn.ne.jp> <5376EED9.9060509@cs.ucla.edu> <20140518075853.1FB8.27F6AC2D@kcn.ne.jp> In-Reply-To: <20140518075853.1FB8.27F6AC2D@kcn.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Norihiro Tanaka wrote: > I also submit a test case for this bug. Thanks, I installed that. From unknown Fri Jun 20 20:10:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17516: [PATCH] grep: no count newline at the head of a text buffer Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Thu, 22 May 2014 04:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17516 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: Norihiro Tanaka Cc: Paul Eggert , 17516@debbugs.gnu.org Received: via spool by 17516-submit@debbugs.gnu.org id=B17516.14007332719946 (code B ref 17516); Thu, 22 May 2014 04:35:02 +0000 Received: (at 17516) by debbugs.gnu.org; 22 May 2014 04:34:31 +0000 Received: from localhost ([127.0.0.1]:55783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnKi7-0002aK-7c for submit@debbugs.gnu.org; Thu, 22 May 2014 00:34:31 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:64208) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnKi4-0002Zx-Cm for 17516@debbugs.gnu.org; Thu, 22 May 2014 00:34:29 -0400 Received: by mail-wg0-f43.google.com with SMTP id l18so2804329wgh.2 for <17516@debbugs.gnu.org>; Wed, 21 May 2014 21:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=vZxfKfyLQNmbKjxMI472pU1he0q0oOJ2uldtrYKeBBc=; b=dlPZqMt8BgwOb+EetiMpoLeEHd6hLL895rjLYsjIcyxWGi0uuZXPNB04RYr4f4gzXe F2W5Gw+UP+REqi+p0EUhgdUMvdER7XwYyLr/jYo73FAgkJqMHbz6nIniLlZhMBiXs0Hs oQX+9nllu09gb8+eS7eMxoJYAi785ZTQyXYLqkDI+UGN++8fBGZ1Zs/BfiV6TibhDKHE p/VRNGsk2nuBiHIModMcaMFHpDLtKqehBoGLZwEQiCEoGd6En0Y5dsfSLwCy7iGZTSRq OOWh0IFImS/ujuyNAM9fcZgMO9NQXRCE4sgWBzY3QQ7fwsnhTkMClHkjofMDHo8vSMXc LWRA== X-Received: by 10.180.109.69 with SMTP id hq5mr14057711wib.30.1400733262462; Wed, 21 May 2014 21:34:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Wed, 21 May 2014 21:34:02 -0700 (PDT) In-Reply-To: <20140518075853.1FB8.27F6AC2D@kcn.ne.jp> References: <20140517102051.673A.27F6AC2D@kcn.ne.jp> <5376EED9.9060509@cs.ucla.edu> <20140518075853.1FB8.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Wed, 21 May 2014 21:34:02 -0700 X-Google-Sender-Auth: aK9EIvTjKhgAW5qAj1i0721Vycs Message-ID: Content-Type: multipart/mixed; boundary=e89a8f3baa0788d9be04f9f5a01c X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --e89a8f3baa0788d9be04f9f5a01c Content-Type: text/plain; charset=ISO-8859-1 On Sat, May 17, 2014 at 3:59 PM, Norihiro Tanaka wrote: > Thanks for the review and push. > > I also submit a test case for this bug. It fails in grep-2.18.146-ebf3, > and succeeds in current master. Thanks again. However, that new test made it so "make syntax-check" would fail. I've suppressed that new failure via the attached: --e89a8f3baa0788d9be04f9f5a01c Content-Type: application/octet-stream; name="0001-maint-avoid-new-false-positive-syntax-check-failure.patch" Content-Disposition: attachment; filename="0001-maint-avoid-new-false-positive-syntax-check-failure.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hvhkeeoq1 RnJvbSAxYzc3MDUzZjU3MWI4MDA1ZDYyMDBiODdlMzlhZTFlOTcxZjlmNmI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog V2VkLCAyMSBNYXkgMjAxNCAyMTozMDowNSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIG1haW50OiBh dm9pZCBuZXcgZmFsc2UtcG9zaXRpdmUgc3ludGF4LWNoZWNrIGZhaWx1cmUKCiogY2ZnLm1rIChl eGNsdWRlX2ZpbGVfbmFtZV9yZWdleHAtLXNjX3Byb2hpYml0X2RvdWJsZWRfd29yZCk6CkV4ZW1w dCBuZXcgdGVzdCBmaWxlIHRoYXQgY29udGFpbnMgbGVnaXRpbWF0ZSB1c2Ugb2YgImluIGluIi4K LS0tCiBjZmcubWsgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvY2ZnLm1rIGIvY2ZnLm1rCmluZGV4IGY4ZGRhZGUuLjBhNjhjN2QgMTAwNjQ0Ci0t LSBhL2NmZy5taworKysgYi9jZmcubWsKQEAgLTg5LDMgKzg5LDUgQEAgZXhjbHVkZV9maWxlX25h bWVfcmVnZXhwLS1zY19wcm9oaWJpdF90YWJfYmFzZWRfaW5kZW50YXRpb24gPSBcCiAgIChNYWtl ZmlsZXxcLihhbXxtaykkJCkKIGV4Y2x1ZGVfZmlsZV9uYW1lX3JlZ2V4cC0tc2NfZXJyb3JfbWVz c2FnZV91cHBlcmNhc2UgPSBec3JjL2RmYVwuYyQkCiBleGNsdWRlX2ZpbGVfbmFtZV9yZWdleHAt LXNjX3Byb2hpYml0X3N0cm5jcHkgPSBec3JjL2RmYVwuYyQkCisKK2V4Y2x1ZGVfZmlsZV9uYW1l X3JlZ2V4cC0tc2NfcHJvaGliaXRfZG91YmxlZF93b3JkID0gXnRlc3RzL2NvdW50LW5ld2xpbmUk JAotLSAKMi4wLjAucmMzCgo= --e89a8f3baa0788d9be04f9f5a01c-- From unknown Fri Jun 20 20:10:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17516: [PATCH] grep: no count newline at the head of a text buffer Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Thu, 22 May 2014 04:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17516 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: Jim Meyering , Norihiro Tanaka Cc: Paul Eggert , 17516@debbugs.gnu.org Received: via spool by 17516-submit@debbugs.gnu.org id=B17516.140073436012130 (code B ref 17516); Thu, 22 May 2014 04:53:02 +0000 Received: (at 17516) by debbugs.gnu.org; 22 May 2014 04:52:40 +0000 Received: from localhost ([127.0.0.1]:55788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnKzg-00039Z-5c for submit@debbugs.gnu.org; Thu, 22 May 2014 00:52:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30788) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnKza-00039F-OI for 17516@debbugs.gnu.org; Thu, 22 May 2014 00:52:37 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4M4qWeY017316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 May 2014 00:52:32 -0400 Received: from [10.3.113.51] (ovpn-113-51.phx2.redhat.com [10.3.113.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4M4qUkB011203; Thu, 22 May 2014 00:52:31 -0400 Message-ID: <537D828E.6040601@redhat.com> Date: Wed, 21 May 2014 22:52:30 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <20140517102051.673A.27F6AC2D@kcn.ne.jp> <5376EED9.9060509@cs.ucla.edu> <20140518075853.1FB8.27F6AC2D@kcn.ne.jp> In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vNecPpjtSw2i63TcCojpralvignBM8D8r" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Spam-Score: -5.7 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vNecPpjtSw2i63TcCojpralvignBM8D8r Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/21/2014 10:34 PM, Jim Meyering wrote: > On Sat, May 17, 2014 at 3:59 PM, Norihiro Tanaka wr= ote: >> Thanks for the review and push. >> >> I also submit a test case for this bug. It fails in grep-2.18.146-ebf= 3, >> and succeeds in current master. >=20 > Thanks again. > However, that new test made it so "make syntax-check" would fail. > I've suppressed that new failure via the attached: It's also possible to rewrite the line: grep -f in 'in' >out || fail=3D1 so as to avoid needing the suppression (I'm not sure which is prettier). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vNecPpjtSw2i63TcCojpralvignBM8D8r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTfYKOAAoJEKeha0olJ0NqFbEIAJllzje0iefrutEZLxLMvhEt N31PETF5J/2/vbWnQn0s7Gx/4fHOD9TGg5GgGz/OfE7E4e9Yx9ZmUKFN4Hr9NyKG VhjkeZHFvEcNZVHU7tM0gm1Ar/EXKCc5A9Egig0e6BDXik3aQx86egqRl+WLP3bo wKe+BkhyPHdVP+FAcBDoEwIHA7OABPy+Pc2ODVTe47fbSfh008wFKI54p5E+3dmE t/AyoiYlR3bEzf/TXcQEpe0vRKbTQXRoZWgk6f+64cKvmS25o8wxh3/QpklHU9T1 bldJXcD4Y52eQlzFLitWhfV61a74dimP3fjxIT74eKZDxe/3xQhixBQr3zl1qX0= =69t+ -----END PGP SIGNATURE----- --vNecPpjtSw2i63TcCojpralvignBM8D8r-- From unknown Fri Jun 20 20:10:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17516: [PATCH] grep: no count newline at the head of a text buffer Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Thu, 22 May 2014 04:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17516 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: Eric Blake Cc: Paul Eggert , Norihiro Tanaka , 17516 <17516@debbugs.gnu.org> Received: via spool by 17516-submit@debbugs.gnu.org id=B17516.140073456012512 (code B ref 17516); Thu, 22 May 2014 04:56:01 +0000 Received: (at 17516) by debbugs.gnu.org; 22 May 2014 04:56:00 +0000 Received: from localhost ([127.0.0.1]:55793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnL2t-0003Fj-Rz for submit@debbugs.gnu.org; Thu, 22 May 2014 00:56:00 -0400 Received: from mail-we0-f170.google.com ([74.125.82.170]:41034) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnL2q-0003FR-TB for 17516@debbugs.gnu.org; Thu, 22 May 2014 00:55:57 -0400 Received: by mail-we0-f170.google.com with SMTP id u57so2982909wes.1 for <17516@debbugs.gnu.org>; Wed, 21 May 2014 21:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=fqZ6RCFi0OxRG+ZOkXy83yM/E0foaxRnxgM4j9fOQqk=; b=UAYmc2w7xYhTr8a87xxjH+a7kuyBx5RvvZ83wL6eRjGsnG3aVbBb+lc4PefSeRCYte EoGP/X/zSI1a0u53Zf2ls7A2PXjn1f+TnNTmVsiamkkiTGx0e0PEAZgBwKHiZJuPrMjW P+gIaZhmlM2z+GXUdCZmQHOfHTlV701xfH7g0CBy5ITkuNReaPnHDH+eTC4dmFUYXYxW HUFROYISYxP3fiuuMkDU3Kvs8fcbbMyE9X/SuHCWa3tVBM5Fdq7Wm2mXdrumLLtBtlyT d7u4v9jRBcVEwvgHfXxTORCBoCCpLCUtqdqwzwRXe3OAXYFgxbtZsr3xr1PeZ0F+1+0G J4gQ== X-Received: by 10.180.74.132 with SMTP id t4mr14118046wiv.30.1400734550920; Wed, 21 May 2014 21:55:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Wed, 21 May 2014 21:55:30 -0700 (PDT) In-Reply-To: <537D828E.6040601@redhat.com> References: <20140517102051.673A.27F6AC2D@kcn.ne.jp> <5376EED9.9060509@cs.ucla.edu> <20140518075853.1FB8.27F6AC2D@kcn.ne.jp> <537D828E.6040601@redhat.com> From: Jim Meyering Date: Wed, 21 May 2014 21:55:30 -0700 X-Google-Sender-Auth: ZL57EpJjwux5NWYFTs2SZwwoUXI Message-ID: Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, May 21, 2014 at 9:52 PM, Eric Blake wrote: > On 05/21/2014 10:34 PM, Jim Meyering wrote: >> On Sat, May 17, 2014 at 3:59 PM, Norihiro Tanaka wrote: >>> Thanks for the review and push. >>> >>> I also submit a test case for this bug. It fails in grep-2.18.146-ebf3, >>> and succeeds in current master. >> >> Thanks again. >> However, that new test made it so "make syntax-check" would fail. >> I've suppressed that new failure via the attached: > > It's also possible to rewrite the line: > > grep -f in 'in' >out || fail=1 > > so as to avoid needing the suppression (I'm not sure which is prettier). Thanks for the suggestion. Since this is a false-positive after all, I prefer to keep the work-around out of the primary source file, even if that means exempting this entire file from that one syntax-check. It is unlikely to matter.