From unknown Sat Jun 21 10:24:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17514 <17514@debbugs.gnu.org> To: bug#17514 <17514@debbugs.gnu.org> Subject: Status: 24.3.91; enhancement: byte-optimize looking-at-p Reply-To: bug#17514 <17514@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:24:44 +0000 retitle 17514 24.3.91; enhancement: byte-optimize looking-at-p reassign 17514 emacs submitter 17514 Shigeru Fukaya severity 17514 wishlist tag 17514 patch wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 16 18:08:21 2014 Received: (at submit) by debbugs.gnu.org; 16 May 2014 22:08:21 +0000 Received: from localhost ([127.0.0.1]:50893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlQIe-0000u0-SO for submit@debbugs.gnu.org; Fri, 16 May 2014 18:08:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57869) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlQIb-0000tn-Uu for submit@debbugs.gnu.org; Fri, 16 May 2014 18:08:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlQIN-00048l-OU for submit@debbugs.gnu.org; Fri, 16 May 2014 18:08:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlQIN-00048h-LY for submit@debbugs.gnu.org; Fri, 16 May 2014 18:08:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlQIE-0001Qg-Ie for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 18:08:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlQI5-00046F-HV for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 18:07:54 -0400 Received: from mail-pb0-x230.google.com ([2607:f8b0:400e:c01::230]:58268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlQI5-00045x-9y for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 18:07:45 -0400 Received: by mail-pb0-f48.google.com with SMTP id rr13so3121955pbb.7 for ; Fri, 16 May 2014 15:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:mime-version:content-type :content-transfer-encoding:message-id; bh=02BF0ReL5K1USebaLvabHk1d4Hr52D3WBJo6H25UHAs=; b=bQt4HQQ89uViQX3K3w2o08t6Mo/maqXWLEEelOUkLo+63OxCEvCfvYbhZgJmC9w8H/ jfxBjwVLHxtcSAia/XRnSjox2n5gI2g3/selCsakmMKvIjNfE3gFnbICPXOGGI/tY9Sq +fe6vGcJ6Ent8nlTjl3XkMYbyF1CfsosgNNvrZSOJYzB+PPhiSnLcqWYDv5dPy5OT/gA i9w3JqxTMXKy3KY4s9danWjWRNDBvllYiSgRGgSS9II/vNA5NaEVMOUoo+hhGZJDFOAi EBJc+Da7CMVclrlM8x8jW2EpHesr8ksVIP4AhmQc+f65TWz7kHXBu4KOSUMHoeZeaV3d M+sA== X-Received: by 10.66.221.99 with SMTP id qd3mr24650549pac.46.1400278064290; Fri, 16 May 2014 15:07:44 -0700 (PDT) Received: from gmail.com (115x125x38x6.ap115.ftth.ucom.ne.jp. [115.125.38.6]) by mx.google.com with ESMTPSA id xk3sm16353433pbb.65.2014.05.16.15.07.42 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 May 2014 15:07:43 -0700 (PDT) From: Shigeru Fukaya To: bug-gnu-emacs@gnu.org Subject: 24.3.91; enhancement: byte-optimize looking-at-p Date: Sat, 17 May 2014 07:07:43 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Mailer: HidemaruMail 6.24 (WinNT,602) Message-Id: <2BCF715342F7C1shigeru.fukaya@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) looking-at-p is now a core function. I think (looking-at-p "a") can be safely optimized to (eq (following-char) ?a). I found there are 8 such codes in the current trunk, and some more possibly changable to looking-at-p from lookin-at. I made an experimental byte-optimization code. (defun byte-optimize-looking-at-p (form) (or (if (and (= (length form) 2) (stringp (nth 1 form))) (if (equal (nth 1 form) "") ;; (looking-at-p "") t (let ((c (byte-optimize-regexp-to-char (nth 1 form)))) (if c (list 'eq (list 'following-char) c))))) ;; fallback to original defsubst expansion (byte-compile-inline-expand form))) (defun byte-optimize-regexp-to-char (regexp) (let* ((special '(?\[ ?* ?. ?\\ ?? ?+ ?^ ?$)) (len (length regexp)) (c (aref regexp (1- len)))) (cond ;; don't accept '\0'. ;; as (following-char) at eob returns 0. ((eq c ?\0) nil) ;; "a" -> ?a ((= len 1) (unless (memq c special) c)) ;; "\\." -> ?. (only special characters, so far) ((= len 2) (when (and (eq (aref regexp 0) ?\\) (memq c special)) c))))) (put 'looking-at-p 'byte-optimizer 'byte-optimize-looking-at-p) (put 'looking-at-p 'side-effect-free t) -- Shigeru From debbugs-submit-bounces@debbugs.gnu.org Fri May 16 18:43:06 2014 Received: (at 17514) by debbugs.gnu.org; 16 May 2014 22:43:06 +0000 Received: from localhost ([127.0.0.1]:50914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlQqH-0001pw-JO for submit@debbugs.gnu.org; Fri, 16 May 2014 18:43:05 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45661) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlQqD-0001pS-V2 for 17514@debbugs.gnu.org; Fri, 16 May 2014 18:43:02 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s4GMgw7S024043; Fri, 16 May 2014 18:42:59 -0400 Received: by pastel.home (Postfix, from userid 20848) id B5393601AD; Fri, 16 May 2014 18:42:58 -0400 (EDT) From: Stefan Monnier To: Shigeru Fukaya Subject: Re: bug#17514: 24.3.91; enhancement: byte-optimize looking-at-p Message-ID: References: <2BCF715342F7C1shigeru.fukaya@gmail.com> Date: Fri, 16 May 2014 18:42:58 -0400 In-Reply-To: <2BCF715342F7C1shigeru.fukaya@gmail.com> (Shigeru Fukaya's message of "Sat, 17 May 2014 07:07:43 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4944=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4944> : inlines <881> : streams <1184903> : uri <1758894> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 17514 Cc: 17514@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) > I think (looking-at-p "a") can be safely optimized to > (eq (following-char) ?a). > I found there are 8 such codes in the current trunk, and some more possibly > changable to looking-at-p from lookin-at. I don't think it's worth the trouble. Better just rewrite those 8 occurrences. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 17 09:06:37 2014 Received: (at 17514) by debbugs.gnu.org; 17 May 2014 13:06:37 +0000 Received: from localhost ([127.0.0.1]:51255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WleJw-00071F-W3 for submit@debbugs.gnu.org; Sat, 17 May 2014 09:06:37 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:55600) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WleJu-00070s-4W for 17514@debbugs.gnu.org; Sat, 17 May 2014 09:06:34 -0400 Received: by mail-pb0-f43.google.com with SMTP id up15so3774250pbc.16 for <17514@debbugs.gnu.org>; Sat, 17 May 2014 06:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:mime-version:content-type :content-transfer-encoding:in-reply-to:references:message-id; bh=3HW5JmIxFhOp+zDGojx5Fi7nGa+LKhIZk03xVncQngg=; b=kyChwc9SaDcK+DB2P7wlg/qHa+WTlJi9jj6uk9Ufg9SMvLfLdUvNN2B4cjiOsibrYL eBDJNwkiQf6gRm7Jfl0gGtYxeme+flbZ5X0MGHVqugwSShgtecZWh0z/5Ze+8qERexGU knG2/Jk6U9an/QPIR2rEfZ3lrJ0wgZfNSDtTTWws2B6kXtw6pKZ/a09Z9RufUsH8dZsZ hJpQeguu59lc99IoRYAU9Gim9ZAwiBURWeOrD3HSitdWWv7nZMdi0i9Ap69rKuA1qcjE i1OxICbJoV4gh/ELa0LJGr0YXMeSv1NJ81K/6ZTOfUBnn/H/qO2f1rd0A2jf3+pxipSH HXXg== X-Received: by 10.67.14.69 with SMTP id fe5mr29185270pad.120.1400331988092; Sat, 17 May 2014 06:06:28 -0700 (PDT) Received: from gmail.com (115x125x38x6.ap115.ftth.ucom.ne.jp. [115.125.38.6]) by mx.google.com with ESMTPSA id qj3sm19900462pbc.91.2014.05.17.06.06.25 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 17 May 2014 06:06:26 -0700 (PDT) From: Shigeru Fukaya To: Stefan Monnier Subject: Re: bug#17514: 24.3.91; enhancement: byte-optimize looking-at-p Date: Sat, 17 May 2014 22:06:23 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Mailer: HidemaruMail 6.24 (WinNT,602) In-Reply-To: References: <2BCF715342F7C1shigeru.fukaya@gmail.com> Message-Id: <2CCF71D0CDB00Bshigeru.fukaya@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17514 Cc: 17514@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I should concentrate on explicit bugs only, maybe. Thank you. >> I think (looking-at-p "a") can be safely optimized to >> (eq (following-char) ?a). >> I found there are 8 such codes in the current trunk, and some more possibly >> changable to looking-at-p from lookin-at. > >I don't think it's worth the trouble. Better just rewrite those >8 occurrences. > > > Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 18 12:54:18 2014 Received: (at control) by debbugs.gnu.org; 18 May 2014 16:54:18 +0000 Received: from localhost ([127.0.0.1]:52322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wm4Lp-0005Bb-BT for submit@debbugs.gnu.org; Sun, 18 May 2014 12:54:17 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:33411 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wm4Ln-0005BO-1F for control@debbugs.gnu.org; Sun, 18 May 2014 12:54:15 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Wm4Lm-0004gm-Lc for control@debbugs.gnu.org; Sun, 18 May 2014 12:54:14 -0400 Date: Sun, 18 May 2014 12:54:14 -0400 Message-Id: Subject: control message for bug 17514 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) tag 17514 wontfix close 17514 From unknown Sat Jun 21 10:24:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Jun 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator