From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 May 2014 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17510@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14002626613785 (code B ref -1); Fri, 16 May 2014 17:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 May 2014 17:51:01 +0000 Received: from localhost ([127.0.0.1]:37543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlMHb-0000yu-Uj for submit@debbugs.gnu.org; Fri, 16 May 2014 13:51:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34994) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlMHY-0000ya-UN for submit@debbugs.gnu.org; Fri, 16 May 2014 13:50:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlMHM-00085J-Gb for submit@debbugs.gnu.org; Fri, 16 May 2014 13:50:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlMHM-000850-9Y for submit@debbugs.gnu.org; Fri, 16 May 2014 13:50:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlMHG-0004nd-1m for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 13:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlMH9-00082h-Qf for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 13:50:37 -0400 Received: from limerock03.mail.cornell.edu ([128.84.12.34]:40123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlMH9-0007zc-M4 for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 13:50:31 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4GHoFHM015969 for ; Fri, 16 May 2014 13:50:15 -0400 Received: from [128.84.234.164] (dijon.math.cornell.edu [128.84.234.164]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4GHoEPY001167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 16 May 2014 13:50:15 -0400 Message-ID: <53764FD9.8090600@cornell.edu> Date: Fri, 16 May 2014 13:50:17 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) This bug was reported in the Cygwin mailing list: https://cygwin.com/ml/cygwin/2014-05/msg00303.html In a Cygwin terminal, do the following, where "emacs" denotes the cygw32 build of emacs (--with-w32). 1. $ emacs --daemon -Q 2. $ emacsclient -c 3. `C-x 5 0' in the client window to exit the frame. 4. Repeat steps 2 and 3. 5. Attempt to carry out steps 2 and 3 a third time. The message "Waiting for Emacs..." appears in the terminal, but no new frame opens. This problem is specific to the cygw32 build; it does not happen with the X11 build of emacs on Cygwin. It also doesn't happen if the server is started via `M-x server-start' in an existing emacs. In GNU Emacs 24.3.91.1 (x86_64-unknown-cygwin) of 2014-05-16 on desktop-new Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --srcdir=/home/kbrown/src/cygemacs/emacs-24.3.91-1.x86_64/src/emacs-24.3.91 --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --libexecdir=/usr/libexec --datadir=/usr/share --localstatedir=/var --sysconfdir=/etc --libdir=/usr/lib --datarootdir=/usr/share --docdir=/usr/share/doc/emacs --htmldir=/usr/share/doc/emacs/html -C --with-w32 'CFLAGS=-ggdb -O2 -pipe -Wimplicit-function-declaration -O0 -fdebug-prefix-map=/home/kbrown/src/cygemacs/emacs-24.3.91-1.x86_64/build=/usr/src/debug/emacs-24.3.91-1 -fdebug-prefix-map=/home/kbrown/src/cygemacs/emacs-24.3.91-1.x86_64/src/emacs-24.3.91=/usr/src/debug/emacs-24.3.91-1' CPPFLAGS= LDFLAGS=-Wl,--stack,0x400000' Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 May 2014 20:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17510@debbugs.gnu.org Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140027080021468 (code B ref 17510); Fri, 16 May 2014 20:07:02 +0000 Received: (at 17510) by debbugs.gnu.org; 16 May 2014 20:06:40 +0000 Received: from localhost ([127.0.0.1]:37678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlOOt-0005aA-8S for submit@debbugs.gnu.org; Fri, 16 May 2014 16:06:40 -0400 Received: from limerock03.mail.cornell.edu ([128.84.12.34]:46363) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlOOn-0005Zo-QI for 17510@debbugs.gnu.org; Fri, 16 May 2014 16:06:37 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4GK6S1l012656 for <17510@debbugs.gnu.org>; Fri, 16 May 2014 16:06:28 -0400 Received: from [128.84.234.164] (dijon.math.cornell.edu [128.84.234.164]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4GK6HLv006404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for <17510@debbugs.gnu.org>; Fri, 16 May 2014 16:06:24 -0400 Message-ID: <53766FBC.1000601@cornell.edu> Date: Fri, 16 May 2014 16:06:20 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> In-Reply-To: <53764FD9.8090600@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/16/2014 1:50 PM, Ken Brown wrote: > This bug was reported in the Cygwin mailing list: > > https://cygwin.com/ml/cygwin/2014-05/msg00303.html > > In a Cygwin terminal, do the following, where "emacs" denotes the cygw32 > build of emacs (--with-w32). > > 1. $ emacs --daemon -Q > 2. $ emacsclient -c > 3. `C-x 5 0' in the client window to exit the frame. > 4. Repeat steps 2 and 3. > 5. Attempt to carry out steps 2 and 3 a third time. The message > "Waiting for Emacs..." appears in the terminal, but no new frame opens. > > This problem is specific to the cygw32 build; it does not happen with > the X11 build of emacs on Cygwin. It also doesn't happen if the server > is started via `M-x server-start' in an existing emacs. And it doesn't happen in emacs-24.3. As soon as I have a chance, I'll do a bisection to see when it started. Ken From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 May 2014 23:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 17510@debbugs.gnu.org, Dmitry Antipov Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.14003699901241 (code B ref 17510); Sat, 17 May 2014 23:40:01 +0000 Received: (at 17510) by debbugs.gnu.org; 17 May 2014 23:39:50 +0000 Received: from localhost ([127.0.0.1]:51804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WloCj-0000Jw-87 for submit@debbugs.gnu.org; Sat, 17 May 2014 19:39:50 -0400 Received: from limerock02.mail.cornell.edu ([128.84.12.100]:45688) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WloCd-0000JT-63 for 17510@debbugs.gnu.org; Sat, 17 May 2014 19:39:47 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4HNdbjN024556; Sat, 17 May 2014 19:39:37 -0400 Received: from [192.168.1.8] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4HNdZhY022263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 17 May 2014 19:39:36 -0400 Message-ID: <5377F335.2080609@cornell.edu> Date: Sat, 17 May 2014 19:39:33 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> In-Reply-To: <53766FBC.1000601@cornell.edu> Content-Type: multipart/mixed; boundary="------------070200010100090006020108" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------070200010100090006020108 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 5/16/2014 4:06 PM, Ken Brown wrote: > On 5/16/2014 1:50 PM, Ken Brown wrote: >> This bug was reported in the Cygwin mailing list: >> >> https://cygwin.com/ml/cygwin/2014-05/msg00303.html >> >> In a Cygwin terminal, do the following, where "emacs" denotes the cygw32 >> build of emacs (--with-w32). >> >> 1. $ emacs --daemon -Q >> 2. $ emacsclient -c >> 3. `C-x 5 0' in the client window to exit the frame. >> 4. Repeat steps 2 and 3. >> 5. Attempt to carry out steps 2 and 3 a third time. The message >> "Waiting for Emacs..." appears in the terminal, but no new frame opens. >> >> This problem is specific to the cygw32 build; it does not happen with >> the X11 build of emacs on Cygwin. It also doesn't happen if the server >> is started via `M-x server-start' in an existing emacs. > > And it doesn't happen in emacs-24.3. As soon as I have a chance, I'll > do a bisection to see when it started. Here's the culprit: revno: 114710 committer: Dmitry Antipov branch nick: trunk timestamp: Fri 2013-10-18 16:57:44 +0400 message: Remove port-specific display name lists to avoid extra complexity and data duplication with display info lists. [...] * w32term.h (w32_display_name_list): Remove declaration. * w32term.c (w32_display_name_list): Remove. (w32_initialize_display_info, x_delete_display, syms_of_w32term): Adjust users. * w32fns.c (x_display_info_for_name, Fx_display_list): Likewise. Use x_display_list where appropriate. [...] The attached patch applied to the emacs-24 branch reverts these changes and fixes the problem. This is presumably no the "right" fix. Note, however, that Dimity's commit introduced a "FIXME" into x_delete_display in w32term.c. Maybe that's the issue. Ken --------------070200010100090006020108 Content-Type: text/plain; charset=windows-1252; name="display_name_list.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="display_name_list.patch" === modified file 'src/w32fns.c' --- src/w32fns.c 2014-05-06 16:00:30 +0000 +++ src/w32fns.c 2014-05-17 22:15:56 +0000 @@ -5184,13 +5184,20 @@ struct w32_display_info * x_display_info_for_name (Lisp_Object name) { + Lisp_Object names; struct w32_display_info *dpyinfo; CHECK_STRING (name); - for (dpyinfo = &one_w32_display_info; dpyinfo; dpyinfo = dpyinfo->next) - if (!NILP (Fstring_equal (XCAR (dpyinfo->name_list_element), name))) - return dpyinfo; + for (dpyinfo = &one_w32_display_info, names = w32_display_name_list; + dpyinfo && !NILP (w32_display_name_list); + dpyinfo = dpyinfo->next, names = XCDR (names)) + { + Lisp_Object tem; + tem = Fstring_equal (XCAR (XCAR (names)), name); + if (!NILP (tem)) + return dpyinfo; + } /* Use this general default value to start with. */ Vx_resource_name = Vinvocation_name; @@ -5325,11 +5332,11 @@ doc: /* Return the list of display names that Emacs has connections to. */) (void) { - Lisp_Object result = Qnil; - struct w32_display_info *wdi; + Lisp_Object tail, result; - for (wdi = x_display_list; wdi; wdi = wdi->next) - result = Fcons (XCAR (wdi->name_list_element), result); + result = Qnil; + for (tail = w32_display_name_list; CONSP (tail); tail = XCDR (tail)) + result = Fcons (XCAR (XCAR (tail)), result); return result; } === modified file 'src/w32term.c' --- src/w32term.c 2014-04-16 14:00:39 +0000 +++ src/w32term.c 2014-05-17 22:15:56 +0000 @@ -100,6 +100,13 @@ struct w32_display_info one_w32_display_info; struct w32_display_info *x_display_list; +/* This is a list of cons cells, each of the form (NAME . FONT-LIST-CACHE), + one for each element of w32_display_list and in the same order. + NAME is the name of the frame. + FONT-LIST-CACHE records previous values returned by x-list-fonts. */ +Lisp_Object w32_display_name_list; + + #if _WIN32_WINNT < 0x0500 && !defined(_W64) /* Pre Windows 2000, this was not available, but define it here so that Emacs compiled on such a platform will run on newer versions. @@ -6161,7 +6168,11 @@ memset (dpyinfo, 0, sizeof (*dpyinfo)); - dpyinfo->name_list_element = Fcons (display_name, Qnil); + /* Put it on w32_display_name_list. */ + w32_display_name_list = Fcons (Fcons (display_name, Qnil), + w32_display_name_list); + dpyinfo->name_list_element = XCAR (w32_display_name_list); + dpyinfo->w32_id_name = xmalloc (SCHARS (Vinvocation_name) + SCHARS (Vsystem_name) + 2); sprintf (dpyinfo->w32_id_name, "%s@%s", @@ -6410,7 +6421,27 @@ void x_delete_display (struct w32_display_info *dpyinfo) { - /* FIXME: the only display info apparently can't be deleted. */ + /* Discard this display from w32_display_name_list and w32_display_list. + We can't use Fdelq because that can quit. */ + if (! NILP (w32_display_name_list) + && EQ (XCAR (w32_display_name_list), dpyinfo->name_list_element)) + w32_display_name_list = XCDR (w32_display_name_list); + else + { + Lisp_Object tail; + + tail = w32_display_name_list; + while (CONSP (tail) && CONSP (XCDR (tail))) + { + if (EQ (XCAR (XCDR (tail)), dpyinfo->name_list_element)) + { + XSETCDR (tail, XCDR (XCDR (tail))); + break; + } + tail = XCDR (tail); + } + } + /* free palette table */ { struct w32_palette_entry * plist; @@ -6547,6 +6578,9 @@ void syms_of_w32term (void) { + staticpro (&w32_display_name_list); + w32_display_name_list = Qnil; + DEFSYM (Qvendor_specific_keysyms, "vendor-specific-keysyms"); DEFSYM (Qadded, "added"); === modified file 'src/w32term.h' --- src/w32term.h 2014-02-04 16:13:51 +0000 +++ src/w32term.h 2014-05-17 22:15:56 +0000 @@ -71,7 +71,8 @@ /* The generic display parameters corresponding to this w32 display. */ struct terminal *terminal; - /* This is a cons cell of the form (NAME . FONT-LIST-CACHE). */ + /* This is a cons cell of the form (NAME . FONT-LIST-CACHE). + The same cons cell also appears in x_display_name_list. */ Lisp_Object name_list_element; /* Number of frames that are on this display. */ @@ -200,6 +201,12 @@ extern struct w32_display_info *x_display_list; extern struct w32_display_info one_w32_display_info; +/* This is a list of cons cells, each of the form (NAME . FONT-LIST-CACHE), + one for each element of w32_display_list and in the same order. + NAME is the name of the frame. + FONT-LIST-CACHE records previous values returned by x-list-fonts. */ +extern Lisp_Object w32_display_name_list; + extern struct frame *x_window_to_frame (struct w32_display_info *, HWND); struct w32_display_info *x_display_info_for_name (Lisp_Object); --------------070200010100090006020108-- From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 May 2014 04:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Reply-To: Eli Zaretskii Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.14003875631413 (code B ref 17510); Sun, 18 May 2014 04:33:02 +0000 Received: (at 17510) by debbugs.gnu.org; 18 May 2014 04:32:43 +0000 Received: from localhost ([127.0.0.1]:51868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlsmA-0000Mi-Ff for submit@debbugs.gnu.org; Sun, 18 May 2014 00:32:42 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:34834) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wlsm6-0000MG-Aq for 17510@debbugs.gnu.org; Sun, 18 May 2014 00:32:40 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0N5R00D005PZ6B00@a-mtaout21.012.net.il> for 17510@debbugs.gnu.org; Sun, 18 May 2014 07:32:31 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5R00DAG5Y70980@a-mtaout21.012.net.il>; Sun, 18 May 2014 07:32:31 +0300 (IDT) Date: Sun, 18 May 2014 07:32:32 +0300 From: Eli Zaretskii In-reply-to: <5377F335.2080609@cornell.edu> X-012-Sender: halo1@inter.net.il Message-id: <831tvremfz.fsf@gnu.org> References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 17 May 2014 19:39:33 -0400 > From: Ken Brown > > On 5/16/2014 4:06 PM, Ken Brown wrote: > > On 5/16/2014 1:50 PM, Ken Brown wrote: > >> This bug was reported in the Cygwin mailing list: > >> > >> https://cygwin.com/ml/cygwin/2014-05/msg00303.html > >> > >> In a Cygwin terminal, do the following, where "emacs" denotes the cygw32 > >> build of emacs (--with-w32). > >> > >> 1. $ emacs --daemon -Q > >> 2. $ emacsclient -c > >> 3. `C-x 5 0' in the client window to exit the frame. > >> 4. Repeat steps 2 and 3. > >> 5. Attempt to carry out steps 2 and 3 a third time. The message > >> "Waiting for Emacs..." appears in the terminal, but no new frame opens. > >> > >> This problem is specific to the cygw32 build; it does not happen with > >> the X11 build of emacs on Cygwin. It also doesn't happen if the server > >> is started via `M-x server-start' in an existing emacs. > > > > And it doesn't happen in emacs-24.3. As soon as I have a chance, I'll > > do a bisection to see when it started. > > Here's the culprit: > > revno: 114710 > committer: Dmitry Antipov > branch nick: trunk > timestamp: Fri 2013-10-18 16:57:44 +0400 > message: > Remove port-specific display name lists to avoid extra > complexity and data duplication with display info lists. > [...] > * w32term.h (w32_display_name_list): Remove declaration. > * w32term.c (w32_display_name_list): Remove. > (w32_initialize_display_info, x_delete_display, syms_of_w32term): > Adjust users. > * w32fns.c (x_display_info_for_name, Fx_display_list): > Likewise. Use x_display_list where appropriate. > [...] > > The attached patch applied to the emacs-24 branch reverts these changes > and fixes the problem. This is presumably no the "right" fix. Note, > however, that Dimity's commit introduced a "FIXME" into x_delete_display > in w32term.c. Maybe that's the issue. Thanks, but you need to be more selective: which one of these changes is the root cause, and why? In general, everything that is related to one_w32_display_info is specific to the WINDOWSNT port, so perhaps the problem is that the Cygwin-w32 build is incorrectly treated the same. But where exactly? Once you point out the parts that are causing this bug, they should be modified for __CYGWIN__, but left alone for WINDOWSNT. Thanks. From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 May 2014 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.14004234415909 (code B ref 17510); Sun, 18 May 2014 14:31:02 +0000 Received: (at 17510) by debbugs.gnu.org; 18 May 2014 14:30:41 +0000 Received: from localhost ([127.0.0.1]:52292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wm26q-0001XE-9m for submit@debbugs.gnu.org; Sun, 18 May 2014 10:30:40 -0400 Received: from limerock01.mail.cornell.edu ([128.84.12.99]:51598) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wm26m-0001Wx-J6 for 17510@debbugs.gnu.org; Sun, 18 May 2014 10:30:38 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4IEUUJh014500; Sun, 18 May 2014 10:30:30 -0400 Received: from [192.168.1.8] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4IEUSGn006693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 18 May 2014 10:30:29 -0400 Message-ID: <5378C404.8050405@cornell.edu> Date: Sun, 18 May 2014 10:30:28 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> In-Reply-To: <831tvremfz.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/18/2014 12:32 AM, Eli Zaretskii wrote: > Thanks, but you need to be more selective: which one of these changes > is the root cause, and why? It's not easy to be selective; these aren't independent changes. There used to be a `w32_display_name_list', which Dmitry removed. Along with this change, he removed the code that used to be in x_delete_display (to delete a display from the list) and replaced it by a FIXME. > In general, everything that is related to one_w32_display_info is > specific to the WINDOWSNT port, so perhaps the problem is that the > Cygwin-w32 build is incorrectly treated the same. But where exactly? Looking at the code, I don't see why this problem is specific to the Cygwin-w32 build. Can you reproduce it in the Windows build? I *think* what must be happening in the recipe that I gave for this bug is that every time a client frame is closed, x_delete_display is called. Before Dmitry's change, this would actually delete something from a list. Now it doesn't, and the server gets messed up and ultimately dies on the third attempt to create a client frame. Unless there's an obvious fix for this, it seems to me that we're far enough into the pretest that we should just revert to the old code, at least for emacs-24. Ken From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 May 2014 15:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Reply-To: Eli Zaretskii Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.14004259049947 (code B ref 17510); Sun, 18 May 2014 15:12:01 +0000 Received: (at 17510) by debbugs.gnu.org; 18 May 2014 15:11:44 +0000 Received: from localhost ([127.0.0.1]:52297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wm2kZ-0002aM-8t for submit@debbugs.gnu.org; Sun, 18 May 2014 11:11:43 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:48958) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wm2kU-0002a1-SH for 17510@debbugs.gnu.org; Sun, 18 May 2014 11:11:40 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0N5R00K00Z0PJ300@mtaout27.012.net.il> for 17510@debbugs.gnu.org; Sun, 18 May 2014 18:08:15 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5R00FYXZDRW160@mtaout27.012.net.il>; Sun, 18 May 2014 18:08:15 +0300 (IDT) Date: Sun, 18 May 2014 18:11:34 +0300 From: Eli Zaretskii In-reply-to: <5378C404.8050405@cornell.edu> X-012-Sender: halo1@inter.net.il Message-id: <83wqdjceah.fsf@gnu.org> References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 18 May 2014 10:30:28 -0400 > From: Ken Brown > CC: 17510@debbugs.gnu.org, dmantipov@yandex.ru > > On 5/18/2014 12:32 AM, Eli Zaretskii wrote: > > Thanks, but you need to be more selective: which one of these changes > > is the root cause, and why? > > It's not easy to be selective; these aren't independent changes. There > used to be a `w32_display_name_list', which Dmitry removed. Along with > this change, he removed the code that used to be in x_delete_display (to > delete a display from the list) and replaced it by a FIXME. Perhaps that FIXME is not relevant to Cygwin, and the removed code should be retained in the Cygwin build. > > In general, everything that is related to one_w32_display_info is > > specific to the WINDOWSNT port, so perhaps the problem is that the > > Cygwin-w32 build is incorrectly treated the same. But where exactly? > > Looking at the code, I don't see why this problem is specific to the > Cygwin-w32 build. If the Cygwin-w32 build wants more (or less) than one display_info object, then that part _is_ specific to Cygwin, because the native Windows build has only one such object that is never deleted. > Can you reproduce it in the Windows build? The native Windows build doesn't support --daemon, so no, I can't. > I *think* what must be happening in the recipe that I gave for this bug > is that every time a client frame is closed, x_delete_display is called. > Before Dmitry's change, this would actually delete something from a > list. Now it doesn't, and the server gets messed up and ultimately dies > on the third attempt to create a client frame. See above: try restoring that code for Cygwin only. > Unless there's an obvious fix for this, it seems to me that we're far > enough into the pretest that we should just revert to the old code, at > least for emacs-24. That would revert a useful cleanup, which I'm not sure is a good idea at this point. From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 May 2014 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.14004417857750 (code B ref 17510); Sun, 18 May 2014 19:37:02 +0000 Received: (at 17510) by debbugs.gnu.org; 18 May 2014 19:36:25 +0000 Received: from localhost ([127.0.0.1]:52402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wm6si-00020v-31 for submit@debbugs.gnu.org; Sun, 18 May 2014 15:36:24 -0400 Received: from limerock02.mail.cornell.edu ([128.84.12.100]:34349) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wm6sf-00020e-0r for 17510@debbugs.gnu.org; Sun, 18 May 2014 15:36:22 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4IJaDr2020824; Sun, 18 May 2014 15:36:14 -0400 Received: from [192.168.1.8] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4IJaBal005791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 18 May 2014 15:36:13 -0400 Message-ID: <53790BAB.3020909@cornell.edu> Date: Sun, 18 May 2014 15:36:11 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> In-Reply-To: <83wqdjceah.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/18/2014 11:11 AM, Eli Zaretskii wrote: >> Date: Sun, 18 May 2014 10:30:28 -0400 >> From: Ken Brown >> CC: 17510@debbugs.gnu.org, dmantipov@yandex.ru >> >> On 5/18/2014 12:32 AM, Eli Zaretskii wrote: >>> Thanks, but you need to be more selective: which one of these changes >>> is the root cause, and why? >> >> It's not easy to be selective; these aren't independent changes. There >> used to be a `w32_display_name_list', which Dmitry removed. Along with >> this change, he removed the code that used to be in x_delete_display (to >> delete a display from the list) and replaced it by a FIXME. > > Perhaps that FIXME is not relevant to Cygwin, and the removed code > should be retained in the Cygwin build. > >>> In general, everything that is related to one_w32_display_info is >>> specific to the WINDOWSNT port, so perhaps the problem is that the >>> Cygwin-w32 build is incorrectly treated the same. But where exactly? >> >> Looking at the code, I don't see why this problem is specific to the >> Cygwin-w32 build. > > If the Cygwin-w32 build wants more (or less) than one display_info > object, then that part _is_ specific to Cygwin, because the native > Windows build has only one such object that is never deleted. > >> Can you reproduce it in the Windows build? > > The native Windows build doesn't support --daemon, so no, I can't. > >> I *think* what must be happening in the recipe that I gave for this bug >> is that every time a client frame is closed, x_delete_display is called. >> Before Dmitry's change, this would actually delete something from a >> list. Now it doesn't, and the server gets messed up and ultimately dies >> on the third attempt to create a client frame. > > See above: try restoring that code for Cygwin only. > >> Unless there's an obvious fix for this, it seems to me that we're far >> enough into the pretest that we should just revert to the old code, at >> least for emacs-24. > > That would revert a useful cleanup, which I'm not sure is a good idea > at this point. How does this look? === modified file 'src/w32fns.c' --- src/w32fns.c 2014-05-06 16:00:30 +0000 +++ src/w32fns.c 2014-05-18 19:21:41 +0000 @@ -5188,9 +5188,22 @@ CHECK_STRING (name); +#ifdef CYGWIN /* See comment in w32term.c */ + Lisp_Object names; + for (dpyinfo = &one_w32_display_info, names = cygw32_display_name_list; + dpyinfo && !NILP (cygw32_display_name_list); + dpyinfo = dpyinfo->next, names = XCDR (names)) + { + Lisp_Object tem; + tem = Fstring_equal (XCAR (XCAR (names)), name); + if (!NILP (tem)) + return dpyinfo; + } +#else /* !CYGWIN */ for (dpyinfo = &one_w32_display_info; dpyinfo; dpyinfo = dpyinfo->next) if (!NILP (Fstring_equal (XCAR (dpyinfo->name_list_element), name))) return dpyinfo; +#endif /* !CYGWIN */ /* Use this general default value to start with. */ Vx_resource_name = Vinvocation_name; @@ -5326,10 +5339,17 @@ (void) { Lisp_Object result = Qnil; + +#ifdef CYGWIN + Lisp_Object tail; + for (tail = cygw32_display_name_list; CONSP (tail); tail = XCDR (tail)) + result = Fcons (XCAR (XCAR (tail)), result); +#else struct w32_display_info *wdi; for (wdi = x_display_list; wdi; wdi = wdi->next) result = Fcons (XCAR (wdi->name_list_element), result); +#endif return result; } === modified file 'src/w32term.c' --- src/w32term.c 2014-04-16 14:00:39 +0000 +++ src/w32term.c 2014-05-18 19:24:17 +0000 @@ -100,6 +100,17 @@ struct w32_display_info one_w32_display_info; struct w32_display_info *x_display_list; +/* In order to support "emacs --daemon" on the Cygwin-w32 build, we + maintain a list of display names. (This compensates for the fact + that the one display can't be deleted. See Bug#17510 and the FIXME + in x_delete_display below.) This is a list of cons cells, each of + the form (NAME . FONT-LIST-CACHE). NAME is the name of the frame. + FONT-LIST-CACHE records previous values returned by + x-list-fonts. */ +#ifdef CYGWIN +Lisp_Object cygw32_display_name_list; +#endif + #if _WIN32_WINNT < 0x0500 && !defined(_W64) /* Pre Windows 2000, this was not available, but define it here so that Emacs compiled on such a platform will run on newer versions. @@ -6162,6 +6173,10 @@ memset (dpyinfo, 0, sizeof (*dpyinfo)); dpyinfo->name_list_element = Fcons (display_name, Qnil); +#ifdef CYGWIN + cygw32_display_name_list = Fcons (dpyinfo->name_list_element, + cygw32_display_name_list); +#endif dpyinfo->w32_id_name = xmalloc (SCHARS (Vinvocation_name) + SCHARS (Vsystem_name) + 2); sprintf (dpyinfo->w32_id_name, "%s@%s", @@ -6411,6 +6426,26 @@ x_delete_display (struct w32_display_info *dpyinfo) { /* FIXME: the only display info apparently can't be deleted. */ +#ifdef CYGWIN + if (! NILP (cygw32_display_name_list) + && EQ (XCAR (cygw32_display_name_list), dpyinfo->name_list_element)) + cygw32_display_name_list = XCDR (cygw32_display_name_list); + else + { + Lisp_Object tail; + + tail = cygw32_display_name_list; + while (CONSP (tail) && CONSP (XCDR (tail))) + { + if (EQ (XCAR (XCDR (tail)), dpyinfo->name_list_element)) + { + XSETCDR (tail, XCDR (XCDR (tail))); + break; + } + tail = XCDR (tail); + } + } +#endif /* CYGWIN */ /* free palette table */ { struct w32_palette_entry * plist; @@ -6547,6 +6582,9 @@ void syms_of_w32term (void) { + staticpro (&cygw32_display_name_list); + cygw32_display_name_list = Qnil; + DEFSYM (Qvendor_specific_keysyms, "vendor-specific-keysyms"); DEFSYM (Qadded, "added"); === modified file 'src/w32term.h' --- src/w32term.h 2014-02-04 16:13:51 +0000 +++ src/w32term.h 2014-05-18 19:13:35 +0000 @@ -200,6 +200,10 @@ extern struct w32_display_info *x_display_list; extern struct w32_display_info one_w32_display_info; +#ifdef CYGWIN +extern Lisp_Object cygw32_display_name_list; +#endif + extern struct frame *x_window_to_frame (struct w32_display_info *, HWND); struct w32_display_info *x_display_info_for_name (Lisp_Object); From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 May 2014 12:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140050101931572 (code B ref 17510); Mon, 19 May 2014 12:04:02 +0000 Received: (at 17510) by debbugs.gnu.org; 19 May 2014 12:03:39 +0000 Received: from localhost ([127.0.0.1]:52902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmMI1-0008D5-VD for submit@debbugs.gnu.org; Mon, 19 May 2014 08:03:38 -0400 Received: from limerock04.mail.cornell.edu ([128.84.12.60]:37480) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmMHu-0008Cg-DI for 17510@debbugs.gnu.org; Mon, 19 May 2014 08:03:31 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4JC3Jq9027998; Mon, 19 May 2014 08:03:19 -0400 Received: from [192.168.1.8] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4JC3Hs0000431 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 19 May 2014 08:03:18 -0400 Message-ID: <5379F304.80004@cornell.edu> Date: Mon, 19 May 2014 08:03:16 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> In-Reply-To: <53790BAB.3020909@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/18/2014 3:36 PM, Ken Brown wrote: > + staticpro (&cygw32_display_name_list); > + cygw32_display_name_list = Qnil; I forgot the #ifdef CYGWIN for this part. From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 May 2014 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Reply-To: Eli Zaretskii Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.14005180294533 (code B ref 17510); Mon, 19 May 2014 16:48:02 +0000 Received: (at 17510) by debbugs.gnu.org; 19 May 2014 16:47:09 +0000 Received: from localhost ([127.0.0.1]:53320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmQiR-0001B2-HC for submit@debbugs.gnu.org; Mon, 19 May 2014 12:47:07 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:40645) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmQiO-0001AT-3T for 17510@debbugs.gnu.org; Mon, 19 May 2014 12:47:05 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N5T00800YKUBX00@a-mtaout22.012.net.il> for 17510@debbugs.gnu.org; Mon, 19 May 2014 19:46:57 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5T007NZYM3ZD60@a-mtaout22.012.net.il>; Mon, 19 May 2014 19:46:51 +0300 (IDT) Date: Mon, 19 May 2014 19:46:56 +0300 From: Eli Zaretskii In-reply-to: <53790BAB.3020909@cornell.edu> X-012-Sender: halo1@inter.net.il Message-id: <837g5hd8cf.fsf@gnu.org> References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 18 May 2014 15:36:11 -0400 > From: Ken Brown > CC: 17510@debbugs.gnu.org, dmantipov@yandex.ru > > > If the Cygwin-w32 build wants more (or less) than one display_info > > object, then that part _is_ specific to Cygwin, because the native > > Windows build has only one such object that is never deleted. > > > >> Can you reproduce it in the Windows build? > > > > The native Windows build doesn't support --daemon, so no, I can't. > > > >> I *think* what must be happening in the recipe that I gave for this bug > >> is that every time a client frame is closed, x_delete_display is called. > >> Before Dmitry's change, this would actually delete something from a > >> list. Now it doesn't, and the server gets messed up and ultimately dies > >> on the third attempt to create a client frame. > > > > See above: try restoring that code for Cygwin only. > > > >> Unless there's an obvious fix for this, it seems to me that we're far > >> enough into the pretest that we should just revert to the old code, at > >> least for emacs-24. > > > > That would revert a useful cleanup, which I'm not sure is a good idea > > at this point. > > How does this look? I guess it's OK for the branch, thanks. But it strikes me that simply replacing the car of dpyinfo->name_list_element by something like "!!!DELETED DISPLAY!!!", or even just an empty string, would serve the same purpose, and save us the nuisance of an additional list in cygw32_display_name_list. After all, all you need is to mark a display deleted without actually deleting it, right? IOW, the main problem is in x_delete_display, and all the rest is just the overhead you needed to fix that, correct? From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 May 2014 17:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: kbrown@cornell.edu Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Reply-To: Eli Zaretskii Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.14005206858948 (code B ref 17510); Mon, 19 May 2014 17:32:01 +0000 Received: (at 17510) by debbugs.gnu.org; 19 May 2014 17:31:25 +0000 Received: from localhost ([127.0.0.1]:53359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmRPI-0002KD-O6 for submit@debbugs.gnu.org; Mon, 19 May 2014 13:31:24 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:53291) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmRPF-0002Jw-Ie for 17510@debbugs.gnu.org; Mon, 19 May 2014 13:31:23 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N5U00K000C1H900@mtaout24.012.net.il> for 17510@debbugs.gnu.org; Mon, 19 May 2014 20:28:16 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5U00DXI0J4SI70@mtaout24.012.net.il>; Mon, 19 May 2014 20:28:16 +0300 (IDT) Date: Mon, 19 May 2014 20:31:19 +0300 From: Eli Zaretskii In-reply-to: <837g5hd8cf.fsf@gnu.org> X-012-Sender: halo1@inter.net.il Message-id: <834n0ld6ag.fsf@gnu.org> References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 19 May 2014 19:46:56 +0300 > From: Eli Zaretskii > Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru > > it strikes me that simply replacing the car of > dpyinfo->name_list_element by something like "!!!DELETED > DISPLAY!!!", or even just an empty string I meant doing the above when a display is deleted. From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 May 2014 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140052755220577 (code B ref 17510); Mon, 19 May 2014 19:26:01 +0000 Received: (at 17510) by debbugs.gnu.org; 19 May 2014 19:25:52 +0000 Received: from localhost ([127.0.0.1]:53453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmTC3-0005Lo-QR for submit@debbugs.gnu.org; Mon, 19 May 2014 15:25:52 -0400 Received: from limerock01.mail.cornell.edu ([128.84.12.99]:36746) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmTC0-0005LX-Do for 17510@debbugs.gnu.org; Mon, 19 May 2014 15:25:49 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4JJPgkI010118; Mon, 19 May 2014 15:25:42 -0400 Received: from [192.168.1.8] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4JJPfbZ016894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 19 May 2014 15:25:42 -0400 Message-ID: <537A5AB4.8070602@cornell.edu> Date: Mon, 19 May 2014 15:25:40 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> In-Reply-To: <837g5hd8cf.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/19/2014 12:46 PM, Eli Zaretskii wrote: > I guess it's OK for the branch, thanks. But it strikes me that simply > replacing the car of dpyinfo->name_list_element by something like > "!!!DELETED DISPLAY!!!", or even just an empty string, would serve the > same purpose, and save us the nuisance of an additional list in > cygw32_display_name_list. After all, all you need is to mark a > display deleted without actually deleting it, right? IOW, the main > problem is in x_delete_display, and all the rest is just the overhead > you needed to fix that, correct? I think that's correct, and I agree that there should be a much simpler fix. I'll have to look into the code and try to understand better exactly what happens when emacs is started as a daemon and then a client frame is opened and closed. I'll hold off on installing my patch until I see if I can find a better solution that is still safe enough for the branch. Ken From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2014 12:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140093511012446 (code B ref 17510); Sat, 24 May 2014 12:39:02 +0000 Received: (at 17510) by debbugs.gnu.org; 24 May 2014 12:38:30 +0000 Received: from localhost ([127.0.0.1]:58673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoBDZ-0003Ef-U2 for submit@debbugs.gnu.org; Sat, 24 May 2014 08:38:30 -0400 Received: from limerock04.mail.cornell.edu ([128.84.12.60]:37535) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoBDV-0003E0-O7 for 17510@debbugs.gnu.org; Sat, 24 May 2014 08:38:26 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4OCcJFf005652; Sat, 24 May 2014 08:38:19 -0400 Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4OCcHjs013153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 24 May 2014 08:38:18 -0400 Message-ID: <538092B6.9000807@cornell.edu> Date: Sat, 24 May 2014 08:38:14 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> <537A5AB4.8070602@cornell.edu> In-Reply-To: <537A5AB4.8070602@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/19/2014 3:25 PM, Ken Brown wrote: > On 5/19/2014 12:46 PM, Eli Zaretskii wrote: >> I guess it's OK for the branch, thanks. But it strikes me that simply >> replacing the car of dpyinfo->name_list_element by something like >> "!!!DELETED DISPLAY!!!", or even just an empty string, would serve the >> same purpose, and save us the nuisance of an additional list in >> cygw32_display_name_list. After all, all you need is to mark a >> display deleted without actually deleting it, right? IOW, the main >> problem is in x_delete_display, and all the rest is just the overhead >> you needed to fix that, correct? > > I think that's correct, and I agree that there should be a much simpler > fix. I'll have to look into the code and try to understand better > exactly what happens when emacs is started as a daemon and then a client > frame is opened and closed. My guess as to the cause of this bug was completely wrong. What happens in my recipe is that the pointer dpyinfo->w32_id_name is freed twice. (This is done in x_delete_display each time the only existing client frame is deleted.) An attempt to create a client frame for the third time then leads to a crash because of malloc corruption. I have no idea why this problem only showed up after Dmitry's code cleanup. The only thing I can think of is that maintaining a list of display names, with insertions and deletions, masked the malloc corruption. I think the right fix here would be to really delete the display when x_delete_display is called, free all resources, and set things up so that everything will be re-initialized if a new frame is created. But this seems like a lot of trouble, possibly with unintended consequences. The following is a much simpler workaround: === modified file 'src/w32term.c' --- src/w32term.c 2014-04-16 14:00:39 +0000 +++ src/w32term.c 2014-05-24 12:13:15 +0000 @@ -6426,7 +6426,9 @@ if (dpyinfo->palette) DeleteObject (dpyinfo->palette); } +#ifndef CYGWIN xfree (dpyinfo->w32_id_name); +#endif w32_reset_fringes (); } I would of course add a comment explaining this. What do you think? Ken From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2014 13:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Reply-To: Eli Zaretskii Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140093634114316 (code B ref 17510); Sat, 24 May 2014 13:00:03 +0000 Received: (at 17510) by debbugs.gnu.org; 24 May 2014 12:59:01 +0000 Received: from localhost ([127.0.0.1]:58678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoBXQ-0003il-8E for submit@debbugs.gnu.org; Sat, 24 May 2014 08:59:00 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:37519) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoBXM-0003iT-F7 for 17510@debbugs.gnu.org; Sat, 24 May 2014 08:58:57 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0N6200M00X04EA00@mtaout28.012.net.il> for 17510@debbugs.gnu.org; Sat, 24 May 2014 15:56:52 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N6200L03XAS1Y30@mtaout28.012.net.il>; Sat, 24 May 2014 15:56:52 +0300 (IDT) Date: Sat, 24 May 2014 15:59:07 +0300 From: Eli Zaretskii In-reply-to: <538092B6.9000807@cornell.edu> X-012-Sender: halo1@inter.net.il Message-id: <83sinzjpt0.fsf@gnu.org> References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> <537A5AB4.8070602@cornell.edu> <538092B6.9000807@cornell.edu> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 24 May 2014 08:38:14 -0400 > From: Ken Brown > CC: 17510@debbugs.gnu.org, dmantipov@yandex.ru > > My guess as to the cause of this bug was completely wrong. What happens > in my recipe is that the pointer dpyinfo->w32_id_name is freed twice. > (This is done in x_delete_display each time the only existing client > frame is deleted.) An attempt to create a client frame for the third > time then leads to a crash because of malloc corruption. > > I have no idea why this problem only showed up after Dmitry's code > cleanup. The only thing I can think of is that maintaining a list of > display names, with insertions and deletions, masked the malloc corruption. > > I think the right fix here would be to really delete the display when > x_delete_display is called, free all resources, and set things up so > that everything will be re-initialized if a new frame is created. But > this seems like a lot of trouble, possibly with unintended consequences. > The following is a much simpler workaround: > > === modified file 'src/w32term.c' > --- src/w32term.c 2014-04-16 14:00:39 +0000 > +++ src/w32term.c 2014-05-24 12:13:15 +0000 > @@ -6426,7 +6426,9 @@ > if (dpyinfo->palette) > DeleteObject (dpyinfo->palette); > } > +#ifndef CYGWIN > xfree (dpyinfo->w32_id_name); > +#endif > > w32_reset_fringes (); > } > > I would of course add a comment explaining this. What do you think? This looks OK to me, but I wonder: is it really correct not to free w32_id_name at all? And if that is correct, why only on Cygwin? Does the Cygwin-w32 build also use a single dpyinfo object, like the native Windows build? If so, perhaps we need not free this in both these builds. IOW, I think your suggested change is OK for the emacs-24 branch, but on the trunk I'd suggest to remove the xfree line altogether. Thanks. From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2014 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140095524714847 (code B ref 17510); Sat, 24 May 2014 18:15:02 +0000 Received: (at 17510) by debbugs.gnu.org; 24 May 2014 18:14:07 +0000 Received: from localhost ([127.0.0.1]:59298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoGSN-0003rO-8L for submit@debbugs.gnu.org; Sat, 24 May 2014 14:14:07 -0400 Received: from limerock01.mail.cornell.edu ([128.84.12.99]:41846) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoGSJ-0003qU-TW for 17510@debbugs.gnu.org; Sat, 24 May 2014 14:14:04 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4OIDvvf017286; Sat, 24 May 2014 14:13:58 -0400 Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4OIDu02015984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 24 May 2014 14:13:57 -0400 Message-ID: <5380E172.8090004@cornell.edu> Date: Sat, 24 May 2014 14:14:10 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> <537A5AB4.8070602@cornell.edu> <538092B6.9000807@cornell.edu> <83sinzjpt0.fsf@gnu.org> In-Reply-To: <83sinzjpt0.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/24/2014 8:59 AM, Eli Zaretskii wrote: > This looks OK to me, but I wonder: is it really correct not to free > w32_id_name at all? And if that is correct, why only on Cygwin? I would say it's harmless not to free w32_id_name. It's malloc'd once and never changed. But I agree that it's harmless also on native Windows. > Does the Cygwin-w32 build also use a single dpyinfo object, like the > native Windows build? Yes > If so, perhaps we need not free this in both > these builds. IOW, I think your suggested change is OK for the > emacs-24 branch, but on the trunk I'd suggest to remove the xfree line > altogether. OK, I've made the change on the emacs-24 branch as revision 117147. After this has been merged to the trunk, I'll remove the xfree line. I'm not closing the bug yet because I forgot to retest my change after revision 117146 was made, and the latter is causing a problem with emacsclient (at least on Cygwin-w32). I need to make sure that this isn't related to my change. Ken From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2014 19:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown , Eli Zaretskii Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140095975924049 (code B ref 17510); Sat, 24 May 2014 19:30:03 +0000 Received: (at 17510) by debbugs.gnu.org; 24 May 2014 19:29:19 +0000 Received: from localhost ([127.0.0.1]:59334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoHd8-0006Fm-QA for submit@debbugs.gnu.org; Sat, 24 May 2014 15:29:19 -0400 Received: from dancol.org ([96.126.100.184]:60191) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoHcw-0006FI-Qm for 17510@debbugs.gnu.org; Sat, 24 May 2014 15:29:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=4zsgIg7A5E3N1FKQtDBfDo14/ofevVDUGHdVPHCrJkg=; b=PTPEjcUVS/eMUgmnAPXhKuKITZ1Lx2FEcV5Gt0nOev4Q8O0WBjtjncMVlM0F6185SAzxEp0Fr6wUc6AuxgK+jLfzqV3kVgWE2zOZFAFMz7NpXDMfpijZDZT8sc8hDPg8aTlOMH/JI90SalZX5Yno+pSTZXFEYpj6lErPc7hm5r0hXqXFATClVGQnWncUOXczOLvPWVJwxe4C2R8tFxShUNlsFRx7PAP2QacN4E6Dyvk9RTqjTrnmiL9v89MQUwOQdYHoJnjRBVvmhAopRK10fxFBiq7xCDRYm52Y0sfDV1NlPCeXceJel29q4o2JAJQb0ZzE8vPThV0ehwGHD6PcGA==; Received: from [2601:8:b240:264::2b1] by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1WoHcp-0002Lu-Mc; Sat, 24 May 2014 12:28:59 -0700 Message-ID: <5380F2FA.1080007@dancol.org> Date: Sat, 24 May 2014 12:28:58 -0700 From: Daniel Colascione User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> <537A5AB4.8070602@cornell.edu> <538092B6.9000807@cornell.edu> In-Reply-To: <538092B6.9000807@cornell.edu> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8JVlc08lMQIxjcXumooJ0a2QmD89obkxg" X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8JVlc08lMQIxjcXumooJ0a2QmD89obkxg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/24/2014 05:38 AM, Ken Brown wrote: > On 5/19/2014 3:25 PM, Ken Brown wrote: >> On 5/19/2014 12:46 PM, Eli Zaretskii wrote: >>> I guess it's OK for the branch, thanks. But it strikes me that simpl= y >>> replacing the car of dpyinfo->name_list_element by something like >>> "!!!DELETED DISPLAY!!!", or even just an empty string, would serve th= e >>> same purpose, and save us the nuisance of an additional list in >>> cygw32_display_name_list. After all, all you need is to mark a >>> display deleted without actually deleting it, right? IOW, the main >>> problem is in x_delete_display, and all the rest is just the overhead= >>> you needed to fix that, correct? >> >> I think that's correct, and I agree that there should be a much simple= r >> fix. I'll have to look into the code and try to understand better >> exactly what happens when emacs is started as a daemon and then a clie= nt >> frame is opened and closed. >=20 > My guess as to the cause of this bug was completely wrong. What happen= s > in my recipe is that the pointer dpyinfo->w32_id_name is freed twice. > (This is done in x_delete_display each time the only existing client > frame is deleted.) An attempt to create a client frame for the third > time then leads to a crash because of malloc corruption. Thanks for finding that. I wonder whether this double-free also has something to do with random crashes people have been seeing in 64-bit Cygwin cygw32 Emacs builds. --8JVlc08lMQIxjcXumooJ0a2QmD89obkxg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTgPL6AAoJEMAaIROpHW7I+4QP/0R13GPfshuKe+OCHWIobFTP Y0QKeNLDx0N3kLjM4dk6EUk7+leYL9ua2G4Y7l64PnV7jx2nszhUqL8Y986Xw8tj grivklCXMWrnpfh7+QXYV9TNO39bnuAMy9ZzSFbe3p+lqJJtGVwDXf3U+15+C6rR aq9tzQ3d259mjJqA6pmROkJf6hi/9Kn2pt5UfXOUGY26+cqb50z1Ab4L4JPeMmN1 WdOztUw64syNDLgqbQU2BDhFMmT1walwIGohOW1zTuurEnaHOY+0GX0dPiXsyKgL 4+781+N6nP39s56cCM91y3SdFLa8zxO11l2YQElVeSpcKp7a4PdPfr1UcjOn/QwF T20xPFVP3+x//JTCx88ozHTNWMqwxghU0Q/+6DZKEbMm8qGuKN+JMhFIZ/ik2zzh 15cNLDsRklORkiHtOI9Stp+9edH5OYNNTcdIERLuZVY+ZkvdZs8DB8C7qN59zl5P Rt2Q1cCJta3g88/Ux0i1FLwwCZncuMgY0LrRynBRI2qisj4gG5tnAruuvjqgsQuc 8JXEuBQJ3YiIS2/mspH+gb+8rLcW/WARD+YXUpL8K9ouwGtbb+++ObHUR7mHK25a ACG3k3jC/FD7dh3vlKUZYzO/LKIY5XR3wBgAHRmkbuipCokuAQqFSBV+A6+fl76v yhCudXmIDm2Et7s3twdI =c1XU -----END PGP SIGNATURE----- --8JVlc08lMQIxjcXumooJ0a2QmD89obkxg-- From unknown Tue Jun 24 17:25:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2014 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel Colascione , Eli Zaretskii Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.140096993216962 (code B ref 17510); Sat, 24 May 2014 22:19:02 +0000 Received: (at 17510) by debbugs.gnu.org; 24 May 2014 22:18:52 +0000 Received: from localhost ([127.0.0.1]:59446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoKHD-0004PW-SL for submit@debbugs.gnu.org; Sat, 24 May 2014 18:18:52 -0400 Received: from limerock04.mail.cornell.edu ([128.84.12.60]:33782) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoKH9-0004Ow-Al for 17510@debbugs.gnu.org; Sat, 24 May 2014 18:18:48 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4OMIY3o004673; Sat, 24 May 2014 18:18:35 -0400 Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4OMIX9R029309 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 24 May 2014 18:18:34 -0400 Message-ID: <53811AC7.7060809@cornell.edu> Date: Sat, 24 May 2014 18:18:47 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> <537A5AB4.8070602@cornell.edu> <538092B6.9000807@cornell.edu> <5380F2FA.1080007@dancol.org> In-Reply-To: <5380F2FA.1080007@dancol.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 5/24/2014 3:28 PM, Daniel Colascione wrote: > On 05/24/2014 05:38 AM, Ken Brown wrote: >> On 5/19/2014 3:25 PM, Ken Brown wrote: >>> On 5/19/2014 12:46 PM, Eli Zaretskii wrote: >>>> I guess it's OK for the branch, thanks. But it strikes me that simply >>>> replacing the car of dpyinfo->name_list_element by something like >>>> "!!!DELETED DISPLAY!!!", or even just an empty string, would serve the >>>> same purpose, and save us the nuisance of an additional list in >>>> cygw32_display_name_list. After all, all you need is to mark a >>>> display deleted without actually deleting it, right? IOW, the main >>>> problem is in x_delete_display, and all the rest is just the overhead >>>> you needed to fix that, correct? >>> >>> I think that's correct, and I agree that there should be a much simpler >>> fix. I'll have to look into the code and try to understand better >>> exactly what happens when emacs is started as a daemon and then a client >>> frame is opened and closed. >> >> My guess as to the cause of this bug was completely wrong. What happens >> in my recipe is that the pointer dpyinfo->w32_id_name is freed twice. >> (This is done in x_delete_display each time the only existing client >> frame is deleted.) An attempt to create a client frame for the third >> time then leads to a crash because of malloc corruption. > > Thanks for finding that. I wonder whether this double-free also has > something to do with random crashes people have been seeing in 64-bit > Cygwin cygw32 Emacs builds. I doubt it, because this double-free occurs in both 64-bit and 32-bit Cygwin. Also, I think it can only be triggered by running emacs as a daemon, and none of the people reporting crashes mentioned doing that. Ken From unknown Tue Jun 24 17:25:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ken Brown Subject: bug#17510: closed (Re: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build) Message-ID: References: <53811ACD.6030100@cornell.edu> <53764FD9.8090600@cornell.edu> X-Gnu-PR-Message: they-closed 17510 X-Gnu-PR-Package: emacs Reply-To: 17510@debbugs.gnu.org Date: Sat, 24 May 2014 22:19:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1400969944-17000-1" This is a multi-part message in MIME format... ------------=_1400969944-17000-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17510@debbugs.gnu.org. --=20 17510: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17510 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1400969944-17000-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17510-done) by debbugs.gnu.org; 24 May 2014 22:18:48 +0000 Received: from localhost ([127.0.0.1]:59444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoKHA-0004PI-I7 for submit@debbugs.gnu.org; Sat, 24 May 2014 18:18:48 -0400 Received: from limerock03.mail.cornell.edu ([128.84.12.34]:58484) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoKH8-0004Ou-9q for 17510-done@debbugs.gnu.org; Sat, 24 May 2014 18:18:47 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4OMIeth027425 for <17510-done@debbugs.gnu.org>; Sat, 24 May 2014 18:18:40 -0400 Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4OMIdKa029342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for <17510-done@debbugs.gnu.org>; Sat, 24 May 2014 18:18:40 -0400 Message-ID: <53811ACD.6030100@cornell.edu> Date: Sat, 24 May 2014 18:18:53 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 Subject: Re: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> <837g5hd8cf.fsf@gnu.org> <537A5AB4.8070602@cornell.edu> <538092B6.9000807@cornell.edu> <83sinzjpt0.fsf@gnu.org> <5380E172.8090004@cornell.edu> In-Reply-To: <5380E172.8090004@cornell.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 17510-done Cc: 17510-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.6 (/) Version: 24.4 Closing. ------------=_1400969944-17000-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 May 2014 17:51:01 +0000 Received: from localhost ([127.0.0.1]:37543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlMHb-0000yu-Uj for submit@debbugs.gnu.org; Fri, 16 May 2014 13:51:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34994) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WlMHY-0000ya-UN for submit@debbugs.gnu.org; Fri, 16 May 2014 13:50:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlMHM-00085J-Gb for submit@debbugs.gnu.org; Fri, 16 May 2014 13:50:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlMHM-000850-9Y for submit@debbugs.gnu.org; Fri, 16 May 2014 13:50:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlMHG-0004nd-1m for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 13:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlMH9-00082h-Qf for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 13:50:37 -0400 Received: from limerock03.mail.cornell.edu ([128.84.12.34]:40123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlMH9-0007zc-M4 for bug-gnu-emacs@gnu.org; Fri, 16 May 2014 13:50:31 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id s4GHoFHM015969 for ; Fri, 16 May 2014 13:50:15 -0400 Received: from [128.84.234.164] (dijon.math.cornell.edu [128.84.234.164]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id s4GHoEPY001167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 16 May 2014 13:50:15 -0400 Message-ID: <53764FD9.8090600@cornell.edu> Date: Fri, 16 May 2014 13:50:17 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.3.91; Problem with `emacs --daemon' in cygw32 build Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) This bug was reported in the Cygwin mailing list: https://cygwin.com/ml/cygwin/2014-05/msg00303.html In a Cygwin terminal, do the following, where "emacs" denotes the cygw32 build of emacs (--with-w32). 1. $ emacs --daemon -Q 2. $ emacsclient -c 3. `C-x 5 0' in the client window to exit the frame. 4. Repeat steps 2 and 3. 5. Attempt to carry out steps 2 and 3 a third time. The message "Waiting for Emacs..." appears in the terminal, but no new frame opens. This problem is specific to the cygw32 build; it does not happen with the X11 build of emacs on Cygwin. It also doesn't happen if the server is started via `M-x server-start' in an existing emacs. In GNU Emacs 24.3.91.1 (x86_64-unknown-cygwin) of 2014-05-16 on desktop-new Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --srcdir=/home/kbrown/src/cygemacs/emacs-24.3.91-1.x86_64/src/emacs-24.3.91 --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --libexecdir=/usr/libexec --datadir=/usr/share --localstatedir=/var --sysconfdir=/etc --libdir=/usr/lib --datarootdir=/usr/share --docdir=/usr/share/doc/emacs --htmldir=/usr/share/doc/emacs/html -C --with-w32 'CFLAGS=-ggdb -O2 -pipe -Wimplicit-function-declaration -O0 -fdebug-prefix-map=/home/kbrown/src/cygemacs/emacs-24.3.91-1.x86_64/build=/usr/src/debug/emacs-24.3.91-1 -fdebug-prefix-map=/home/kbrown/src/cygemacs/emacs-24.3.91-1.x86_64/src/emacs-24.3.91=/usr/src/debug/emacs-24.3.91-1' CPPFLAGS= LDFLAGS=-Wl,--stack,0x400000' Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix ------------=_1400969944-17000-1--