GNU bug report logs - #17488
24.3; mail-sendmail-undelimit-header doesn't respect mail-header-separator

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17488 in the body.
You can then email your comments to 17488 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Cc: Russ Allbery <eagle <at> eyrie.org>
Subject: 24.3;
 mail-sendmail-undelimit-header doesn't respect mail-header-separator
Date: Wed, 14 May 2014 10:28:41 +0900

Hi,

This is probably a rare case, so I'm not sure if it's worth
fixing, though.  If one sets `mail-header-separator' to

"                                       ."

it causes a mail corruption.  It is because `rfc822-goto-eoh'
doesn't respect `mail-header-separator' and the first line of
a message body, rather than the separator, is deleted.

`smtpmail-send-it' and `mailclient-send-it' use it by way of
`mail-sendmail-undelimit-header'.  And `sendmail-send-it' uses
it by way of `mail-header-end'.

Thanks.

Message #8 received at 17488 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: Russ Allbery <eagle <at> eyrie.org>, 17488 <at> debbugs.gnu.org
Subject: Re: bug#17488: 24.3;
 mail-sendmail-undelimit-header doesn't respect mail-header-separator
Date: Sun, 15 Apr 2018 20:09:45 +0200

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> This is probably a rare case, so I'm not sure if it's worth
> fixing, though.  If one sets `mail-header-separator' to
>
> "                                       ."
>
> it causes a mail corruption.  It is because `rfc822-goto-eoh'
> doesn't respect `mail-header-separator' and the first line of
> a message body, rather than the separator, is deleted.

Hm...  I think `rfc822-goto-eoh' does the right thing: It doesn't care
about `mail-header-separator', because that's a user setting for mail
composition buffers, not something that should be consulted after making
that buffer into an RFC2822 mail.

> `smtpmail-send-it' and `mailclient-send-it' use it by way of
> `mail-sendmail-undelimit-header'.  And `sendmail-send-it' uses
> it by way of `mail-header-end'.

So `mail-sendmail-undelimit-header' should consult that variable, I
think, instead of using `rfc822-goto-eoh'?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 17488 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Russ Allbery <eagle <at> eyrie.org>, 17488 <at> debbugs.gnu.org
Subject: Re: bug#17488: 24.3;
 mail-sendmail-undelimit-header doesn't respect mail-header-separator
Date: Mon, 16 Apr 2018 11:28:56 +0900

On Sun, 15 Apr 2018 20:09:45 +0200, Lars Ingebrigtsen wrote:
> Hm...  I think `rfc822-goto-eoh' does the right thing: It doesn't care
> about `mail-header-separator', because that's a user setting for mail
> composition buffers, not something that should be consulted after making
> that buffer into an RFC2822 mail.

I see.  It got obvious that `rfc822-goto-eoh' shouldn't respect
`mail-header-separator' after having understood what
`mail-sendmail-delimit-header' does --- it looks for *eoh* using
`rfc822-goto-eoh' and then inserts `mail-header-separator'.  So,
it's a function that converts an RFC2822 mail into the one usable
in a mail composition buffer.  Although there is no program that
uses `mail-sendmail-delimit-header' in Emacs.

>> `smtpmail-send-it' and `mailclient-send-it' use it by way of
>> `mail-sendmail-undelimit-header'.  And `sendmail-send-it' uses
>> it by way of `mail-header-end'.

> So `mail-sendmail-undelimit-header' should consult that variable, I
> think, instead of using `rfc822-goto-eoh'?

I think it will work, but I changed my mind.  That is,
`rfc822-goto-eoh' should be used with an RFC2822 mail, and a mail
composing software should replace the `mail-header-separator' with
an empty line before sending a mail to the `sendmail-function',
like Gnus does.

Regards,

Message #14 received at 17488 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: Russ Allbery <eagle <at> eyrie.org>, 17488 <at> debbugs.gnu.org
Subject: Re: bug#17488: 24.3;
 mail-sendmail-undelimit-header doesn't respect mail-header-separator
Date: Mon, 16 Apr 2018 13:52:41 +0200

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

>> So `mail-sendmail-undelimit-header' should consult that variable, I
>> think, instead of using `rfc822-goto-eoh'?
>
> I think it will work, but I changed my mind.  That is,
> `rfc822-goto-eoh' should be used with an RFC2822 mail, and a mail
> composing software should replace the `mail-header-separator' with
> an empty line before sending a mail to the `sendmail-function',
> like Gnus does.

Yes, they should, so `mail-sendmail-undelimit-header' will normally be a
function that does absolutely nothing (as it is today :-)).  So it
should either be removed, or adjusted to do what it says it does (i.e.,
find the delimited and remove it).  I'll do the latter, and we can
contemplate the former...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 17488 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Russ Allbery <eagle <at> eyrie.org>, 17488 <at> debbugs.gnu.org
Subject: Re: bug#17488: 24.3;
 mail-sendmail-undelimit-header doesn't respect mail-header-separator
Date: Tue, 17 Apr 2018 15:26:18 +0900

On Mon, 16 Apr 2018 13:42:02 -0400, Lars Ingebrigtsen wrote:
> branch: scratch/prop-search
> commit e1a0cbbcf8389c76f67048e69139b5b0adf2cf38
> Author: Lars Ingebrigtsen <larsi <at> gnus.org>
> Commit: Lars Ingebrigtsen <larsi <at> gnus.org>

>     Make mail-sendmail-undelimit-header actually remove the delimiter

>     * lisp/mail/sendmail.el (mail-sendmail-undelimit-header): Actually
>     remove the mail header separator (bug#17488).  In all the cases
>     where this is called, the separator will probably already have
>     been removed, so the only thing this does is place point at the
>     end of the headers.

This change caused the following error:

Debugger entered--Lisp error: (search-failed "^--text follows this line--\n")
  re-search-forward("^--text follows this line--\n")
  mail-sendmail-undelimit-header()
  smtpmail-send-it()
  message-smtpmail-send-it()

So, I've added ``nil t'' to the re-search form.  ;-)

Message #24 received at 17488 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: Russ Allbery <eagle <at> eyrie.org>, 17488 <at> debbugs.gnu.org
Subject: Re: bug#17488: 24.3;
 mail-sendmail-undelimit-header doesn't respect mail-header-separator
Date: Tue, 17 Apr 2018 13:46:37 +0200

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> So, I've added ``nil t'' to the re-search form.  ;-)

Thanks!  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.