GNU bug report logs - #17485
(srfi srfi-1) reduce-right does not scale, version 2.0.9

Previous Next

Full log

View this message in rfc822 format

From: Mark H Weaver <mhw <at> netris.org>
To: David Kastrup <dak <at> gnu.org>
Cc: 17485 <at> debbugs.gnu.org
Subject: bug#17485: [PATCH 2/3] Rewrite take-right, drop-right, drop-right!
Date: Sat, 20 Sep 2014 10:56:12 -0400

David Kastrup <dak <at> gnu.org> writes:

> * module/srfi/srfi-1.scm (take-right, drop-right, drop-right!): The
>   definitions tended to be overly complicate and/or rely on pushing
>   material on the VM stack, detrimental to scalability for Guile 2.0 and
>   also worse for performance.
>
>   The changed definitions lead to different, more accurate exceptions
>   being raised.  They rely on length+ returning the length of dotted
>   lists, behavior that is not specified by the SRFI-1 definition but
>   available in GUILE.

Your patches look good to me, except that we can't change 'length+' as
you propose.  Instead I'd like to add a lax variant of 'length+' with a
different name, and use that.

I can take care of doing this myself, and will of course still credit
you in whatever manner you prefer, but I've run into a legal problem: we
don't currently have copyright papers for you on file.  Are you willing
to file copyright papers for GUILE?

      Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.