From unknown Sun Jun 22 00:15:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17481: Mini bug with option --exclude-dir Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Mon, 12 May 2014 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17481 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: ksz@cs.toronto.edu, 17481@debbugs.gnu.org X-Debbugs-Original-To: Khaled Ziyaeen , bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13999276348291 (code B ref -1); Mon, 12 May 2014 20:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 May 2014 20:47:14 +0000 Received: from localhost ([127.0.0.1]:32944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wjx7x-00029e-6P for submit@debbugs.gnu.org; Mon, 12 May 2014 16:47:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52599) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wjx7t-00029O-Vk for submit@debbugs.gnu.org; Mon, 12 May 2014 16:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjx7f-0004Ay-1h for submit@debbugs.gnu.org; Mon, 12 May 2014 16:47:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjx7e-0004Au-Vo for submit@debbugs.gnu.org; Mon, 12 May 2014 16:46:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjx7X-0008NB-HG for bug-grep@gnu.org; Mon, 12 May 2014 16:46:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjx7P-00044U-9y for bug-grep@gnu.org; Mon, 12 May 2014 16:46:47 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:58709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjx7P-000445-4a for bug-grep@gnu.org; Mon, 12 May 2014 16:46:39 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id DAEC539E80BC; Mon, 12 May 2014 13:46:37 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zlpRIbZfH20y; Mon, 12 May 2014 13:46:31 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 90B2939E80BE; Mon, 12 May 2014 13:46:31 -0700 (PDT) Message-ID: <53713327.3090506@cs.ucla.edu> Date: Mon, 12 May 2014 13:46:31 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Severity: minor Thanks for the bug report. Unfortunately we didn't have enough time to get to this before the next grep release, but is a reasonable thing to do so I'll resend this to bug-grep so that it gets a proper bug report number (we're using a new bug-reporting system). On 06/06/2013 08:48 AM, Khaled Ziyaeen wrote: > Hello, > > I would like to report a bug in the implementation of the --exclude-dir > option in GNU grep 2.10 version. > > If running > grep --exclude-dir "/hdd1/lib/udev/devices/" -r eads /hdd1 > > It will still examine /hdd1/lib/udev/devices. > > However, if running > grep --exclude-dir "/hdd1/lib/udev/devices" -r eads > /hdd1 > > Then, that folder I wanted to include is actually ignored. I think that the > extra slash at the end, while unnecessary, must not break down the > ---exclude-dir feature. > > Happy to help fix the bug! > > Best, > > Khaled. From unknown Sun Jun 22 00:15:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#17481: closed (Re: Mini bug with option --exclude-dir) Message-ID: References: <53810AFA.3010006@cs.ucla.edu> <53713327.3090506@cs.ucla.edu> X-Gnu-PR-Message: they-closed 17481 X-Gnu-PR-Package: grep Reply-To: 17481@debbugs.gnu.org Date: Sat, 24 May 2014 21:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1400965922-4191-1" This is a multi-part message in MIME format... ------------=_1400965922-4191-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17481: Mini bug with option --exclude-dir which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17481@debbugs.gnu.org. --=20 17481: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17481 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1400965922-4191-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17481-done) by debbugs.gnu.org; 24 May 2014 21:11:36 +0000 Received: from localhost ([127.0.0.1]:59406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoJE7-00014o-UO for submit@debbugs.gnu.org; Sat, 24 May 2014 17:11:36 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:54142) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoJE4-00014X-J6 for 17481-done@debbugs.gnu.org; Sat, 24 May 2014 17:11:33 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id EB34FA6000F; Sat, 24 May 2014 14:11:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lQEWVwtf30Zy; Sat, 24 May 2014 14:11:22 -0700 (PDT) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9C01CA60002; Sat, 24 May 2014 14:11:22 -0700 (PDT) Message-ID: <53810AFA.3010006@cs.ucla.edu> Date: Sat, 24 May 2014 14:11:22 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Khaled Ziyaeen Subject: Re: Mini bug with option --exclude-dir Content-Type: multipart/mixed; boundary="------------020008030305070306010307" X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 17481-done Cc: 17481-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) This is a multi-part message in MIME format. --------------020008030305070306010307 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I pushed the attached patch to fix this. Thanks again for reporting the problem. --------------020008030305070306010307 Content-Type: text/plain; charset=UTF-8; name="0001-grep-exclude-dir-FOO-now-ignores-the-trailing-slash.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-grep-exclude-dir-FOO-now-ignores-the-trailing-slash.pat"; filename*1="ch" RnJvbSBhYTE3ODgyNDI1Yzg4MmNlODE0MmY1ZjE1ODgwYWEyMzhjMWZhODU1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDI0IE1heSAyMDE0IDE0OjA2OjI5IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZ3JlcDogLS1leGNsdWRlLWRpcj1GT08vIG5vdyBpZ25vcmVzIHRoZSB0cmFpbGluZyBz bGFzaAoKUHJvYmxlbSByZXBvcnRlZCBieSBLaGFsZWQgWml5YWVlbjsgc2VlOiBodHRwOi8v YnVncy5nbnUub3JnLzE3NDgxCiogTkVXUywgZG9jL2dyZXAudGV4aSAoRmlsZSBhbmQgRGly ZWN0b3J5IFNlbGVjdGlvbik6IERvY3VtZW50IHRoaXMuCiogc3JjL2dyZXAuYyAobWFpbik6 IEltcGxlbWVudCB0aGlzLgoqIHRlc3RzL2luY2x1ZGUtZXhjbHVkZTogVGVzdCB0aGlzLgot LS0KIE5FV1MgICAgICAgICAgICAgICAgICB8IDUgKysrKysKIGRvYy9ncmVwLnRleGkgICAg ICAgICB8IDQgKystLQogc3JjL2dyZXAuYyAgICAgICAgICAgIHwgMSArCiB0ZXN0cy9pbmNs dWRlLWV4Y2x1ZGUgfCA0ICsrKysKIDQgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCBiZjMx OTQwLi4xMGIyZDE5IDEwMDY0NAotLS0gYS9ORVdTCisrKyBiL05FV1MKQEAgLTIsNiArMiwx MSBAQCBHTlUgZ3JlcCBORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LSotIG91dGxpbmUgLSotCiAKICogTm90ZXdvcnRoeSBjaGFuZ2VzIGluIHJlbGVhc2UgPy4/ ICg/Pz8/LT8/LT8/KSBbP10KIAorKiogQ2hhbmdlcyBpbiBiZWhhdmlvcgorCisgIGdyZXAg LS1leGNsdWRlLWRpcj0nRk9PLycgbm93IGV4Y2x1ZGVzIHRoZSBkaXJlY3RvcnkgRk9PLgor ICBQcmV2aW91c2x5LCB0aGUgdHJhaWxpbmcgc2xhc2ggbWVhbnQgdGhlIG9wdGlvbiB3YXMg aW5lZmZlY3RpdmUuCisKIAogKiBOb3Rld29ydGh5IGNoYW5nZXMgaW4gcmVsZWFzZSAyLjE5 ICgyMDE0LTA1LTIyKSBbc3RhYmxlXQogCmRpZmYgLS1naXQgYS9kb2MvZ3JlcC50ZXhpIGIv ZG9jL2dyZXAudGV4aQppbmRleCBmZWVlMGQ4Li5jOTQxN2U1IDEwMDY0NAotLS0gYS9kb2Mv Z3JlcC50ZXhpCisrKyBiL2RvYy9ncmVwLnRleGkKQEAgLTY2OCw4ICs2NjgsOCBAQCB1bmRl ciBAb3B0aW9uey0tZXhjbHVkZX0pLgogQGl0ZW0gLS1leGNsdWRlLWRpcj1AdmFye2Rpcn0K IEBvcGluZGV4IC0tZXhjbHVkZS1kaXIKIEBjaW5kZXggZXhjbHVkZSBkaXJlY3Rvcmllcwot RXhjbHVkZSBkaXJlY3RvcmllcyBtYXRjaGluZyB0aGUgcGF0dGVybiBAdmFye2Rpcn0gZnJv bSByZWN1cnNpdmUKLWRpcmVjdG9yeSBzZWFyY2hlcy4KK1NraXAgYW55IGRpcmVjdG9yeSB3 aG9zZSBuYW1lIG1hdGNoZXMgdGhlIHBhdHRlcm4gQHZhcntkaXJ9LCBpZ25vcmluZworYW55 IHJlZHVuZGFudCB0cmFpbGluZyBzbGFzaGVzIGluIEB2YXJ7ZGlyfS4KIAogQGl0ZW0gLUkK IFByb2Nlc3MgYSBiaW5hcnkgZmlsZSBhcyBpZiBpdCBkaWQgbm90IGNvbnRhaW4gbWF0Y2hp bmcgZGF0YTsKZGlmZiAtLWdpdCBhL3NyYy9ncmVwLmMgYi9zcmMvZ3JlcC5jCmluZGV4IGVj OTU1ZDguLjZhMmEwMjkgMTAwNjQ0Ci0tLSBhL3NyYy9ncmVwLmMKKysrIGIvc3JjL2dyZXAu YwpAQCAtMjIzNCw2ICsyMjM0LDcgQEAgbWFpbiAoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQog ICAgICAgY2FzZSBFWENMVURFX0RJUkVDVE9SWV9PUFRJT046CiAgICAgICAgIGlmICghZXhj bHVkZWRfZGlyZWN0b3J5X3BhdHRlcm5zKQogICAgICAgICAgIGV4Y2x1ZGVkX2RpcmVjdG9y eV9wYXR0ZXJucyA9IG5ld19leGNsdWRlICgpOworICAgICAgICBzdHJpcF90cmFpbGluZ19z bGFzaGVzIChvcHRhcmcpOwogICAgICAgICBhZGRfZXhjbHVkZSAoZXhjbHVkZWRfZGlyZWN0 b3J5X3BhdHRlcm5zLCBvcHRhcmcsIEVYQ0xVREVfV0lMRENBUkRTKTsKICAgICAgICAgYnJl YWs7CiAKZGlmZiAtLWdpdCBhL3Rlc3RzL2luY2x1ZGUtZXhjbHVkZSBiL3Rlc3RzL2luY2x1 ZGUtZXhjbHVkZQppbmRleCAyODQ2NWNiLi45YzA3MTM5IDEwMDc1NQotLS0gYS90ZXN0cy9p bmNsdWRlLWV4Y2x1ZGUKKysrIGIvdGVzdHMvaW5jbHVkZS1leGNsdWRlCkBAIC0zNiw2ICsz NiwxMCBAQCBncmVwIC1yIC0tZXhjbHVkZS1kaXI9ZGlyIC4geCA+IG91dCB8fCBmYWlsPTEK IHNvcnQgb3V0ID4gayAmJiBtdiBrIG91dAogY29tcGFyZSBleHAtbm90LWRpciBvdXQgfHwg ZmFpbD0xCiAKK2dyZXAgLXIgLS1leGNsdWRlLWRpcj1kaXIvIC4geCA+IG91dCB8fCBmYWls PTEKK3NvcnQgb3V0ID4gayAmJiBtdiBrIG91dAorY29tcGFyZSBleHAtbm90LWRpciBvdXQg fHwgZmFpbD0xCisKICMgVGVzdCB3aXRoIGEgbm9uLWdsb2IuCiBncmVwIC1yIC0taW5jbHVk ZT1hICAgIC4geCA+IG91dCB8fCBmYWlsPTEKICMgbm8gbmVlZCB0byBzb3J0Ci0tIAoxLjku MAoK --------------020008030305070306010307-- ------------=_1400965922-4191-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 May 2014 20:47:14 +0000 Received: from localhost ([127.0.0.1]:32944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wjx7x-00029e-6P for submit@debbugs.gnu.org; Mon, 12 May 2014 16:47:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52599) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wjx7t-00029O-Vk for submit@debbugs.gnu.org; Mon, 12 May 2014 16:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjx7f-0004Ay-1h for submit@debbugs.gnu.org; Mon, 12 May 2014 16:47:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjx7e-0004Au-Vo for submit@debbugs.gnu.org; Mon, 12 May 2014 16:46:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjx7X-0008NB-HG for bug-grep@gnu.org; Mon, 12 May 2014 16:46:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wjx7P-00044U-9y for bug-grep@gnu.org; Mon, 12 May 2014 16:46:47 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:58709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wjx7P-000445-4a for bug-grep@gnu.org; Mon, 12 May 2014 16:46:39 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id DAEC539E80BC; Mon, 12 May 2014 13:46:37 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zlpRIbZfH20y; Mon, 12 May 2014 13:46:31 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 90B2939E80BE; Mon, 12 May 2014 13:46:31 -0700 (PDT) Message-ID: <53713327.3090506@cs.ucla.edu> Date: Mon, 12 May 2014 13:46:31 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Khaled Ziyaeen , bug-grep@gnu.org Subject: Re: Mini bug with option --exclude-dir References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Severity: minor Thanks for the bug report. Unfortunately we didn't have enough time to get to this before the next grep release, but is a reasonable thing to do so I'll resend this to bug-grep so that it gets a proper bug report number (we're using a new bug-reporting system). On 06/06/2013 08:48 AM, Khaled Ziyaeen wrote: > Hello, > > I would like to report a bug in the implementation of the --exclude-dir > option in GNU grep 2.10 version. > > If running > grep --exclude-dir "/hdd1/lib/udev/devices/" -r eads /hdd1 > > It will still examine /hdd1/lib/udev/devices. > > However, if running > grep --exclude-dir "/hdd1/lib/udev/devices" -r eads > /hdd1 > > Then, that folder I wanted to include is actually ignored. I think that the > extra slash at the end, while unnecessary, must not break down the > ---exclude-dir feature. > > Happy to help fix the bug! > > Best, > > Khaled. ------------=_1400965922-4191-1--