From unknown Sun Jun 22 03:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings Resent-From: behoffski Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Mon, 12 May 2014 04:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17472 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: 17472@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139986730327804 (code B ref -1); Mon, 12 May 2014 04:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 May 2014 04:01:43 +0000 Received: from localhost ([127.0.0.1]:59973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WjhQs-0007EO-PD for submit@debbugs.gnu.org; Mon, 12 May 2014 00:01:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55711) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WjhQq-0007Dx-Eu for submit@debbugs.gnu.org; Mon, 12 May 2014 00:01:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjhQk-00047f-IP for submit@debbugs.gnu.org; Mon, 12 May 2014 00:01:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjhQk-00047a-Fp for submit@debbugs.gnu.org; Mon, 12 May 2014 00:01:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjhQj-0006D4-L2 for bug-grep@gnu.org; Mon, 12 May 2014 00:01:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjhQi-000472-OA for bug-grep@gnu.org; Mon, 12 May 2014 00:01:33 -0400 Received: from ipmail05.adl6.internode.on.net ([2001:44b8:8060:ff02:300:1:6:5]:16875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjhQi-00045j-Db for bug-grep@gnu.org; Mon, 12 May 2014 00:01:32 -0400 Received: from ppp121-45-76-128.lns20.adl6.internode.on.net (HELO [192.168.1.1]) ([121.45.76.128]) by ipmail05.adl6.internode.on.net with ESMTP; 12 May 2014 13:31:25 +0930 Message-ID: <53704794.2010404@grouse.com.au> Date: Mon, 12 May 2014 13:31:24 +0930 From: behoffski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040401000900050206040900" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------040401000900050206040900 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit A few months ago, "make syntax-check" would complain if any string that was subject to localisation started with an upper-case character. Almost all messages in Grep conform to this standard. However, "make syntax-check" no longer complains about two cases in the current master (dfa.c, function lex ()): dfaerror (_("Invalid content of \\{\\}")); dfaerror (_("Regular expression too big")); I don't know if this constraint is being relaxed, or if the check has changed somehow. (Is syntax-check provided via gnulib?) Attached is a simple patch that converts the two error strings above to have a lower-case first character. This may be useful to help maintain consistent message formatting. cheers, behoffski (Brenton Hoff) Programmer, Grouse Software --------------040401000900050206040900 Content-Type: text/x-patch; name="01-lowercase-lex-dfaerror-messages.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="01-lowercase-lex-dfaerror-messages.patch" >From 5ba304cbbdf89e736dfdd087613ba64e6dc32f50 Mon Sep 17 00:00:00 2001 From: behoffski Date: Mon, 12 May 2014 12:58:56 +0930 Subject: [PATCH] dfa.c (lex): Remove first-letter capitalisation of two dfaerror message strings. --- src/dfa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dfa.c b/src/dfa.c index 3c9cb75..2408278 100644 --- a/src/dfa.c +++ b/src/dfa.c @@ -1409,10 +1409,10 @@ lex (void) { if (syntax_bits & RE_INVALID_INTERVAL_ORD) goto normal_char; - dfaerror (_("Invalid content of \\{\\}")); + dfaerror (_("invalid content of \\{\\}")); } if (RE_DUP_MAX < maxrep) - dfaerror (_("Regular expression too big")); + dfaerror (_("regular expression too big")); lexptr = p; lexleft = lim - p; } -- 1.8.5.5 --------------040401000900050206040900-- From unknown Sun Jun 22 03:58:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Mon, 12 May 2014 06:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17472 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: behoffski Cc: 17472@debbugs.gnu.org Received: via spool by 17472-submit@debbugs.gnu.org id=B17472.139987518912284 (code B ref 17472); Mon, 12 May 2014 06:14:01 +0000 Received: (at 17472) by debbugs.gnu.org; 12 May 2014 06:13:09 +0000 Received: from localhost ([127.0.0.1]:60049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WjjU4-0003C3-Pq for submit@debbugs.gnu.org; Mon, 12 May 2014 02:13:09 -0400 Received: from mail-yk0-f182.google.com ([209.85.160.182]:46944) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WjjU2-0003BR-Hr for 17472@debbugs.gnu.org; Mon, 12 May 2014 02:13:07 -0400 Received: by mail-yk0-f182.google.com with SMTP id 9so5504307ykp.13 for <17472@debbugs.gnu.org>; Sun, 11 May 2014 23:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=b73ID5xjSj6EwOe/WP9AMdqg9kRHIif4/iO9a8UjNB8=; b=F+33s+YmBevYrIm56xmWXlTtU6Af3WNschl5aDnEgQd6EIULYhMlPsCZOhAR1FkPWV a6iJziIzq0ljNcFopjQCB4Eq5bUQEZu2r5qY76W+ECsvzvuobEfS+Uj57+oVmnypXHXS jfSvWQVSqOAZ1KWgeMw4R6y+bkXcISRCsOKE6e969Uh6snSfR43XflreqSzfxBLvg7tC WBIPvE+iHI1im4S5Hn5jh0cyRd5rPAp7KULtPU0sUBL/M+E9bM0sTYIXPNvaN25JM3u3 pxNTFNPh+q1FgzXnEnlZvSO2R3K1nK1FaVVrbyB3gJM7RU34EcNqHVEc0sN6cOorgcC9 JR5Q== X-Received: by 10.236.197.68 with SMTP id s44mr37449799yhn.109.1399875181054; Sun, 11 May 2014 23:13:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.127.18 with HTTP; Sun, 11 May 2014 23:12:39 -0700 (PDT) In-Reply-To: <53704794.2010404@grouse.com.au> References: <53704794.2010404@grouse.com.au> From: Jim Meyering Date: Sun, 11 May 2014 23:12:39 -0700 X-Google-Sender-Auth: vGfyrdKOH9G-W0P8gSrsJofVfoY Message-ID: Content-Type: multipart/mixed; boundary=20cf303f6a44e5a7db04f92dd606 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --20cf303f6a44e5a7db04f92dd606 Content-Type: text/plain; charset=ISO-8859-1 On Sun, May 11, 2014 at 9:01 PM, behoffski wrote: > A few months ago, "make syntax-check" would complain if any string that > was subject to localisation started with an upper-case character. > Almost all messages in Grep conform to this standard. However, > "make syntax-check" no longer complains about two cases in the current > master (dfa.c, function lex ()): > > dfaerror (_("Invalid content of \\{\\}")); > dfaerror (_("Regular expression too big")); > > I don't know if this constraint is being relaxed, or if the check has > changed somehow. (Is syntax-check provided via gnulib?) > > Attached is a simple patch that converts the two error strings above to > have a lower-case first character. This may be useful to help maintain > consistent message formatting. Thanks for the patch. That syntax-check rule does indeed come from gnulib, but it looks only at error-like functions whose names match /[^rp]error/. That hard-coded pattern would better be customizable. BTW, those strings were added in 2012. I've adjusted the commit message to be more consistent, and will defer pushing your change to master until after the release. Many translation teams have already updated strings for the release, so I'd rather not change translatable messages until after 2.19. --20cf303f6a44e5a7db04f92dd606 Content-Type: application/octet-stream; name="0001-maint-uncapitalize-first-letter-of-two-dfaerror-mess.patch" Content-Disposition: attachment; filename="0001-maint-uncapitalize-first-letter-of-two-dfaerror-mess.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hv3daf9e1 RnJvbSBiZjkxZmQ1ODMwMzJhY2M2Mzg1NGFhNjI0MmEyNDhmMWUyMTdlMDc5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBiZWhvZmZza2kgPGJlaG9mZnNraUBncm91c2UuY29tLmF1PgpE YXRlOiBNb24sIDEyIE1heSAyMDE0IDEyOjU4OjU2ICswOTMwClN1YmplY3Q6IFtQQVRDSF0gbWFp bnQ6IHVuY2FwaXRhbGl6ZSBmaXJzdCBsZXR0ZXIgb2YgdHdvIGRmYWVycm9yIG1lc3NhZ2UKIHN0 cmluZ3MKCiogZGZhLmMgKGxleCk6IE1ha2UgdHdvIG1lc3NhZ2Ugc3RyaW5ncyBjb25zaXN0ZW50 IHdpdGggYWxsIG9mCnRoZSBvdGhlcnM6IGRvIG5vdCBjYXBpdGFsaXplIHRoZSBmaXJzdCBsZXR0 ZXIgb2YgdGhlIGZpcnN0IHdvcmQuCi0tLQogc3JjL2RmYS5jIHwgNCArKy0tCiAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9k ZmEuYyBiL3NyYy9kZmEuYwppbmRleCAzYzljYjc1Li4yNDA4Mjc4IDEwMDY0NAotLS0gYS9zcmMv ZGZhLmMKKysrIGIvc3JjL2RmYS5jCkBAIC0xNDA5LDEwICsxNDA5LDEwIEBAIGxleCAodm9pZCkK ICAgICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIGlmIChzeW50YXhfYml0cyAmIFJFX0lO VkFMSURfSU5URVJWQUxfT1JEKQogICAgICAgICAgICAgICAgICAgZ290byBub3JtYWxfY2hhcjsK LSAgICAgICAgICAgICAgICBkZmFlcnJvciAoXygiSW52YWxpZCBjb250ZW50IG9mIFxce1xcfSIp KTsKKyAgICAgICAgICAgICAgICBkZmFlcnJvciAoXygiaW52YWxpZCBjb250ZW50IG9mIFxce1xc fSIpKTsKICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKFJFX0RVUF9NQVggPCBtYXhy ZXApCi0gICAgICAgICAgICAgIGRmYWVycm9yIChfKCJSZWd1bGFyIGV4cHJlc3Npb24gdG9vIGJp ZyIpKTsKKyAgICAgICAgICAgICAgZGZhZXJyb3IgKF8oInJlZ3VsYXIgZXhwcmVzc2lvbiB0b28g YmlnIikpOwogICAgICAgICAgICAgbGV4cHRyID0gcDsKICAgICAgICAgICAgIGxleGxlZnQgPSBs aW0gLSBwOwogICAgICAgICAgIH0KLS0gCjIuMC4wLnJjMwoK --20cf303f6a44e5a7db04f92dd606-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 12 16:25:35 2014 Received: (at control) by debbugs.gnu.org; 12 May 2014 20:25:35 +0000 Received: from localhost ([127.0.0.1]:32928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wjwmz-0000LC-P0 for submit@debbugs.gnu.org; Mon, 12 May 2014 16:25:34 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:38840) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wjwmw-0000Kt-KK for control@debbugs.gnu.org; Mon, 12 May 2014 16:25:31 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 3A83639E80BC for ; Mon, 12 May 2014 13:25:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NC9ozov88BZ2 for ; Mon, 12 May 2014 13:25:16 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id BDE7339E801D for ; Mon, 12 May 2014 13:25:16 -0700 (PDT) Message-ID: <53712E2C.9000902@cs.ucla.edu> Date: Mon, 12 May 2014 13:25:16 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: 17472 is minor Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) severity 17472 minor From unknown Sun Jun 22 03:58:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: behoffski Subject: bug#17472: closed (Re: bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings) Message-ID: References: <53704794.2010404@grouse.com.au> X-Gnu-PR-Message: they-closed 17472 X-Gnu-PR-Package: grep X-Gnu-PR-Keywords: patch Reply-To: 17472@debbugs.gnu.org Date: Sat, 24 May 2014 05:28:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1400909282-23382-1" This is a multi-part message in MIME format... ------------=_1400909282-23382-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17472: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17472@debbugs.gnu.org. --=20 17472: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17472 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1400909282-23382-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17472-done) by debbugs.gnu.org; 24 May 2014 05:27:40 +0000 Received: from localhost ([127.0.0.1]:58549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wo4Ud-00064I-J7 for submit@debbugs.gnu.org; Sat, 24 May 2014 01:27:39 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:41530) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wo4Ua-000641-Ih for 17472-done@debbugs.gnu.org; Sat, 24 May 2014 01:27:37 -0400 Received: by mail-wi0-f177.google.com with SMTP id f8so1802330wiw.4 for <17472-done@debbugs.gnu.org>; Fri, 23 May 2014 22:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=MiS2rJaEI+bLrPfxxgUts+cgy5xcIcUSIb/rGyvkMVo=; b=sZM+DYphfnnROnzZG2MWKJPnyCDhcViAzzIl209lbHl6i2ny8WdyGTI1TWDzYjzsUB Bu6axtOmZhrEapFljqRdB70YYP/0E0VLeSgBuZJUJruQcY0A533z6Y9AWV5aQrzhZWLj k49LtQSolf17CHeAC4j7Su19v4ytN68kGnbej0jf7jQofAoJ0+nV0w/AtieSqkmFBpM5 5DHZhSmETdscYen75Vb7yMjmEehrLnLgf+Qib86JUVxVn3M0QSHMjcrto/5XQEavN3rG wvOwe6M/0V41+gaV+wrjPX2fhS9sAiwZ3/8JMhDZhH1/rt9hTa1sMWQ1brH85AHqzUr0 6GOQ== X-Received: by 10.194.190.42 with SMTP id gn10mr9477992wjc.9.1400909250791; Fri, 23 May 2014 22:27:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Fri, 23 May 2014 22:27:10 -0700 (PDT) In-Reply-To: References: <53704794.2010404@grouse.com.au> From: Jim Meyering Date: Fri, 23 May 2014 22:27:10 -0700 X-Google-Sender-Auth: uguSf-vBDmFCE8YRVYP_SM_KS08 Message-ID: Subject: Re: bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings To: behoffski Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17472-done Cc: 17472-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, May 11, 2014 at 11:12 PM, Jim Meyering wrote: > On Sun, May 11, 2014 at 9:01 PM, behoffski wrote: >> A few months ago, "make syntax-check" would complain if any string that >> was subject to localisation started with an upper-case character. >> Almost all messages in Grep conform to this standard. However, >> "make syntax-check" no longer complains about two cases in the current >> master (dfa.c, function lex ()): >> >> dfaerror (_("Invalid content of \\{\\}")); >> dfaerror (_("Regular expression too big")); >> >> I don't know if this constraint is being relaxed, or if the check has >> changed somehow. (Is syntax-check provided via gnulib?) >> >> Attached is a simple patch that converts the two error strings above to >> have a lower-case first character. This may be useful to help maintain >> consistent message formatting. > > Thanks for the patch. > That syntax-check rule does indeed come from gnulib, but it > looks only at error-like functions whose names match /[^rp]error/. > That hard-coded pattern would better be customizable. > > BTW, those strings were added in 2012. > > I've adjusted the commit message to be more consistent, and will > defer pushing your change to master until after the release. > Many translation teams have already updated strings for the > release, so I'd rather not change translatable messages > until after 2.19. Pushed. ------------=_1400909282-23382-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 May 2014 04:01:43 +0000 Received: from localhost ([127.0.0.1]:59973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WjhQs-0007EO-PD for submit@debbugs.gnu.org; Mon, 12 May 2014 00:01:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55711) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WjhQq-0007Dx-Eu for submit@debbugs.gnu.org; Mon, 12 May 2014 00:01:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjhQk-00047f-IP for submit@debbugs.gnu.org; Mon, 12 May 2014 00:01:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjhQk-00047a-Fp for submit@debbugs.gnu.org; Mon, 12 May 2014 00:01:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjhQj-0006D4-L2 for bug-grep@gnu.org; Mon, 12 May 2014 00:01:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WjhQi-000472-OA for bug-grep@gnu.org; Mon, 12 May 2014 00:01:33 -0400 Received: from ipmail05.adl6.internode.on.net ([2001:44b8:8060:ff02:300:1:6:5]:16875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WjhQi-00045j-Db for bug-grep@gnu.org; Mon, 12 May 2014 00:01:32 -0400 Received: from ppp121-45-76-128.lns20.adl6.internode.on.net (HELO [192.168.1.1]) ([121.45.76.128]) by ipmail05.adl6.internode.on.net with ESMTP; 12 May 2014 13:31:25 +0930 Message-ID: <53704794.2010404@grouse.com.au> Date: Mon, 12 May 2014 13:31:24 +0930 From: behoffski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: bug-grep@gnu.org Subject: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings Content-Type: multipart/mixed; boundary="------------040401000900050206040900" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------040401000900050206040900 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit A few months ago, "make syntax-check" would complain if any string that was subject to localisation started with an upper-case character. Almost all messages in Grep conform to this standard. However, "make syntax-check" no longer complains about two cases in the current master (dfa.c, function lex ()): dfaerror (_("Invalid content of \\{\\}")); dfaerror (_("Regular expression too big")); I don't know if this constraint is being relaxed, or if the check has changed somehow. (Is syntax-check provided via gnulib?) Attached is a simple patch that converts the two error strings above to have a lower-case first character. This may be useful to help maintain consistent message formatting. cheers, behoffski (Brenton Hoff) Programmer, Grouse Software --------------040401000900050206040900 Content-Type: text/x-patch; name="01-lowercase-lex-dfaerror-messages.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="01-lowercase-lex-dfaerror-messages.patch" >From 5ba304cbbdf89e736dfdd087613ba64e6dc32f50 Mon Sep 17 00:00:00 2001 From: behoffski Date: Mon, 12 May 2014 12:58:56 +0930 Subject: [PATCH] dfa.c (lex): Remove first-letter capitalisation of two dfaerror message strings. --- src/dfa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dfa.c b/src/dfa.c index 3c9cb75..2408278 100644 --- a/src/dfa.c +++ b/src/dfa.c @@ -1409,10 +1409,10 @@ lex (void) { if (syntax_bits & RE_INVALID_INTERVAL_ORD) goto normal_char; - dfaerror (_("Invalid content of \\{\\}")); + dfaerror (_("invalid content of \\{\\}")); } if (RE_DUP_MAX < maxrep) - dfaerror (_("Regular expression too big")); + dfaerror (_("regular expression too big")); lexptr = p; lexleft = lim - p; } -- 1.8.5.5 --------------040401000900050206040900-- ------------=_1400909282-23382-1--