Subject: bug#17458: closed (Re: bug#17458: minor dfa.c suggestion)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 11 May 2014 03:17:02 +0000

Your bug report

#17458: minor dfa.c suggestion

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
17458: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17458
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#17458: minor dfa.c suggestion
From: Paul Eggert <[email-masked]>
To: Aharon Robbins <[email-masked]>, [email-masked]
Date: Sat, 10 May 2014 20:16:04 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

Aharon Robbins wrote:
> Since dfa.h now include <stdbool.h>, you don't need to do it in dfa.c

Thanks.  stddef.h too.  I pushed the attached patch.
From 140c401e6a73cc0d6e4febfdf29e6bb60212f230 Mon Sep 17 00:00:00 2001
From: Paul Eggert <[email-masked]>
Date: Sat, 10 May 2014 20:14:01 -0700
Subject: [PATCH] dfa: omit double includes

* src/dfa.c: Don't include stddef.h or stdbool.h, as dfa.h includes
them already, and it's the same module as we are.
Suggested by Aharon Robbins in: http://bugs.gnu.org/17458
---
 src/dfa.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/dfa.c b/src/dfa.c
index ba19a72..3c9cb75 100644
--- a/src/dfa.c
+++ b/src/dfa.c
@@ -27,12 +27,10 @@
 #include <assert.h>
 #include <ctype.h>
 #include <stdio.h>
-#include <stddef.h>
 #include <stdlib.h>
 #include <limits.h>
 #include <string.h>
 #include <locale.h>
-#include <stdbool.h>
 
 #define STREQ(a, b) (strcmp (a, b) == 0)
 
-- 
1.9.0

Subject: minor dfa.c suggestion
From: Aharon Robbins <[email-masked]>
To: [email-masked]
Date: Sun, 11 May 2014 06:06:10 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi guys.

Since dfa.h now include <stdbool.h>, you don't need to do it in dfa.c

Arnold