GNU bug report logs - #17446
24.4.50; What is the situation around `called-interactively-p'?

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Fri, 9 May 2014 12:31:01 UTC

Severity: wishlist

Found in version 24.4.50

Fixed in version 25.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log


Message #14 received at 17446 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 17446 <at> debbugs.gnu.org
Subject: Re: bug#17446: 24.4.50;
 What is the situation around `called-interactively-p'?
Date: Fri, 09 May 2014 10:15:01 -0400
> but as mentionned in `called-interactively-p' this is not working with
> code compiled (I use lexical-binding),

I don't know which "mention" you're thinking of here.
`called-interactively-p' is supposed to work (more or less as
well/poorly) in compiled code.

> thus `dont-compile' have been made obsolete.

It's not related.

> So what to do actually to fix such issues ?

Use an additional argument (you can call it `interactive'), provided by
the `interactive' spec?

> Do you plan to make something better around the terrible
> `called-interactively-p' ?

We have that already: the extra arg, as suggested in C-h
f called-interactively-p.

> It seems the only reason `dont-compile' have been made obsolete is
> to force people fixing their code to make it working compiled;

It's obsolete for the following reasons:
- I don't know of any use for it.
- I haven't seen a use of it yet.
- It seems to only make sense for ugly hacks.

> That's ok, but what to do when nothing else is possible ?

AFAIK something else is always possible and preferable.  But I don't
know enough about your problem to know that it's indeed also the case in
your situation.


        Stefan




This bug report was last modified 8 years and 123 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.