From juri@jurta.org Tue Dec 30 15:45:39 2008 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Dec 2008 23:45:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBUNjZJc021708 for ; Tue, 30 Dec 2008 15:45:37 -0800 Received: from mail.gnu.org ([199.232.76.166]:46190 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LHoGG-0002Wb-6l for emacs-pretest-bug@gnu.org; Tue, 30 Dec 2008 18:44:32 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LHoHF-0004W5-5q for emacs-pretest-bug@gnu.org; Tue, 30 Dec 2008 18:45:34 -0500 Received: from relay03.kiev.sovam.com ([62.64.120.201]:56988) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LHoHE-0004Vn-Q0 for emacs-pretest-bug@gnu.org; Tue, 30 Dec 2008 18:45:33 -0500 Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay03.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1LHoHC-000Dgk-76 for emacs-pretest-bug@gnu.org; Wed, 31 Dec 2008 01:45:30 +0200 From: Juri Linkov To: emacs-pretest-bug@gnu.org Subject: bug-reference-mode doesn't fontify when called from mode hook Organization: JURTA Date: Wed, 31 Dec 2008 01:44:21 +0200 Message-ID: <877i5hfctm.fsf@jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanner-Signature: 5389b9e13478507b5d7b23e4ed053241 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Trusted X-SpamTest-Info: Profiles 6624 [Dec 31 2008] X-SpamTest-Info: {received from trusted relay: common white list} X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: white ip list X-SpamTest-Rate: 10 X-SpamTest-Status: Trusted X-SpamTest-Status-Extended: trusted X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. With the following mode hook: (add-hook 'change-log-mode-hook 'bug-reference-mode) and a file local variable `bug-reference-url-format' in the ChangeLog file: ;; Local Variables: ;; bug-reference-url-format: "http://debbugs.gnu.org/cgi/bugreport.cgi?bug=%s" ;; End: bug references never get fontified because `bug-reference-mode' tests whether a variable `bug-reference-url-format' is non-nil before calling `(jit-lock-register #'bug-reference-fontify)' in `bug-reference-mode', and this variable is not yet set because it gets initialized later in `hack-local-variables' called after `set-auto-mode' in `normal-mode'. -- Juri Linkov http://www.jurta.org/emacs/ From rgm@gnu.org Thu Jan 8 17:49:45 2009 Received: (at 1744) by emacsbugs.donarmstrong.com; 9 Jan 2009 01:49:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n091ng1B031126 for <1744@emacsbugs.donarmstrong.com>; Thu, 8 Jan 2009 17:49:44 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LL6U8-0001Zg-BV; Thu, 08 Jan 2009 20:48:28 -0500 From: Glenn Morris To: Juri Linkov Cc: 1744@debbugs.gnu.org Subject: Re: bug#1744: bug-reference-mode doesn't fontify when called from mode hook References: <877i5hfctm.fsf@jurta.org> X-Spook: NORAD Israel bank cryptographic gamma Majic assassinate X-Ran: QsCS`qJ;J^}An&@hZ/:qCd45Y^Qa+!F9ke(Ze"8T[ X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 08 Jan 2009 20:48:28 -0500 In-Reply-To: <877i5hfctm.fsf@jurta.org> (Juri Linkov's message of "Wed, 31 Dec 2008 01:44:21 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Juri Linkov wrote: > (add-hook 'change-log-mode-hook 'bug-reference-mode) > > and a file local variable `bug-reference-url-format' > in the ChangeLog file: [...] > bug references never get fontified because `bug-reference-mode' tests > whether a variable `bug-reference-url-format' is non-nil before calling > `(jit-lock-register #'bug-reference-fontify)' in `bug-reference-mode', > and this variable is not yet set because it gets initialized later > in `hack-local-variables' called after `set-auto-mode' in `normal-mode'. This reminds me a bit of bug#347. How about something like this: *** bug-reference.el 5 Jan 2009 03:23:16 -0000 1.6 --- bug-reference.el 9 Jan 2009 01:47:30 -0000 *************** *** 114,121 **** "" nil (if bug-reference-mode (when bug-reference-url-format ! (jit-lock-register #'bug-reference-fontify)) (jit-lock-unregister #'bug-reference-fontify) (save-restriction (widen) --- 114,125 ---- "" nil (if bug-reference-mode + (progn + (let ((enable-local-variables :safe) + (enable-local-eval nil)) + (hack-local-variables)) (when bug-reference-url-format ! (jit-lock-register #'bug-reference-fontify))) (jit-lock-unregister #'bug-reference-fontify) (save-restriction (widen) From juri@jurta.org Sun Jan 11 16:59:14 2009 Received: (at 1744) by emacsbugs.donarmstrong.com; 12 Jan 2009 00:59:14 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from relay01.kiev.sovam.com (relay01.kiev.sovam.com [62.64.120.200]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0C0x6R8026859 for <1744@emacsbugs.donarmstrong.com>; Sun, 11 Jan 2009 16:59:07 -0800 Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1LMB9C-000G6Y-BL; Mon, 12 Jan 2009 02:59:18 +0200 From: Juri Linkov To: Glenn Morris Cc: 1744@debbugs.gnu.org Subject: Re: bug#1744: bug-reference-mode doesn't fontify when called from mode hook Organization: JURTA References: <877i5hfctm.fsf@jurta.org> Date: Mon, 12 Jan 2009 02:57:09 +0200 In-Reply-To: (Glenn Morris's message of "Thu, 08 Jan 2009 20:48:28 -0500") Message-ID: <871vv9jrmq.fsf@jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanner-Signature: b72b012eade34d4806fecc225a7d7ed8 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Trusted X-SpamTest-Info: Profiles 6713 [Jan 12 2009] X-SpamTest-Info: {received from trusted relay: common white list} X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: white ip list X-SpamTest-Rate: 10 X-SpamTest-Status: Trusted X-SpamTest-Status-Extended: trusted X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release > This reminds me a bit of bug#347. How about something like this: > > *** bug-reference.el 5 Jan 2009 03:23:16 -0000 1.6 > --- bug-reference.el 9 Jan 2009 01:47:30 -0000 > *************** > *** 114,121 **** > "" > nil > (if bug-reference-mode > (when bug-reference-url-format > ! (jit-lock-register #'bug-reference-fontify)) > (jit-lock-unregister #'bug-reference-fontify) > (save-restriction > (widen) > --- 114,125 ---- > "" > nil > (if bug-reference-mode > + (progn > + (let ((enable-local-variables :safe) > + (enable-local-eval nil)) > + (hack-local-variables)) I think it's a fairly brittle solution to deal with direct hacking of local variables. I propose a simpler solution that postpones checking for non-nil bug-reference-url-format in bug-reference-fontify that gets called after bug-reference-url-format is set from the local variables section. A good side of it is that even when bug-reference-url-format is still not specified for the moment of font-locking, bug numbers are still highlighted. I've verified that the following patch works also when `mode: bug-reference' is located before `bug-reference-url-format: "..."' in ChangeLog files: Index: lisp/progmodes/bug-reference.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/bug-reference.el,v retrieving revision 1.6 diff -u -w -b -r1.6 bug-reference.el --- lisp/progmodes/bug-reference.el 5 Jan 2009 03:23:16 -0000 1.6 +++ lisp/progmodes/bug-reference.el 12 Jan 2009 00:52:15 -0000 @@ -85,9 +85,11 @@ (let ((overlay (make-overlay (match-beginning 0) (match-end 0) nil t nil))) (overlay-put overlay 'category 'bug-reference) + ;; Don't put a link if format is undefined + (when bug-reference-url-format (overlay-put overlay 'bug-reference-url (format bug-reference-url-format - (match-string-no-properties 1))))))))) + (match-string-no-properties 1)))))))))) ;; Taken from button.el. (defun bug-reference-push-button (&optional pos use-mouse-action) @@ -108,14 +110,12 @@ ;;;###autoload (define-minor-mode bug-reference-mode - "Minor mode to buttonize bugzilla references in the current buffer. -Requires `bug-reference-url-format' to be set in the buffer." + "Minor mode to buttonize bugzilla references in the current buffer." nil "" nil (if bug-reference-mode - (when bug-reference-url-format - (jit-lock-register #'bug-reference-fontify)) + (jit-lock-register #'bug-reference-fontify) (jit-lock-unregister #'bug-reference-fontify) (save-restriction (widen) @@ -128,8 +128,7 @@ "" nil (if bug-reference-prog-mode - (when bug-reference-url-format - (jit-lock-register #'bug-reference-fontify)) + (jit-lock-register #'bug-reference-fontify) (jit-lock-unregister #'bug-reference-fontify) (save-restriction (widen) -- Juri Linkov http://www.jurta.org/emacs/ From rgm@gnu.org Sun Jan 11 17:37:36 2009 Received: (at 1744) by emacsbugs.donarmstrong.com; 12 Jan 2009 01:37:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0C1bXRr004914 for <1744@emacsbugs.donarmstrong.com>; Sun, 11 Jan 2009 17:37:34 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LMBix-0004Fu-GO; Sun, 11 Jan 2009 20:36:15 -0500 From: Glenn Morris To: Juri Linkov Cc: 1744@debbugs.gnu.org Subject: Re: bug#1744: bug-reference-mode doesn't fontify when called from mode hook References: <877i5hfctm.fsf@jurta.org> <871vv9jrmq.fsf@jurta.org> X-Spook: STARLAN Ft. Meade White Water NWO electronic surveillance X-Ran: WLRL9NySTHy^J;!kEOAze,x>O@{Th8P@uJ^Z!4(MlU]"^x!Vh!N X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sun, 11 Jan 2009 20:36:15 -0500 In-Reply-To: <871vv9jrmq.fsf@jurta.org> (Juri Linkov's message of "Mon, 12 Jan 2009 02:57:09 +0200") Message-ID: <6jhc45z4og.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Juri Linkov wrote: > I propose a simpler solution Fine by me. From monnier@iro.umontreal.ca Mon Jan 12 13:07:00 2009 Received: (at 1744) by emacsbugs.donarmstrong.com; 12 Jan 2009 21:07:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0CL6vqg013182 for <1744@emacsbugs.donarmstrong.com>; Mon, 12 Jan 2009 13:06:58 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEAJE/a0lMCpxj/2dsb2JhbACBbNF6hW+BbA X-IronPort-AV: E=Sophos;i="4.37,254,1231131600"; d="scan'208";a="32199939" Received: from 76-10-156-99.dsl.teksavvy.com (HELO pastel.home) ([76.10.156.99]) by ironport2-out.teksavvy.com with ESMTP; 12 Jan 2009 16:06:52 -0500 Received: by pastel.home (Postfix, from userid 20848) id B16E78440; Mon, 12 Jan 2009 16:06:51 -0500 (EST) From: Stefan Monnier To: Glenn Morris Cc: 1744@debbugs.gnu.org, Juri Linkov Subject: Re: bug#1744: bug-reference-mode doesn't fontify when called from mode hook Message-ID: References: <877i5hfctm.fsf@jurta.org> <871vv9jrmq.fsf@jurta.org> <6jhc45z4og.fsf@fencepost.gnu.org> Date: Mon, 12 Jan 2009 16:06:51 -0500 In-Reply-To: <6jhc45z4og.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 11 Jan 2009 20:36:15 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Juri Linkov wrote: >> I propose a simpler solution Yes, that's a good solution, thanks. Stefan From juri@jurta.org Tue Jan 13 16:45:04 2009 Received: (at 1744-done) by emacsbugs.donarmstrong.com; 14 Jan 2009 00:45:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from relay03.kiev.sovam.com (relay03.kiev.sovam.com [62.64.120.201]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0E0j0U1011090 for <1744-done@emacsbugs.donarmstrong.com>; Tue, 13 Jan 2009 16:45:01 -0800 Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay03.kiev.sovam.com with esmtp (Exim 4.69) (envelope-from ) id 1LMtsQ-000Q0Y-V8 for 1744-done@emacsbugs.donarmstrong.com; Wed, 14 Jan 2009 02:44:59 +0200 From: Juri Linkov To: 1744-done@debbugs.gnu.org Subject: Re: bug#1744: bug-reference-mode doesn't fontify when called from mode hook Organization: JURTA References: <877i5hfctm.fsf@jurta.org> <871vv9jrmq.fsf@jurta.org> <6jhc45z4og.fsf@fencepost.gnu.org> Date: Wed, 14 Jan 2009 02:44:32 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 12 Jan 2009 16:06:51 -0500") Message-ID: <87vdsiaf7z.fsf@jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanner-Signature: 59ad91030643e2e4d9f5816f5d310f8d X-DrWeb-checked: yes Fixed. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Sat Aug 16 16:10:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 Feb 2009 15:24:08 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator