GNU bug report logs - #17430
24.4.50; minibuffer history forgets the first entry

Previous Next

Package: emacs;

Reported by: Jarek Czekalski <jarekczek <at> poczta.onet.pl>

Date: Wed, 7 May 2014 11:09:02 UTC

Severity: normal

Merged with 17432

Found in version 24.4.50

Done: Jarek Czekalski <jarekczek <at> poczta.onet.pl>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 17430 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jarek Czekalski <jarekczek <at> poczta.onet.pl>
Cc: 17430 <at> debbugs.gnu.org
Subject: Re: bug#17430: 24.4.50; minibuffer history forgets the first entry
Date: Wed, 07 May 2014 09:55:57 -0400

> The history value is not properly initialized. Seems like r87775
> introduced a regression, because histval is not set to nil in minibuf.c.

Indeed, thanks.

> Stefan, could you review the patch? If I am to commit this, to which
> branch? emacs-24?

Looks good.  Please install on emacs-24.
But please also just initialize the variable directly in its
declaration, as in:

  Lisp_Object histval = find_symbol_value (Vminibuffer_history_variable);


-- Stefan
This bug report was last modified 11 years and 74 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.