GNU bug report logs - #17420
[PATCH] grep: always convert fgrep to grep

Previous Next

Full log

Message #8 received at 17420 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17420 <at> debbugs.gnu.org
Subject: Re: bug#17420: [PATCH] grep: always convert fgrep to grep
Date: Wed, 07 May 2014 00:00:18 -0700

[Message part 1 (text/plain, inline)]

Norihiro Tanaka wrote:
> By the way, if `FGREP_NO_DFA' env. is set, fgrep still uses fgrep matcher.

I'd rather not introduce another environment variable.  GREP_COLOR and 
GREP_COLORS and GREP_OPTIONS are now commonly considered to have been 
mistakes, and I'd rather not compound them.

Instead, how about removing the fgrep matcher entirely?  That'll make 
the code simpler and easier to maintain, which is a real plus.  Perhaps 
it'll be slower in a few cases, but as long as significant slowdowns are 
rare, that's OK.

Something like the attached patch, say.

[0001-grep-simplify-by-removing-Fexecute-kwsearch.c-etc.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.