GNU bug report logs - #17418
#:select gives access to private variables

Previous Next

Package: guile;

Reported by: ludo <at> gnu.org (Ludovic Courtès)

Date: Tue, 6 May 2014 08:49:02 UTC

Severity: normal

Done: Andy Wingo <wingo <at> pobox.com>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 17418 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 17418 <at> debbugs.gnu.org
Subject: Re: bug#17418: #:select gives access to private variables
Date: Tue, 03 Jun 2014 19:08:54 -0400
ludo <at> gnu.org (Ludovic Courtès) writes:

> Mark H Weaver <mhw <at> netris.org> skribis:
>
>> Perhaps we should consider making #:select issue a warning when it
>> imports private bindings,
>
> Yes, sounds like a good idea.

Sounds good.  Specifically, I guess we should deprecate this way of
using #:select.

If you do this, can you adjust system/repl/coop-server.scm to avoid it?
It imports the following private bindings:

  start-repl* run-server* add-open-socket! close-socket!

>> and also adding a mechanism to import private bindings without a
>> warning.
>
> I’m unsure about this.  Normally we don’t want to allow that, because
> that defeats the purpose of modules.

Fair enough.  Having mulled it over, I tend to agree that we should not
try to make this more convenient.

> OTOH, in practice we occasionally need this ability; I typically use
> @@ for that, but it’s not as nice as a real import.

I think asking people to use @@ is reasonable here.

    Thanks,
      Mark




This bug report was last modified 9 years and 64 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.