GNU bug report logs - #17416
insecure temp files in ob-screen.el

Previous Next

Full log

Message #12 received at 17416 <at> debbugs.gnu.org (full text, mbox):

From: Eric Schulte <schulte.eric <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 17416 <at> debbugs.gnu.org, Eric Schulte <schulte.eric <at> gmail.com>
Subject: Re: [O] bug#17416: insecure temp files in ob-screen.el
Date: Thu, 08 May 2014 12:20:23 -0600

Glenn Morris <rgm <at> gnu.org> writes:

> Eric Schulte wrote:
>
>>> org-babel-screen-session-write-temp-file and org-babel-screen-test seem
>>> to use predictable temp-file names, which is a security issue. Using
>>> `make-temp-file', or if the file names really need to be predictable,
>>> something equivalent to `doc-view-make-safe-dir' (there should really be
>>> a general utility function for this IMO) to first create a /tmp
>>> subdirectory would avoid this.
>>
>> I just pushed up a fix for this issue.  Thanks,
>
> If you mean
>
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=fea672d30ef4701721c0d4aa70462760a6b21be7
>
> then's there still org-babel-screen-test.
>

Fixed.

>
> (These are definitely fixes that need merging into the emacs-24 branch.
> IIUC this means they need to be in your maint branch?)

Cherrypicked into maint.

Thanks,

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.