From unknown Wed Jun 18 23:07:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17406 <17406@debbugs.gnu.org> To: bug#17406 <17406@debbugs.gnu.org> Subject: Status: C-g C-g in GC causes crash Reply-To: bug#17406 <17406@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:07:07 +0000 retitle 17406 C-g C-g in GC causes crash reassign 17406 emacs submitter 17406 rms@gnu.org severity 17406 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 05 03:00:22 2014 Received: (at submit) by debbugs.gnu.org; 5 May 2014 07:00:22 +0000 Received: from localhost ([127.0.0.1]:51223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WhCsv-0000bY-U9 for submit@debbugs.gnu.org; Mon, 05 May 2014 03:00:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42260) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WhCst-0000ay-Rz for submit@debbugs.gnu.org; Mon, 05 May 2014 03:00:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhCsj-0003OC-D8 for submit@debbugs.gnu.org; Mon, 05 May 2014 03:00:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,GAPPY_SUBJECT, RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhCsj-0003O1-Au for submit@debbugs.gnu.org; Mon, 05 May 2014 03:00:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhCsi-0001Ge-CC for bug-gnu-emacs@gnu.org; Mon, 05 May 2014 03:00:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhCsg-0003LX-MK for bug-gnu-emacs@gnu.org; Mon, 05 May 2014 03:00:08 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhCsg-0003LP-Jz for bug-gnu-emacs@gnu.org; Mon, 05 May 2014 03:00:06 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WhCsg-0007fm-5E; Mon, 05 May 2014 03:00:06 -0400 Date: Mon, 05 May 2014 03:00:06 -0400 Message-Id: Content-Type: text/plain; charset=ISO-8859-15 From: Richard Stallman To: bug-gnu-emacs@gnu.org Subject: C-g C-g in GC causes crash X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: rms@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] When GC starts taking a long time, I can easily type C-g C-g during a GC if I have garbage-collection-messages set. This stops Emacs as it should. When I continue it, it asks (correctly) if I want to abort and dump core. I say no, and then it crashes. A backtrace showed me why: tty_send_additional_strings calls Fterminal_parameter which calls Fassq which does QUIT; -- Dr Richard Stallman President, Free Software Foundation 51 Franklin St Boston MA 02110 USA www.fsf.org www.gnu.org Skype: No way! That's nonfree (freedom-denying) software. Use Ekiga or an ordinary phone call. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 15:37:19 2017 Received: (at control) by debbugs.gnu.org; 29 Aug 2017 19:37:19 +0000 Received: from localhost ([127.0.0.1]:32881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmmK7-0007KE-HU for submit@debbugs.gnu.org; Tue, 29 Aug 2017 15:37:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmmK5-0007K2-Fs for control@debbugs.gnu.org; Tue, 29 Aug 2017 15:37:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmmJz-0005Rw-JG for control@debbugs.gnu.org; Tue, 29 Aug 2017 15:37:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmmJz-0005Rq-Fi for control@debbugs.gnu.org; Tue, 29 Aug 2017 15:37:11 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dmmJz-0000aA-82 for control@debbugs.gnu.org; Tue, 29 Aug 2017 15:37:11 -0400 Subject: control message for bug 28279 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 29 Aug 2017 15:37:11 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 17406 28279 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 01:10:20 2017 Received: (at 17406) by debbugs.gnu.org; 18 Sep 2017 05:10:20 +0000 Received: from localhost ([127.0.0.1]:45479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtoK4-0004J4-AJ for submit@debbugs.gnu.org; Mon, 18 Sep 2017 01:10:20 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtoK2-0004Io-1g; Mon, 18 Sep 2017 01:10:18 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 49CA6160D41; Sun, 17 Sep 2017 22:10:11 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UACiW_yiZ6EX; Sun, 17 Sep 2017 22:10:10 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7A67F160D8D; Sun, 17 Sep 2017 22:10:10 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0J49WT-XSatU; Sun, 17 Sep 2017 22:10:10 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 52893160D41; Sun, 17 Sep 2017 22:10:10 -0700 (PDT) To: Eric Hoffman From: Paul Eggert Subject: Re: 25.2; repeatable crash when hitting C-g twice Organization: UCLA Computer Science Department Message-ID: <8dd2fcc7-c78f-f313-a9eb-cbe35344fe21@cs.ucla.edu> Date: Sun, 17 Sep 2017 22:10:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D8E6DDAD5EB4B2FC92F1EB0C" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 17406 Cc: 17406@debbugs.gnu.org, 28279@debbugs.gnu.org, Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------D8E6DDAD5EB4B2FC92F1EB0C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Eli's suggestion looks good. I tweaked his patch slightly to avoid some c= alls=20 and installed the attached into the emacs-26 branch to implement it. Plea= se give=20 it a try. --------------D8E6DDAD5EB4B2FC92F1EB0C Content-Type: text/x-patch; name="0001-Avoid-crash-with-C-g-C-g-in-GC.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Avoid-crash-with-C-g-C-g-in-GC.patch" =46rom e56681085ee0575358b2193d69dd1a3c2ecf3dee Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 17 Sep 2017 22:01:56 -0700 Subject: [PATCH] Avoid crash with C-g C-g in GC Problem reported by Richard Stallman (Bug#17406). Based on fix suggested by Eli Zaretskii (Bug#28279#16). * src/term.c (tty_send_additional_strings): Use only safe accessors, to avoid crash when C-g C-g in GC. --- src/term.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/term.c b/src/term.c index a2ae8c2..065bce4 100644 --- a/src/term.c +++ b/src/term.c @@ -155,12 +155,16 @@ tty_ring_bell (struct frame *f) static void tty_send_additional_strings (struct terminal *terminal, Lisp_Object sym)= { - Lisp_Object lisp_terminal; - Lisp_Object extra_codes; + /* Use only accessors like CDR_SAFE and assq_no_quit to avoid any + form of quitting or signaling an error, since this function can + run as part of the "emergency escape" procedure invoked in the + middle of GC, where quitting means crashing (Bug#17406). */ + if (! terminal->name) + return; struct tty_display_info *tty =3D terminal->display_info.tty; =20 - XSETTERMINAL (lisp_terminal, terminal); - for (extra_codes =3D Fterminal_parameter (lisp_terminal, sym); + for (Lisp_Object extra_codes + =3D CDR_SAFE (assq_no_quit (sym, terminal->param_alist)); CONSP (extra_codes); extra_codes =3D XCDR (extra_codes)) { --=20 2.7.4 --------------D8E6DDAD5EB4B2FC92F1EB0C-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 20 17:42:00 2017 Received: (at control) by debbugs.gnu.org; 20 Nov 2017 22:42:00 +0000 Received: from localhost ([127.0.0.1]:49623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGulL-0002uK-VJ for submit@debbugs.gnu.org; Mon, 20 Nov 2017 17:42:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGulK-0002u5-FY for control@debbugs.gnu.org; Mon, 20 Nov 2017 17:41:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGulE-0006C7-Nz for control@debbugs.gnu.org; Mon, 20 Nov 2017 17:41:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGulE-0006C1-L2 for control@debbugs.gnu.org; Mon, 20 Nov 2017 17:41:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eGulE-0000nS-FH for control@debbugs.gnu.org; Mon, 20 Nov 2017 17:41:52 -0500 Subject: control message for bug 28279 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 20 Nov 2017 17:41:52 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) # 059184e close 28279 26.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 20 17:44:06 2017 Received: (at control) by debbugs.gnu.org; 20 Nov 2017 22:44:06 +0000 Received: from localhost ([127.0.0.1]:49630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGunO-0002yi-AZ for submit@debbugs.gnu.org; Mon, 20 Nov 2017 17:44:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGunM-0002xz-D4 for control@debbugs.gnu.org; Mon, 20 Nov 2017 17:44:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGunG-00004z-MG for control@debbugs.gnu.org; Mon, 20 Nov 2017 17:43:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGunG-0008WT-Ia for control@debbugs.gnu.org; Mon, 20 Nov 2017 17:43:58 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eGunG-00013I-Cr for control@debbugs.gnu.org; Mon, 20 Nov 2017 17:43:58 -0500 Subject: control message for bug 17395 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 20 Nov 2017 17:43:58 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) forcemerge 17406 17395 From unknown Wed Jun 18 23:07:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Dec 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator