GNU bug report logs - #17393
24.4.50; [PATCH] diary Chinese support

Previous Next

Full log

View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 17393 <at> debbugs.gnu.org, William Xu <william.xwl <at> gmail.com>
Subject: bug#17393: 24.4.50; [PATCH] diary Chinese support
Date: Sat, 03 May 2014 14:39:21 -0400

Thanks. Please apply, with the necessary doc and NEWS updates.
Very minor comments below.

Leo Liu wrote:

> +(declare-function calendar-mark-1         "diary-lib")
> +(declare-function diary-mark-entries-1    "diary-lib")
> +(declare-function diary-list-entries-1    "diary-lib")
> +(declare-function diary-insert-entry-1    "diary-lib")
> +(declare-function diary-date-display-form "diary-lib")

The existing files use autoload.

> +(declare-function diary-anniversary       "diary-lib")

Unused?

> +Chinese date diary entries must be prefaced by `diary-chinese-entry-symbol'
> +\(normally an `C').

"a `C'".

> +;;;###cal-autoload
> +(defun diary-chinese-anniversary (month day &optional year mark)

Doc string please.

> +(defcustom diary-chinese-entry-symbol "C"
> +  "Symbol indicating a diary entry according to the Chinese calendar."
> +  :type 'string
> +  :group 'diary)

:version tag.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.