Subject: bug#17393: 24.4.50; [PATCH] diary Chinese support

From: Glenn Morris <[email-masked]>
Date: Sat, 03 May 2014 14:39:21 -0400

Thanks. Please apply, with the necessary doc and NEWS updates.
Very minor comments below.

Leo Liu wrote:

> +(declare-function calendar-mark-1         "diary-lib")
> +(declare-function diary-mark-entries-1    "diary-lib")
> +(declare-function diary-list-entries-1    "diary-lib")
> +(declare-function diary-insert-entry-1    "diary-lib")
> +(declare-function diary-date-display-form "diary-lib")

The existing files use autoload.

> +(declare-function diary-anniversary       "diary-lib")

Unused?

> +Chinese date diary entries must be prefaced by `diary-chinese-entry-symbol'
> +\(normally an `C').

"a `C'".

> +;;;###cal-autoload
> +(defun diary-chinese-anniversary (month day &optional year mark)

Doc string please.

> +(defcustom diary-chinese-entry-symbol "C"
> +  "Symbol indicating a diary entry according to the Chinese calendar."
> +  :type 'string
> +  :group 'diary)

:version tag.