GNU bug report logs - #1739
[Toby Speight] Broken host regexps in generic-x

Previous Next

Full log

View this message in rfc822 format

From: Sven Joachim <svenjoac <at> gmx.de>
To: bug-gnu-emacs <at> gnu.org
Subject: bug#1739: [Toby Speight] Broken host regexps in generic-x
Date: Tue, 30 Dec 2008 09:51:15 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

Another old bug in Debian's BTS, this time with a patch.  The patch
doesn't apply anymore, but it was easy for me to create a new one:

--8<---------------cut here---------------start------------->8---
--- generic-x.el.~1.55.~	2008-10-04 05:11:46.000000000 +0200
+++ generic-x.el	2008-12-30 09:45:00.000000000 +0100
@@ -376,7 +376,7 @@
 (define-generic-mode hosts-generic-mode
   '(?#)
   '("localhost")
-  '(("\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 font-lock-constant-face))
+  '(("\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 font-lock-constant-face))
   '("[hH][oO][sS][tT][sS]\\'")
   nil
   "Generic mode for HOSTS files."))
@@ -1811,7 +1811,7 @@
   '("cache" "primary" "secondary" "forwarders" "limit" "options"
     "directory" "check-names")
   ;; List of additional font-lock-expressions
-  '(("\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 font-lock-constant-face)
+  '(("\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 font-lock-constant-face)
     ("^directory\\s-+\\(.*\\)"              1 font-lock-variable-name-face)
     ("^\\(primary\\|cache\\)\\s-+\\([.A-Za-z]+\\)\\s-+\\(.*\\)"
      (2 font-lock-variable-name-face)
@@ -1829,7 +1829,7 @@
   ;; List of keywords
   '("IN" "NS" "CNAME" "SOA" "PTR" "MX" "A")
   ;; List of additional font-lock-expressions
-  '(("\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 font-lock-constant-face)
+  '(("\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 font-lock-constant-face)
     ("^\\([.A-Za-z0-9]+\\)"                 1 font-lock-variable-name-face))
   ;; List of additional auto-mode-alist expressions
   nil
--8<---------------cut here---------------end--------------->8---

[Message part 2 (message/rfc822, inline)]

From: Toby Speight <streapadair <at> gmx.net>
To: Debian Bug Tracking System <submit <at> bugs.debian.org>
Subject: Bug#239344: emacs21-common: Broken host regexps in generic-x
Date: Mon, 22 Mar 2004 12:01:56 +0000

[Message part 3 (text/plain, inline)]

Package: emacs21-common
Version: 21.3+1-4
Severity: normal
Tags: patch
File: /usr/share/emacs/21.3/lisp/generic-x.el

Some of the regexps in generic-x have only single backslashes to
escape '.' characters - the result being that they match any
character, including '.' - see patch:

[generic-x.diff (text/x-patch, inline)]

--- /usr/share/emacs/21.3/lisp/generic-x.el	2003-10-31 18:30:36.000000000 +0000
+++ generic-x.el	2004-03-22 11:55:06.000000000 +0000
@@ -258,7 +258,7 @@
 (define-generic-mode 'hosts-generic-mode
    (list ?#)
    (list "localhost")
-   '(("\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 'font-lock-constant-face))
+   '(("\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 'font-lock-constant-face))
    (list "[hH][oO][sS][tT][sS]\\'")
    nil
    "Generic mode for HOSTS files."))
@@ -1681,7 +1681,7 @@
         "directory" "check-names")
   ;;List of additional font-lock-expressions
   (list
-   (list "\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 'font-lock-constant-face)
+   (list "\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 'font-lock-constant-face)
    (list "^directory\\s-+\\(.*\\)" 1 'font-lock-variable-name-face)
    (list "^\\(primary\\|cache\\)\\s-+\\([.A-Za-z]+\\)\\s-+\\(.*\\)"
          (list 2 'font-lock-variable-name-face)
@@ -1700,7 +1700,7 @@
   (list "IN" "NS" "CNAME" "SOA" "PTR" "MX" "A")
   ;;List of additional font-lock-expressions
   (list
-   (list "\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 'font-lock-constant-face)
+   (list "\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 'font-lock-constant-face)
    (list "^\\([.A-Za-z0-9]+\\)" 1 'font-lock-variable-name-face)
    )
   ;;List of additional automode-alist expressions

[Message part 5 (text/plain, inline)]

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (300, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.24
Locale: LANG=en_GB, LC_CTYPE=en_GB (ignored: LC_ALL set to en_GB)

Versions of packages emacs21-common depends on:
ii  dpkg                        1.10.19      Package maintenance system for Deb
ii  emacsen-common              1.4.15       Common facilities for all emacsen.
ii  libc6                       2.3.2.ds1-11 GNU C Library: Shared libraries an
ii  liblockfile1                1.05         NFS-safe locking library, includes

-- no debconf information

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.