GNU bug report logs - #17380
grep -C 0 could also give separators

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17380 in the body.
You can then email your comments to 17380 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-grep <at> gnu.org
Subject: grep -C 0 could also give separators
Date: Thu, 01 May 2014 13:33:22 +0800

One notices that when -C 0 is used, it acts like no -C was given at all.
Perhaps it should still output the group separators like -C 1 etc. does.
grep (GNU grep) 2.18

Message #10 received at 17380 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Dan Jacobson <jidanni <at> jidanni.org>
Cc: 17380 <at> debbugs.gnu.org
Subject: bug#17380: grep -C 0 could also give separators
Date: Fri, 09 May 2014 08:53:44 +0900

I think it's designed.  Could you tell us why you think it's a bug?

Message #13 received at 17380 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17380 <at> debbugs.gnu.org
Subject: Re: bug#17380: grep -C 0 could also give separators
Date: Fri, 09 May 2014 08:00:53 +0800

I was just thinking maybe some people would want the separators in all
cases, and it would make the behavior of the option more consistent. But
no big deal.

>>>>> "NT" == Norihiro Tanaka <noritnk <at> kcn.ne.jp> writes:
NT> I think it's designed.  Could you tell us why you think it's a bug?

Message #16 received at 17380 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: <jidanni <at> jidanni.org>
Cc: 17380 <at> debbugs.gnu.org
Subject: bug#17380: grep -C 0 could also give separators
Date: Sat, 10 May 2014 14:58:42 +0900

[Message part 1 (text/plain, inline)]

The argument that a separater should also be output for zero might be
reasonable, because zero is allowed with -A, -B or -C option, though I
think it isn't necessary.

[0001-grep-output-a-separator-by-explicit-zero-with-A-B-or.patch (text/plain, attachment)]

Message #19 received at 17380 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17380 <at> debbugs.gnu.org
Subject: Re: bug#17380: grep -C 0 could also give separators
Date: Sat, 10 May 2014 15:46:54 +0800

Thanks!

Message #22 received at 17380 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, jidanni <at> jidanni.org
Cc: 17380 <at> debbugs.gnu.org
Subject: Re: bug#17380: grep -C 0 could also give separators
Date: Sat, 10 May 2014 01:27:04 -0700

[Message part 1 (text/plain, inline)]

Norihiro Tanaka wrote:
> The argument that a separater should also be output for zero might be reasonable

It sounds reasonable to me, too.  Unfortunately that patch did not work 
for me.  Also, the change should be documented in NEWS, and the 
documentation updated, and a test case added.  I installed the attached 
patches.

[0001-grep-A-0-B-0-C-0-now-output-a-separator.patch (text/plain, attachment)]

[0002-tests-add-test-case-for-C-0-change.patch (text/plain, attachment)]

Message #27 received at 17380-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 17380-done <at> debbugs.gnu.org
Subject: Re: bug#17380: grep -C 0 could also give separators
Date: Sat, 10 May 2014 01:28:41 -0700

Since the bug is fixed I'm closing it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.