From unknown Wed Jun 18 23:05:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17379 <17379@debbugs.gnu.org> To: bug#17379 <17379@debbugs.gnu.org> Subject: Status: 24.3.90.1 pretest: (ag-get-arg 0) somehow returns nil in the middle of advice Reply-To: bug#17379 <17379@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:05:29 +0000 retitle 17379 24.3.90.1 pretest: (ag-get-arg 0) somehow returns nil in the = middle of advice reassign 17379 emacs submitter 17379 Le Wang severity 17379 normal tag 17379 wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 30 22:58:55 2014 Received: (at submit) by debbugs.gnu.org; 1 May 2014 02:58:55 +0000 Received: from localhost ([127.0.0.1]:46943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WfhD4-00017u-PH for submit@debbugs.gnu.org; Wed, 30 Apr 2014 22:58:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39165) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WfhD1-00017c-SB for submit@debbugs.gnu.org; Wed, 30 Apr 2014 22:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfhCv-0002tE-OR for submit@debbugs.gnu.org; Wed, 30 Apr 2014 22:58:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfhCv-0002tA-LR for submit@debbugs.gnu.org; Wed, 30 Apr 2014 22:58:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfhCu-00011L-Or for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2014 22:58:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfhCt-0002sx-Py for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2014 22:58:44 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:39023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfhCt-0002sr-I0 for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2014 22:58:43 -0400 Received: by mail-we0-f174.google.com with SMTP id k48so2480454wev.5 for ; Wed, 30 Apr 2014 19:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=sEtQ0nIsfHyMm9ywLFunwed9TfKQjsIPQknfkBeVsZU=; b=ofm6VPHeHU+Z4QzCoO/p2f/jWVyk1l62yhmzzfc7JuK3owDV6uQTGmGfwVSI7rh07x guzZk3LuW5gOEQ3SH5coEHAK19PcGc+8lQQiWPj7dIbXlG0XbcTEQYmfxo1spj2AEAU1 vTzEV2V3EuyyTl3lwhS4mEigj/zG53PqDW03krKo1O1nKk8uO+nkIk9nSq6VWd11dhex YlN28jxUQoYQ3caSzWD6v1+QtO2n6PNbr54IsX+P+c1tfdoTK31+BuS/UhXJzrl6fa9M bJGoyjPZ2gOVvq+u1DOw5+xd87sIu/id5Jd+wCfv/JGj8Hd92947i7vHeyYnozcV1coH OulA== MIME-Version: 1.0 X-Received: by 10.180.93.133 with SMTP id cu5mr94253wib.47.1398913121802; Wed, 30 Apr 2014 19:58:41 -0700 (PDT) Received: by 10.216.157.200 with HTTP; Wed, 30 Apr 2014 19:58:41 -0700 (PDT) Date: Wed, 30 Apr 2014 22:58:41 -0400 Message-ID: Subject: 24.3.90.1 pretest: (ag-get-arg 0) somehow returns nil in the middle of advice From: Le Wang To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Ok the repro steps are very specific. I've tried to make a simpler repro, but could not with the time I had. The important 2 line of code is here: https://github.com/lewang/flx/blob/test-bug-report/flx-ido.el#L226-227 The advice around it is very basic. The only interesting thing is after (setq test (ad-get-arg 0)) test is nil, but original-items is correct. ----------------------------------------------------- Repro steps 1. clone git@github.com:lewang/flx.git 2. switch to branch "test-bug-report" 3. open "flx-ido.el" 4. follow installation instructions: in header https://github.com/lewang/flx/blob/test-bug-report/flx-ido.el#L48-54 5. press "C-x b" 6. Look at "*Messages*" buffer. The advice isn't complicated I have no idea what's going on there. -- Le From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 30 23:54:58 2014 Received: (at control) by debbugs.gnu.org; 1 May 2014 03:54:58 +0000 Received: from localhost ([127.0.0.1]:46951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wfi5J-0002sV-Mp for submit@debbugs.gnu.org; Wed, 30 Apr 2014 23:54:58 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:47055) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wfi5H-0002s6-4m; Wed, 30 Apr 2014 23:54:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+K9B/2dsb2JhbABZgwY7gw/APYEXF3SCJQEBAQECAVYjBQsLDiYSFBgNJIgECA3SDBMEjHqCAAeEOASpGYFqgXGBWyE X-IPAS-Result: ArYGAIDvNVPO+K9B/2dsb2JhbABZgwY7gw/APYEXF3SCJQEBAQECAVYjBQsLDiYSFBgNJIgECA3SDBMEjHqCAAeEOASpGYFqgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="61158327" Received: from 206-248-175-65.dsl.teksavvy.com (HELO pastel.home) ([206.248.175.65]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Apr 2014 23:54:49 -0400 Received: by pastel.home (Postfix, from userid 20848) id EBD4D60505; Wed, 30 Apr 2014 23:54:48 -0400 (EDT) From: Stefan Monnier To: Le Wang Subject: Re: bug#17379: 24.3.90.1 pretest: (ag-get-arg 0) somehow returns nil in the middle of advice Message-ID: References: Date: Wed, 30 Apr 2014 23:54:48 -0400 In-Reply-To: (Le Wang's message of "Wed, 30 Apr 2014 22:58:41 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control Cc: 17379-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) tags 17379 wontfix thanks > Ok the repro steps are very specific. I've tried to make a simpler > repro, but could not with the time I had. > The important 2 line of code is here: > https://github.com/lewang/flx/blob/test-bug-report/flx-ido.el#L226-227 > The advice around it is very basic. The only interesting thing is > after (setq test (ad-get-arg 0)) > test is nil, but original-items is correct. The arglist of ido-set-matches-1 is (items &optional do-full), so (ad-get-arg 0) is `items', which you have rebound to nil. AFAICT, this bug is very old. And, AFAICT, you can't fix it without breaking backward compatibility. The new advice mechanism in 24.4 (i.e. advice-add) does not suffer from these problems, tho. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 07:21:35 2014 Received: (at 17379-done) by debbugs.gnu.org; 1 May 2014 11:21:35 +0000 Received: from localhost ([127.0.0.1]:47035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wfp3X-0000RA-B8 for submit@debbugs.gnu.org; Thu, 01 May 2014 07:21:35 -0400 Received: from mail-we0-f181.google.com ([74.125.82.181]:40891) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wfp3V-0000Qt-0Z for 17379-done@debbugs.gnu.org; Thu, 01 May 2014 07:21:33 -0400 Received: by mail-we0-f181.google.com with SMTP id q58so2921327wes.40 for <17379-done@debbugs.gnu.org>; Thu, 01 May 2014 04:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=y407GikULes12EYN4tzZ2T/esiHlm5Fzq1K0g32+5KM=; b=PYEZCDSXvMtMztdCBu6zPzMfXOLYKf/zJeWL+BsPZSLmJ7iAZ4gfinTbMdKUDZ00Mw hd+cTfsjktplOia00famTqAbBAx0DowTad3AJKkTyipGfG17bEtOhkmvniOOQrUBWh4c yBAr4SEuohSRdwDiDrS4Mi2FQ05FTQUZIqb3OzildFhf5bPPZ/1vXzP8Scq2PR2yRFNt gWwtcVN4DMrwo9kST1iQQZrZhIUuIV5Be0XetA0lEtUPDPFZeG0Ezzr1eUjH7CQClgxA PNk6wOsVRB0Y+d18ytzSo9aOpTgahDE4FX5xvx2zDDnbu2tYsxeFIBrV1/tt6v8kHy3u bx6g== MIME-Version: 1.0 X-Received: by 10.180.96.225 with SMTP id dv1mr1783055wib.37.1398943286746; Thu, 01 May 2014 04:21:26 -0700 (PDT) Received: by 10.216.157.200 with HTTP; Thu, 1 May 2014 04:21:26 -0700 (PDT) In-Reply-To: References: Date: Thu, 1 May 2014 07:21:26 -0400 Message-ID: Subject: Re: bug#17379: 24.3.90.1 pretest: (ag-get-arg 0) somehow returns nil in the middle of advice From: Le Wang To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 17379-done Cc: 17379-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Apr 30, 2014 at 11:54 PM, Stefan Monnier wrote: > AFAICT, this bug is very old. And, AFAICT, you can't fix it without > breaking backward compatibility. The new advice mechanism in 24.4 > (i.e. advice-add) does not suffer from these problems, tho. Ahh. I completely missed that items binding. It makes sense now. Thanks! -- Le From unknown Wed Jun 18 23:05:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 May 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator