GNU bug report logs - #17376
[PATCH] grep: fix the different behaviour for a invalid sequence between KWset and DFA

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17376: closed ([PATCH] grep: fix the different behaviour for
 a invalid sequence between KWset and DFA)
Date: Mon, 05 May 2014 02:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 04 May 2014 19:41:29 -0700
with message-id <5366FA59.30307 <at> cs.ucla.edu>
and subject line Re: bug#17376: [PATCH] grep: fix the different behaviour for a invalid sequence between KWset and DFA
has caused the debbugs.gnu.org bug report #17376,
regarding [PATCH] grep: fix the different behaviour for a invalid sequence between KWset and DFA
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17376: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17376
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: fix the different behaviour for a invalid sequence
 between KWset and DFA
Date: Thu, 01 May 2014 00:02:19 +0900

[Message part 3 (text/plain, inline)]

Thare is different behaviour for a invalid sequence between KWset and DFA.

  encode() { echo "$1" | tr ABC '\357\274\241'; }
  encode ABC | env LC_ALL=en_US.utf8 src/grep "$(encode A)\|q"
  encode ABC | env LC_ALL=en_US.utf8 src/grep -F "$(encode A)"
  encode sABC | env LC_ALL=en_US.utf8 src/grep "a$(encode A)\|q"
  encode sABC | env LC_ALL=en_US.utf8 src/grep -F "a$(encode A)"

We expect that all of them are same results, but only 4th returns 1 row.
This patch fixes it, changes all into 1 row returned.

Norihiro

[patch.txt (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17376-done <at> debbugs.gnu.org
Subject: Re: bug#17376: [PATCH] grep: fix the different behaviour for a invalid
 sequence between KWset and DFA
Date: Sun, 04 May 2014 19:41:29 -0700

[Message part 6 (text/plain, inline)]

Thanks for that fix.  I found a few glitches, mostly having to do with 
storing WEOF in a wchar_t, which is not portable.  There were also some 
opportunities for simplification and clarification.  I installed the 
patch, and followed it up with the attached three patches.  The second 
patch is the only one that fixes any bugs.

[0001-tests-improve-coverage-for-prefix-of-multibyte.patch (text/plain, attachment)]

[0002-grep-simplify-and-fix-problems-with-KWset-DFA-agreem.patch (text/plain, attachment)]

[0003-dfa-minor-simplification.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.