GNU bug report logs - #17350
[PATCH] grep: speed up for a case to repeat failure in DFA after success in kwset

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17350 <at> debbugs.gnu.org
Subject: bug#17350: [PATCH] grep: speed up for a case to repeat failure in DFA after success in kwset
Date: Fri, 9 May 2014 12:38:51 -0700

[Message part 1 (text/plain, inline)]

On Tue, May 6, 2014 at 7:46 AM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> Thanks, I pushed that with minor changes to the ChangeLog message (first
> attached patch).  It's a tad faster to combine the relevant flags at
> compile-time so I did that (second attached patch).

Reading your 0002 "dfa: minor performance improvement for previous
change", I noticed that the fall-through "case BACKREF:" was not
marked as such, so have added a few /* fallthrough */ comments, to
mark the places where one (or a static analyzer) might have a doubt:

[0001-maint-mark-some-breakless-cases-with-fallthrough-com.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.