GNU bug report logs - #17350
[PATCH] grep: speed up for a case to repeat failure in DFA after success in kwset

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 17350 <at> debbugs.gnu.org
Subject: bug#17350: [PATCH] grep: speed up for a case to repeat failure in DFA after success in kwset
Date: Tue, 06 May 2014 18:45:25 -0700

Norihiro Tanaka wrote:
> Paul Eggert wrote:
>> Anyway, I reworded the text in a different way to avoid the misuse of
>> "if" (third attached patch).
>
> By the way, do you purposely replace spaces with tabs in third patch?

Yes, we're using tabs to line up code that is multicolumn (typically the 
first column is code, the second comments).  Admittedly the code is not 
consistent in this area.

I'd prefer a different style, where there's a comment on one line and 
code on the next, and where there are no tabs, but now's not a good time 
to change styles.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.