GNU bug report logs - #17350
[PATCH] grep: speed up for a case to repeat failure in DFA after success in kwset

Previous Next

Full log

Message #28 received at 17350 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17350 <at> debbugs.gnu.org
Subject: Re: bug#17350: [PATCH] grep: speed up for a case to repeat failure
 in DFA after success in kwset
Date: Wed, 30 Apr 2014 00:10:26 -0700

[Message part 1 (text/plain, inline)]

Thanks for working on that.  A few comments.  First, the ChangeLog 
entries can be improved; I put a proposed rewrite of them into the first 
two attached patches (the code's the same).  Second, building with 
--enable-gcc-warnings causes a complaint about dfasuperset needing to be 
declared pure.  Third, EGexecute still has quite a bit of duplicate 
code, even with the patch.  I took at shot at simplifying it (and fixing 
the 2nd problem) in the third attached patch.  This passes "make check" 
but I have not benchmarked it.

[0001-grep-simplify-superset.patch (text/plain, attachment)]

[0002-grep-adjust-timing-back-to-kwset-when-dfaisfast-is-t.patch (text/plain, attachment)]

[0003-grep-simplify-EGexecute-further.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.