GNU bug report logs - #17341
memory leak in dfa.c

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Aharon Robbins <arnold <at> skeeve.com>
Subject: bug#17341: closed (Re: bug#17341: memory leak in dfa.c)
Date: Fri, 25 Apr 2014 06:31:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#17341: memory leak in dfa.c

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 17341 <at> debbugs.gnu.org.

-- 
17341: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17341
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Aharon Robbins <arnold <at> skeeve.com>, 17341-done <at> debbugs.gnu.org
Subject: Re: bug#17341: memory leak in dfa.c
Date: Thu, 24 Apr 2014 23:30:36 -0700

Thanks, I merged that into the master version.

[Message part 3 (message/rfc822, inline)]

From: Aharon Robbins <arnold <at> skeeve.com>
To: bug-grep <at> gnu.org
Subject: memory leak in dfa.c
Date: Thu, 24 Apr 2014 22:19:53 +0300

Hi.

Thanks to valgrind, I tracked down this memory leak in dfa.c. dfasuperset()
when it does dfafree(sup) doesn't free(sup).  Here's the fix.

Thanks,

Arnold
-----------------------
diff --git a/src/dfa.c b/src/dfa.c
index 8fc3d6f..9106814 100644
--- a/src/dfa.c
+++ b/src/dfa.c
@@ -3533,7 +3533,10 @@ dfasuperset (struct dfa *d)
   sup->tindex = j;
 
   if ((d->mb_cur_max == 1 && !have_achar) || !have_nchar)
-    dfafree (sup);
+    {
+      dfafree (sup);
+      free (sup);
+    }
   else
     d->superset = sup;
 }

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.