GNU bug report logs - #17336
[PATCH] grep: warning to be uninitialized with -Wall

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17336 <at> debbugs.gnu.org
Subject: bug#17336: [PATCH] grep: warning to be uninitialized with -Wall
Date: Thu, 24 Apr 2014 21:52:59 -0700

[Message part 1 (text/plain, inline)]

Norihiro Tanaka wrote:
> I can't find any reasons that `accept' variable should be uninitialized.

Two reasons.  First, if we add initialization to the source, that might 
cause some compilers to generate less-efficient code.  More important, 
adding initialization might cause some human readers of the code to 
become confused, and to think that the initialization is necessary.

If you're using -Wall, I suggest configuring with './configure 
--enable-gcc-warnings', as that should avoid the problem.

Come to think of it, perhaps we should get rid of the '#ifdef lint' code 
here, as in the attached patch.  These days GCC is smart enough to 
figure this stuff out without that code, if one uses 
--enable-gcc-warnings.  This works for me with GCC 4.9.0 and with GCC 
4.8.2.  --enable-gcc-warnings is intended for relatively-recent GCC 
versions; we needn't worry about supporting old versions.

[Wall.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.