GNU bug report logs - #17336
[PATCH] grep: warning to be uninitialized with -Wall

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: bug#17336: closed (bug#17336: [PATCH] grep: warning to be
 uninitialized with -Wall)
Date: Fri, 25 Apr 2014 15:59:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#17336: [PATCH] grep: warning to be uninitialized with -Wall

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 17336 <at> debbugs.gnu.org.

-- 
17336: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17336
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17336-done <at> debbugs.gnu.org
Subject: bug#17336: [PATCH] grep: warning to be uninitialized with -Wall
Date: Sat, 26 Apr 2014 00:58:40 +0900

Paul Eggert wrote:
> Two reasons.  First, if we add initialization to the source, that might
> cause some compilers to generate less-efficient code.  More important,
> adding initialization might cause some human readers of the code to
> become confused, and to think that the initialization is necessary.

Thanks, I agree.

Norihiro

[Message part 3 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: warning to be uninitialized with -Wall
Date: Fri, 25 Apr 2014 08:04:36 +0900

[Message part 4 (text/plain, inline)]

If `lint' macro isn't defined, kwset.c is warned to be uninitialized
with -Wall.  Of course, even if it's warned, there is no operational
problems.  However, I can't find any reasons that `accept' variable
should be uninitialized.  So fix it.

Norihiro

[patch.txt (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.