GNU bug report logs - #17336
[PATCH] grep: warning to be uninitialized with -Wall

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17336: closed ([PATCH] grep: warning to be uninitialized with
 -Wall)
Date: Fri, 25 Apr 2014 15:59:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 26 Apr 2014 00:58:40 +0900
with message-id <20140426005839.B549.27F6AC2D <at> kcn.ne.jp>
and subject line bug#17336: [PATCH] grep: warning to be uninitialized with -Wall
has caused the debbugs.gnu.org bug report #17336,
regarding [PATCH] grep: warning to be uninitialized with -Wall
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17336: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17336
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] grep: warning to be uninitialized with -Wall
Date: Fri, 25 Apr 2014 08:04:36 +0900

[Message part 3 (text/plain, inline)]

If `lint' macro isn't defined, kwset.c is warned to be uninitialized
with -Wall.  Of course, even if it's warned, there is no operational
problems.  However, I can't find any reasons that `accept' variable
should be uninitialized.  So fix it.

Norihiro

[patch.txt (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 17336-done <at> debbugs.gnu.org
Subject: bug#17336: [PATCH] grep: warning to be uninitialized with -Wall
Date: Sat, 26 Apr 2014 00:58:40 +0900

Paul Eggert wrote:
> Two reasons.  First, if we add initialization to the source, that might
> cause some compilers to generate less-efficient code.  More important,
> adding initialization might cause some human readers of the code to
> become confused, and to think that the initialization is necessary.

Thanks, I agree.

Norihiro

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.