GNU bug report logs - #17329
[PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum.

Previous Next

Full log

Message #8 received at 17329 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Edgars Irmejs <edgars.irmejs <at> gmail.com>
Cc: 17329 <at> debbugs.gnu.org
Subject: Re: bug#17329: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing
 comma from enum.
Date: Wed, 23 Apr 2014 22:20:16 +0100

On 04/23/2014 08:20 PM, Edgars Irmejs wrote:
> ---
>  ChangeLog |    4 ++++
>  gl/lib/fadvise.h  |    4 ++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index e69de29..cf30f09 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -0,0 +1,4 @@
> +2014-04-23  Edgars Irmejs <edgars.irmejs <at> gmail.com>
> +
> +* gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum.
> +
> diff --git a/gl/lib/fadvise.h b/gl/lib/fadvise.h
> index ce4bd76..11ecd8f 100644
> --- a/gl/lib/fadvise.h
> +++ b/gl/lib/fadvise.h
> @@ -48,7 +48,7 @@ typedef enum {
>    FADVISE_NOREUSE =    POSIX_FADV_NOREUSE,
>    FADVISE_DONTNEED =   POSIX_FADV_DONTNEED,
>    FADVISE_WILLNEED =   POSIX_FADV_WILLNEED,
> -  FADVISE_RANDOM =     POSIX_FADV_RANDOM,
> +  FADVISE_RANDOM =     POSIX_FADV_RANDOM
>  } fadvice_t;
>  #else
>  typedef enum {
> @@ -57,7 +57,7 @@ typedef enum {
>    FADVISE_NOREUSE,
>    FADVISE_DONTNEED,
>    FADVISE_WILLNEED,
> -  FADVISE_RANDOM,
> +  FADVISE_RANDOM
>  } fadvice_t;
>  #endif
> 
> --
> 1.7.9
> 

I'll include this thanks.
It would be good to know if there was a specific
issue with this with an old compiler, or if it's
just a style change?

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.