GNU bug report logs - #17329
[PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum.

Previous Next

Full log

Message #11 received at 17329 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Pádraig Brady <P <at> draigBrady.com>,
 Edgars Irmejs <edgars.irmejs <at> gmail.com>
Cc: 17329 <at> debbugs.gnu.org
Subject: Re: bug#17329: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing
 comma from enum.
Date: Wed, 23 Apr 2014 15:49:58 -0600

[Message part 1 (text/plain, inline)]

On 04/23/2014 03:20 PM, Pádraig Brady wrote:

>> +++ b/gl/lib/fadvise.h
>> @@ -48,7 +48,7 @@ typedef enum {
>>    FADVISE_NOREUSE =    POSIX_FADV_NOREUSE,
>>    FADVISE_DONTNEED =   POSIX_FADV_DONTNEED,
>>    FADVISE_WILLNEED =   POSIX_FADV_WILLNEED,
>> -  FADVISE_RANDOM =     POSIX_FADV_RANDOM,
>> +  FADVISE_RANDOM =     POSIX_FADV_RANDOM
>>  } fadvice_t;
>>  #else
>>  typedef enum {
>> @@ -57,7 +57,7 @@ typedef enum {
>>    FADVISE_NOREUSE,
>>    FADVISE_DONTNEED,
>>    FADVISE_WILLNEED,
>> -  FADVISE_RANDOM,
>> +  FADVISE_RANDOM
>>  } fadvice_t;
>>  #endif
>>
>> --
>> 1.7.9
>>
> 
> I'll include this thanks.
> It would be good to know if there was a specific
> issue with this with an old compiler, or if it's
> just a style change?

Coreutils requires a C99 compiler, which means trailing comma support is
required.

If this were directly in gnulib, though, where we still cater to C89
compilers, this patch makes total sense.  And given the location of this
file in the coreutils repo, it looks like we intend for fadvise.h to
eventually migrate to gnulib if it proves useful elsewhere.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.