From unknown Sun Jun 22 07:56:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17329: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum. Resent-From: Edgars Irmejs Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 23 Apr 2014 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 17329@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13982865766665 (code B ref -1); Wed, 23 Apr 2014 20:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Apr 2014 20:56:16 +0000 Received: from localhost ([127.0.0.1]:56530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd4DH-0001jN-E6 for submit@debbugs.gnu.org; Wed, 23 Apr 2014 16:56:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd2is-0007Mf-5S for submit@debbugs.gnu.org; Wed, 23 Apr 2014 15:20:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wd2iq-0000hu-DY for submit@debbugs.gnu.org; Wed, 23 Apr 2014 15:20:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd2iq-0000hp-BP for submit@debbugs.gnu.org; Wed, 23 Apr 2014 15:20:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd2ip-0007KB-Cb for bug-coreutils@gnu.org; Wed, 23 Apr 2014 15:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wd2io-0000hP-8y for bug-coreutils@gnu.org; Wed, 23 Apr 2014 15:20:43 -0400 Received: from mail-vc0-x242.google.com ([2607:f8b0:400c:c03::242]:60717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd2in-0000hH-Vu for bug-coreutils@gnu.org; Wed, 23 Apr 2014 15:20:42 -0400 Received: by mail-vc0-f194.google.com with SMTP id lh14so347241vcb.5 for ; Wed, 23 Apr 2014 12:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=M8DLxiNyRT8FyLmjvNKxfN77YyUxNp5s5eHHqpyy40c=; b=fmdVZ2BeWty7BjgeivFDfTTaGTscpNTMiSUo1Zh8zHFEgvFLSszgbdOIeTLmthBNZn pvLFwhhzzX7gy34g4Y/SRYfQ0x5Wod+isapefBiIPc8mcLSisYw0BfROrwt6nhemyArT KwEmroi3p1WiA6Pk0Xp9b+4d6QtcUWx5TSYJyBJF19V1+YpS1y6n8TeBcAfst33U91vb LRsOlPMPaFIBoOIUQPaA+up8XE+N7pWJKeRmb2lJSBOexNwtzAf5gCUjAgYAdFK/Vvqa bxWmpHHoQjghlrlbn7BxTHF9PGdO9F/OEl23dY/Z2LdzOqbDqMfyCgOvQg3suVB9RdBY Ki2g== MIME-Version: 1.0 X-Received: by 10.58.34.67 with SMTP id x3mr1054387vei.37.1398280840728; Wed, 23 Apr 2014 12:20:40 -0700 (PDT) X-Google-Sender-Delegation: thesviests@gmail.com Received: by 10.58.154.135 with HTTP; Wed, 23 Apr 2014 12:20:40 -0700 (PDT) Date: Wed, 23 Apr 2014 22:20:40 +0300 X-Google-Sender-Auth: cBserC-1-iLCGRkwKFZLGbjBk0E Message-ID: From: Edgars Irmejs Content-Type: multipart/alternative; boundary=089e013a0d72ced64e04f7baa057 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Wed, 23 Apr 2014 16:56:13 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e013a0d72ced64e04f7baa057 Content-Type: text/plain; charset=UTF-8 --- ChangeLog | 4 ++++ gl/lib/fadvise.h | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index e69de29..cf30f09 100644 --- a/ChangeLog +++ b/ChangeLog @@ -0,0 +1,4 @@ +2014-04-23 Edgars Irmejs + +* gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum. + diff --git a/gl/lib/fadvise.h b/gl/lib/fadvise.h index ce4bd76..11ecd8f 100644 --- a/gl/lib/fadvise.h +++ b/gl/lib/fadvise.h @@ -48,7 +48,7 @@ typedef enum { FADVISE_NOREUSE = POSIX_FADV_NOREUSE, FADVISE_DONTNEED = POSIX_FADV_DONTNEED, FADVISE_WILLNEED = POSIX_FADV_WILLNEED, - FADVISE_RANDOM = POSIX_FADV_RANDOM, + FADVISE_RANDOM = POSIX_FADV_RANDOM } fadvice_t; #else typedef enum { @@ -57,7 +57,7 @@ typedef enum { FADVISE_NOREUSE, FADVISE_DONTNEED, FADVISE_WILLNEED, - FADVISE_RANDOM, + FADVISE_RANDOM } fadvice_t; #endif -- 1.7.9 --089e013a0d72ced64e04f7baa057 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
---
=C2=A0ChangeLog | =C2=A0 =C2=A04 ++++
=C2=A0gl/lib/fadvise.h =C2=A0| =C2=A0 =C2=A04 ++--
=C2= =A02 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e69de29..cf30f09 100644
--- a/ChangeLog
+++ = b/ChangeLog
@@ -0,0 +1,4 @@
+2014-04-23 =C2=A0Edgars Ir= mejs <edgars.irmejs@gmail.com= >
+
+* gl/lib/fadvise.h (fadvice_t): Remove trailing comma fro= m enum.
+
diff --git a/gl/lib/fadvise.h b/gl/lib/fadvis= e.h
index ce4bd76..11ecd8f 100644
--- a/gl/lib/fadvise.= h
+++ b/gl/lib/fadvise.h
@@ -48,7 +48,7 @@ typedef enum {
=C2=A0 =C2=A0FADVISE_NOREUSE =3D =C2=A0 =C2=A0POSIX_FADV_NOREUSE,
=C2=A0 =C2=A0FADVISE_DONTNEED =3D =C2=A0 POSIX_FADV_DONTNEED,
<= div>=C2=A0 =C2=A0FADVISE_WILLNEED =3D =C2=A0 POSIX_FADV_WILLNEED,
- =C2=A0FADVISE_RANDOM =3D =C2=A0 =C2=A0 POSIX_FADV_RANDOM,
= + =C2=A0FADVISE_RANDOM =3D =C2=A0 =C2=A0 POSIX_FADV_RANDOM
=C2=A0= } fadvice_t;
=C2=A0#else
=C2=A0typedef enum {
@@ -57,7 +57,7 @@ typedef enum {
=C2=A0 =C2=A0FADVISE_NOREUSE,
=C2=A0 =C2=A0FADVISE_DONTNEED,
=C2=A0 =C2=A0FADVISE_WILLNEED= ,
- =C2=A0FADVISE_RANDOM,
+ =C2=A0FADVISE_RANDOM
<= div>=C2=A0} fadvice_t;
=C2=A0#endif

--
1.7.9
--089e013a0d72ced64e04f7baa057-- From unknown Sun Jun 22 07:56:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17329: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum. Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 23 Apr 2014 21:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Edgars Irmejs Cc: 17329@debbugs.gnu.org Received: via spool by 17329-submit@debbugs.gnu.org id=B17329.13982880279121 (code B ref 17329); Wed, 23 Apr 2014 21:21:01 +0000 Received: (at 17329) by debbugs.gnu.org; 23 Apr 2014 21:20:27 +0000 Received: from localhost ([127.0.0.1]:56542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd4ah-0002N3-E7 for submit@debbugs.gnu.org; Wed, 23 Apr 2014 17:20:27 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:15063) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd4ae-0002Mt-4H for 17329@debbugs.gnu.org; Wed, 23 Apr 2014 17:20:25 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBABYuWFNtT8h6/2dsb2JhbAANTYc7wSmBMoMZAQEBBCMPAUYQCw0LAgIFFgsCAgkDAgECAQ82Bg0BBQIBAYgpAxapW3acNw2GVBeBKYsXghgHgm+BSgEDlwQBiHKDaoIWh0WBQA Received: from unknown (HELO [192.168.1.79]) ([109.79.200.122]) by mail2.vodafone.ie with ESMTP; 23 Apr 2014 22:20:17 +0100 Message-ID: <53582E90.6060908@draigBrady.com> Date: Wed, 23 Apr 2014 22:20:16 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 04/23/2014 08:20 PM, Edgars Irmejs wrote: > --- > ChangeLog | 4 ++++ > gl/lib/fadvise.h | 4 ++-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index e69de29..cf30f09 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -0,0 +1,4 @@ > +2014-04-23 Edgars Irmejs > + > +* gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum. > + > diff --git a/gl/lib/fadvise.h b/gl/lib/fadvise.h > index ce4bd76..11ecd8f 100644 > --- a/gl/lib/fadvise.h > +++ b/gl/lib/fadvise.h > @@ -48,7 +48,7 @@ typedef enum { > FADVISE_NOREUSE = POSIX_FADV_NOREUSE, > FADVISE_DONTNEED = POSIX_FADV_DONTNEED, > FADVISE_WILLNEED = POSIX_FADV_WILLNEED, > - FADVISE_RANDOM = POSIX_FADV_RANDOM, > + FADVISE_RANDOM = POSIX_FADV_RANDOM > } fadvice_t; > #else > typedef enum { > @@ -57,7 +57,7 @@ typedef enum { > FADVISE_NOREUSE, > FADVISE_DONTNEED, > FADVISE_WILLNEED, > - FADVISE_RANDOM, > + FADVISE_RANDOM > } fadvice_t; > #endif > > -- > 1.7.9 > I'll include this thanks. It would be good to know if there was a specific issue with this with an old compiler, or if it's just a style change? thanks, Pádraig. From unknown Sun Jun 22 07:56:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#17329: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum. Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 23 Apr 2014 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: =?UTF-8?Q?P=C3=A1draig?= Brady , Edgars Irmejs Cc: 17329@debbugs.gnu.org Received: via spool by 17329-submit@debbugs.gnu.org id=B17329.139828980512095 (code B ref 17329); Wed, 23 Apr 2014 21:51:02 +0000 Received: (at 17329) by debbugs.gnu.org; 23 Apr 2014 21:50:05 +0000 Received: from localhost ([127.0.0.1]:56546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd53M-00038y-Ut for submit@debbugs.gnu.org; Wed, 23 Apr 2014 17:50:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6485) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd53J-00038Q-3F for 17329@debbugs.gnu.org; Wed, 23 Apr 2014 17:50:03 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3NLnxoU015427 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 23 Apr 2014 17:49:59 -0400 Received: from [10.3.113.108] (ovpn-113-108.phx2.redhat.com [10.3.113.108]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s3NLnw0L013207; Wed, 23 Apr 2014 17:49:58 -0400 Message-ID: <53583586.7050409@redhat.com> Date: Wed, 23 Apr 2014 15:49:58 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 References: <53582E90.6060908@draigBrady.com> In-Reply-To: <53582E90.6060908@draigBrady.com> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wrebfkPQ62D1gad5QDPkxEgbKUw9F068b" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -5.7 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wrebfkPQ62D1gad5QDPkxEgbKUw9F068b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/23/2014 03:20 PM, P=C3=A1draig Brady wrote: >> +++ b/gl/lib/fadvise.h >> @@ -48,7 +48,7 @@ typedef enum { >> FADVISE_NOREUSE =3D POSIX_FADV_NOREUSE, >> FADVISE_DONTNEED =3D POSIX_FADV_DONTNEED, >> FADVISE_WILLNEED =3D POSIX_FADV_WILLNEED, >> - FADVISE_RANDOM =3D POSIX_FADV_RANDOM, >> + FADVISE_RANDOM =3D POSIX_FADV_RANDOM >> } fadvice_t; >> #else >> typedef enum { >> @@ -57,7 +57,7 @@ typedef enum { >> FADVISE_NOREUSE, >> FADVISE_DONTNEED, >> FADVISE_WILLNEED, >> - FADVISE_RANDOM, >> + FADVISE_RANDOM >> } fadvice_t; >> #endif >> >> -- >> 1.7.9 >> >=20 > I'll include this thanks. > It would be good to know if there was a specific > issue with this with an old compiler, or if it's > just a style change? Coreutils requires a C99 compiler, which means trailing comma support is required. If this were directly in gnulib, though, where we still cater to C89 compilers, this patch makes total sense. And given the location of this file in the coreutils repo, it looks like we intend for fadvise.h to eventually migrate to gnulib if it proves useful elsewhere. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wrebfkPQ62D1gad5QDPkxEgbKUw9F068b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTWDWGAAoJEKeha0olJ0NqE8IH/iT+wW2N03SS8q+p7qiyA0gb 3lIzwpNb6p8dT4QxwzbzyWGhqCuHCFYTgVQKKqAZYoIy9My5+tz544qBCPtIooKu oNCQuZ7vIvNxX+Z2IKkimeKDje5YBcSFit9GqYFky5rIKUMyPiw54bonmLdsv8M1 npe1o0GHORA6KFNHwfvwurlWLM7ysUc1S32bXZ+QeaCuCsixvO60/FizCogjW/Nj Lzat2JjSyAYd4AA6B4C66L8uqowhBGroMTi4KIFZgBR6ukVPKopNPUaD2e80eR4a PwYqTc4LsFdlH08GVWyfb6s0FpNUksjRrYWeVwFX1uMFe/pMIpWqwUNlbecIYSI= =+RXx -----END PGP SIGNATURE----- --wrebfkPQ62D1gad5QDPkxEgbKUw9F068b-- From unknown Sun Jun 22 07:56:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Edgars Irmejs Subject: bug#17329: closed (Re: bug#17329: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum.) Message-ID: References: <5359AD2A.1030605@draigBrady.com> X-Gnu-PR-Message: they-closed 17329 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 17329@debbugs.gnu.org Date: Fri, 25 Apr 2014 00:33:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1398385983-8527-1" This is a multi-part message in MIME format... ------------=_1398385983-8527-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #17329: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from = enum. which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 17329@debbugs.gnu.org. --=20 17329: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D17329 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1398385983-8527-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 17329-done) by debbugs.gnu.org; 25 Apr 2014 00:32:49 +0000 Received: from localhost ([127.0.0.1]:57557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WdU4O-0002D2-Va for submit@debbugs.gnu.org; Thu, 24 Apr 2014 20:32:49 -0400 Received: from mail1.vodafone.ie ([213.233.128.43]:52463) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WdU4L-0002Cr-7q for 17329-done@debbugs.gnu.org; Thu, 24 Apr 2014 20:32:46 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwBAFusWVNtTZ4l/2dsb2JhbAANTIcRvH2EO4E0gxoBAQQjDwFGEAsNDQIFFgsCAgkDAgECAUUGDQEHAQGIQqZadqNCF4EpjTAHgm+BSgEDn3yDa4ldgUA Received: from unknown (HELO [192.168.1.79]) ([109.77.158.37]) by mail1.vodafone.ie with ESMTP; 25 Apr 2014 01:32:43 +0100 Message-ID: <5359AD2A.1030605@draigBrady.com> Date: Fri, 25 Apr 2014 01:32:42 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Edgars Irmejs Subject: Re: bug#17329: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum. References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 17329-done Cc: 17329-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) I pushed that so marking bug as done. thanks! Pádraig. ------------=_1398385983-8527-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Apr 2014 20:56:16 +0000 Received: from localhost ([127.0.0.1]:56530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd4DH-0001jN-E6 for submit@debbugs.gnu.org; Wed, 23 Apr 2014 16:56:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wd2is-0007Mf-5S for submit@debbugs.gnu.org; Wed, 23 Apr 2014 15:20:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wd2iq-0000hu-DY for submit@debbugs.gnu.org; Wed, 23 Apr 2014 15:20:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd2iq-0000hp-BP for submit@debbugs.gnu.org; Wed, 23 Apr 2014 15:20:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd2ip-0007KB-Cb for bug-coreutils@gnu.org; Wed, 23 Apr 2014 15:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wd2io-0000hP-8y for bug-coreutils@gnu.org; Wed, 23 Apr 2014 15:20:43 -0400 Received: from mail-vc0-x242.google.com ([2607:f8b0:400c:c03::242]:60717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wd2in-0000hH-Vu for bug-coreutils@gnu.org; Wed, 23 Apr 2014 15:20:42 -0400 Received: by mail-vc0-f194.google.com with SMTP id lh14so347241vcb.5 for ; Wed, 23 Apr 2014 12:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=M8DLxiNyRT8FyLmjvNKxfN77YyUxNp5s5eHHqpyy40c=; b=fmdVZ2BeWty7BjgeivFDfTTaGTscpNTMiSUo1Zh8zHFEgvFLSszgbdOIeTLmthBNZn pvLFwhhzzX7gy34g4Y/SRYfQ0x5Wod+isapefBiIPc8mcLSisYw0BfROrwt6nhemyArT KwEmroi3p1WiA6Pk0Xp9b+4d6QtcUWx5TSYJyBJF19V1+YpS1y6n8TeBcAfst33U91vb LRsOlPMPaFIBoOIUQPaA+up8XE+N7pWJKeRmb2lJSBOexNwtzAf5gCUjAgYAdFK/Vvqa bxWmpHHoQjghlrlbn7BxTHF9PGdO9F/OEl23dY/Z2LdzOqbDqMfyCgOvQg3suVB9RdBY Ki2g== MIME-Version: 1.0 X-Received: by 10.58.34.67 with SMTP id x3mr1054387vei.37.1398280840728; Wed, 23 Apr 2014 12:20:40 -0700 (PDT) X-Google-Sender-Delegation: thesviests@gmail.com Received: by 10.58.154.135 with HTTP; Wed, 23 Apr 2014 12:20:40 -0700 (PDT) Date: Wed, 23 Apr 2014 22:20:40 +0300 X-Google-Sender-Auth: cBserC-1-iLCGRkwKFZLGbjBk0E Message-ID: Subject: [PATCH] * gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum. From: Edgars Irmejs To: bug-coreutils@gnu.org Content-Type: multipart/alternative; boundary=089e013a0d72ced64e04f7baa057 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 23 Apr 2014 16:56:13 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e013a0d72ced64e04f7baa057 Content-Type: text/plain; charset=UTF-8 --- ChangeLog | 4 ++++ gl/lib/fadvise.h | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index e69de29..cf30f09 100644 --- a/ChangeLog +++ b/ChangeLog @@ -0,0 +1,4 @@ +2014-04-23 Edgars Irmejs + +* gl/lib/fadvise.h (fadvice_t): Remove trailing comma from enum. + diff --git a/gl/lib/fadvise.h b/gl/lib/fadvise.h index ce4bd76..11ecd8f 100644 --- a/gl/lib/fadvise.h +++ b/gl/lib/fadvise.h @@ -48,7 +48,7 @@ typedef enum { FADVISE_NOREUSE = POSIX_FADV_NOREUSE, FADVISE_DONTNEED = POSIX_FADV_DONTNEED, FADVISE_WILLNEED = POSIX_FADV_WILLNEED, - FADVISE_RANDOM = POSIX_FADV_RANDOM, + FADVISE_RANDOM = POSIX_FADV_RANDOM } fadvice_t; #else typedef enum { @@ -57,7 +57,7 @@ typedef enum { FADVISE_NOREUSE, FADVISE_DONTNEED, FADVISE_WILLNEED, - FADVISE_RANDOM, + FADVISE_RANDOM } fadvice_t; #endif -- 1.7.9 --089e013a0d72ced64e04f7baa057 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
---
=C2=A0ChangeLog | =C2=A0 =C2=A04 ++++
=C2=A0gl/lib/fadvise.h =C2=A0| =C2=A0 =C2=A04 ++--
=C2= =A02 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e69de29..cf30f09 100644
--- a/ChangeLog
+++ = b/ChangeLog
@@ -0,0 +1,4 @@
+2014-04-23 =C2=A0Edgars Ir= mejs <edgars.irmejs@gmail.com= >
+
+* gl/lib/fadvise.h (fadvice_t): Remove trailing comma fro= m enum.
+
diff --git a/gl/lib/fadvise.h b/gl/lib/fadvis= e.h
index ce4bd76..11ecd8f 100644
--- a/gl/lib/fadvise.= h
+++ b/gl/lib/fadvise.h
@@ -48,7 +48,7 @@ typedef enum {
=C2=A0 =C2=A0FADVISE_NOREUSE =3D =C2=A0 =C2=A0POSIX_FADV_NOREUSE,
=C2=A0 =C2=A0FADVISE_DONTNEED =3D =C2=A0 POSIX_FADV_DONTNEED,
<= div>=C2=A0 =C2=A0FADVISE_WILLNEED =3D =C2=A0 POSIX_FADV_WILLNEED,
- =C2=A0FADVISE_RANDOM =3D =C2=A0 =C2=A0 POSIX_FADV_RANDOM,
= + =C2=A0FADVISE_RANDOM =3D =C2=A0 =C2=A0 POSIX_FADV_RANDOM
=C2=A0= } fadvice_t;
=C2=A0#else
=C2=A0typedef enum {
@@ -57,7 +57,7 @@ typedef enum {
=C2=A0 =C2=A0FADVISE_NOREUSE,
=C2=A0 =C2=A0FADVISE_DONTNEED,
=C2=A0 =C2=A0FADVISE_WILLNEED= ,
- =C2=A0FADVISE_RANDOM,
+ =C2=A0FADVISE_RANDOM
<= div>=C2=A0} fadvice_t;
=C2=A0#endif

--
1.7.9
--089e013a0d72ced64e04f7baa057-- ------------=_1398385983-8527-1--