GNU bug report logs - #17328
dfa.c will fail if used on more than one DFA

Previous Next

Full log

Message #10 received at 17328-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Aharon Robbins <arnold <at> skeeve.com>, 17328-done <at> debbugs.gnu.org
Subject: Re: bug#17328: dfa.c will fail if used on more than one DFA
Date: Wed, 23 Apr 2014 12:49:29 -0700

[Message part 1 (text/plain, inline)]

Thanks for reporting that.  That static variable was the result of a 
recent optimization.  I guess we'll need to optimize in a different 
way.  I noticed another static variable that dfaexec also uses, namely 
'mbs'; this needs to be moved into the struct dfa, for the benefit of 
any applications that really need stateful encodings.  A bonus is that I 
expect this'll make the dfa code run a bit faster. I installed the 
attached patch, which I hope addresses the issues you raised along with 
the mbs issue.

The code still needs more work in this area.  There shouldn't be any 
static variables at all, even when parsing, though this would change the 
API.  And the code isn't consistent about referring to dfa->mb_cur_max 
versus MB_CUR_MAX; not sure why that is.

[0001-dfa-omit-static-variables-that-limited-dfaexec-to-on.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.