GNU bug report logs - #17320
24.3.90.1[pretest]; bug-sourcing design-flaw

Previous Next

Full log

View this message in rfc822 format

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: 17320 <at> debbugs.gnu.org
Subject: bug#17320: 24.3.90.1[pretest]; bug-sourcing design-flaw
Date: Wed, 23 Apr 2014 09:43:38 +0200

When looking for bug #17247

noticed the following

lisp.el, line 374:

    ;; When comparing point against pos, we want to consider that if
    ;; point was right after the end of the function, it's still
    ;; considered as "in that function".
    ;; E.g. `eval-defun' from right after the last close-paren.
    (unless (bolp)
      (skip-chars-forward " \t")
      (if (looking-at "\\s<\\|\n")
          (forward-line 1)))



;;;;;;;;;

A core function should not do that kind of provisions.
Employing forward-line, point might end up at the beginning of valid code, not at the end.
Thus beginning and end of functions are in risk being mixed.

Suggest to drop that and let `eval-defun' etc. make provisions at their needs.

Thanks,

Andreas

GNU Emacs 24.3.90.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2014-04-21

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.