From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 23 01:30:05 2014 Received: (at submit) by debbugs.gnu.org; 23 Apr 2014 05:30:05 +0000 Received: from localhost ([127.0.0.1]:55612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wcpkw-0001Qu-VF for submit@debbugs.gnu.org; Wed, 23 Apr 2014 01:30:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39043) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wcpkt-0001QI-RV for submit@debbugs.gnu.org; Wed, 23 Apr 2014 01:30:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wcpkn-0008Sc-UQ for submit@debbugs.gnu.org; Wed, 23 Apr 2014 01:29:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wcpkn-0008SX-RE for submit@debbugs.gnu.org; Wed, 23 Apr 2014 01:29:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wcpkj-0008Qz-0m for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 01:29:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wcpke-0008Rb-7w for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 01:29:48 -0400 Received: from mailrelay004.isp.belgacom.be ([195.238.6.170]:9197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wcpke-0008RJ-1x for bug-gnu-emacs@gnu.org; Wed, 23 Apr 2014 01:29:44 -0400 X-Belgacom-Dynamic: yes Received: from 2.152-246-81.adsl-dyn.isp.belgacom.be (HELO LDLC-portable) ([81.246.152.2]) by relay.skynet.be with ESMTP; 23 Apr 2014 07:29:42 +0200 From: Nicolas Richard To: bug-gnu-emacs@gnu.org Subject: 24.3.50; Error when battery-status-function reports "N/A" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Wed, 23 Apr 2014 07:29:42 +0200 Message-ID: <87eh0owr3t.fsf@yahoo.fr> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, When I open the lid of my laptop, it might happen that the percentage is "N/A". battery.el assumed it is a number. I suggest the following patch to avoid the lisp error (sorry I did not save the backtrace). In GNU Emacs 24.3.50.7 (i686-pc-linux-gnu, GTK+ Version 2.24.20) of 2014-04-10 on LDLC-portable Windowing system distributor `The X.Org Foundation', version 11.0.11405000 System Description: Ubuntu 13.10 Configured using: `configure 'CFLAGS=-g3 -O2'' Important settings: value of $LANG: fr_BE.UTF-8 locale-coding-system: utf-8-unix 2 files changed, 16 insertions(+), 9 deletions(-) lisp/ChangeLog | 4 ++++ lisp/battery.el | 21 ++++++++++++--------- Modified lisp/ChangeLog diff --git a/lisp/ChangeLog b/lisp/ChangeLog index a31aa5d..d81712f 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,7 @@ +2014-04-11 Nicolas Richard + + * battery.el (battery-update): Handle the case where battery + status is "N/A". 2014-04-23 Stefan Monnier * simple.el (completion-list-mode-map): Use choose-completion for the Modified lisp/battery.el diff --git a/lisp/battery.el b/lisp/battery.el index 1eef80a..768ed78 100644 --- a/lisp/battery.el +++ b/lisp/battery.el @@ -201,19 +201,22 @@ seconds." (defun battery-update () "Update battery status information in the mode line." - (let ((data (and battery-status-function (funcall battery-status-function)))) + (let* ((data (and battery-status-function (funcall battery-status-function))) + (percentage (car (read-from-string (cdr (assq ?p data)))))) (setq battery-mode-line-string (propertize (if (and battery-mode-line-format - (<= (car (read-from-string (cdr (assq ?p data)))) - battery-mode-line-limit)) - (battery-format - battery-mode-line-format - data) + (or + (not (numberp percentage)) + (<= percentage + battery-mode-line-limit))) + (battery-format battery-mode-line-format data) "") 'face - (and (<= (car (read-from-string (cdr (assq ?p data)))) - battery-load-critical) - 'error) + (or + (not (numberp percentage)) + (and (<= percentage + battery-load-critical) + 'error)) 'help-echo "Battery status information"))) (force-mode-line-update)) -- Nico. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 27 20:23:47 2014 Received: (at 17319-done) by debbugs.gnu.org; 28 Apr 2014 00:23:48 +0000 Received: from localhost ([127.0.0.1]:43386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WeZMJ-0007Ew-Eo for submit@debbugs.gnu.org; Sun, 27 Apr 2014 20:23:47 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:41273 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WeZMH-0007Eo-GY for 17319-done@debbugs.gnu.org; Sun, 27 Apr 2014 20:23:46 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WeZMF-0003wM-Vl; Sun, 27 Apr 2014 20:23:44 -0400 From: Glenn Morris To: 17319-done@debbugs.gnu.org Subject: Re: bug#17319: 24.3.50; Error when battery-status-function reports "N/A" References: <87eh0owr3t.fsf@yahoo.fr> X-Spook: plutonium rs9512c ANC benelux militia Craig Livingstone X-Ran: t]b@ow26fSi(}(Y{2c1"F|;a0AT9o\@x3FaDAaU^X]H_7bu):Lu%3r)LQm!4kmSjFi(SS# X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sun, 27 Apr 2014 20:23:43 -0400 In-Reply-To: <87eh0owr3t.fsf@yahoo.fr> (Nicolas Richard's message of "Wed, 23 Apr 2014 07:29:42 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 17319-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Version: 24.4 Looks like this was applied. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 28 23:57:36 2014 Received: (at 17319-done) by debbugs.gnu.org; 29 Apr 2014 03:57:36 +0000 Received: from localhost ([127.0.0.1]:44266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WezAk-0004ej-N6 for submit@debbugs.gnu.org; Mon, 28 Apr 2014 23:57:35 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53583) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WezAh-0004eF-Rj for 17319-done@debbugs.gnu.org; Mon, 28 Apr 2014 23:57:32 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s3T3vR2D028901; Mon, 28 Apr 2014 23:57:29 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 122D966632; Fri, 25 Apr 2014 14:02:00 -0400 (EDT) From: Stefan Monnier To: Nicolas Richard Subject: Re: bug#17319: 24.3.50; Error when battery-status-function reports "N/A" Message-ID: References: <87eh0owr3t.fsf@yahoo.fr> Date: Fri, 25 Apr 2014 14:02:00 -0400 In-Reply-To: <87eh0owr3t.fsf@yahoo.fr> (Nicolas Richard's message of "Wed, 23 Apr 2014 07:29:42 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4925=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4925> : inlines <786> : streams <1168801> : uri <1743348> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 17319-done Cc: 17319-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) > When I open the lid of my laptop, it might happen that the percentage is > "N/A". battery.el assumed it is a number. I suggest the following patch > to avoid the lisp error (sorry I did not save the backtrace). Thanks, installed in emacs-24. Stefan From unknown Tue Aug 19 23:13:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 May 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator