From unknown Sat Jun 21 10:39:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#17311 <17311@debbugs.gnu.org> To: bug#17311 <17311@debbugs.gnu.org> Subject: Status: M-x speedbar-get-focus fails due to a non-symbol argument to run-hooks Reply-To: bug#17311 <17311@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:39:53 +0000 retitle 17311 M-x speedbar-get-focus fails due to a non-symbol argument to = run-hooks=20 reassign 17311 emacs submitter 17311 Ivan Shmakov severity 17311 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 21 14:15:29 2014 Received: (at submit) by debbugs.gnu.org; 21 Apr 2014 18:15:29 +0000 Received: from localhost ([127.0.0.1]:54356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WcIkZ-0005iL-GN for submit@debbugs.gnu.org; Mon, 21 Apr 2014 14:15:28 -0400 Received: from fely.am-1.org ([78.47.74.50]:39098) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WcIkW-0005i9-N8 for submit@debbugs.gnu.org; Mon, 21 Apr 2014 14:15:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=p7Ctb1TJDHcIDnVDjXGkXycmq1q7GY/+VL+Rps40Heg=; b=ECba0aBGAB4Vjw3aK4kuQE2+vcdKpq7DzuAcVtvLJJ/5GfGJ9tQi0LonN9FiXK1QFs8yYAL7TvidUn2Hg7oy3PSzOtrM7gLw/OiUFKDlEPOtfLPLwj6AMqZ6wg3+0jHQLA6a7Q7YyYwTdX2Cq/b7lS6o5hI1pnMlEceeQykSJmg=; Received: from oneingray-1-pt.tunnel.tserv10.par1.ipv6.he.net ([2001:470:1f12:1eb::2] helo=waterlily.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1WcIkV-0004EC-8X for submit@debbugs.gnu.org; Mon, 21 Apr 2014 18:15:23 +0000 Received: from violet.siamics.net ([2001:470:1f13:1eb::1:1d]) by waterlily.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WcIkN-0007nt-TO for submit@debbugs.gnu.org; Tue, 22 Apr 2014 01:15:15 +0700 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtp (Exim 4.80) (envelope-from ) id 1WcIkN-0007dE-2P for submit@debbugs.gnu.org; Tue, 22 Apr 2014 01:15:15 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: M-x speedbar-get-focus fails due to a non-symbol argument to run-hooks Date: Mon, 21 Apr 2014 18:15:14 +0000 Message-ID: <87mwfeft1p.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Package: emacs As of cff4b64e835d [1], M-x speedbar-get-focus RET (as called from, say, erc-speedbar-browser) fails with a backtrace like: Debugger entered--Lisp error: (wrong-type-argument symbolp #[nil =E2=80=A6 = [speedbar-update-flag t speedbar-timer-fn] 1]) run-hooks(#[nil =E2=80=A6 [speedbar-update-flag t speedbar-timer-fn] 1]) dframe-get-focus(speedbar-frame speedbar-frame-mode #[nil =E2=80=A6 [spee= dbar-update-flag t speedbar-timer-fn] 1]) speedbar-get-focus() call-interactively(speedbar-get-focus record nil) command-execute(speedbar-get-focus record) execute-extended-command(nil "speedbar-get-focus") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) The likely cause is that the change made last August as part of 02d1dcff167d [2] was in fact incomplete. Specifically, while dframe-get-focus was changed to allow only a hook argument (that is: a hook variable, as accepted by run-hooks): index 21b5085..6696707 100644 --- a/lisp/dframe.el +++ b/lisp/dframe.el @@ -616,7 +622,7 @@ (defun dframe-get-focus (frame-var activator &optional = hook) ) (other-frame 0) ;; If updates are off, then refresh the frame (they want it now...) - (run-hooks 'hook)) + (run-hooks hook)) =20 =20 (defun dframe-close-frame () At least one of its callers =E2=80=93 speedbar-get-focus =E2=80=93 was /no= t/ updated accordingly (as of [1]): 1061 (defun speedbar-get-focus () =E2=80=A6 1067 (dframe-get-focus 'speedbar-frame 'speedbar-frame-mode 1068 (lambda () (let ((speedbar-update-flag t)) 1069 (speedbar-timer-fn))))) I guess employing in speedbar-get-focus something like the =E2=80=98conv-hook=E2=80=99 wrapper currently used in dframe-frame-mode wi= ll resolve the issue. [1] http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/vc/ediff-diff.el= ?h=3Dtrunk&id=3Dcff4b64e835d8a198ada0dcf32e69ab03642ae60 [2] http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/vc/ediff-diff.el= ?h=3Dtrunk&id=3D02d1dcff167d8ed868df68abd7a46706f8ab5f11 --=20 FSF associate member #7257 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 21 17:46:07 2014 Received: (at 17311) by debbugs.gnu.org; 21 Apr 2014 21:46:07 +0000 Received: from localhost ([127.0.0.1]:54441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WcM2Q-000562-S7 for submit@debbugs.gnu.org; Mon, 21 Apr 2014 17:46:07 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:56740) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WcM2N-00055q-TU for 17311@debbugs.gnu.org; Mon, 21 Apr 2014 17:46:04 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s3LLk0LB017006; Mon, 21 Apr 2014 17:46:00 -0400 Received: by pastel.home (Postfix, from userid 20848) id 17D54600CA; Mon, 21 Apr 2014 17:46:00 -0400 (EDT) From: Stefan Monnier To: Ivan Shmakov Subject: Re: bug#17311: M-x speedbar-get-focus fails due to a non-symbol argument to run-hooks Message-ID: References: <87mwfeft1p.fsf@violet.siamics.net> Date: Mon, 21 Apr 2014 17:46:00 -0400 In-Reply-To: <87mwfeft1p.fsf@violet.siamics.net> (Ivan Shmakov's message of "Mon, 21 Apr 2014 18:15:14 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4919=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4919> : inlines <751> : streams <1164206> : uri <1736701> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 17311 Cc: 17311@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) > At least one of its callers =E2=80=93 speedbar-get-focus =E2=80=93 was /= not/ > updated accordingly (as of [1]): Good point, thank you. I just removed that `hook' argument on the `emacs-24' branch, since that code can just as well be run by the caller anyway. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 21:24:43 2014 Received: (at control) by debbugs.gnu.org; 3 May 2014 01:24:43 +0000 Received: from localhost ([127.0.0.1]:48883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgOh1-0002lL-1d for submit@debbugs.gnu.org; Fri, 02 May 2014 21:24:43 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:60275 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgOgz-0002lC-NC for control@debbugs.gnu.org; Fri, 02 May 2014 21:24:42 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WgOgz-0000mB-5g for control@debbugs.gnu.org; Fri, 02 May 2014 21:24:41 -0400 Date: Fri, 02 May 2014 21:24:41 -0400 Message-Id: Subject: control message for bug 17311 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) close 17311 24.4 From unknown Sat Jun 21 10:39:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 31 May 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator