GNU bug report logs - #17306
grep: skip checking of multibyte character boundary, reaching at eolbyte

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Mon, 21 Apr 2014 12:29:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17306: closed (grep: skip checking of multibyte character
 boundary, reaching at eolbyte)
Date: Fri, 25 Apr 2014 00:59:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 24 Apr 2014 17:58:28 -0700
with message-id <5359B334.7050202 <at> cs.ucla.edu>
and subject line Re: bug#17306: grep: skip checking of multibyte character boundary, reaching at eolbyte
has caused the debbugs.gnu.org bug report #17306,
regarding grep: skip checking of multibyte character boundary, reaching at eolbyte
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17306: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17306
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: grep: skip checking of multibyte character boundary,
 reaching at eolbyte
Date: Mon, 21 Apr 2014 21:27:34 +0900
[Message part 3 (text/plain, inline)]
In dfaexec(), if reaches at eolbyte, we can skip checking of multibyte
character boundary.  So then process mbp until here.

Norihiro
[patch.txt (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 17306-done <at> debbugs.gnu.org
Subject: Re: bug#17306: grep: skip checking of multibyte character boundary,
 reaching at eolbyte
Date: Thu, 24 Apr 2014 17:58:28 -0700
[Message part 6 (text/plain, inline)]
Norihiro Tanaka wrote:
> In dfaexec(), if reaches at eolbyte, we can skip checking of multibyte
> character boundary.  So then process mbp until here.

Thanks, I installed that.  The "mbp = p" assignment can be done 
unconditionally.  Some of the other code in the neighborhood can stand 
some minor cleanups too, so I did that as per the attached patches.


[0001-dfa-simplify-and-be-more-consistent-about-MB_CUR_MAX.patch (text/plain, attachment)]
[0002-dfa-minor-simplification-of-dfaexec.patch (text/plain, attachment)]

This bug report was last modified 11 years and 25 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.