GNU bug report logs - #17300
fails to build due to defsetf, cl-define-compiler-macro in cl-macs.el (structures)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Daniel Colascione <dancol <at> dancol.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#17300: closed (fails to build due to defsetf, cl-define-compiler-macro
 in cl-macs.el (structures) )
Date: Sun, 20 Apr 2014 14:47:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 20 Apr 2014 07:46:32 -0700
with message-id <5353DDC8.40408 <at> dancol.org>
and subject line Re: bug#17300: fails to build due to defsetf, cl-define-compiler-macro in cl-macs.el (structures)
has caused the debbugs.gnu.org bug report #17300,
regarding fails to build due to defsetf, cl-define-compiler-macro in cl-macs.el (structures) 
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
17300: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17300
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: fails to build due to defsetf,
 cl-define-compiler-macro in cl-macs.el (structures) 
Date: Sun, 20 Apr 2014 11:26:25 +0000

Package:  emacs

	As of 20eb3d6e5262 [1], Emacs fails to build from a clean
	directory with the output like:

Loading /home/private/users/ivan/devel/emacs-2014-04-20-build/lisp/emacs-lisp/nadvice.el (source)...
Loading /home/private/users/ivan/devel/emacs-2014-04-20-build/lisp/minibuffer.el (source)...
Eager macro-expansion failure: (void-function defsetf)
Symbol's function definition is void: defsetf
make[1]: *** [bootstrap-emacs] Error 1
make[1]: Leaving directory `/home/private/users/ivan/devel/emacs-2014-04-20-build/src'

	Apparently, the “defstruct introspection” commit [2] is to
	blame, as it introduced to cl-macs.el:

	• the use of the ‘defsetf’ macro, defined in cl.el (not
	  currently required by cl-macs.el, and possibly leading to a
	  circular dependency);

	• two invocations of the ‘cl-define-compiler-macro’ in the
	  “Structures.” section /prior/ to its definition in “Compiler
	  macros.” later in the same file.

	The first issue could be solved by simply replacing defsetf by
	gv-define-simple-setter.  The solution for the second is to move
	these two invocations below the definition of the macro.

[1] http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/vc/ediff-diff.el?h=emacs-24&id=20eb3d6e5262a31147b42a9733010ce397fdc3d8
[2] http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/vc/ediff-diff.el?h=emacs-24&id=49b8b4c4a07e9e3d160367cc52d4ef4fb7f3fa22

PS.  And since when using periods in ‘;;; ’-headings within the code
	became a convention, BTW?

-- 
FSF associate member #7257

[Message part 3 (message/rfc822, inline)]

From: Daniel Colascione <dancol <at> dancol.org>
To: Ivan Shmakov <ivan <at> siamics.net>, 17300 <at> debbugs.gnu.org, 
 17300-done <at> debbugs.gnu.org
Subject: Re: bug#17300: fails to build due to defsetf, cl-define-compiler-macro
 in cl-macs.el (structures)
Date: Sun, 20 Apr 2014 07:46:32 -0700

[Message part 4 (text/plain, inline)]

On 04/20/2014 04:26 AM, Ivan Shmakov wrote:
> Package:  emacs
> 
> 	As of 20eb3d6e5262 [1], Emacs fails to build from a clean
> 	directory with the output like:

Fixed.

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.